82831 2012-03-31 05:30:23 -0700 [BlackBerry] Upstream BlackBerry change to MediaPlayer.h 2014-01-28 08:14:59 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 73144 1 charles.wei charles.wei andersca eric.carlson leo.yang rwlbuis staikos tonikitoo oldest_to_newest 592843 0 charles.wei 2012-03-31 05:30:23 -0700 Need to upstream BlackBerry-specific change to MediaPlayer.h, MediaPlayerPrivateBlackBerry.h(cpp) are already upstreamed and need this patch to build upstreaming code. 592848 1 134954 charles.wei 2012-03-31 05:40:38 -0700 Created attachment 134954 Patch 592850 2 134954 rwlbuis 2012-03-31 05:55:20 -0700 Comment on attachment 134954 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134954&action=review > Source/WebCore/platform/graphics/MediaPlayer.h:312 > + MediaPlayerPrivateInterface* implementation() { return m_private.get(); } Why is this needed? 592854 3 charles.wei 2012-03-31 06:07:04 -0700 (In reply to comment #2) > (From update of attachment 134954 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134954&action=review > > > Source/WebCore/platform/graphics/MediaPlayer.h:312 > > + MediaPlayerPrivateInterface* implementation() { return m_private.get(); } > > Why is this needed? BlackBerry porting need to access the implementation which stores implementation-specific information, like volume-control and volume-status. Look at html/HTMLMediaElement.cpp html/shadow/MediaControlElements.cpp rendering/MediaControlElements.cpp 594509 4 134954 tonikitoo 2012-04-03 08:34:05 -0700 Comment on attachment 134954 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134954&action=review > Source/WebCore/platform/graphics/MediaPlayer.h:89 > + MediaPlayerPrivateInterface* qnxMediaPlayer; "qnx" does not seem too good here. >>> Source/WebCore/platform/graphics/MediaPlayer.h:312 >>> + MediaPlayerPrivateInterface* implementation() { return m_private.get(); } >> >> Why is this needed? > > BlackBerry porting need to access the implementation which stores implementation-specific information, like volume-control and volume-status. > > Look at html/HTMLMediaElement.cpp > html/shadow/MediaControlElements.cpp > rendering/MediaControlElements.cpp Does not it make more sense to add methods to MediaPlayer itself, and hide the "implementation" for the callee? 594556 5 134954 eric.carlson 2012-04-03 09:31:59 -0700 Comment on attachment 134954 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134954&action=review >>>> Source/WebCore/platform/graphics/MediaPlayer.h:312 >>>> + MediaPlayerPrivateInterface* implementation() { return m_private.get(); } >>> >>> Why is this needed? >> >> BlackBerry porting need to access the implementation which stores implementation-specific information, like volume-control and volume-status. >> >> Look at html/HTMLMediaElement.cpp >> html/shadow/MediaControlElements.cpp >> rendering/MediaControlElements.cpp > > Does not it make more sense to add methods to MediaPlayer itself, and hide the "implementation" for the callee? The "PrivateInterface" part of the class name should be a strong hint that the interface is really private. Will it be a burden to add MediaPlayer methods to access the information you need? 134954 2012-03-31 05:40:38 -0700 2012-04-03 09:31:59 -0700 Patch bug-82831-20120331204548.patch text/plain 1925 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTBkZWQzYzAxZTBiMTll NjZlNWIwNTc5MzI4YThkZDJlYmNlYzQxMS4uZjBjZmRhMGFkN2IzOTQ2M2Y0NDlhMmYzMDE5MTE0 Y2Y5MGYwYTYwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTMxICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gVXBzdHJlYW0gQmxhY2tCZXJyeSBjaGFuZ2UgdG8gTWVkaWFQbGF5ZXIuaAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI4MzEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMs IGp1c3QgdG8gbWFrZSBCbGFja0JlcnJ5IHBvcnRpbmcgdG8gYnVpbGQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQ bGF5ZXI6OmltcGxlbWVudGF0aW9uKToKKyAgICAgICAgKE1lZGlhUGxheWVyKToKKwogMjAxMi0w My0yOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDaHJvbWl1 bV0gRGVsZXRlIFdlYktpdC9jaHJvbWl1bS9icmlkZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oCmluZGV4IGJjMTBmYzMwNjEzZTdmMDJhYThhOTIx N2EzZDU4YWJhZWM4NzU0MDguLjI4ZjUwZjJjMmQzNmU2MmYwZDM5MDFlNmQ0YzFmY2Y5MjFlMjQ2 ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxh eWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIu aApAQCAtNzMsNyArNzMsOCBAQCBzdHJ1Y3QgUGxhdGZvcm1NZWRpYSB7CiAgICAgICAgIENocm9t aXVtTWVkaWFQbGF5ZXJUeXBlLAogICAgICAgICBRdE1lZGlhUGxheWVyVHlwZSwKICAgICAgICAg QVZGb3VuZGF0aW9uTWVkaWFQbGF5ZXJUeXBlLAotICAgICAgICBBVkZvdW5kYXRpb25DRk1lZGlh UGxheWVyVHlwZQorICAgICAgICBBVkZvdW5kYXRpb25DRk1lZGlhUGxheWVyVHlwZSwKKyAgICAg ICAgUU5YTWVkaWFQbGF5ZXJUeXBlCiAgICAgfSB0eXBlOwogCiAgICAgdW5pb24gewpAQCAtODUs NiArODYsNyBAQCBzdHJ1Y3QgUGxhdGZvcm1NZWRpYSB7CiAgICAgICAgIE1lZGlhUGxheWVyUHJp dmF0ZUludGVyZmFjZSogcXRNZWRpYVBsYXllcjsKICAgICAgICAgQVZQbGF5ZXIqIGF2Zk1lZGlh UGxheWVyOwogICAgICAgICBBVkNGUGxheWVyKiBhdmNmTWVkaWFQbGF5ZXI7CisgICAgICAgIE1l ZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSogcW54TWVkaWFQbGF5ZXI7CiAgICAgfSBtZWRpYTsK IH07CiAKQEAgLTMwNyw2ICszMDksOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBleGl0RnVsbHNjcmVl bigpOwogI2VuZGlmCiAKKyAgICBNZWRpYVBsYXllclByaXZhdGVJbnRlcmZhY2UqIGltcGxlbWVu dGF0aW9uKCkgeyByZXR1cm4gbV9wcml2YXRlLmdldCgpOyB9CisKICNpZiBVU0UoQUNDRUxFUkFU RURfQ09NUE9TSVRJTkcpCiAgICAgLy8gd2hldGhlciBhY2NlbGVyYXRlZCByZW5kZXJpbmcgaXMg c3VwcG9ydGVkIGJ5IHRoZSBtZWRpYSBlbmdpbmUgZm9yIHRoZSBjdXJyZW50IG1lZGlhLgogICAg IGJvb2wgc3VwcG9ydHNBY2NlbGVyYXRlZFJlbmRlcmluZygpIGNvbnN0Owo=