82825 2012-03-31 00:14:37 -0700 [BlackBerry] Refactor : NetworkJob::handleNotifyHeaderReceived. 2012-03-31 05:37:42 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 jasonliuwebkit webkit-unassigned rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 592812 0 jasonliuwebkit 2012-03-31 00:14:37 -0700 We should use "else if" to decrease string's compare. 592814 1 134947 jasonliuwebkit 2012-03-31 00:22:35 -0700 Created attachment 134947 Patch 592818 2 134949 jasonliuwebkit 2012-03-31 00:51:57 -0700 Created attachment 134949 Patch 592841 3 134949 rwlbuis 2012-03-31 05:26:08 -0700 Comment on attachment 134949 Patch Makes sense. 592846 4 134949 webkit.review.bot 2012-03-31 05:37:38 -0700 Comment on attachment 134949 Patch Clearing flags on attachment: 134949 Committed r112790: <http://trac.webkit.org/changeset/112790> 592847 5 webkit.review.bot 2012-03-31 05:37:42 -0700 All reviewed patches have been landed. Closing bug. 134947 2012-03-31 00:22:35 -0700 2012-03-31 00:51:43 -0700 Patch bug-82825-20120331152231.patch text/plain 2999 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDVkZDZhNTM5NDUwZDk3 NmVmZTYxZWM0NGEzMzc4MmNhMDNmNWFiZC4uN2VjYTUyY2I4MDliZDE1NTdkNDM4Yzg1ZTMxZmMy NjI5Y2RiY2RhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTMxICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBSZWZhY3RvciA6IE5ldHdvcmtKb2I6OmhhbmRsZU5vdGlmeUhlYWRlclJlY2VpdmVkLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI4MjUKKwor ICAgICAgICBXZSBzaG91bGQgdXNlICJlbHNlIGlmIiB0byBkZWNyZWFzZSBzdHJpbmcncyBjb21w YXJlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gUmVmYWN0b3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya0pvYi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrSm9iOjpoYW5k bGVOb3RpZnlIZWFkZXJSZWNlaXZlZCk6CisKIDIwMTItMDMtMzAgIEVyaWMgU2VpZGVsICA8ZXJp Y0B3ZWJraXQub3JnPgogICAgICAgICBzdHlsZUZvckVsZW1lbnQoKSBzaG91bGQgdXNlIGVudW1z IGluc3RlYWQgb2YgYm9vbHMgc28gd2UgY2FuIGFsbCB1bmRlcnN0YW5kIHdoYXQgaXQncyBkb2lu ZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI4MDcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9OZXR3b3JrSm9iLmNwcAppbmRleCA2YTE4OWNlMjlhMTczZjVhZGIwYzU2MTJmYjc0NmU3ZmY0 YjFiM2MxLi40NWFjYjAzOGY5NTcyOWRiMGY0Y2EwMDAzOTFiNDc5ZDQ0MDA4Y2E3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pv Yi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05l dHdvcmtKb2IuY3BwCkBAIC0yOTQsMTEgKzI5NCw5IEBAIHZvaWQgTmV0d29ya0pvYjo6aGFuZGxl Tm90aWZ5SGVhZGVyUmVjZWl2ZWQoY29uc3QgU3RyaW5nJiBrZXksIGNvbnN0IFN0cmluZyYgdmFs CiAgICAgU3RyaW5nIGxvd2VyS2V5ID0ga2V5Lmxvd2VyKCk7CiAgICAgaWYgKGxvd2VyS2V5ID09 ICJjb250ZW50LXR5cGUiKQogICAgICAgICBtX2NvbnRlbnRUeXBlID0gdmFsdWUubG93ZXIoKTsK LQotICAgIGlmIChsb3dlcktleSA9PSAiY29udGVudC1kaXNwb3NpdGlvbiIpCisgICAgZWxzZSBp ZiAobG93ZXJLZXkgPT0gImNvbnRlbnQtZGlzcG9zaXRpb24iKQogICAgICAgICBtX2NvbnRlbnRE aXNwb3NpdGlvbiA9IHZhbHVlOwotCi0gICAgaWYgKGxvd2VyS2V5ID09ICJzZXQtY29va2llIikg eworICAgIGVsc2UgaWYgKGxvd2VyS2V5ID09ICJzZXQtY29va2llIikgewogICAgICAgICAvLyBG SVhNRTogSWYgYSB0YWIgaXMgY2xvc2VkLCBzb21ldGltZXMgbmV0d29yayBkYXRhIHdpbGwgY29t ZSBpbiBhZnRlciB0aGUgZnJhbWUgaGFzIGJlZW4gZGV0YWNoZWQgZnJvbSBpdHMgcGFnZSBidXQg YmVmb3JlIGl0IGlzIGRlbGV0ZWQuCiAgICAgICAgIC8vIElmIHRoaXMgaGFwcGVucywgbV9mcmFt ZS0+cGFnZSgpIHdpbGwgcmV0dXJuIDAsIGFuZCBtX2ZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCkg d2lsbCBiZSBpbiBhIGJhZCBzdGF0ZSBhbmQgY2FsbGluZyBpbnRvIGl0IHdpbGwgY3Jhc2guCiAg ICAgICAgIC8vIEZvciBub3cgd2UgY2hlY2sgZm9yIHRoaXMgZXhwbGljaXRseSBieSBjaGVja2lu ZyBtX2ZyYW1lLT5wYWdlKCkuIEJ1dCB3ZSBzaG91bGQgZmluZCBvdXQgd2h5IHRoZSBuZXR3b3Jr IGpvYiBoYXNuJ3QgYmVlbiBjYW5jZWxsZWQgd2hlbiB0aGUgZnJhbWUgd2FzIGRldGFjaGVkLgpA QCAtMzExLDE0ICszMDksMTEgQEAgdm9pZCBOZXR3b3JrSm9iOjpoYW5kbGVOb3RpZnlIZWFkZXJS ZWNlaXZlZChjb25zdCBTdHJpbmcmIGtleSwgY29uc3QgU3RyaW5nJiB2YWwKICAgICAgICAgICAg IG1fcmVzcG9uc2Uuc2V0SFRUUEhlYWRlckZpZWxkKGtleSwgbV9yZXNwb25zZS5odHRwSGVhZGVy RmllbGQoa2V5KSArICJcclxuIiArIHZhbHVlKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgfQotICAgIH0KLQotICAgIGlmIChsb3dlcktleSA9PSAid3d3LWF1dGhlbnRpY2F0ZSIpCisg ICAgfSBlbHNlIGlmIChsb3dlcktleSA9PSAid3d3LWF1dGhlbnRpY2F0ZSIpCiAgICAgICAgIGhh bmRsZUF1dGhIZWFkZXIoUHJvdGVjdGlvblNwYWNlU2VydmVySFRUUCwgdmFsdWUpOwogICAgIGVs c2UgaWYgKGxvd2VyS2V5ID09ICJwcm94eS1hdXRoZW50aWNhdGUiICYmICFCbGFja0JlcnJ5OjpQ bGF0Zm9ybTo6Q2xpZW50OjpnZXQoKS0+Z2V0UHJveHlBZGRyZXNzKCkuZW1wdHkoKSkKICAgICAg ICAgaGFuZGxlQXV0aEhlYWRlcihQcm90ZWN0aW9uU3BhY2VQcm94eUhUVFAsIHZhbHVlKTsKLQot ICAgIGlmIChlcXVhbElnbm9yaW5nQ2FzZShrZXksIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpOZXR3 b3JrUmVxdWVzdDo6SEVBREVSX0JMQUNLQkVSUllfRlRQKSkKKyAgICBlbHNlIGlmIChsb3dlcktl eSA9PSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6TmV0d29ya1JlcXVlc3Q6OkhFQURFUl9CTEFDS0JF UlJZX0ZUUCkKICAgICAgICAgaGFuZGxlRlRQSGVhZGVyKHZhbHVlKTsKIAogICAgIG1fcmVzcG9u c2Uuc2V0SFRUUEhlYWRlckZpZWxkKGtleSwgdmFsdWUpOwo= 134949 2012-03-31 00:51:57 -0700 2012-03-31 05:37:38 -0700 Patch bug-82825-20120331155154.patch text/plain 3011 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDVkZDZhNTM5NDUwZDk3 NmVmZTYxZWM0NGEzMzc4MmNhMDNmNWFiZC4uN2VjYTUyY2I4MDliZDE1NTdkNDM4Yzg1ZTMxZmMy NjI5Y2RiY2RhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTMxICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBSZWZhY3RvciA6IE5ldHdvcmtKb2I6OmhhbmRsZU5vdGlmeUhlYWRlclJlY2VpdmVkLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI4MjUKKwor ICAgICAgICBXZSBzaG91bGQgdXNlICJlbHNlIGlmIiB0byBkZWNyZWFzZSBzdHJpbmcncyBjb21w YXJlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gUmVmYWN0b3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya0pvYi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrSm9iOjpoYW5k bGVOb3RpZnlIZWFkZXJSZWNlaXZlZCk6CisKIDIwMTItMDMtMzAgIEVyaWMgU2VpZGVsICA8ZXJp Y0B3ZWJraXQub3JnPgogICAgICAgICBzdHlsZUZvckVsZW1lbnQoKSBzaG91bGQgdXNlIGVudW1z IGluc3RlYWQgb2YgYm9vbHMgc28gd2UgY2FuIGFsbCB1bmRlcnN0YW5kIHdoYXQgaXQncyBkb2lu ZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI4MDcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9OZXR3b3JrSm9iLmNwcAppbmRleCA2YTE4OWNlMjlhMTczZjVhZGIwYzU2MTJmYjc0NmU3ZmY0 YjFiM2MxLi4zNDg2M2Y2N2IwMzRjMGM5M2Q1YWVlM2IzN2I0ZjNlN2ZmOWFjZGZlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pv Yi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05l dHdvcmtKb2IuY3BwCkBAIC0yOTQsMTEgKzI5NCw5IEBAIHZvaWQgTmV0d29ya0pvYjo6aGFuZGxl Tm90aWZ5SGVhZGVyUmVjZWl2ZWQoY29uc3QgU3RyaW5nJiBrZXksIGNvbnN0IFN0cmluZyYgdmFs CiAgICAgU3RyaW5nIGxvd2VyS2V5ID0ga2V5Lmxvd2VyKCk7CiAgICAgaWYgKGxvd2VyS2V5ID09 ICJjb250ZW50LXR5cGUiKQogICAgICAgICBtX2NvbnRlbnRUeXBlID0gdmFsdWUubG93ZXIoKTsK LQotICAgIGlmIChsb3dlcktleSA9PSAiY29udGVudC1kaXNwb3NpdGlvbiIpCisgICAgZWxzZSBp ZiAobG93ZXJLZXkgPT0gImNvbnRlbnQtZGlzcG9zaXRpb24iKQogICAgICAgICBtX2NvbnRlbnRE aXNwb3NpdGlvbiA9IHZhbHVlOwotCi0gICAgaWYgKGxvd2VyS2V5ID09ICJzZXQtY29va2llIikg eworICAgIGVsc2UgaWYgKGxvd2VyS2V5ID09ICJzZXQtY29va2llIikgewogICAgICAgICAvLyBG SVhNRTogSWYgYSB0YWIgaXMgY2xvc2VkLCBzb21ldGltZXMgbmV0d29yayBkYXRhIHdpbGwgY29t ZSBpbiBhZnRlciB0aGUgZnJhbWUgaGFzIGJlZW4gZGV0YWNoZWQgZnJvbSBpdHMgcGFnZSBidXQg YmVmb3JlIGl0IGlzIGRlbGV0ZWQuCiAgICAgICAgIC8vIElmIHRoaXMgaGFwcGVucywgbV9mcmFt ZS0+cGFnZSgpIHdpbGwgcmV0dXJuIDAsIGFuZCBtX2ZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCkg d2lsbCBiZSBpbiBhIGJhZCBzdGF0ZSBhbmQgY2FsbGluZyBpbnRvIGl0IHdpbGwgY3Jhc2guCiAg ICAgICAgIC8vIEZvciBub3cgd2UgY2hlY2sgZm9yIHRoaXMgZXhwbGljaXRseSBieSBjaGVja2lu ZyBtX2ZyYW1lLT5wYWdlKCkuIEJ1dCB3ZSBzaG91bGQgZmluZCBvdXQgd2h5IHRoZSBuZXR3b3Jr IGpvYiBoYXNuJ3QgYmVlbiBjYW5jZWxsZWQgd2hlbiB0aGUgZnJhbWUgd2FzIGRldGFjaGVkLgpA QCAtMzExLDE0ICszMDksMTEgQEAgdm9pZCBOZXR3b3JrSm9iOjpoYW5kbGVOb3RpZnlIZWFkZXJS ZWNlaXZlZChjb25zdCBTdHJpbmcmIGtleSwgY29uc3QgU3RyaW5nJiB2YWwKICAgICAgICAgICAg IG1fcmVzcG9uc2Uuc2V0SFRUUEhlYWRlckZpZWxkKGtleSwgbV9yZXNwb25zZS5odHRwSGVhZGVy RmllbGQoa2V5KSArICJcclxuIiArIHZhbHVlKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgfQotICAgIH0KLQotICAgIGlmIChsb3dlcktleSA9PSAid3d3LWF1dGhlbnRpY2F0ZSIpCisg ICAgfSBlbHNlIGlmIChsb3dlcktleSA9PSAid3d3LWF1dGhlbnRpY2F0ZSIpCiAgICAgICAgIGhh bmRsZUF1dGhIZWFkZXIoUHJvdGVjdGlvblNwYWNlU2VydmVySFRUUCwgdmFsdWUpOwogICAgIGVs c2UgaWYgKGxvd2VyS2V5ID09ICJwcm94eS1hdXRoZW50aWNhdGUiICYmICFCbGFja0JlcnJ5OjpQ bGF0Zm9ybTo6Q2xpZW50OjpnZXQoKS0+Z2V0UHJveHlBZGRyZXNzKCkuZW1wdHkoKSkKICAgICAg ICAgaGFuZGxlQXV0aEhlYWRlcihQcm90ZWN0aW9uU3BhY2VQcm94eUhUVFAsIHZhbHVlKTsKLQot ICAgIGlmIChlcXVhbElnbm9yaW5nQ2FzZShrZXksIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpOZXR3 b3JrUmVxdWVzdDo6SEVBREVSX0JMQUNLQkVSUllfRlRQKSkKKyAgICBlbHNlIGlmIChlcXVhbEln bm9yaW5nQ2FzZShrZXksIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpOZXR3b3JrUmVxdWVzdDo6SEVB REVSX0JMQUNLQkVSUllfRlRQKSkKICAgICAgICAgaGFuZGxlRlRQSGVhZGVyKHZhbHVlKTsKIAog ICAgIG1fcmVzcG9uc2Uuc2V0SFRUUEhlYWRlckZpZWxkKGtleSwgdmFsdWUpOwo=