82819 2012-03-30 19:42:16 -0700 search field on Google.com does not have the AXSearchField subrole 2012-04-03 00:16:00 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach oldest_to_newest 592750 0 cfleizach 2012-03-30 19:42:16 -0700 Search fields do not have the AXSubrole: AXSearchField 592815 1 134948 cfleizach 2012-03-31 00:33:05 -0700 Created attachment 134948 patch 593684 2 134948 darin 2012-04-02 12:26:33 -0700 Comment on attachment 134948 patch View in context: https://bugs.webkit.org/attachment.cgi?id=134948&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:506 > + // Some websites don't label their search fields as search, so we should fallback to some heuristics. This comment doesn’t explain why these heuristics are helpful. Nor why these heuristics are sufficient. > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:508 > + String nameAttribute = getAttribute(nameAttr); const AtomicString& nameAttribute = fastGetAttribute(nameAttr); > LayoutTests/platform/mac/accessibility/search-subrole-expected.txt:15 > +PASS nosearch.subrole is 'AXSubrole: ' Could use more coverage for the negative. For example, an element that is not in any form. Need coverage for the “not case sensitive” aspect. All these are all lowercase so the “false” for case sensitive is not tested at all. 594253 3 cfleizach 2012-04-03 00:16:00 -0700 http://trac.webkit.org/changeset/112989 134948 2012-03-31 00:33:05 -0700 2012-04-02 12:26:33 -0700 patch patch.txt text/plain 7503 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjc4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTAzLTMxICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IHNlYXJjaCBmaWVs ZCBvbiBHb29nbGUuY29tIGRvZXMgbm90IGhhdmUgdGhlIEFYU2VhcmNoRmllbGQgc3Vicm9sZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI4MTkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZXRlY3Qgc2Vh cmNoIGZpZWxkcyB3aGVuIHBvc3NpYmxlIGZvciBhY2Nlc3NpYmlsaXR5LgorCisgICAgICAgIFRl c3Q6IHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlYXJjaC1zdWJyb2xlLmh0bWwKKworICAg ICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oOgorICAgICAgICAoV2Vi Q29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdDo6aXNTZWFyY2hGaWVsZCk6CisgICAgICAgICogYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmlzU2VhcmNoRmllbGQpOgorICAgICAgICAo V2ViQ29yZSk6CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0Lmg6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0KToKKyAgICAgICAgKiBh Y2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlci5tbToKKyAgICAg ICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgc3Vicm9sZV0pOgorCiAyMDEyLTAz LTMwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0Nocm9taXVt XSBNb3ZlIFJlc291cmNlSGFuZGxlIHRvIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jaHJvbWl1 bQpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIubW0JKHJldmlzaW9uIDExMjY5 MykKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlP YmplY3RXcmFwcGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNTg0LDYgKzE1ODQsOCBAQAogewog ICAgIGlmIChtX29iamVjdC0+aXNQYXNzd29yZEZpZWxkKCkpCiAgICAgICAgIHJldHVybiBOU0Fj Y2Vzc2liaWxpdHlTZWN1cmVUZXh0RmllbGRTdWJyb2xlOworICAgIGlmIChtX29iamVjdC0+aXNT ZWFyY2hGaWVsZCgpKQorICAgICAgICByZXR1cm4gTlNBY2Nlc3NpYmlsaXR5U2VhcmNoRmllbGRT dWJyb2xlOwogICAgIAogICAgIGlmIChtX29iamVjdC0+aXNBdHRhY2htZW50KCkpIHsKICAgICAg ICAgTlNWaWV3KiBhdHRhY2hWaWV3ID0gW3NlbGYgYXR0YWNobWVudFZpZXddOwpJbmRleDogU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVu ZGVyT2JqZWN0LmgJKHJldmlzaW9uIDExMjY5MykKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC03Myw2 ICs3Myw3IEBACiAgICAgdmlydHVhbCBib29sIGlzTmF0aXZlSW1hZ2UoKSBjb25zdDsKICAgICB2 aXJ0dWFsIGJvb2wgaXNQYXNzd29yZEZpZWxkKCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGlz TmF0aXZlVGV4dENvbnRyb2woKSBjb25zdDsKKyAgICB2aXJ0dWFsIGJvb2wgaXNTZWFyY2hGaWVs ZCgpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBpc1dlYkFyZWEoKSBjb25zdDsKICAgICB2aXJ0 dWFsIGJvb2wgaXNGaWxlVXBsb2FkQnV0dG9uKCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGlz SW5wdXRJbWFnZSgpIGNvbnN0OwpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5T2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHJldmlzaW9uIDExMjY5MykKKysrIFNvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCSh3b3JraW5nIGNv cHkpCkBAIC0zMzEsNiArMzMxLDcgQEAKICAgICB2aXJ0dWFsIGJvb2wgaXNJbWFnZUJ1dHRvbigp IGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdmlydHVhbCBib29sIGlzUGFzc3dvcmRGaWVs ZCgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdmlydHVhbCBib29sIGlzTmF0aXZlVGV4 dENvbnRyb2woKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorICAgIHZpcnR1YWwgYm9vbCBpc1Nl YXJjaEZpZWxkKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNX ZWJBcmVhKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNDaGVj a2JveCgpIGNvbnN0IHsgcmV0dXJuIHJvbGVWYWx1ZSgpID09IENoZWNrQm94Um9sZTsgfQogICAg IHZpcnR1YWwgYm9vbCBpc1JhZGlvQnV0dG9uKCkgY29uc3QgeyByZXR1cm4gcm9sZVZhbHVlKCkg PT0gUmFkaW9CdXR0b25Sb2xlOyB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAJKHJldmlzaW9u IDExMjY5NCkKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJl bmRlck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5MSw2ICs0OTEsMzIgQEAKICAgICBy ZXR1cm4gbV9yZW5kZXJlci0+aXNUZXh0Q29udHJvbCgpOwogfQogICAgIAorYm9vbCBBY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0Ojppc1NlYXJjaEZpZWxkKCkgY29uc3QKK3sKKyAgICBpZiAoIW5v ZGUoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIAorICAgIEhUTUxJbnB1dEVsZW1lbnQq IGlucHV0RWxlbWVudCA9IG5vZGUoKS0+dG9JbnB1dEVsZW1lbnQoKTsKKyAgICBpZiAoIWlucHV0 RWxlbWVudCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKGlucHV0RWxlbWVudC0+ aXNTZWFyY2hGaWVsZCgpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIC8vIFNvbWUgd2Vi c2l0ZXMgZG9uJ3QgbGFiZWwgdGhlaXIgc2VhcmNoIGZpZWxkcyBhcyBzZWFyY2gsIHNvIHdlIHNo b3VsZCBmYWxsYmFjayB0byBzb21lIGhldXJpc3RpY3MuCisgICAgLy8gQ2hlY2sgdGhlIG5vZGUg bmFtZSBvZiB0aGUgaW5wdXQgdHlwZSwgc29tZXRpbWVzIGl0J3MgInNlYXJjaCIuCisgICAgU3Ry aW5nIG5hbWVBdHRyaWJ1dGUgPSBnZXRBdHRyaWJ1dGUobmFtZUF0dHIpOworICAgIGlmIChuYW1l QXR0cmlidXRlLmNvbnRhaW5zKCJzZWFyY2giLCBmYWxzZSkpCisgICAgICAgIHJldHVybiB0cnVl OworICAgIAorICAgIC8vIENoZWNrIHRoZSBmb3JtIGFjdGlvbiBhbmQgdGhlIG5hbWUsIHdoaWNo IHdpbGwgc29tZXRpbWVzIGJlICJzZWFyY2giLgorICAgIEhUTUxGb3JtRWxlbWVudCogZm9ybSA9 IGlucHV0RWxlbWVudC0+Zm9ybSgpOworICAgIGlmIChmb3JtICYmIChmb3JtLT5uYW1lKCkuY29u dGFpbnMoInNlYXJjaCIsIGZhbHNlKSB8fCBmb3JtLT5hY3Rpb24oKS5jb250YWlucygic2VhcmNo IiwgZmFsc2UpKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgCisgICAgcmV0dXJuIGZhbHNl OworfQorICAgIAogYm9vbCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojppc05hdGl2ZUltYWdl KCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9yZW5kZXJlci0+aXNCb3hNb2RlbE9iamVjdCgpICYm IHRvUmVuZGVyQm94TW9kZWxPYmplY3QobV9yZW5kZXJlciktPmlzSW1hZ2UoKTsKSW5kZXg6IExh eW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDExMjc4MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTMxICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFj aEBhcHBsZS5jb20+CisKKyAgICAgICAgc2VhcmNoIGZpZWxkIG9uIEdvb2dsZS5jb20gZG9lcyBu b3QgaGF2ZSB0aGUgQVhTZWFyY2hGaWVsZCBzdWJyb2xlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjgxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2Vh cmNoLXN1YnJvbGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMv YWNjZXNzaWJpbGl0eS9zZWFyY2gtc3Vicm9sZS5odG1sOiBBZGRlZC4KKwogMjAxMi0wMy0zMCAg RGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmVydGVkIHIxMTI3 NjcsIGJlY2F1c2UgaXQgY2F1c2VkIG1hbnkgdmVydGljYWwgdGV4dCB0ZXN0cyB0byBmYWlsLgpJ bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXN1YnJv bGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJp bGl0eS9zZWFyY2gtc3Vicm9sZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXN1YnJvbGUuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSw0OCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRN TC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jl c291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBpZD0iYm9k eSI+CisKKzxpbnB1dCB0eXBlPSJzZWFyY2giIGlkPSJzZWFyY2gxIj48YnI+CisKKzxpbnB1dCB0 eXBlPSJ0ZXh0IiBuYW1lPSJzZWFyY2giIGlkPSJzZWFyY2gyIj48YnI+CisKKzxmb3JtIGFjdGlv bj0iL3NlYXJjaCI+Cis8aW5wdXQgdHlwZT0idGV4dCIgaWQ9InNlYXJjaDMiPgorPC9mb3JtPgor Cis8Zm9ybSBuYW1lPSJzZWFyY2htZSIgYWN0aW9uPSIvIj4KKzxpbnB1dCB0eXBlPSJ0ZXh0IiBp ZD0ic2VhcmNoNCI+Cis8L2Zvcm0+CisKKzxmb3JtIG5hbWU9Ii8iIGFjdGlvbj0iLyI+Cis8aW5w dXQgdHlwZT0idGV4dCIgaWQ9Im5vc2VhcmNoIj4KKzwvZm9ybT4KKworPHAgaWQ9ImRlc2NyaXB0 aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPHNjcmlwdD4KKworICAgIGRl c2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgd2UgY2FuIGRldGVjdCBhIHNlYXJjaCBmaWVsZCBi YXNlZCBvbiBhIGZldyBoZXVyaXN0aWNzLiIpOworCisgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmls aXR5Q29udHJvbGxlcikgeworCisgICAgICAgIGZvciAodmFyIGsgPSAxOyBrIDw9IDQ7IGsrKykg eworICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNlYXJjaCIgKyBrKS5mb2N1 cygpOworICAgICAgICAgICAgdmFyIHNlYXJjaCA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZv Y3VzZWRFbGVtZW50OworICAgICAgICAgICAgc2hvdWxkQmUoInNlYXJjaC5zdWJyb2xlIiwgIidB WFN1YnJvbGU6IEFYU2VhcmNoRmllbGQnIik7CisgICAgICAgIH0KKworICAgICAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgibm9zZWFyY2giKS5mb2N1cygpOworICAgICAgICB2YXIgbm9zZWFy Y2ggPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudDsKKyAgICAgICAgc2hv dWxkQmUoIm5vc2VhcmNoLnN1YnJvbGUiLCAiJ0FYU3Vicm9sZTogJyIpOworICAgIH0KKworPC9z Y3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0 LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXN1YnJvbGUtZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlYXJj aC1zdWJyb2xlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlYXJjaC1zdWJyb2xlLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSwxOSBAQAorCisKKworCisKK1RoaXMgdGVzdHMgdGhhdCB3ZSBjYW4g ZGV0ZWN0IGEgc2VhcmNoIGZpZWxkIGJhc2VkIG9uIGEgZmV3IGhldXJpc3RpY3MuCisKK09uIHN1 Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2Vk IGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHNlYXJjaC5zdWJyb2xlIGlzICdBWFN1YnJv bGU6IEFYU2VhcmNoRmllbGQnCitQQVNTIHNlYXJjaC5zdWJyb2xlIGlzICdBWFN1YnJvbGU6IEFY U2VhcmNoRmllbGQnCitQQVNTIHNlYXJjaC5zdWJyb2xlIGlzICdBWFN1YnJvbGU6IEFYU2VhcmNo RmllbGQnCitQQVNTIHNlYXJjaC5zdWJyb2xlIGlzICdBWFN1YnJvbGU6IEFYU2VhcmNoRmllbGQn CitQQVNTIG5vc2VhcmNoLnN1YnJvbGUgaXMgJ0FYU3Vicm9sZTogJworUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisK