82786 2012-03-30 14:58:54 -0700 Add a compile assert for the size of FontDescription 2012-03-30 15:36:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa darin eric gustavo kling koivisto mitz ojan pnormand tony xan.lopez oldest_to_newest 592521 0 rniwa 2012-03-30 14:58:54 -0700 Add a compile assert for the size of FontDescription 592531 1 134895 rniwa 2012-03-30 15:07:52 -0700 Created attachment 134895 Patch 592545 2 134895 pnormand 2012-03-30 15:24:02 -0700 Comment on attachment 134895 Patch Attachment 134895 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12266544 592546 3 134895 eric 2012-03-30 15:24:44 -0700 Comment on attachment 134895 Patch Seems reasonable. 592557 4 134895 rniwa 2012-03-30 15:30:50 -0700 Comment on attachment 134895 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134895&action=review > Source/WebCore/platform/graphics/FontDescription.cpp:42 > + uint32_t bitfields : 8; Oops, gotta rename this :( 592562 5 rniwa 2012-03-30 15:36:13 -0700 Committed r112736: <http://trac.webkit.org/changeset/112736> 134895 2012-03-30 15:07:52 -0700 2012-03-30 15:30:50 -0700 Patch bug-82786-20120330150751.patch text/plain 3237 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjcyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTMwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhIGNvbXBpbGUgYXNzZXJ0 IGZvciB0aGUgc2l6ZSBvZiBGb250RGVzY3JpcHRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGhlIGFzc2VydGlvbi4gQWxzbyBjb252ZXJ0 ZWQgYSBjb3VwbGUgb2YgYm9vbGVhbiBiaXRmaWVsZHMgdG8gdW5zaW5nZWQuCisgICAgICAgIEkn dmUgdmVyaWZpZWQgdGhhdCB0aGUgY29udmVyc2lvbnMgYXJlIHNhZmUgKHRoZXkncmUgb25seSB1 c2VkIGluIEZvbnREZXNjcmlwdGlvbi5oL2NwcCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9Gb250RGVzY3JpcHRpb24uY3BwOgorICAgICAgICAoU2FtZVNpemVBc0ZvbnREZXNjcmlw dGlvbik6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9G b250RGVzY3JpcHRpb24uaDoKKyAgICAgICAgKEZvbnREZXNjcmlwdGlvbik6CisKIDIwMTItMDMt MzAgIE5hdCBEdWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0g QnVtcCBtYXggdGV4dHVyZSB1cGRhdGVzIHBlciBmcmFtZSB0byA0OApJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udERlc2NyaXB0aW9uLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RGVzY3JpcHRpb24uY3BwCShy ZXZpc2lvbiAxMTI3MjMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250 RGVzY3JpcHRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw2ICszMiwxOCBAQAogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKK3N0cnVjdCBTYW1lU2l6ZUFzRm9udERlc2NyaXB0aW9uIHsKKyAg ICBGb250RmFtaWx5IGZhbWlseUxpc3Q7CisgICAgdm9pZCogc2V0dGluZ3M7CisgICAgUmVmUHRy PEZvbnRGZWF0dXJlU2V0dGluZ3M+IG1fZmVhdHVyZVNldHRpbmdzOworICAgIGZsb2F0IHNpemVz WzJdOworICAgIC8vIEZYSU1FOiBNYWtlIHRoZW0gZml0IGludG8gb25lIHdvcmQuCisgICAgdWlu dDMyX3QgYml0ZmllbGRzOworICAgIHVpbnQzMl90IGJpdGZpZWxkcyA6IDg7Cit9CisKK0NPTVBJ TEVfQVNTRVJUKHNpemVvZihGb250RGVzY3JpcHRpb24pID09IHNpemVvZihTYW1lU2l6ZUFzRm9u dERlc2NyaXB0aW9uKSwgRm9udERlc2NyaXB0aW9uX3Nob3VsZF9zdGF5X3NtYWxsKTsKKwogRm9u dFdlaWdodCBGb250RGVzY3JpcHRpb246OmxpZ2h0ZXJXZWlnaHQodm9pZCkgY29uc3QKIHsKICAg ICAvLyBGSVhNRTogU2hvdWxkIGFjdHVhbGx5IHJldHVybiB0aGUgQ1NTIHdlaWdodCBjb3JyZXNw b25kaW5nIHRvIG5leHQgbGlnaHRlc3QKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0ZvbnREZXNjcmlwdGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0ZvbnREZXNjcmlwdGlvbi5oCShyZXZpc2lvbiAxMTI3MjMpCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RGVzY3JpcHRpb24uaAkod29ya2lu ZyBjb3B5KQpAQCAtMTgyLDExICsxODIsMTEgQEAgcHJpdmF0ZToKIAogICAgIHVuc2lnbmVkIG1f aXRhbGljIDogMTsgLy8gRm9udEl0YWxpYwogICAgIHVuc2lnbmVkIG1fc21hbGxDYXBzIDogMTsg Ly8gRm9udFNtYWxsQ2FwcwotICAgIGJvb2wgbV9pc0Fic29sdXRlU2l6ZSA6IDE7ICAgLy8gV2hl dGhlciBvciBub3QgQ1NTIHNwZWNpZmllZCBhbiBleHBsaWNpdCBzaXplCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAvLyAobG9naWNhbCBzaXplcyBsaWtlICJtZWRpdW0iIGRvbid0 IGNvdW50KS4KKyAgICB1bnNpZ25lZCBtX2lzQWJzb2x1dGVTaXplIDogMTsgLy8gV2hldGhlciBv ciBub3QgQ1NTIHNwZWNpZmllZCBhbiBleHBsaWNpdCBzaXplCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgLy8gKGxvZ2ljYWwgc2l6ZXMgbGlrZSAibWVkaXVtIiBkb24ndCBjb3Vu dCkuCiAgICAgdW5zaWduZWQgbV93ZWlnaHQgOiA4OyAvLyBGb250V2VpZ2h0CiAgICAgdW5zaWdu ZWQgbV9nZW5lcmljRmFtaWx5IDogMzsgLy8gR2VuZXJpY0ZhbWlseVR5cGUKLSAgICBib29sIG1f dXNlUHJpbnRlckZvbnQgOiAxOworICAgIHVuc2lnbmVkIG1fdXNlUHJpbnRlckZvbnQgOiAxOwog CiAgICAgdW5zaWduZWQgbV9yZW5kZXJpbmdNb2RlIDogMTsgIC8vIFVzZWQgdG8gc3dpdGNoIGJl dHdlZW4gQ0cgYW5kIEdESSB0ZXh0IG9uIFdpbmRvd3MuCiAgICAgdW5zaWduZWQgbV9rZXJuaW5n IDogMjsgLy8gS2VybmluZwpAQCAtMjAxLDcgKzIwMSw3IEBAIHByaXZhdGU6CiAKICAgICB1bnNp Z25lZCBtX2ZvbnRTbW9vdGhpbmcgOiAyOyAvLyBGb250U21vb3RoaW5nTW9kZQogICAgIHVuc2ln bmVkIG1fdGV4dFJlbmRlcmluZyA6IDI7IC8vIFRleHRSZW5kZXJpbmdNb2RlCi0gICAgYm9vbCBt X2lzU3BlY2lmaWVkRm9udCA6IDE7IC8vIFRydWUgaWYgYSB3ZWIgcGFnZSBzcGVjaWZpZXMgYSBu b24tZ2VuZXJpYyBmb250IGZhbWlseSBhcyB0aGUgZmlyc3QgZm9udCBmYW1pbHkuCisgICAgdW5z aWduZWQgbV9pc1NwZWNpZmllZEZvbnQgOiAxOyAvLyBUcnVlIGlmIGEgd2ViIHBhZ2Ugc3BlY2lm aWVzIGEgbm9uLWdlbmVyaWMgZm9udCBmYW1pbHkgYXMgdGhlIGZpcnN0IGZvbnQgZmFtaWx5Lgog ICAgIFVTY3JpcHRDb2RlIG1fc2NyaXB0OyAvLyBVc2VkIHRvIGhlbHAgY2hvb3NlIGFuIGFwcHJv cHJpYXRlIGZvbnQgZm9yIGdlbmVyaWMgZm9udCBmYW1pbGllcy4KIH07CiAK