82780 2012-03-30 14:24:59 -0700 Add a compile assert for the size of RenderText 2012-03-30 22:16:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa darin dglazkov eric gustavo kling koivisto ojan pnormand tony webkit.review.bot xan.lopez oldest_to_newest 592498 0 rniwa 2012-03-30 14:24:59 -0700 Add a compile assert for the size of RenderText 592499 1 134882 rniwa 2012-03-30 14:25:48 -0700 Created attachment 134882 Patch 592505 2 134882 pnormand 2012-03-30 14:31:05 -0700 Comment on attachment 134882 Patch Attachment 134882 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12288439 592506 3 rniwa 2012-03-30 14:35:26 -0700 As I suspected, we need to re-order floats here. 592524 4 134890 rniwa 2012-03-30 15:01:50 -0700 Created attachment 134890 Fixed gtk build 592547 5 134890 webkit-ews 2012-03-30 15:24:58 -0700 Comment on attachment 134890 Fixed gtk build Attachment 134890 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12253485 592552 6 134890 webkit-ews 2012-03-30 15:27:48 -0700 Comment on attachment 134890 Fixed gtk build Attachment 134890 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12262469 592555 7 134890 webkit.review.bot 2012-03-30 15:29:00 -0700 Comment on attachment 134890 Fixed gtk build Attachment 134890 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12265492 592559 8 134890 buildbot 2012-03-30 15:31:50 -0700 Comment on attachment 134890 Fixed gtk build Attachment 134890 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12265490 592569 9 rniwa 2012-03-30 15:39:51 -0700 Oops, I also need to change the order of initialization :( 592570 10 134902 rniwa 2012-03-30 15:40:04 -0700 Created attachment 134902 Another build fix 592796 11 134902 dpranke 2012-03-30 21:50:26 -0700 Comment on attachment 134902 Another build fix View in context: https://bugs.webkit.org/attachment.cgi?id=134902&action=review > Source/WebCore/ChangeLog:8 > + Added an assertion. You should probably note that you moved fields around as well ... 592801 12 rniwa 2012-03-30 22:16:40 -0700 Committed r112776: <http://trac.webkit.org/changeset/112776> 134882 2012-03-30 14:25:48 -0700 2012-03-30 15:01:45 -0700 Patch bug-82780-20120330142547.patch text/plain 1329 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjcyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTMwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhIGNvbXBpbGUgYXNzZXJ0 IGZvciB0aGUgc2l6ZSBvZiBSZW5kZXJUZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04Mjc4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZGVkIGFuIGFzc2VydGlvbi4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJUZXh0LmNwcDoKKyAgICAgICAgKFNhbWVTaXplQXNSZW5kZXJUZXh0KToKKyAg ICAgICAgKFdlYkNvcmUpOgorCiAyMDEyLTAzLTMwICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFw cGxlLmNvbT4KIAogICAgICAgICBDYWNoZSBvcmlnaW4gY2hlY2sgcmVzdWx0IHRvIFJ1bGVEYXRh CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCShyZXZpc2lvbiAx MTI3MjMpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTUzLDYgKzUzLDE1IEBAIHVzaW5nIG5hbWVzcGFjZSBVbmljb2RlOwogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NsYXNzIFNhbWVTaXplQXNSZW5kZXJUZXh0IDogcHVibGlj IFJlbmRlck9iamVjdCB7CisgICAgZmxvYXQgd2lkdGhzWzRdOworICAgIFN0cmluZyB0ZXh0Owor ICAgIHZvaWQqIHBvaW50ZXJzWzJdOworICAgIHVpbnQzMl90IGJpdGZpZWxkcyA6IDE2OworfTsK KworQ09NUElMRV9BU1NFUlQoc2l6ZW9mKFJlbmRlclRleHQpID09IHNpemVvZihTYW1lU2l6ZUFz UmVuZGVyVGV4dCksIFJlbmRlclRleHRfc2hvdWxkX3N0YXlfc21hbGwpOworCiBjbGFzcyBTZWN1 cmVUZXh0VGltZXI7CiB0eXBlZGVmIEhhc2hNYXA8UmVuZGVyVGV4dCosIFNlY3VyZVRleHRUaW1l cio+IFNlY3VyZVRleHRUaW1lck1hcDsKIHN0YXRpYyBTZWN1cmVUZXh0VGltZXJNYXAqIGdTZWN1 cmVUZXh0VGltZXJzID0gMDsK 134890 2012-03-30 15:01:50 -0700 2012-03-30 15:38:40 -0700 Fixed gtk build bug-82780-20120330150148.patch text/plain 2238 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjcyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTMwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhIGNvbXBpbGUgYXNzZXJ0 IGZvciB0aGUgc2l6ZSBvZiBSZW5kZXJUZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04Mjc4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZGVkIGFuIGFzc2VydGlvbi4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJUZXh0LmNwcDoKKyAgICAgICAgKFNhbWVTaXplQXNSZW5kZXJUZXh0KToKKyAg ICAgICAgKFdlYkNvcmUpOgorCiAyMDEyLTAzLTMwICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEJ1bXAgbWF4IHRleHR1cmUgdXBkYXRlcyBwZXIg ZnJhbWUgdG8gNDgKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJ KHJldmlzaW9uIDExMjcyOSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTMsNiArNTMsMTUgQEAgdXNpbmcgbmFtZXNwYWNlIFVu aWNvZGU7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorY2xhc3MgU2FtZVNpemVBc1JlbmRlclRl eHQgOiBwdWJsaWMgUmVuZGVyT2JqZWN0IHsKKyAgICBmbG9hdCB3aWR0aHNbNF07CisgICAgU3Ry aW5nIHRleHQ7CisgICAgdm9pZCogcG9pbnRlcnNbMl07CisgICAgdWludDMyX3QgYml0ZmllbGRz IDogMTY7Cit9OworCitDT01QSUxFX0FTU0VSVChzaXplb2YoUmVuZGVyVGV4dCkgPT0gc2l6ZW9m KFNhbWVTaXplQXNSZW5kZXJUZXh0KSwgUmVuZGVyVGV4dF9zaG91bGRfc3RheV9zbWFsbCk7CisK IGNsYXNzIFNlY3VyZVRleHRUaW1lcjsKIHR5cGVkZWYgSGFzaE1hcDxSZW5kZXJUZXh0KiwgU2Vj dXJlVGV4dFRpbWVyKj4gU2VjdXJlVGV4dFRpbWVyTWFwOwogc3RhdGljIFNlY3VyZVRleHRUaW1l ck1hcCogZ1NlY3VyZVRleHRUaW1lcnMgPSAwOwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGV4dC5oCShyZXZpc2lvbiAxMTI3MjkpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjYsMTYgKzE2NiwxNSBAQCBwcml2 YXRlOgogICAgIHZvaWQgc2VjdXJlVGV4dChVQ2hhciBtYXNrKTsKIAogICAgIGZsb2F0IG1fbWlu V2lkdGg7IC8vIGhlcmUgdG8gbWluaW1pemUgcGFkZGluZyBpbiA2NC1iaXQuCisgICAgZmxvYXQg bV9tYXhXaWR0aDsKKyAgICBmbG9hdCBtX2JlZ2luTWluV2lkdGg7CisgICAgZmxvYXQgbV9lbmRN aW5XaWR0aDsKIAogICAgIFN0cmluZyBtX3RleHQ7CiAKICAgICBJbmxpbmVUZXh0Qm94KiBtX2Zp cnN0VGV4dEJveDsKICAgICBJbmxpbmVUZXh0Qm94KiBtX2xhc3RUZXh0Qm94OwogCi0gICAgZmxv YXQgbV9tYXhXaWR0aDsKLSAgICBmbG9hdCBtX2JlZ2luTWluV2lkdGg7Ci0gICAgZmxvYXQgbV9l bmRNaW5XaWR0aDsKLQogICAgIGJvb2wgbV9oYXNCcmVha2FibGVDaGFyIDogMTsgLy8gV2hldGhl ciBvciBub3Qgd2UgY2FuIGJlIGJyb2tlbiBpbnRvIG11bHRpcGxlIGxpbmVzLgogICAgIGJvb2wg bV9oYXNCcmVhayA6IDE7IC8vIFdoZXRoZXIgb3Igbm90IHdlIGhhdmUgYSBoYXJkIGJyZWFrIChl LmcuLCA8cHJlPiB3aXRoICdcbicpLgogICAgIGJvb2wgbV9oYXNUYWIgOiAxOyAvLyBXaGV0aGVy IG9yIG5vdCB3ZSBoYXZlIGEgdmFyaWFibGUgd2lkdGggdGFiIGNoYXJhY3RlciAoZS5nLiwgPHBy ZT4gd2l0aCAnXHQnKS4K 134902 2012-03-30 15:40:04 -0700 2012-03-30 21:50:26 -0700 Another build fix bug-82780-20120330154003.patch text/plain 2722 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjcyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTMwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhIGNvbXBpbGUgYXNzZXJ0 IGZvciB0aGUgc2l6ZSBvZiBSZW5kZXJUZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04Mjc4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZGVkIGFuIGFzc2VydGlvbi4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJUZXh0LmNwcDoKKyAgICAgICAgKFNhbWVTaXplQXNSZW5kZXJUZXh0KToKKyAg ICAgICAgKFdlYkNvcmUpOgorCiAyMDEyLTAzLTMwICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEJ1bXAgbWF4IHRleHR1cmUgdXBkYXRlcyBwZXIg ZnJhbWUgdG8gNDgKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJ KHJldmlzaW9uIDExMjcyOSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTMsNiArNTMsMTUgQEAgdXNpbmcgbmFtZXNwYWNlIFVu aWNvZGU7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorY2xhc3MgU2FtZVNpemVBc1JlbmRlclRl eHQgOiBwdWJsaWMgUmVuZGVyT2JqZWN0IHsKKyAgICBmbG9hdCB3aWR0aHNbNF07CisgICAgU3Ry aW5nIHRleHQ7CisgICAgdm9pZCogcG9pbnRlcnNbMl07CisgICAgdWludDMyX3QgYml0ZmllbGRz IDogMTY7Cit9OworCitDT01QSUxFX0FTU0VSVChzaXplb2YoUmVuZGVyVGV4dCkgPT0gc2l6ZW9m KFNhbWVTaXplQXNSZW5kZXJUZXh0KSwgUmVuZGVyVGV4dF9zaG91bGRfc3RheV9zbWFsbCk7CisK IGNsYXNzIFNlY3VyZVRleHRUaW1lcjsKIHR5cGVkZWYgSGFzaE1hcDxSZW5kZXJUZXh0KiwgU2Vj dXJlVGV4dFRpbWVyKj4gU2VjdXJlVGV4dFRpbWVyTWFwOwogc3RhdGljIFNlY3VyZVRleHRUaW1l ck1hcCogZ1NlY3VyZVRleHRUaW1lcnMgPSAwOwpAQCAtMTI3LDEyICsxMzYsMTIgQEAgc3RhdGlj IHZvaWQgbWFrZUNhcGl0YWxpemVkKFN0cmluZyogc3RyaQogUmVuZGVyVGV4dDo6UmVuZGVyVGV4 dChOb2RlKiBub2RlLCBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IHN0cikKICAgICAgOiBSZW5kZXJP YmplY3Qobm9kZSkKICAgICAgLCBtX21pbldpZHRoKC0xKQotICAgICAsIG1fdGV4dChzdHIpCi0g ICAgICwgbV9maXJzdFRleHRCb3goMCkKLSAgICAgLCBtX2xhc3RUZXh0Qm94KDApCiAgICAgICwg bV9tYXhXaWR0aCgtMSkKICAgICAgLCBtX2JlZ2luTWluV2lkdGgoMCkKICAgICAgLCBtX2VuZE1p bldpZHRoKDApCisgICAgICwgbV90ZXh0KHN0cikKKyAgICAgLCBtX2ZpcnN0VGV4dEJveCgwKQor ICAgICAsIG1fbGFzdFRleHRCb3goMCkKICAgICAgLCBtX2hhc1RhYihmYWxzZSkKICAgICAgLCBt X2xpbmVzRGlydHkoZmFsc2UpCiAgICAgICwgbV9jb250YWluc1JldmVyc2VkVGV4dChmYWxzZSkK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuaAkocmV2aXNpb24gMTEyNzI5 KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuaAkod29ya2luZyBjb3B5 KQpAQCAtMTY2LDE2ICsxNjYsMTUgQEAgcHJpdmF0ZToKICAgICB2b2lkIHNlY3VyZVRleHQoVUNo YXIgbWFzayk7CiAKICAgICBmbG9hdCBtX21pbldpZHRoOyAvLyBoZXJlIHRvIG1pbmltaXplIHBh ZGRpbmcgaW4gNjQtYml0LgorICAgIGZsb2F0IG1fbWF4V2lkdGg7CisgICAgZmxvYXQgbV9iZWdp bk1pbldpZHRoOworICAgIGZsb2F0IG1fZW5kTWluV2lkdGg7CiAKICAgICBTdHJpbmcgbV90ZXh0 OwogCiAgICAgSW5saW5lVGV4dEJveCogbV9maXJzdFRleHRCb3g7CiAgICAgSW5saW5lVGV4dEJv eCogbV9sYXN0VGV4dEJveDsKIAotICAgIGZsb2F0IG1fbWF4V2lkdGg7Ci0gICAgZmxvYXQgbV9i ZWdpbk1pbldpZHRoOwotICAgIGZsb2F0IG1fZW5kTWluV2lkdGg7Ci0KICAgICBib29sIG1faGFz QnJlYWthYmxlQ2hhciA6IDE7IC8vIFdoZXRoZXIgb3Igbm90IHdlIGNhbiBiZSBicm9rZW4gaW50 byBtdWx0aXBsZSBsaW5lcy4KICAgICBib29sIG1faGFzQnJlYWsgOiAxOyAvLyBXaGV0aGVyIG9y IG5vdCB3ZSBoYXZlIGEgaGFyZCBicmVhayAoZS5nLiwgPHByZT4gd2l0aCAnXG4nKS4KICAgICBi b29sIG1faGFzVGFiIDogMTsgLy8gV2hldGhlciBvciBub3Qgd2UgaGF2ZSBhIHZhcmlhYmxlIHdp ZHRoIHRhYiBjaGFyYWN0ZXIgKGUuZy4sIDxwcmU+IHdpdGggJ1x0JykuCg==