82767 2012-03-30 12:10:33 -0700 Add a compile assert for the size of InlineFlowBox 2012-03-30 14:21:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa darin eric hyatt kling koivisto mitz ojan tony webkit.review.bot oldest_to_newest 592376 0 rniwa 2012-03-30 12:10:33 -0700 Add a compile assert for the size of InlineFlowBox 592380 1 134856 rniwa 2012-03-30 12:12:44 -0700 Created attachment 134856 Patch 592393 2 134856 tony 2012-03-30 12:21:27 -0700 Comment on attachment 134856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134856&action=review > Source/WebCore/rendering/InlineFlowBox.cpp:50 > + uint32_t bitfields : 24; Can we drop the : 24? It's always going to round up to the packing size, right? > Source/WebCore/rendering/InlineFlowBox.h:315 > + unsigned m_hasAnnotationsBefore : 1; > + unsigned m_hasAnnotationsAfter : 1; Should we add getters and setters for these (I guess to RootInlineBox)? 592395 3 134856 rniwa 2012-03-30 12:23:57 -0700 Comment on attachment 134856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134856&action=review >> Source/WebCore/rendering/InlineFlowBox.h:315 >> + unsigned m_hasAnnotationsAfter : 1; > > Should we add getters and setters for these (I guess to RootInlineBox)? Maybe in the future. As is, these member variables are only used by RootInlineBox. It'll be nice if we had some macro or WTF template that enforces such a restriction. 592464 4 134856 ojan 2012-03-30 13:47:04 -0700 Comment on attachment 134856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134856&action=review >>> Source/WebCore/rendering/InlineFlowBox.h:315 >>> + unsigned m_hasAnnotationsAfter : 1; >> >> Should we add getters and setters for these (I guess to RootInlineBox)? > > Maybe in the future. As is, these member variables are only used by RootInlineBox. > It'll be nice if we had some macro or WTF template that enforces such a restriction. Not adding getters/setters seems like it's asking for bugs down the road. Can you just make these private and manually add protected getters/setters? For something simple like this, I don't think we need complicated macros/templates. 592489 5 134856 webkit.review.bot 2012-03-30 14:14:44 -0700 Comment on attachment 134856 Patch Clearing flags on attachment: 134856 Committed r112725: <http://trac.webkit.org/changeset/112725> 592490 6 webkit.review.bot 2012-03-30 14:14:49 -0700 All reviewed patches have been landed. Closing bug. 592495 7 rniwa 2012-03-30 14:21:12 -0700 (In reply to comment #4) > Not adding getters/setters seems like it's asking for bugs down the road. Can you just make these private and manually add protected getters/setters? For something simple like this, I don't think we need complicated macros/templates. I wouldn't think so since these member variables are only used in InlineFlowBox and RootInlineBox but I wouldn't object to making such a change. 134856 2012-03-30 12:12:44 -0700 2012-03-30 14:14:44 -0700 Patch bug-82767-20120330121243.patch text/plain 3275 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjcwOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAzLTMwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhIGNvbXBpbGUgYXNzZXJ0 IGZvciB0aGUgc2l6ZSBvZiBJbmxpbmVGbG93Qm94CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Mjc2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGNvbXBpbGUgYXNzZXJ0IHRvIGVuc3VyZSBJbmxp bmVGbG93Qm94IHN0YXlzIHNtYWxsLgorICAgICAgICBBbHNvIG1ha2Ugc29tZSBvZiB0aGUgbWVt YmVyIHZhcmlhYmxlcyBub3QgdXNlZCBpbiBSb290SW5saW5lQm94IHByaXZhdGUuCisKKyAgICAg ICAgQ2hhbmdpbmcgdGhlc2UgYm9vbGVhbnMgdG8gdW5zaWduZWQgaXMgc2FmZSBhcyBJJ3ZlIGF1 ZGl0ZWQgYWxsIGNvZGUgdGhhdAorICAgICAgICB1c2VzIHRoZXNlIG1lbWJlciB2YXJpYWJsZXMg KHRoZXkncmUgYWxsIGluIElubGluZUZsb3dCb3ggb3IgUm9vdElubGluZUJveCkuCisKKyAgICAg ICAgKiByZW5kZXJpbmcvSW5saW5lRmxvd0JveC5jcHA6CisgICAgICAgIChTYW1lU2l6ZUFzSW5s aW5lRmxvd0JveCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiByZW5kZXJpbmcvSW5s aW5lRmxvd0JveC5oOgorICAgICAgICAoSW5saW5lRmxvd0JveCk6CisKIDIwMTItMDMtMzAgIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBTaG93IGEgc2Ny b2xsaW5nIGluZGljYXRvciBsaWdodCB3aGVuIGNvbXBvc2l0aW5nIGJvcmRlcnMgYXJlIHR1cm5l ZCBvbgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcAko cmV2aXNpb24gMTEyNjk2KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dC b3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NSw2ICs0NSwxMyBAQCB1c2luZyBuYW1lc3BhY2Ug c3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NsYXNzIFNhbWVTaXplQXNJbmxpbmVGbG93 Qm94IDogcHVibGljIElubGluZUJveCB7CisgICAgdm9pZCogcG9pbnRlcnNbNV07CisgICAgdWlu dDMyX3QgYml0ZmllbGRzIDogMjQ7Cit9OworCitDT01QSUxFX0FTU0VSVChzaXplb2YoSW5saW5l Rmxvd0JveCkgPT0gc2l6ZW9mKFNhbWVTaXplQXNJbmxpbmVGbG93Qm94KSwgSW5saW5lRmxvd0Jv eF9zaG91bGRfc3RheV9zbWFsbCk7CisKICNpZm5kZWYgTkRFQlVHCiAKIElubGluZUZsb3dCb3g6 On5JbmxpbmVGbG93Qm94KCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVG bG93Qm94LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZs b3dCb3guaAkocmV2aXNpb24gMTEyNjk2KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lu bGluZUZsb3dCb3guaAkod29ya2luZyBjb3B5KQpAQCAtMjk3LDIwICsyOTcsMjIgQEAgcHJvdGVj dGVkOgogICAgIElubGluZUZsb3dCb3gqIG1fcHJldkxpbmVCb3g7IC8vIFRoZSBwcmV2aW91cyBi b3ggdGhhdCBhbHNvIHVzZXMgb3VyIFJlbmRlck9iamVjdAogICAgIElubGluZUZsb3dCb3gqIG1f bmV4dExpbmVCb3g7IC8vIFRoZSBuZXh0IGJveCB0aGF0IGFsc28gdXNlcyBvdXIgUmVuZGVyT2Jq ZWN0CiAKLSAgICBib29sIG1faW5jbHVkZUxvZ2ljYWxMZWZ0RWRnZSA6IDE7Ci0gICAgYm9vbCBt X2luY2x1ZGVMb2dpY2FsUmlnaHRFZGdlIDogMTsKLSAgICBib29sIG1faGFzVGV4dENoaWxkcmVu IDogMTsKLSAgICBib29sIG1faGFzVGV4dERlc2NlbmRhbnRzIDogMTsKLSAgICBib29sIG1fZGVz Y2VuZGFudHNIYXZlU2FtZUxpbmVIZWlnaHRBbmRCYXNlbGluZSA6IDE7Citwcml2YXRlOgorICAg IHVuc2lnbmVkIG1faW5jbHVkZUxvZ2ljYWxMZWZ0RWRnZSA6IDE7CisgICAgdW5zaWduZWQgbV9p bmNsdWRlTG9naWNhbFJpZ2h0RWRnZSA6IDE7CisgICAgdW5zaWduZWQgbV9oYXNUZXh0Q2hpbGRy ZW4gOiAxOworICAgIHVuc2lnbmVkIG1faGFzVGV4dERlc2NlbmRhbnRzIDogMTsKKyAgICB1bnNp Z25lZCBtX2Rlc2NlbmRhbnRzSGF2ZVNhbWVMaW5lSGVpZ2h0QW5kQmFzZWxpbmUgOiAxOwogCitw cm90ZWN0ZWQ6CiAgICAgLy8gVGhlIGZvbGxvd2luZyBtZW1iZXJzIGFyZSBvbmx5IHVzZWQgYnkg Um9vdElubGluZUJveCBidXQgbW92ZWQgaGVyZSB0byBrZWVwIHRoZSBiaXRzIHBhY2tlZC4KIAog ICAgIC8vIFdoZXRoZXIgb3Igbm90IHRoaXMgbGluZSB1c2VzIGFscGhhYmV0aWMgb3IgaWRlb2dy YXBoaWMgYmFzZWxpbmVzIGJ5IGRlZmF1bHQuCiAgICAgdW5zaWduZWQgbV9iYXNlbGluZVR5cGUg OiAxOyAvLyBGb250QmFzZWxpbmUKIAogICAgIC8vIElmIHRoZSBsaW5lIGNvbnRhaW5zIGFueSBy dWJ5IHJ1bnMsIHRoZW4gdGhpcyB3aWxsIGJlIHRydWUuCi0gICAgYm9vbCBtX2hhc0Fubm90YXRp b25zQmVmb3JlIDogMTsKLSAgICBib29sIG1faGFzQW5ub3RhdGlvbnNBZnRlciA6IDE7CisgICAg dW5zaWduZWQgbV9oYXNBbm5vdGF0aW9uc0JlZm9yZSA6IDE7CisgICAgdW5zaWduZWQgbV9oYXNB bm5vdGF0aW9uc0FmdGVyIDogMTsKIAogICAgIHVuc2lnbmVkIG1fbGluZUJyZWFrQmlkaVN0YXR1 c0VvciA6IDU7IC8vIFdURjo6VW5pY29kZTo6RGlyZWN0aW9uCiAgICAgdW5zaWduZWQgbV9saW5l QnJlYWtCaWRpU3RhdHVzTGFzdFN0cm9uZyA6IDU7IC8vIFdURjo6VW5pY29kZTo6RGlyZWN0aW9u CkBAIC0zMjAsNyArMzIyLDcgQEAgcHJvdGVjdGVkOgogCiAjaWZuZGVmIE5ERUJVRwogcHJpdmF0 ZToKLSAgICBib29sIG1faGFzQmFkQ2hpbGRMaXN0OworICAgIHVuc2lnbmVkIG1faGFzQmFkQ2hp bGRMaXN0IDogMTsKICNlbmRpZgogfTsKIAo=