82761 2012-03-30 11:40:45 -0700 fast/forms/search-event-delay.html is asserting in markAllMisspellingsAndBadGrammarInRanges() 2012-09-18 15:44:46 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser enrica jiapu.mail kling mitz morrita rniwa simon.fraser webkit-bug-importer oldest_to_newest 592348 0 simon.fraser 2012-03-30 11:40:45 -0700 Test is hitting this on the bots: ASSERTION FAILED: unifiedTextCheckerEnabled() /Volumes/Data/slave/lion-intel-debug/build/Source/WebCore/editing/Editor.cpp(1911) : void WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeMask, WebCore::Range *, WebCore::Range *) 1 0x10ac62b53 WebCore::SpellingCorrectionController::correctionPanelTimerFired(WebCore::Timer<WebCore::SpellingCorrectionController>*) 2 0x10ac66fe3 WebCore::Timer<WebCore::SpellingCorrectionController>::fired() 3 0x10ae6e107 WebCore::ThreadTimers::sharedTimerFiredInternal() 4 0x10ae6de49 WebCore::ThreadTimers::sharedTimerFired() 5 0x10ac34483 _ZN7WebCoreL10timerFiredEP16__CFRunLoopTimerPv 6 0x7fff8bbbec24 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 7 0x7fff8bbbe776 __CFRunLoopDoTimer 8 0x7fff8bb9f001 __CFRunLoopRun 9 0x7fff8bb9e676 CFRunLoopRunSpecific 10 0x7fff89940f9f -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 11 0x1082657b9 _ZL7runTestRKNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEE 12 0x1082640aa _ZL20runTestingServerLoopv 13 0x108263919 dumpRenderTree(int, char const**) 14 0x10826601c main 15 0x10824f364 start 592679 1 webkit-bug-importer 2012-03-30 17:40:33 -0700 <rdar://problem/11159937> 592683 2 simon.fraser 2012-03-30 17:44:40 -0700 I'm adding ASSERT(m_frame) to see if that's the issue. 723061 3 simon.fraser 2012-09-18 14:42:27 -0700 I think DRT and WTR need to reset the 'unifiedTextCheckingEnabled' pref between tests. 723075 4 simon.fraser 2012-09-18 15:03:21 -0700 *** Bug 96012 has been marked as a duplicate of this bug. *** 723078 5 simon.fraser 2012-09-18 15:04:10 -0700 *** Bug 85273 has been marked as a duplicate of this bug. *** 723085 6 164627 simon.fraser 2012-09-18 15:17:59 -0700 Created attachment 164627 Patch 723098 7 164627 rniwa 2012-09-18 15:35:49 -0700 Comment on attachment 164627 Patch Looks reasonable. 723108 8 simon.fraser 2012-09-18 15:44:46 -0700 http://trac.webkit.org/changeset/128941 164627 2012-09-18 15:17:59 -0700 2012-09-18 15:35:48 -0700 Patch bug-82761-20120918151729.patch text/plain 3273 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4OTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODc4MTNjMGM2M2M2NDM3 OGZmNjA3NzY0ZjcxNjM3MjY2Y2RjMmVlZC4uYTEzZDM5ODVhNzFlZDI3MTM0MTAzYmQ5MGQ2YmRj MmQzY2FkOTRlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTE4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIGZhc3QvZm9ybXMv c2VhcmNoLWV2ZW50LWRlbGF5Lmh0bWwgaXMgYXNzZXJ0aW5nIGluIG1hcmtBbGxNaXNzcGVsbGlu Z3NBbmRCYWRHcmFtbWFySW5SYW5nZXMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODI3NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTcGVjdWxhdGl2ZSBmaXggZm9yIHRoaXMgYXNzZXJ0aW9uOiBoYXZl IEludGVybmFsU2V0dGluZ3Mgc2F2ZQorICAgICAgICBhbmQgcmVzdG9yZSB0aGUgdmFsdWUgb2Yg dGhlICJ1bmlmaWVkVGV4dENoZWNrZXJFbmFibGVkIiBzZXR0aW5nCisgICAgICAgIGJldHdlZW4g dGVzdHMsIHNvIHRoYXQgdGVzdHMgY2hhbmdlIHRoZSB2YWx1ZSBvZiB0aGlzIHNldHRpbmcgZG9u J3QKKyAgICAgICAgYWZmZWN0IGxhdGVyIHRlc3RzLgorCisgICAgICAgICogdGVzdGluZy9JbnRl cm5hbFNldHRpbmdzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsU2V0dGluZ3M6OkJh Y2t1cDo6QmFja3VwKToKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsU2V0dGluZ3M6OkJhY2t1 cDo6cmVzdG9yZVRvKToKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFsU2V0dGluZ3MuaDoKKyAg ICAgICAgKEJhY2t1cCk6CisKIDIwMTItMDktMTggIEpvaG4gTWVsbG9yICA8am9obm1lQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBUZXh0IEF1dG9zaXppbmc6IElnbm9yZSBjb25zdHJhaW5lZCBo ZWlnaHRzIGluIGNlcnRhaW4gY2lyY3Vtc3RhbmNlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFsU2V0dGluZ3MuY3BwCmluZGV4IGI5NWJiYzM2Y2Q1MTdhY2E0NzdiMGZiMDIwNTdi NDdjYThiYTkyMWUuLjFhNGMxNWE3NWY3OGRlNmY1N2ZhZmJhY2Q5ZDYyODAxZjQyMWQ3ZTkgMTAw NzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmNwcApAQCAtODAsNiAr ODAsNyBAQCBJbnRlcm5hbFNldHRpbmdzOjpCYWNrdXA6OkJhY2t1cChQYWdlKiBwYWdlLCBTZXR0 aW5ncyogc2V0dGluZ3MpCiAgICAgLCBtX29yaWdpbmFsQXV0aG9yU2hhZG93RE9NRm9yQW55RWxl bWVudEVuYWJsZWQoUnVudGltZUVuYWJsZWRGZWF0dXJlczo6YXV0aG9yU2hhZG93RE9NRm9yQW55 RWxlbWVudEVuYWJsZWQoKSkKICNlbmRpZgogICAgICwgbV9vcmlnaW5hbEVkaXRpbmdCZWhhdmlv cihzZXR0aW5ncy0+ZWRpdGluZ0JlaGF2aW9yVHlwZSgpKQorICAgICwgbV9vcmlnaW5hbFVuaWZp ZWRTcGVsbENoZWNrZXJFbmFibGVkKHNldHRpbmdzLT51bmlmaWVkVGV4dENoZWNrZXJFbmFibGVk KCkpCiAgICAgLCBtX29yaWdpbmFsRml4ZWRQb3NpdGlvbkNyZWF0ZXNTdGFja2luZ0NvbnRleHQo c2V0dGluZ3MtPmZpeGVkUG9zaXRpb25DcmVhdGVzU3RhY2tpbmdDb250ZXh0KCkpCiAgICAgLCBt X29yaWdpbmFsU3luY1hIUkluRG9jdW1lbnRzRW5hYmxlZChzZXR0aW5ncy0+c3luY1hIUkluRG9j dW1lbnRzRW5hYmxlZCgpKQogI2lmIEVOQUJMRShJTlNQRUNUT1IpICYmIEVOQUJMRShKQVZBU0NS SVBUX0RFQlVHR0VSKQpAQCAtMTEzLDYgKzExNCw3IEBAIHZvaWQgSW50ZXJuYWxTZXR0aW5nczo6 QmFja3VwOjpyZXN0b3JlVG8oUGFnZSogcGFnZSwgU2V0dGluZ3MqIHNldHRpbmdzKQogICAgIFJ1 bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNldEF1dGhvclNoYWRvd0RPTUZvckFueUVsZW1lbnRFbmFi bGVkKG1fb3JpZ2luYWxBdXRob3JTaGFkb3dET01Gb3JBbnlFbGVtZW50RW5hYmxlZCk7CiAjZW5k aWYKICAgICBzZXR0aW5ncy0+c2V0RWRpdGluZ0JlaGF2aW9yVHlwZShtX29yaWdpbmFsRWRpdGlu Z0JlaGF2aW9yKTsKKyAgICBzZXR0aW5ncy0+c2V0VW5pZmllZFRleHRDaGVja2VyRW5hYmxlZCht X29yaWdpbmFsVW5pZmllZFNwZWxsQ2hlY2tlckVuYWJsZWQpOwogICAgIHNldHRpbmdzLT5zZXRG aXhlZFBvc2l0aW9uQ3JlYXRlc1N0YWNraW5nQ29udGV4dChtX29yaWdpbmFsRml4ZWRQb3NpdGlv bkNyZWF0ZXNTdGFja2luZ0NvbnRleHQpOwogICAgIHNldHRpbmdzLT5zZXRTeW5jWEhSSW5Eb2N1 bWVudHNFbmFibGVkKG1fb3JpZ2luYWxTeW5jWEhSSW5Eb2N1bWVudHNFbmFibGVkKTsKICNpZiBF TkFCTEUoSU5TUEVDVE9SKSAmJiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5oIGIvU291cmNlL1dl YkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmgKaW5kZXggZjVhYWQ4ZWRjMjJhMzAwNDRk YjMwODA2MjI4NWQ4Mjc4ZTg2MTRkYS4uNzQ0ZTVhYjcyNzM3OGUzYjViZmM4YjA4ZjgzZjgzOTJi MGIwYjFlOSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRp bmdzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmgKQEAg LTYyLDYgKzYyLDcgQEAgcHVibGljOgogICAgICAgICBib29sIG1fb3JpZ2luYWxBdXRob3JTaGFk b3dET01Gb3JBbnlFbGVtZW50RW5hYmxlZDsKICNlbmRpZgogICAgICAgICBFZGl0aW5nQmVoYXZp b3JUeXBlIG1fb3JpZ2luYWxFZGl0aW5nQmVoYXZpb3I7CisgICAgICAgIGJvb2wgbV9vcmlnaW5h bFVuaWZpZWRTcGVsbENoZWNrZXJFbmFibGVkOwogICAgICAgICBib29sIG1fb3JpZ2luYWxGaXhl ZFBvc2l0aW9uQ3JlYXRlc1N0YWNraW5nQ29udGV4dDsKICAgICAgICAgYm9vbCBtX29yaWdpbmFs U3luY1hIUkluRG9jdW1lbnRzRW5hYmxlZDsKICNpZiBFTkFCTEUoSU5TUEVDVE9SKSAmJiBFTkFC TEUoSkFWQVNDUklQVF9ERUJVR0dFUikK