82760 2012-03-30 11:32:26 -0700 WebViewImpl doesn't notify the page that the user has canceled fullscreen. 2012-04-03 00:21:34 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 bbudge webkit-unassigned fishd gustavo pnormand webkit.review.bot xan.lopez oldest_to_newest 592341 0 bbudge 2012-03-30 11:32:26 -0700 Recent changes in WebCore::Document caused a regression in Chromium. The page isn't getting notified when the user presses ESC or clicks the exit fullscreen bubble. http://trac.webkit.org/changeset/112596 592401 1 134862 bbudge 2012-03-30 12:35:03 -0700 Created attachment 134862 Proposed Patch 592507 2 134862 fishd 2012-03-30 14:38:42 -0700 Comment on attachment 134862 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134862&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:1337 > + doc->webkitCancelFullScreen(); I was expecting to see webkitCancelFullScreen called from willExitFullScreen. The implication of calling webkitCancelFullScreen here is that we will have already called Document::webkitWillExitFullScreenForElement. It seems like that might confuse Document (if not now, then later). 592602 3 134908 bbudge 2012-03-30 15:59:37 -0700 Created attachment 134908 Proposed patch 592718 4 134908 pnormand 2012-03-30 18:40:34 -0700 Comment on attachment 134908 Proposed patch Attachment 134908 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12247610 592909 5 134973 bbudge 2012-03-31 12:36:54 -0700 Created attachment 134973 Proposed Patch 592910 6 bbudge 2012-03-31 12:38:14 -0700 Resubmitting. There was some problem with the last patch on GTK. 593686 7 134973 fishd 2012-04-02 12:29:03 -0700 Comment on attachment 134973 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134973&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:1327 > + doc->webkitCancelFullScreen(); if exiting fullscreen is initiated by JS calling document.webkitCancelFullScreen(), then we will eventually reach this code again. it looks like the second call to webkitCancelFullScreen() will call webkitExitFullscreen(). in this case, do we have to worry about a second webkitfullscreenchange event being generated? it looks like Document::addDocumentToFullScreenChangeEventQueue() could be called more than once. 593792 8 bbudge 2012-04-02 13:49:53 -0700 When we call webkitCancelFullScreen the second time, it exits at the first if-statement: if (!topDocument()->webkitFullscreenElement()) return; It seems a little fragile, but webkitExitFullscreen() isn't called a second time. If we want to avoid the second call, I can't see a way to distinguish whether the cancel is coming from the page or the embedder at this level. Ideas? 594224 9 134973 fishd 2012-04-02 23:25:29 -0700 Comment on attachment 134973 Proposed Patch OK, thanks for verifying that! 594254 10 134973 webkit.review.bot 2012-04-03 00:21:29 -0700 Comment on attachment 134973 Proposed Patch Clearing flags on attachment: 134973 Committed r112991: <http://trac.webkit.org/changeset/112991> 594255 11 webkit.review.bot 2012-04-03 00:21:34 -0700 All reviewed patches have been landed. Closing bug. 134862 2012-03-30 12:35:03 -0700 2012-03-30 15:59:37 -0700 Proposed Patch aaa.txt text/plain 2001 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTI3MTApCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIy IEBACisyMDEyLTAzLTMwICBCaWxsIEJ1ZGdlICA8YmJ1ZGdlQGNocm9taXVtLm9yZz4KKworICAg ICAgICBXZWJWaWV3SW1wbCBkb2Vzbid0IG5vdGlmeSB0aGUgcGFnZSB0aGF0IHRoZSB1c2VyIGhh cyBjYW5jZWxlZCBmdWxsc2NyZWVuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODI3NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlZpZXdJbXBsOjpkaWRFeGl0RnVsbFNjcmVlbik6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJ bXBsOjpleGl0RnVsbFNjcmVlbkZvckVsZW1lbnQpOgorCisyMDEyLTAzLTMwICBCaWxsIEJ1ZGdl ICA8YmJ1ZGdlQGNocm9taXVtLm9yZz4KKworICAgICAgICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRp b24gYW5kIGJ1ZyBVUkwgKE9PUFMhKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKwogMjAxMi0wMy0zMCAgSWFu IFZvbGxpY2sgIDx2b2xsaWNrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEZs YWt5IGFuaW1hdGlvbiB1bml0IHRlc3QgQ0NMYXllclRyZWVIb3N0VGVzdFN5bmNocm9uaXplQW5p bWF0aW9uU3RhcnRUaW1lcwpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp ZXdJbXBsLmNwcAkocmV2aXNpb24gMTEyNzA5KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMwLDEyICsxMzMwLDEzIEBA IHZvaWQgV2ViVmlld0ltcGw6OmRpZEV4aXRGdWxsU2NyZWVuKCkKICAgICBpZiAoIW1fZnVsbFNj cmVlbkZyYW1lKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoRG9jdW1lbnQqIGRvYyA9IG1f ZnVsbFNjcmVlbkZyYW1lLT5kb2N1bWVudCgpKSB7Ci0gICAgICAgIGlmIChkb2MtPndlYmtpdElz RnVsbFNjcmVlbigpKQotICAgICAgICAgICAgZG9jLT53ZWJraXREaWRFeGl0RnVsbFNjcmVlbkZv ckVsZW1lbnQoMCk7Ci0gICAgfQotCisgICAgRG9jdW1lbnQqIGRvYyA9IG1fZnVsbFNjcmVlbkZy YW1lLT5kb2N1bWVudCgpOworICAgIC8vIENsZWFyIG1fZnVsbFNjcmVlbkZyYW1lIG5vdyB0byBz dXBwcmVzcyB0aGUgY2xpZW50IG5vdGlmaWNhdGlvbi4KICAgICBtX2Z1bGxTY3JlZW5GcmFtZS5j bGVhcigpOworICAgIGlmIChkb2MgJiYgZG9jLT53ZWJraXRJc0Z1bGxTY3JlZW4oKSkgeworICAg ICAgICBkb2MtPndlYmtpdENhbmNlbEZ1bGxTY3JlZW4oKTsKKyAgICAgICAgZG9jLT53ZWJraXRE aWRFeGl0RnVsbFNjcmVlbkZvckVsZW1lbnQoMCk7CisgICAgfQogI2VuZGlmCiB9CiAKQEAgLTE1 NTQsNyArMTU1NSw3IEBAIHZvaWQgV2ViVmlld0ltcGw6OmVudGVyRnVsbFNjcmVlbkZvckVsZW0K IAogdm9pZCBXZWJWaWV3SW1wbDo6ZXhpdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KFdlYkNvcmU6OkVs ZW1lbnQqIGVsZW1lbnQpCiB7Ci0gICAgaWYgKG1fY2xpZW50KQorICAgIGlmIChtX2NsaWVudCAm JiBtX2Z1bGxTY3JlZW5GcmFtZSkKICAgICAgICAgbV9jbGllbnQtPmV4aXRGdWxsU2NyZWVuKCk7 CiB9CiAK 134908 2012-03-30 15:59:37 -0700 2012-03-31 12:37:43 -0700 Proposed patch aaa.txt text/plain 2682 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTI3MjkpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEz IEBACisyMDEyLTAzLTMwICBCaWxsIEJ1ZGdlICA8YmJ1ZGdlQGNocm9taXVtLm9yZz4KKworICAg ICAgICBXZWJWaWV3SW1wbCBkb2Vzbid0IG5vdGlmeSB0aGUgcGFnZSB0aGF0IHRoZSB1c2VyIGhh cyBjYW5jZWxlZCBmdWxsc2NyZWVuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODI3NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgICogc3JjL1dlYlZp ZXdJbXBsLmg6CisKIDIwMTItMDMtMzAgIE1hcmsgUGlsZ3JpbSAgPHBpbGdyaW1AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIEdFT0xPQ0FUSU9OIHNob3VsZCBiZSBpbXBsZW1lbnRlZCBhcyBQYWdl IFN1cHBsZW1lbnQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBs LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5jcHAJKHJldmlzaW9uIDExMjcyOSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzU2LDYgKzM1Niw3IEBAIFdlYlZpZXdJ bXBsOjpXZWJWaWV3SW1wbChXZWJWaWV3Q2xpZW50KiAKICAgICAsIG1faXNUcmFuc3BhcmVudChm YWxzZSkKICAgICAsIG1fdGFic1RvTGlua3MoZmFsc2UpCiAgICAgLCBtX2RyYWdTY3JvbGxUaW1l cihhZG9wdFB0cihuZXcgRHJhZ1Njcm9sbFRpbWVyKSkKKyAgICAsIG1faXNDYW5jZWxpbmdGdWxs U2NyZWVuKGZhbHNlKQogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICAsIG1f cm9vdEdyYXBoaWNzTGF5ZXIoMCkKICAgICAsIG1faXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0 aXZlKGZhbHNlKQpAQCAtMTMxOSw4ICsxMzIwLDE0IEBAIHZvaWQgV2ViVmlld0ltcGw6OndpbGxF eGl0RnVsbFNjcmVlbigpCiAgICAgICAgIHJldHVybjsKIAogICAgIGlmIChEb2N1bWVudCogZG9j ID0gbV9mdWxsU2NyZWVuRnJhbWUtPmRvY3VtZW50KCkpIHsKLSAgICAgICAgaWYgKGRvYy0+d2Vi a2l0SXNGdWxsU2NyZWVuKCkpCisgICAgICAgIGlmIChkb2MtPndlYmtpdElzRnVsbFNjcmVlbigp KSB7CisgICAgICAgICAgICAvLyBXaGVuIHRoZSBjbGllbnQgZXhpdHMgZnJvbSBmdWxsIHNjcmVl biB3ZSBoYXZlIHRvIGNhbGwgd2Via2l0Q2FuY2VsRnVsbFNjcmVlbiB0bworICAgICAgICAgICAg Ly8gbm90aWZ5IHRoZSBkb2N1bWVudC4gV2hpbGUgZG9pbmcgdGhhdCwgc3VwcHJlc3Mgbm90aWZp Y2F0aW9ucyBiYWNrIHRvIHRoZSBjbGllbnQuCisgICAgICAgICAgICBtX2lzQ2FuY2VsaW5nRnVs bFNjcmVlbiA9IHRydWU7CisgICAgICAgICAgICBkb2MtPndlYmtpdENhbmNlbEZ1bGxTY3JlZW4o KTsKKyAgICAgICAgICAgIG1faXNDYW5jZWxpbmdGdWxsU2NyZWVuID0gZmFsc2U7CiAgICAgICAg ICAgICBkb2MtPndlYmtpdFdpbGxFeGl0RnVsbFNjcmVlbkZvckVsZW1lbnQoMCk7CisgICAgICAg IH0KICAgICB9CiAjZW5kaWYKIH0KQEAgLTE1NTUsNiArMTU2Miw5IEBAIHZvaWQgV2ViVmlld0lt cGw6OmVudGVyRnVsbFNjcmVlbkZvckVsZW0KIAogdm9pZCBXZWJWaWV3SW1wbDo6ZXhpdEZ1bGxT Y3JlZW5Gb3JFbGVtZW50KFdlYkNvcmU6OkVsZW1lbnQqIGVsZW1lbnQpCiB7CisgICAgLy8gVGhl IGNsaWVudCBpcyBleGl0aW5nIGZ1bGwgc2NyZWVuLCBzbyBkb24ndCBzZW5kIGEgbm90aWZpY2F0 aW9uLgorICAgIGlmIChtX2lzQ2FuY2VsaW5nRnVsbFNjcmVlbikKKyAgICAgICAgcmV0dXJuOwog ICAgIGlmIChtX2NsaWVudCkKICAgICAgICAgbV9jbGllbnQtPmV4aXRGdWxsU2NyZWVuKCk7CiB9 CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgJKHJldmlzaW9u IDExMjcyOSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgJKHdv cmtpbmcgY29weSkKQEAgLTcxNCw2ICs3MTQsNyBAQCBwcml2YXRlOgogCiAgICAgLy8gSWYgc2V0 LCB0aGUgV2ViVmlldyBpcyBpbiBmdWxsc2NyZWVuIG1vZGUgZm9yIGFuIGVsZW1lbnQgaW4gdGhp cyBmcmFtZS4KICAgICBSZWZQdHI8V2ViQ29yZTo6RnJhbWU+IG1fZnVsbFNjcmVlbkZyYW1lOwor ICAgIGJvb2wgbV9pc0NhbmNlbGluZ0Z1bGxTY3JlZW47CiAKICNpZiBVU0UoQUNDRUxFUkFURURf Q09NUE9TSVRJTkcpCiAgICAgV2ViQ29yZTo6SW50UmVjdCBtX3Jvb3RMYXllclNjcm9sbERhbWFn ZTsK 134973 2012-03-31 12:36:54 -0700 2012-04-03 00:21:29 -0700 Proposed Patch aaa.txt text/plain 2820 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTI3OTkpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTAzLTMxICBCaWxsIEJ1ZGdlICA8YmJ1ZGdlQGNocm9taXVtLm9yZz4KKworICAg ICAgICBXZWJWaWV3SW1wbCBkb2Vzbid0IG5vdGlmeSB0aGUgcGFnZSB0aGF0IHRoZSB1c2VyIGhh cyBjYW5jZWxlZCBmdWxsc2NyZWVuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODI3NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlZpZXdJbXBsOjpXZWJWaWV3SW1wbCk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjp3 aWxsRXhpdEZ1bGxTY3JlZW4pOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6ZXhpdEZ1 bGxTY3JlZW5Gb3JFbGVtZW50KToKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuaDoKKwogMjAx Mi0wMy0yOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDaHJv bWl1bV0gRGVsZXRlIFdlYktpdC9jaHJvbWl1bS9icmlkZ2UKSW5kZXg6IFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlzaW9uIDExMjc5NikKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzU2LDYgKzM1Niw3IEBAIFdlYlZpZXdJbXBsOjpXZWJWaWV3SW1wbChXZWJWaWV3Q2xpZW50KiAK ICAgICAsIG1faXNUcmFuc3BhcmVudChmYWxzZSkKICAgICAsIG1fdGFic1RvTGlua3MoZmFsc2Up CiAgICAgLCBtX2RyYWdTY3JvbGxUaW1lcihhZG9wdFB0cihuZXcgRHJhZ1Njcm9sbFRpbWVyKSkK KyAgICAsIG1faXNDYW5jZWxpbmdGdWxsU2NyZWVuKGZhbHNlKQogI2lmIFVTRShBQ0NFTEVSQVRF RF9DT01QT1NJVElORykKICAgICAsIG1fcm9vdEdyYXBoaWNzTGF5ZXIoMCkKICAgICAsIG1faXNB Y2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlKGZhbHNlKQpAQCAtMTMxOSw4ICsxMzIwLDE0IEBA IHZvaWQgV2ViVmlld0ltcGw6OndpbGxFeGl0RnVsbFNjcmVlbigpCiAgICAgICAgIHJldHVybjsK IAogICAgIGlmIChEb2N1bWVudCogZG9jID0gbV9mdWxsU2NyZWVuRnJhbWUtPmRvY3VtZW50KCkp IHsKLSAgICAgICAgaWYgKGRvYy0+d2Via2l0SXNGdWxsU2NyZWVuKCkpCisgICAgICAgIGlmIChk b2MtPndlYmtpdElzRnVsbFNjcmVlbigpKSB7CisgICAgICAgICAgICAvLyBXaGVuIHRoZSBjbGll bnQgZXhpdHMgZnJvbSBmdWxsIHNjcmVlbiB3ZSBoYXZlIHRvIGNhbGwgd2Via2l0Q2FuY2VsRnVs bFNjcmVlbiB0bworICAgICAgICAgICAgLy8gbm90aWZ5IHRoZSBkb2N1bWVudC4gV2hpbGUgZG9p bmcgdGhhdCwgc3VwcHJlc3Mgbm90aWZpY2F0aW9ucyBiYWNrIHRvIHRoZSBjbGllbnQuCisgICAg ICAgICAgICBtX2lzQ2FuY2VsaW5nRnVsbFNjcmVlbiA9IHRydWU7CisgICAgICAgICAgICBkb2Mt PndlYmtpdENhbmNlbEZ1bGxTY3JlZW4oKTsKKyAgICAgICAgICAgIG1faXNDYW5jZWxpbmdGdWxs U2NyZWVuID0gZmFsc2U7CiAgICAgICAgICAgICBkb2MtPndlYmtpdFdpbGxFeGl0RnVsbFNjcmVl bkZvckVsZW1lbnQoMCk7CisgICAgICAgIH0KICAgICB9CiAjZW5kaWYKIH0KQEAgLTE1NTUsNiAr MTU2Miw5IEBAIHZvaWQgV2ViVmlld0ltcGw6OmVudGVyRnVsbFNjcmVlbkZvckVsZW0KIAogdm9p ZCBXZWJWaWV3SW1wbDo6ZXhpdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KFdlYkNvcmU6OkVsZW1lbnQq IGVsZW1lbnQpCiB7CisgICAgLy8gVGhlIGNsaWVudCBpcyBleGl0aW5nIGZ1bGwgc2NyZWVuLCBz byBkb24ndCBzZW5kIGEgbm90aWZpY2F0aW9uLgorICAgIGlmIChtX2lzQ2FuY2VsaW5nRnVsbFNj cmVlbikKKyAgICAgICAgcmV0dXJuOwogICAgIGlmIChtX2NsaWVudCkKICAgICAgICAgbV9jbGll bnQtPmV4aXRGdWxsU2NyZWVuKCk7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmgJKHJldmlzaW9uIDExMjc5NikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTcxNCw2ICs3MTQsNyBAQCBw cml2YXRlOgogCiAgICAgLy8gSWYgc2V0LCB0aGUgV2ViVmlldyBpcyBpbiBmdWxsc2NyZWVuIG1v ZGUgZm9yIGFuIGVsZW1lbnQgaW4gdGhpcyBmcmFtZS4KICAgICBSZWZQdHI8V2ViQ29yZTo6RnJh bWU+IG1fZnVsbFNjcmVlbkZyYW1lOworICAgIGJvb2wgbV9pc0NhbmNlbGluZ0Z1bGxTY3JlZW47 CiAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgV2ViQ29yZTo6SW50UmVj dCBtX3Jvb3RMYXllclNjcm9sbERhbWFnZTsK