82756 2012-03-30 11:10:19 -0700 Add a compile assert for the size of CSSProperty 2012-03-30 11:27:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cmarcelo eric gustavo kling koivisto macpherson menard ojan pnormand tony webkit.review.bot xan.lopez oldest_to_newest 592316 0 rniwa 2012-03-30 11:10:19 -0700 Add a compile assert for the size of CSSProperty 592317 1 134841 rniwa 2012-03-30 11:11:32 -0700 Created attachment 134841 Patch 592323 2 134841 kling 2012-03-30 11:15:52 -0700 Comment on attachment 134841 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134841&action=review r=me > Source/WebCore/css/CSSProperty.h:60 > +private: Whoa. Great change. 592324 3 134841 ojan 2012-03-30 11:17:44 -0700 Comment on attachment 134841 Patch This patch does a lot more than just add a compile assert! Please add descriptions for the other changes (wrapValue && bool-->unsigned && making member variables private). 592332 4 134841 pnormand 2012-03-30 11:21:45 -0700 Comment on attachment 134841 Patch Attachment 134841 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12266417 592337 5 rniwa 2012-03-30 11:27:22 -0700 Committed r112699: <http://trac.webkit.org/changeset/112699> 134841 2012-03-30 11:11:32 -0700 2012-03-30 11:21:45 -0700 Patch bug-82756-20120330111131.patch text/plain 4644 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjY5NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTMwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhIGNvbXBpbGUgYXNzZXJ0 IGZvciB0aGUgc2l6ZSBvZiBDU1NQcm9wZXJ0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI3NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgYSBjb21waWxlIGFzc2VydCB0byBlbnN1cmUgQ1NTUHJv cGVydHkgaW5zdGFuY2VzIHN0YXkgc21hbGwuCisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6Y3JlYXRlRm9udEZhY2VSdWxlKToKKyAg ICAgICAgKiBjc3MvQ1NTUHJvcGVydHkuY3BwOgorICAgICAgICAoU2FtZVNpemVBc0NTU1Byb3Bl cnR5KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJvcGVydHk6 OndyYXBWYWx1ZUluQ29tbWFTZXBhcmF0ZWRMaXN0KToKKyAgICAgICAgKiBjc3MvQ1NTUHJvcGVy dHkuaDoKKyAgICAgICAgKENTU1Byb3BlcnR5KToKKwogMjAxMi0wMy0zMCAgQ2hyaXMgRmxlaXph Y2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBDcmFzaCBhdCBXZWJDb3Jl OjpyZW5kZXJPYmplY3RDb250YWluc1Bvc2l0aW9uKFdlYkNvcmU6OlJlbmRlck9iamVjdCosIFdl YkNvcmU6OlBvc2l0aW9uIGNvbnN0JikKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJz ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCShy ZXZpc2lvbiAxMTI2NDMpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtOTA4NiwxMSArOTA4Niw5IEBAIENTU1J1bGUqIENTU1BhcnNlcjo6Y3Jl YXRlRm9udEZhY2VSdWxlKCkKICAgICBtX2FsbG93SW1wb3J0UnVsZXMgPSBtX2FsbG93TmFtZXNw YWNlRGVjbGFyYXRpb25zID0gZmFsc2U7CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1f cGFyc2VkUHJvcGVydGllcy5zaXplKCk7ICsraSkgewogICAgICAgICBDU1NQcm9wZXJ0eSYgcHJv cGVydHkgPSBtX3BhcnNlZFByb3BlcnRpZXNbaV07Ci0gICAgICAgIGlmIChwcm9wZXJ0eS5pZCgp ID09IENTU1Byb3BlcnR5Rm9udFZhcmlhbnQgJiYgcHJvcGVydHkudmFsdWUoKS0+aXNQcmltaXRp dmVWYWx1ZSgpKSB7Ci0gICAgICAgICAgICBSZWZQdHI8Q1NTVmFsdWU+IHZhbHVlID0gcHJvcGVy dHkubV92YWx1ZS5yZWxlYXNlKCk7Ci0gICAgICAgICAgICBwcm9wZXJ0eS5tX3ZhbHVlID0gQ1NT VmFsdWVMaXN0OjpjcmVhdGVDb21tYVNlcGFyYXRlZCgpOwotICAgICAgICAgICAgc3RhdGljX2Nh c3Q8Q1NTVmFsdWVMaXN0Kj4ocHJvcGVydHkudmFsdWUoKSktPmFwcGVuZCh2YWx1ZS5yZWxlYXNl KCkpOwotICAgICAgICB9IGVsc2UgaWYgKHByb3BlcnR5LmlkKCkgPT0gQ1NTUHJvcGVydHlGb250 RmFtaWx5ICYmICghcHJvcGVydHkudmFsdWUoKS0+aXNWYWx1ZUxpc3QoKSB8fCBzdGF0aWNfY2Fz dDxDU1NWYWx1ZUxpc3QqPihwcm9wZXJ0eS52YWx1ZSgpKS0+bGVuZ3RoKCkgIT0gMSkpIHsKKyAg ICAgICAgaWYgKHByb3BlcnR5LmlkKCkgPT0gQ1NTUHJvcGVydHlGb250VmFyaWFudCAmJiBwcm9w ZXJ0eS52YWx1ZSgpLT5pc1ByaW1pdGl2ZVZhbHVlKCkpCisgICAgICAgICAgICBwcm9wZXJ0eS53 cmFwVmFsdWVJbkNvbW1hU2VwYXJhdGVkTGlzdCgpOworICAgICAgICBlbHNlIGlmIChwcm9wZXJ0 eS5pZCgpID09IENTU1Byb3BlcnR5Rm9udEZhbWlseSAmJiAoIXByb3BlcnR5LnZhbHVlKCktPmlz VmFsdWVMaXN0KCkgfHwgc3RhdGljX2Nhc3Q8Q1NTVmFsdWVMaXN0Kj4ocHJvcGVydHkudmFsdWUo KSktPmxlbmd0aCgpICE9IDEpKSB7CiAgICAgICAgICAgICAvLyBVbmxpa2UgZm9udC1mYW1pbHkg cHJvcGVydHksIGZvbnQtZmFtaWx5IGRlc2NyaXB0b3IgaW4gQGZvbnQtZmFjZSBydWxlCiAgICAg ICAgICAgICAvLyBoYXMgdG8gYmUgYSB2YWx1ZSBsaXN0IHdpdGggZXhhY3RseSBvbmUgZmFtaWx5 IG5hbWUuIEl0IGNhbm5vdCBoYXZlIGEKICAgICAgICAgICAgIC8vIGhhdmUgJ2luaXRpYWwnIHZh bHVlIGFuZCBjYW5ub3QgJ2luaGVyaXQnIGZyb20gcGFyZW50LgpJbmRleDogU291cmNlL1dlYkNv cmUvY3NzL0NTU1Byb3BlcnR5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUHJvcGVydHkuY3BwCShyZXZpc2lvbiAxMTI2NDMpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUHJvcGVydHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMywxNiArMjMsMzEgQEAKIAogI2lu Y2x1ZGUgIkNTU1Byb3BlcnR5TG9uZ2hhbmQuaCIKICNpbmNsdWRlICJDU1NQcm9wZXJ0eU5hbWVz LmgiCisjaW5jbHVkZSAiQ1NTVmFsdWVMaXN0LmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcu aCIKICNpbmNsdWRlICJSZW5kZXJTdHlsZUNvbnN0YW50cy5oIgogCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKK3N0cnVjdCBTYW1lU2l6ZUFzQ1NTUHJvcGVydHkgeworICAgIHVpbnQzMl90IGJpdGZp ZWxkczsKKyAgICB2b2lkKiB2YWx1ZTsKK307CisKK0NPTVBJTEVfQVNTRVJUKHNpemVvZihDU1NQ cm9wZXJ0eSkgPT0gc2l6ZW9mKFNhbWVTaXplQXNDU1NQcm9wZXJ0eSksIENTU1Byb3BlcnR5X3No b3VsZF9zdGF5X3NtYWxsKTsKKwogU3RyaW5nIENTU1Byb3BlcnR5Ojpjc3NUZXh0KCkgY29uc3QK IHsKICAgICByZXR1cm4gU3RyaW5nKGdldFByb3BlcnR5TmFtZShzdGF0aWNfY2FzdDxDU1NQcm9w ZXJ0eUlEPihpZCgpKSkpICsgIjogIiArIG1fdmFsdWUtPmNzc1RleHQoKSArIChpc0ltcG9ydGFu dCgpID8gIiAhaW1wb3J0YW50IiA6ICIiKSArICI7ICI7CiB9CiAKK3ZvaWQgQ1NTUHJvcGVydHk6 OndyYXBWYWx1ZUluQ29tbWFTZXBhcmF0ZWRMaXN0KCkKK3sKKyAgICBSZWZQdHI8Q1NTVmFsdWU+ IHZhbHVlID0gbV92YWx1ZS5yZWxlYXNlKCk7CisgICAgbV92YWx1ZSA9IENTU1ZhbHVlTGlzdDo6 Y3JlYXRlQ29tbWFTZXBhcmF0ZWQoKTsKKyAgICBzdGF0aWNfY2FzdDxDU1NWYWx1ZUxpc3QqPiht X3ZhbHVlLmdldCgpKS0+YXBwZW5kKHZhbHVlLnJlbGVhc2UoKSk7Cit9CisKIGVudW0gTG9naWNh bEJveFNpZGUgeyBCZWZvcmVTaWRlLCBFbmRTaWRlLCBBZnRlclNpZGUsIFN0YXJ0U2lkZSB9Owog ZW51bSBQaHlzaWNhbEJveFNpZGUgeyBUb3BTaWRlLCBSaWdodFNpZGUsIEJvdHRvbVNpZGUsIExl ZnRTaWRlIH07CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0eS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0eS5oCShyZXZpc2lvbiAxMTI2 NDMpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJvcGVydHkuaAkod29ya2luZyBjb3B5KQpA QCAtNTIsMTUgKzUyLDE4IEBAIHB1YmxpYzoKIAogICAgIFN0cmluZyBjc3NUZXh0KCkgY29uc3Q7 CiAKKyAgICB2b2lkIHdyYXBWYWx1ZUluQ29tbWFTZXBhcmF0ZWRMaXN0KCk7CisKICAgICBzdGF0 aWMgaW50IHJlc29sdmVEaXJlY3Rpb25Bd2FyZVByb3BlcnR5KGludCBwcm9wZXJ0eUlELCBUZXh0 RGlyZWN0aW9uLCBXcml0aW5nTW9kZSk7CiAgICAgc3RhdGljIGJvb2wgaXNJbmhlcml0ZWRQcm9w ZXJ0eSh1bnNpZ25lZCBwcm9wZXJ0eUlEKTsKIAorcHJpdmF0ZToKICAgICAvLyBNYWtlIHN1cmUg dGhlIGZvbGxvd2luZyBmaXRzIGluIDQgYnl0ZXMuIFJlYWxseS4KICAgICB1bnNpZ25lZCBtX2lk IDogMTQ7CiAgICAgdW5zaWduZWQgbV9zaG9ydGhhbmRJRCA6IDE0OyAvLyBJZiB0aGlzIHByb3Bl cnR5IHdhcyBzZXQgYXMgcGFydCBvZiBhIHNob3J0aGFuZCwgZ2l2ZXMgdGhlIHNob3J0aGFuZC4K LSAgICBib29sIG1faW1wb3J0YW50IDogMTsKLSAgICBib29sIG1faW1wbGljaXQgOiAxOyAvLyBX aGV0aGVyIG9yIG5vdCB0aGUgcHJvcGVydHkgd2FzIHNldCBpbXBsaWNpdGx5IGFzIHRoZSByZXN1 bHQgb2YgYSBzaG9ydGhhbmQuCi0gICAgYm9vbCBtX2luaGVyaXRlZCA6IDE7CisgICAgdW5zaWdu ZWQgbV9pbXBvcnRhbnQgOiAxOworICAgIHVuc2lnbmVkIG1faW1wbGljaXQgOiAxOyAvLyBXaGV0 aGVyIG9yIG5vdCB0aGUgcHJvcGVydHkgd2FzIHNldCBpbXBsaWNpdGx5IGFzIHRoZSByZXN1bHQg b2YgYSBzaG9ydGhhbmQuCisgICAgdW5zaWduZWQgbV9pbmhlcml0ZWQgOiAxOwogCiAgICAgUmVm UHRyPENTU1ZhbHVlPiBtX3ZhbHVlOwogfTsK