82738 2012-03-30 09:25:39 -0700 [EFL] keycode translation is wrong for function keys 2012-05-15 00:21:01 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 naginenis naginenis gyuyoung.kim lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 592215 0 naginenis 2012-03-30 09:25:39 -0700 The following code sets wrong keycode value for function keys. // Set F_XX keys to the windowsKeyMap. >> for (unsigned int i = 1; i < 25; i++) { > String key = "F" + String::number(i); >> windowsKeyMap().set(key, VK_F1 + i); Vk_F1 keycode is equivalent to F1, so it should be 'VK_F1 + i - 1' instead of 'VK_F1 + i'. 592232 1 134832 naginenis 2012-03-30 09:46:42 -0700 Created attachment 134832 Patch Fix keycode translation for function keys 592418 2 134832 rakuco 2012-03-30 12:50:06 -0700 Comment on attachment 134832 Patch Looks good, thanks. 596399 3 134832 webkit.review.bot 2012-04-05 01:47:36 -0700 Comment on attachment 134832 Patch Clearing flags on attachment: 134832 Committed r113300: <http://trac.webkit.org/changeset/113300> 596400 4 webkit.review.bot 2012-04-05 01:47:41 -0700 All reviewed patches have been landed. Closing bug. 134832 2012-03-30 09:46:42 -0700 2012-04-05 01:47:36 -0700 Patch keyMap.patch text/plain 2407 naginenis ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3MGVkNTZjLi4yYzcwZjhkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDMt MzAgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5j b20+CisKKyAgICAgICAgW0VGTF0ga2V5Y29kZSB0cmFuc2xhdGlvbiBpcyB3cm9uZyBmb3IgZnVu Y3Rpb24ga2V5cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODI3MzgKKworICAgICAgICBVbnNraXAgZmFzdC9ldmVudHMva2V5ZG93bi1mdW5jdGlvbi1r ZXlzLmh0bWwKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL2VmbC9Ta2lwcGVkOgorCiAyMDEyLTAzLTMwICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBHVEsgcmViYXNl bGluZSBhZnRlciByMTEyNTgyIGFuZCByMTEyMzkxLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZWZsL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZApp bmRleCA5NjZkYjEzLi5jZmFlM2I2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9l ZmwvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZApAQCAtMTM2 OCw3ICsxMzY4LDYgQEAgZmFzdC9ldmVudHMvZXZlbnQtdmlldy10b1N0cmluZy5odG1sCiBmYXN0 L2V2ZW50cy9qcy1rZXlib2FyZC1ldmVudC1jcmVhdGlvbi5odG1sCiBmYXN0L2V2ZW50cy9rZXkt ZXZlbnRzLWluLWlucHV0LWJ1dHRvbi5odG1sCiBmYXN0L2V2ZW50cy9rZXktZXZlbnRzLWluLWlu cHV0LXRleHQuaHRtbAotZmFzdC9ldmVudHMva2V5ZG93bi1mdW5jdGlvbi1rZXlzLmh0bWwKIGZh c3QvZXZlbnRzL2tleWRvd24tbnVtcGFkLWtleXMuaHRtbAogZmFzdC9ldmVudHMvb25zZWFyY2gt ZW50ZXIuaHRtbAogZmFzdC9ldmVudHMvb3B0aW9uLXRhYi5odG1sCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODE2 YmE2YS4uYTBkOGI2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTMwICBT dWRhcnNhbmEgTmFnaW5lbmkgIDxzdWRhcnNhbmEubmFnaW5lbmlAbGludXguaW50ZWwuY29tPgor CisgICAgICAgIFtFRkxdIGtleWNvZGUgdHJhbnNsYXRpb24gaXMgd3JvbmcgZm9yIGZ1bmN0aW9u IGtleXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgy NzM4CisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyBrZXljb2RlIHRyYW5zbGF0aW9uIGZvciBm dW5jdGlvbiBrZXlzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL2tleWRvd24tZnVuY3Rpb24ta2V5cy5odG1sCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9lZmwvRWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Y3JlYXRlV2luZG93c0tleU1hcCk6CisKIDIwMTItMDMtMzAgIFBoaWxpcHBlIE5v cm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdlYkF1ZGlvIGNo YW5uZWxTaXplIGlzc3VlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv RWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0Vm bEtleWJvYXJkVXRpbGl0aWVzLmNwcAppbmRleCBkZjg1YjI1Li4wMDhlMmY2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvRWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9FZmxLZXlib2FyZFV0aWxpdGllcy5jcHAK QEAgLTE2Myw3ICsxNjMsNyBAQCBzdGF0aWMgdm9pZCBjcmVhdGVXaW5kb3dzS2V5TWFwKCkKICAg ICAvLyBTZXQgRl9YWCBrZXlzIHRvIHRoZSB3aW5kb3dzS2V5TWFwLgogICAgIGZvciAodW5zaWdu ZWQgaW50IGkgPSAxOyBpIDwgMjU7IGkrKykgewogICAgICAgICBTdHJpbmcga2V5ID0gIkYiICsg U3RyaW5nOjpudW1iZXIoaSk7Ci0gICAgICAgIHdpbmRvd3NLZXlNYXAoKS5zZXQoa2V5LCBWS19G MSArIGkpOworICAgICAgICB3aW5kb3dzS2V5TWFwKCkuc2V0KGtleSwgVktfRjEgKyBpIC0gMSk7 CiAgICAgfQogfQogCg==