82731 2012-03-30 07:24:32 -0700 [chromium] Flaky animation unit test CCLayerTreeHostTestSynchronizeAnimationStartTimes 2012-03-30 12:06:19 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vollick vollick danakj jamesr webkit.review.bot oldest_to_newest 592146 0 vollick 2012-03-30 07:24:32 -0700 Synchronized start times may be compared before synchronization has actually happened. Need to move this comparison into notifyAnimationStarted. 592148 1 134809 vollick 2012-03-30 07:27:38 -0700 Created attachment 134809 Patch 592268 2 134809 jamesr 2012-03-30 10:37:04 -0700 Comment on attachment 134809 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134809&action=review R=me, but you don't need this extra pointer. > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:1069 > + , m_layerTreeHostImpl(0) you don't need this, there's already a public layerTreeHost() getter on your grand-father class (CCLayerTreeHostTest). 592289 3 vollick 2012-03-30 10:51:41 -0700 (In reply to comment #2) > (From update of attachment 134809 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134809&action=review > > R=me, but you don't need this extra pointer. > > > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:1069 > > + , m_layerTreeHostImpl(0) > > you don't need this, there's already a public layerTreeHost() getter on your grand-father class (CCLayerTreeHostTest). I wasn't sure if there was a way to get the CCLayerTreeHostImpl associated with the CCLayerTreeHost obtained from layerTreeHost(). My best thought was to grab a pointer to it from one of the test hooks. Is there a better way? 592294 4 jamesr 2012-03-30 10:55:50 -0700 Oh sorry, I misread (haven't woken up yet I suppose). Your approach seems good. 592372 5 134809 webkit.review.bot 2012-03-30 12:06:15 -0700 Comment on attachment 134809 Patch Clearing flags on attachment: 134809 Committed r112708: <http://trac.webkit.org/changeset/112708> 592373 6 webkit.review.bot 2012-03-30 12:06:19 -0700 All reviewed patches have been landed. Closing bug. 134809 2012-03-30 07:27:38 -0700 2012-03-30 12:06:15 -0700 Patch bug-82731-20120330102736.patch text/plain 2928 vollick U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDlhYTdmZTZkNzc0ZGMxZjBkZmJmYzMwMmU2OGQ4ZTBlY2I0MjM0NjguLmQ5YmUxZjQ4MzZmMGU0 OThjMzE5MjBhZjY1NTNlMTdkZTEzYjNlNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDMtMzAgIElhbiBWb2xsaWNrICA8dm9sbGlja0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBGbGFreSBhbmltYXRpb24gdW5pdCB0ZXN0IEND TGF5ZXJUcmVlSG9zdFRlc3RTeW5jaHJvbml6ZUFuaW1hdGlvblN0YXJ0VGltZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNzMxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0cy9DQ0xheWVyVHJl ZUhvc3RUZXN0LmNwcDoKKyAgICAgICAgKFdURjo6Q0NMYXllclRyZWVIb3N0VGVzdFN5bmNocm9u aXplQW5pbWF0aW9uU3RhcnRUaW1lczo6Q0NMYXllclRyZWVIb3N0VGVzdFN5bmNocm9uaXplQW5p bWF0aW9uU3RhcnRUaW1lcyk6CisgICAgICAgIChXVEY6OkNDTGF5ZXJUcmVlSG9zdFRlc3RTeW5j aHJvbml6ZUFuaW1hdGlvblN0YXJ0VGltZXM6OmFuaW1hdGVMYXllcnMpOgorICAgICAgICAoQ0NM YXllclRyZWVIb3N0VGVzdFN5bmNocm9uaXplQW5pbWF0aW9uU3RhcnRUaW1lcyk6CisgICAgICAg IChXVEY6OkNDTGF5ZXJUcmVlSG9zdFRlc3RTeW5jaHJvbml6ZUFuaW1hdGlvblN0YXJ0VGltZXM6 Om5vdGlmeUFuaW1hdGlvblN0YXJ0ZWQpOgorCiAyMDEyLTAzLTI5ICBNaWNoYWwgTW9jbnkgIDxt bW9jbnlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIEVuc3VyZSBmcmFtZWJ1ZmZl ciBleGlzdHMgYXQgdGhlIHN0YXJ0IG9mIGJlZ2luRHJhd2luZ0ZyYW1lLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RUZXN0LmNwcCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0VGVzdC5jcHAKaW5kZXgg NThhOWRjNGM5Mzk5NThmYTBlNmRiNzhiODQxM2EzMmYzZDliYzA1Zi4uMDE5MDIyNTc3NjYxZGQ4 OTViYzJiOWNlNjNmYjUwZDUyMWFhYTJhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdFRlc3QuY3BwCkBAIC0xMDY2LDYgKzEwNjYsNyBA QCBjbGFzcyBDQ0xheWVyVHJlZUhvc3RUZXN0U3luY2hyb25pemVBbmltYXRpb25TdGFydFRpbWVz IDogcHVibGljIENDTGF5ZXJUcmVlSG9zdAogcHVibGljOgogICAgIENDTGF5ZXJUcmVlSG9zdFRl c3RTeW5jaHJvbml6ZUFuaW1hdGlvblN0YXJ0VGltZXMoKQogICAgICAgICA6IG1fbnVtQW5pbWF0 ZXMoMCkKKyAgICAgICAgLCBtX2xheWVyVHJlZUhvc3RJbXBsKDApCiAgICAgewogICAgIH0KIApA QCAtMTA3NCwxNCArMTA3NSwyMiBAQCBwdWJsaWM6CiAgICAgICAgIHBvc3RBZGRBbmltYXRpb25U b01haW5UaHJlYWQoKTsKICAgICB9CiAKLSAgICB2aXJ0dWFsIHZvaWQgYW5pbWF0ZUxheWVycyhD Q0xheWVyVHJlZUhvc3RJbXBsKiBsYXllclRyZWVIb3N0SW1wbCwgZG91YmxlIG1vbm90b25pY1Rp bWUpCisgICAgdmlydHVhbCB2b2lkIGFuaW1hdGVMYXllcnMoQ0NMYXllclRyZWVIb3N0SW1wbCog bGF5ZXJUcmVlSG9zdEltcGwsIGRvdWJsZSkKICAgICB7CisgICAgICAgIG1fbGF5ZXJUcmVlSG9z dEltcGwgPSBsYXllclRyZWVIb3N0SW1wbDsKKwogICAgICAgICBpZiAoIW1fbnVtQW5pbWF0ZXMp IHsKICAgICAgICAgICAgIG1fbnVtQW5pbWF0ZXMrKzsKICAgICAgICAgICAgIHJldHVybjsKICAg ICAgICAgfQorICAgIH0KKworICAgIHZpcnR1YWwgdm9pZCBub3RpZnlBbmltYXRpb25TdGFydGVk KGRvdWJsZSB0aW1lKQorICAgIHsKKyAgICAgICAgaWYgKCFtX251bUFuaW1hdGVzKQorICAgICAg ICAgICAgcmV0dXJuOwogCi0gICAgICAgIENDTGF5ZXJBbmltYXRpb25Db250cm9sbGVyKiBjb250 cm9sbGVySW1wbCA9IGxheWVyVHJlZUhvc3RJbXBsLT5yb290TGF5ZXIoKS0+bGF5ZXJBbmltYXRp b25Db250cm9sbGVyKCk7CisgICAgICAgIENDTGF5ZXJBbmltYXRpb25Db250cm9sbGVyKiBjb250 cm9sbGVySW1wbCA9IG1fbGF5ZXJUcmVlSG9zdEltcGwtPnJvb3RMYXllcigpLT5sYXllckFuaW1h dGlvbkNvbnRyb2xsZXIoKTsKICAgICAgICAgQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXIqIGNv bnRyb2xsZXIgPSBtX2xheWVyVHJlZUhvc3QtPnJvb3RMYXllcigpLT5sYXllckFuaW1hdGlvbkNv bnRyb2xsZXIoKTsKICAgICAgICAgQ0NBY3RpdmVBbmltYXRpb24qIGFuaW1hdGlvbkltcGwgPSBj b250cm9sbGVySW1wbC0+Z2V0QWN0aXZlQW5pbWF0aW9uKDAsIENDQWN0aXZlQW5pbWF0aW9uOjpP cGFjaXR5KTsKICAgICAgICAgQ0NBY3RpdmVBbmltYXRpb24qIGFuaW1hdGlvbiA9IGNvbnRyb2xs ZXItPmdldEFjdGl2ZUFuaW1hdGlvbigwLCBDQ0FjdGl2ZUFuaW1hdGlvbjo6T3BhY2l0eSk7CkBA IC0xMDk3LDYgKzExMDYsNyBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgaW50IG1fbnVtQW5p bWF0ZXM7CisgICAgQ0NMYXllclRyZWVIb3N0SW1wbCogbV9sYXllclRyZWVIb3N0SW1wbDsKIH07 CiAKIFRFU1RfRihDQ0xheWVyVHJlZUhvc3RUZXN0U3luY2hyb25pemVBbmltYXRpb25TdGFydFRp bWVzLCBydW5NdWx0aVRocmVhZCkK