82729 2012-03-30 06:58:32 -0700 [GTK] Disable introspection build in the at-spi2-core module 2012-03-30 09:19:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 code.vineet code.vineet pnormand webkit.review.bot oldest_to_newest 592128 0 code.vineet 2012-03-30 06:58:32 -0700 jhbuild is failing on linux(ubuntu). Filing bug as per discussion on IRC with philn-tp. 592131 1 134801 code.vineet 2012-03-30 07:03:05 -0700 Created attachment 134801 proposed patch proposed patch. 592139 2 134801 pnormand 2012-03-30 07:15:40 -0700 Comment on attachment 134801 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=134801&action=review Looks good indeed but the ChangeLog just needs a little update. > Tools/ChangeLog:3 > + Introspections needs to be disable for "at-spi2-core" module Can you use the updated bug title please? > Tools/ChangeLog:9 > + Fixes jhbuild issue for gtk. > + Disabling Introspection for at-spi2-core module. Just mention that this change is a follow-up of bug 82395 which initially disabled for other modules of the set. 592141 3 134801 gustavo 2012-03-30 07:19:26 -0700 Comment on attachment 134801 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=134801&action=review > Tools/gtk/jhbuild.modules:175 > + <autotools id="at-spi2-core" autogenargs="--disable-introspection"> If you can put the autogenargs in a new line, aligned with id like the other modules that would be great =) 592142 4 134805 code.vineet 2012-03-30 07:19:45 -0700 Created attachment 134805 Updated Patch Done Thanks.. 592145 5 134807 code.vineet 2012-03-30 07:24:26 -0700 Created attachment 134807 Patch Sorry I was too quick.. :) 592150 6 134807 pnormand 2012-03-30 07:31:44 -0700 Comment on attachment 134807 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134807&action=review > Tools/gtk/jhbuild.modules:176 > + <autotools id="at-spi2-core" > + autogenargs="--disable-introspection"> Doesn't seem to be aligned with the id= 592155 7 134812 code.vineet 2012-03-30 07:37:41 -0700 Created attachment 134812 another_attempt 592164 8 134812 pnormand 2012-03-30 07:52:45 -0700 Comment on attachment 134812 another_attempt Thanks :) 592208 9 134812 webkit.review.bot 2012-03-30 09:18:56 -0700 Comment on attachment 134812 another_attempt Clearing flags on attachment: 134812 Committed r112672: <http://trac.webkit.org/changeset/112672> 592209 10 webkit.review.bot 2012-03-30 09:19:00 -0700 All reviewed patches have been landed. Closing bug. 134801 2012-03-30 07:03:05 -0700 2012-03-30 07:19:45 -0700 proposed patch q.diff text/plain 1250 code.vineet SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMjY2MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTAzLTMwICBWaW5lZXQgQ2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xh LmNvbT4KKworICAgICAgICBJbnRyb3NwZWN0aW9ucyBuZWVkcyB0byBiZSBkaXNhYmxlIGZvciAi YXQtc3BpMi1jb3JlIiBtb2R1bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgyNzI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4ZXMgamhidWlsZCBpc3N1ZSBmb3IgZ3RrLgorICAgICAgICBEaXNhYmxp bmcgSW50cm9zcGVjdGlvbiBmb3IgYXQtc3BpMi1jb3JlIG1vZHVsZS4KKworICAgICAgICAqIGd0 ay9qaGJ1aWxkLm1vZHVsZXM6CisKIDIwMTItMDMtMzAgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hp QHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ2hhbmdlIEVOQUJMRV9JTlBVVF9DT0xPUiB0byBFTkFC TEVfSU5QVVRfVFlQRV9DT0xPUiBhbmQgZW5hYmxlIGl0IGZvciBjaHJvbWl1bQpJbmRleDogVG9v bHMvZ3RrL2poYnVpbGQubW9kdWxlcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9ndGsvamhidWlsZC5t b2R1bGVzCShyZXZpc2lvbiAxMTI2NTMpCisrKyBUb29scy9ndGsvamhidWlsZC5tb2R1bGVzCSh3 b3JraW5nIGNvcHkpCkBAIC0xNzIsNyArMTcyLDcgQEAKICAgICA8L2JyYW5jaD4KICAgPC9hdXRv dG9vbHM+CiAKLSAgPGF1dG90b29scyBpZD0iYXQtc3BpMi1jb3JlIj4KKyAgPGF1dG90b29scyBp ZD0iYXQtc3BpMi1jb3JlIiBhdXRvZ2VuYXJncz0iLS1kaXNhYmxlLWludHJvc3BlY3Rpb24iPgog ICAgIDxicmFuY2ggbW9kdWxlPSJwdWIvR05PTUUvc291cmNlcy9hdC1zcGkyLWNvcmUvMi4yL2F0 LXNwaTItY29yZS0yLjIuMS50YXIueHoiIHZlcnNpb249IjIuMi4xIgogICAgICAgICAgICAgcmVw bz0iZnRwLmdub21lLm9yZyIKICAgICAgICAgICAgIGhhc2g9InNoYTI1NjoyYTQxMjk0MjBkZWNj YTM2NTdlMTYzYTRkYmIxYTNjYjI4YWNhZmUzMmVhMTI5MjQxN2ZkZDgxMDg0ZDQ4ZmFjIgo= 134805 2012-03-30 07:19:45 -0700 2012-03-30 07:24:26 -0700 Updated Patch quick.diff text/plain 1252 code.vineet SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMjY2NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTAzLTMwICBWaW5lZXQgQ2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xh LmNvbT4KKworICAgICAgICBbR1RLXSBEaXNhYmxlIGludHJvc3BlY3Rpb24gYnVpbGQgaW4gdGhl IGF0LXNwaTItY29yZSBtb2R1bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgyNzI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2hhbmdlIGlzIGEgZm9sbG93LXVwIG9mIGJ1ZyA4MjM5NSB3aGljaCBpbml0 aWFsbHkgZGlzYWJsZWQgZm9yIG90aGVyIG1vZHVsZXMgb2YgdGhlIHNldC4KKworICAgICAgICAq IGd0ay9qaGJ1aWxkLm1vZHVsZXM6CisKIDIwMTItMDMtMzAgIEplc3VzIFNhbmNoZXotUGFsZW5j aWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIEFkZCBhICJwcmV2 aWV3IiBzdGF0ZSB0byBQYWdlIFZpc2liaWxpdHkgQVBJIGltcGxlbWVudGF0aW9uCkluZGV4OiBU b29scy9ndGsvamhidWlsZC5tb2R1bGVzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL2d0ay9qaGJ1aWxk Lm1vZHVsZXMJKHJldmlzaW9uIDExMjY1MykKKysrIFRvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMJ KHdvcmtpbmcgY29weSkKQEAgLTE3Miw3ICsxNzIsNyBAQAogICAgIDwvYnJhbmNoPgogICA8L2F1 dG90b29scz4KIAotICA8YXV0b3Rvb2xzIGlkPSJhdC1zcGkyLWNvcmUiPgorICA8YXV0b3Rvb2xz IGlkPSJhdC1zcGkyLWNvcmUiIGF1dG9nZW5hcmdzPSItLWRpc2FibGUtaW50cm9zcGVjdGlvbiI+ CiAgICAgPGJyYW5jaCBtb2R1bGU9InB1Yi9HTk9NRS9zb3VyY2VzL2F0LXNwaTItY29yZS8yLjIv YXQtc3BpMi1jb3JlLTIuMi4xLnRhci54eiIgdmVyc2lvbj0iMi4yLjEiCiAgICAgICAgICAgICBy ZXBvPSJmdHAuZ25vbWUub3JnIgogICAgICAgICAgICAgaGFzaD0ic2hhMjU2OjJhNDEyOTQyMGRl Y2NhMzY1N2UxNjNhNGRiYjFhM2NiMjhhY2FmZTMyZWExMjkyNDE3ZmRkODEwODRkNDhmYWMiCg== 134807 2012-03-30 07:24:26 -0700 2012-03-30 07:37:41 -0700 Patch quick.diff text/plain 1295 code.vineet SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMjY2NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTAzLTMwICBWaW5lZXQgQ2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xh LmNvbT4KKworICAgICAgICBbR1RLXSBEaXNhYmxlIGludHJvc3BlY3Rpb24gYnVpbGQgaW4gdGhl IGF0LXNwaTItY29yZSBtb2R1bGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MjcyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgY2hhbmdlIGlzIGEgZm9sbG93LXVwIG9mIGJ1ZyA4MjM5NSB3aGlj aCBpbml0aWFsbHkgZGlzYWJsZWQgZm9yIG90aGVyIG1vZHVsZXMgb2YgdGhlIHNldC4KKworICAg ICAgICAqIGd0ay9qaGJ1aWxkLm1vZHVsZXM6IERpc2FibGUgaW50cm9zcGVjdGlvbi4KKwogMjAx Mi0wMy0zMCAgSmVzdXMgU2FuY2hlei1QYWxlbmNpYSAgPGplc3VzLnBhbGVuY2lhQG9wZW5ib3Nz YS5vcmc+CiAKICAgICAgICAgQWRkIGEgInByZXZpZXciIHN0YXRlIHRvIFBhZ2UgVmlzaWJpbGl0 eSBBUEkgaW1wbGVtZW50YXRpb24KSW5kZXg6IFRvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwkocmV2aXNpb24gMTEyNjUzKQor KysgVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwkod29ya2luZyBjb3B5KQpAQCAtMTcyLDcgKzE3 Miw4IEBACiAgICAgPC9icmFuY2g+CiAgIDwvYXV0b3Rvb2xzPgogCi0gIDxhdXRvdG9vbHMgaWQ9 ImF0LXNwaTItY29yZSI+CisgIDxhdXRvdG9vbHMgaWQ9ImF0LXNwaTItY29yZSIgCisgICAgICAg ICAgICBhdXRvZ2VuYXJncz0iLS1kaXNhYmxlLWludHJvc3BlY3Rpb24iPgogICAgIDxicmFuY2gg bW9kdWxlPSJwdWIvR05PTUUvc291cmNlcy9hdC1zcGkyLWNvcmUvMi4yL2F0LXNwaTItY29yZS0y LjIuMS50YXIueHoiIHZlcnNpb249IjIuMi4xIgogICAgICAgICAgICAgcmVwbz0iZnRwLmdub21l Lm9yZyIKICAgICAgICAgICAgIGhhc2g9InNoYTI1NjoyYTQxMjk0MjBkZWNjYTM2NTdlMTYzYTRk YmIxYTNjYjI4YWNhZmUzMmVhMTI5MjQxN2ZkZDgxMDg0ZDQ4ZmFjIgo= 134812 2012-03-30 07:37:41 -0700 2012-03-30 09:18:56 -0700 another_attempt quick.diff text/plain 1296 code.vineet SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMjY2NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTAzLTMwICBWaW5lZXQgQ2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xh LmNvbT4KKworICAgICAgICBbR1RLXSBEaXNhYmxlIGludHJvc3BlY3Rpb24gYnVpbGQgaW4gdGhl IGF0LXNwaTItY29yZSBtb2R1bGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MjcyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgY2hhbmdlIGlzIGEgZm9sbG93LXVwIG9mIGJ1ZyA4MjM5NSB3aGlj aCBpbml0aWFsbHkgZGlzYWJsZWQgZm9yIG90aGVyIG1vZHVsZXMgb2YgdGhlIHNldC4KKworICAg ICAgICAqIGd0ay9qaGJ1aWxkLm1vZHVsZXM6IERpc2FibGUgaW50cm9zcGVjdGlvbi4KKwogMjAx Mi0wMy0zMCAgSmVzdXMgU2FuY2hlei1QYWxlbmNpYSAgPGplc3VzLnBhbGVuY2lhQG9wZW5ib3Nz YS5vcmc+CiAKICAgICAgICAgQWRkIGEgInByZXZpZXciIHN0YXRlIHRvIFBhZ2UgVmlzaWJpbGl0 eSBBUEkgaW1wbGVtZW50YXRpb24KSW5kZXg6IFRvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwkocmV2aXNpb24gMTEyNjUzKQor KysgVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwkod29ya2luZyBjb3B5KQpAQCAtMTcyLDcgKzE3 Miw4IEBACiAgICAgPC9icmFuY2g+CiAgIDwvYXV0b3Rvb2xzPgogCi0gIDxhdXRvdG9vbHMgaWQ9 ImF0LXNwaTItY29yZSI+CisgIDxhdXRvdG9vbHMgaWQ9ImF0LXNwaTItY29yZSIgCisgICAgICAg ICAgICAgYXV0b2dlbmFyZ3M9Ii0tZGlzYWJsZS1pbnRyb3NwZWN0aW9uIj4KICAgICA8YnJhbmNo IG1vZHVsZT0icHViL0dOT01FL3NvdXJjZXMvYXQtc3BpMi1jb3JlLzIuMi9hdC1zcGkyLWNvcmUt Mi4yLjEudGFyLnh6IiB2ZXJzaW9uPSIyLjIuMSIKICAgICAgICAgICAgIHJlcG89ImZ0cC5nbm9t ZS5vcmciCiAgICAgICAgICAgICBoYXNoPSJzaGEyNTY6MmE0MTI5NDIwZGVjY2EzNjU3ZTE2M2E0 ZGJiMWEzY2IyOGFjYWZlMzJlYTEyOTI0MTdmZGQ4MTA4NGQ0OGZhYyIK