82725 2012-03-30 05:44:17 -0700 REGRESSION(r112489): Tentatively introduces a lot of webfont-related test flakiness on Snow Leopard (Requested by apavlov on #webkit). 2012-11-29 11:03:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 82884 76684 1 webkit.review.bot bashi apavlov bashi dglazkov oldest_to_newest 592096 0 webkit.review.bot 2012-03-30 05:44:17 -0700 http://trac.webkit.org/changeset/112489 broke the build: Tentatively introduces a lot of webfont-related test flakiness on Snow Leopard (Requested by apavlov on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 592097 1 134792 webkit.review.bot 2012-03-30 05:44:57 -0700 Created attachment 134792 ROLLOUT of r112489 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 592101 2 bashi 2012-03-30 05:50:55 -0700 (In reply to comment #0) > http://trac.webkit.org/changeset/112489 broke the build: > Tentatively introduces a lot of webfont-related test flakiness on Snow Leopard (Requested by apavlov on #webkit). > > This is an automatic bug report generated by the sheriff-bot. If this bug > report was created because of a flaky test, please file a bug for the flaky > test (if we don't already have one on file) and dup this bug against that bug > so that we can track how often these flaky tests case pain. > > "Only you can prevent forest fires." -- Smokey the Bear http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fcanvas%2F2d.text.draw.fill.maxWidth.gradient.html%2Cfast%2Fcss%2Ffont-face-insert-link.html%2Ccompositing%2Fgeometry%2Fempty-embed-rects.html%2Ccompositing%2Fgeometry%2Fobject-clip-rects-assertion.html%2Ccss2.1%2F20110323%2Fblock-non-replaced-height-005.htm%2Ccss2.1%2Ft0805-c5518-brdr-t-01-e.html%2Ccss2.1%2Ft1503-c522-font-family-00-b.html%2Ccss3%2Fselectors3%2Fhtml%2Fcss3-modsel-64.html%2Ccss3%2Fselectors3%2Fxhtml%2Fcss3-modsel-64.xml%2Ccss3%2Fselectors3%2Fxml%2Fcss3-modsel-64.xml%2Cediting%2Fdeleting%2Fdelete-first-list-item.html%2Cediting%2FexecCommand%2Fprint.html%2Cediting%2Finserting%2Finsert-3851164-fix.html%2Cediting%2Fpasteboard%2Fdrop-text-without-selection.html%2Cediting%2Fselection%2F3690703-2.html%2Cediting%2Fselection%2Fvertical-lr-ltr-extend-line-backward-br.html%2Cediting%2Fstyle%2F5017613-1.html%2Cfast%2Fcss%2Ffont-face-woff.html%2Cfast%2Fforms%2Fbasic-textareas-quirks.html%2Cfast%2Fimages%2Fembed-does-not-propagate-dimensions-to-object-ancestor.html%2Chttp%2Ftests%2Fappcache%2Fremove-cache.html%2Chttp%2Ftests%2Fappcache%2Fxhr-foreign-resource.html I glanced one of the test and noticed it uses timer to wait font loading, it is essentially flaky. I think these tests should be updated. 592116 3 134792 webkit.review.bot 2012-03-30 06:17:32 -0700 Comment on attachment 134792 ROLLOUT of r112489 Clearing flags on attachment: 134792 Committed r112659: <http://trac.webkit.org/changeset/112659> 592117 4 webkit.review.bot 2012-03-30 06:17:36 -0700 All reviewed patches have been landed. Closing bug. 593108 5 bashi 2012-04-01 17:34:56 -0700 Even after my patch was rolled out, it looks webfont-related tests are still flaky. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/14337 I don't think my patch is the cause. apalov@, what do you think? 593348 6 apavlov 2012-04-02 04:48:34 -0700 (In reply to comment #5) > Even after my patch was rolled out, it looks webfont-related tests are still flaky. > http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/14337 > > I don't think my patch is the cause. apalov@, what do you think? Yes, looks like the culprit was elsewhere. 779203 7 ap 2012-11-29 11:03:07 -0800 Is this bug still needed? 134792 2012-03-30 05:44:57 -0700 2012-03-30 06:17:32 -0700 ROLLOUT of r112489 bug-82725-20120330124750.patch text/plain 3043 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2UzZTRkZmM4NGJlYWVh NjI1ZDY0ZTBlNTBmMTYyNGJmYjZjNjI0NC4uMzdlZjY1ZTY0M2Y0MTQzZDhhYzBiYTU4MWJlZDM4 YWQ4M2U2NzQzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTMwICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTEyNDg5LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMTI0ODkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgyNzI1CisKKyAgICAgICAgVGVudGF0aXZlbHkgaW50cm9kdWNlcyBhIGxvdCBv ZiB3ZWJmb250LXJlbGF0ZWQgdGVzdCBmbGFraW5lc3MKKyAgICAgICAgb24gU25vdyBMZW9wYXJk IChSZXF1ZXN0ZWQgYnkgYXBhdmxvdiBvbiAjd2Via2l0KS4KKworICAgICAgICAqIGNzcy9DU1NT ZWdtZW50ZWRGb250RmFjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NTZWdtZW50ZWRGb250 RmFjZTo6Z2V0Rm9udERhdGEpOgorCiAyMDEyLTAzLTMwICBWaW5lZXQgQ2hhdWRoYXJ5ICA8cmdm NzQ4QG1vdG9yb2xhLmNvbT4KIAogICAgICAgICBJRExQYXJzZXIucG0gc2hvdWxkIGJlIGFibGUg dG8gcGFyc2Ugc2VxdWVuY2U8VD4gYXMgbWV0aG9kIGFyZ3VtZW50LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL0NTU1NlZ21lbnRlZEZvbnRGYWNlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NTZWdtZW50ZWRGb250RmFjZS5jcHAKaW5kZXggY2Y5ZWM5ZTJlZDJmOWZlZjJiYmQ5 NGZmNjVlMGFhZTMyYTM4NDEwMi4uYmIwMGQwMjIwZGViYzcxMjBkMzJkMzcwNzFjYTZlZjMzMmU2 MDY1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlZ21lbnRlZEZvbnRGYWNl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VnbWVudGVkRm9udEZhY2UuY3BwCkBA IC04MSwyMyArODEsNiBAQCB2b2lkIENTU1NlZ21lbnRlZEZvbnRGYWNlOjphcHBlbmRGb250RmFj ZShQYXNzUmVmUHRyPENTU0ZvbnRGYWNlPiBmb250RmFjZSkKICAgICBtX2ZvbnRGYWNlcy5hcHBl bmQoZm9udEZhY2UpOwogfQogCi1zdGF0aWMgdm9pZCBhcHBlbmRGb250RGF0YVdpdGhJbnZhbGlk VW5pY29kZVJhbmdlSWZMb2FkaW5nKFNlZ21lbnRlZEZvbnREYXRhKiBuZXdGb250RGF0YSwgY29u c3QgU2ltcGxlRm9udERhdGEqIGZhY2VGb250RGF0YSwgY29uc3QgVmVjdG9yPENTU0ZvbnRGYWNl OjpVbmljb2RlUmFuZ2U+JiByYW5nZXMpCi17Ci0gICAgaWYgKGZhY2VGb250RGF0YS0+aXNMb2Fk aW5nKCkpIHsKLSAgICAgICAgbmV3Rm9udERhdGEtPmFwcGVuZFJhbmdlKEZvbnREYXRhUmFuZ2Uo MCwgMCwgZmFjZUZvbnREYXRhKSk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICB1bnNp Z25lZCBudW1SYW5nZXMgPSByYW5nZXMuc2l6ZSgpOwotICAgIGlmICghbnVtUmFuZ2VzKSB7Ci0g ICAgICAgIG5ld0ZvbnREYXRhLT5hcHBlbmRSYW5nZShGb250RGF0YVJhbmdlKDAsIDB4N0ZGRkZG RkYsIGZhY2VGb250RGF0YSkpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgZm9yICh1 bnNpZ25lZCBqID0gMDsgaiA8IG51bVJhbmdlczsgKytqKQotICAgICAgICBuZXdGb250RGF0YS0+ YXBwZW5kUmFuZ2UoRm9udERhdGFSYW5nZShyYW5nZXNbal0uZnJvbSgpLCByYW5nZXNbal0udG8o KSwgZmFjZUZvbnREYXRhKSk7Ci19Ci0KIEZvbnREYXRhKiBDU1NTZWdtZW50ZWRGb250RmFjZTo6 Z2V0Rm9udERhdGEoY29uc3QgRm9udERlc2NyaXB0aW9uJiBmb250RGVzY3JpcHRpb24pCiB7CiAg ICAgaWYgKCFpc1ZhbGlkKCkpCkBAIC0xMjEsNyArMTA0LDE0IEBAIEZvbnREYXRhKiBDU1NTZWdt ZW50ZWRGb250RmFjZTo6Z2V0Rm9udERhdGEoY29uc3QgRm9udERlc2NyaXB0aW9uJiBmb250RGVz Y3JpcHRpCiAgICAgICAgIGJvb2wgc3ludGhldGljSXRhbGljID0gISh0cmFpdHNNYXNrICYgRm9u dFN0eWxlSXRhbGljTWFzaykgJiYgKGRlc2lyZWRUcmFpdHNNYXNrICYgRm9udFN0eWxlSXRhbGlj TWFzayk7CiAgICAgICAgIGlmIChjb25zdCBTaW1wbGVGb250RGF0YSogZmFjZUZvbnREYXRhID0g bV9mb250RmFjZXNbaV0tPmdldEZvbnREYXRhKGZvbnREZXNjcmlwdGlvbiwgc3ludGhldGljQm9s ZCwgc3ludGhldGljSXRhbGljKSkgewogICAgICAgICAgICAgQVNTRVJUKCFmYWNlRm9udERhdGEt PmlzU2VnbWVudGVkKCkpOwotICAgICAgICAgICAgYXBwZW5kRm9udERhdGFXaXRoSW52YWxpZFVu aWNvZGVSYW5nZUlmTG9hZGluZyhuZXdGb250RGF0YS5nZXQoKSwgZmFjZUZvbnREYXRhLCBtX2Zv bnRGYWNlc1tpXS0+cmFuZ2VzKCkpOworICAgICAgICAgICAgY29uc3QgVmVjdG9yPENTU0ZvbnRG YWNlOjpVbmljb2RlUmFuZ2U+JiByYW5nZXMgPSBtX2ZvbnRGYWNlc1tpXS0+cmFuZ2VzKCk7Cisg ICAgICAgICAgICB1bnNpZ25lZCBudW1SYW5nZXMgPSByYW5nZXMuc2l6ZSgpOworICAgICAgICAg ICAgaWYgKCFudW1SYW5nZXMpCisgICAgICAgICAgICAgICAgbmV3Rm9udERhdGEtPmFwcGVuZFJh bmdlKEZvbnREYXRhUmFuZ2UoMCwgMHg3RkZGRkZGRiwgZmFjZUZvbnREYXRhKSk7CisgICAgICAg ICAgICBlbHNlIHsKKyAgICAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGogPSAwOyBqIDwgbnVt UmFuZ2VzOyArK2opCisgICAgICAgICAgICAgICAgICAgIG5ld0ZvbnREYXRhLT5hcHBlbmRSYW5n ZShGb250RGF0YVJhbmdlKHJhbmdlc1tqXS5mcm9tKCksIHJhbmdlc1tqXS50bygpLCBmYWNlRm9u dERhdGEpKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KICAgICBpZiAobmV3Rm9u dERhdGEtPm51bVJhbmdlcygpKSB7Cg==