82724 2012-03-30 05:13:46 -0700 [EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation 2012-08-06 05:27:24 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82579 0 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco sw0524.lee webkit.review.bot oldest_to_newest 592078 0 mikhail.pozdnyakov 2012-03-30 05:13:46 -0700 EFL's LayoutTestController needs removeAllVisitedLinks implementation in oreder to unskip http/tests/globalhistory/history-delegate-basic-visited-links.html 592109 1 134796 mikhail.pozdnyakov 2012-03-30 06:07:16 -0700 Created attachment 134796 fix: implementation of LayoutTestController::removeAllVisitedLinks() method 592125 2 134796 gyuyoung.kim 2012-03-30 06:36:01 -0700 Comment on attachment 134796 fix: implementation of LayoutTestController::removeAllVisitedLinks() method Even though a patch is simple, I like to add simple description to patch personally. But, it looks this patch is clear. LGTM. 592129 3 mikhail.pozdnyakov 2012-03-30 06:58:41 -0700 (In reply to comment #2) > (From update of attachment 134796 [details]) > Even though a patch is simple, I like to add simple description to patch personally. But, it looks this patch is clear. LGTM. Added a short description of the fix. 592423 4 134796 rakuco 2012-03-30 12:54:05 -0700 Comment on attachment 134796 fix: implementation of LayoutTestController::removeAllVisitedLinks() method Looks good. 594080 5 134796 gyuyoung.kim 2012-04-02 17:42:48 -0700 Comment on attachment 134796 fix: implementation of LayoutTestController::removeAllVisitedLinks() method Looks good to me too. 681299 6 gyuyoung.kim 2012-07-27 18:41:22 -0700 It looks you need to rebase this patch. Then, please find reviewer on irc. 688000 7 156658 mikhail.pozdnyakov 2012-08-06 04:32:20 -0700 Created attachment 156658 rebased 688015 8 156658 ossy 2012-08-06 04:55:05 -0700 Comment on attachment 156658 rebased rs=me. 688041 9 156658 webkit.review.bot 2012-08-06 05:27:19 -0700 Comment on attachment 156658 rebased Clearing flags on attachment: 156658 Committed r124756: <http://trac.webkit.org/changeset/124756> 688042 10 webkit.review.bot 2012-08-06 05:27:24 -0700 All reviewed patches have been landed. Closing bug. 134796 2012-03-30 06:07:16 -0700 2012-08-06 04:32:20 -0700 fix: implementation of LayoutTestController::removeAllVisitedLinks() method bug82724 text/plain 2763 mikhail.pozdnyakov Y29tbWl0IGVhMDBkZjdiOTZmMDlmYjIwODJkMDRjZGY1NWUzMTUzMTFkYWQxMzMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg RnJpIE1hciAzMCAxNTo0MTowNSAyMDEyICswMzAwCgogICAgYnVnODI3MjQKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWY4 YjAyZi4uZTNiMjRmMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEyLTAzLTMwICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgogCisgICAgICAgIFtF RkxdIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIG5lZWRzIHJlbW92ZUFsbFZpc2l0ZWRMaW5r cyBpbXBsZW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODI3MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2VmbC9Ta2lwcGVkOgorCisyMDEyLTAzLTMwICBNaWtoYWlsIFBv emRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCiAgICAgICAgIFtFRkxd IEdsb2JhbCBoaXN0b3J5IGRlbGVnYXRlIHN1cHBvcnQgZm9yIEVGTCBwb3J0CiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjU3OQogCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC9Ta2lwcGVkCmluZGV4IGQ0NzA3ODguLjk5Yzc4MDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9T a2lwcGVkCkBAIC02NjksOSArNjY5LDYgQEAgc3RvcmFnZS90cmFuc2FjdGlvbi1jYWxsYmFjay1p c29sYXRlZC13b3JsZC5odG1sCiBzdG9yYWdlL3RyYW5zYWN0aW9uLWVycm9yLWNhbGxiYWNrLWlz b2xhdGVkLXdvcmxkLmh0bWwKIHN0b3JhZ2UvdHJhbnNhY3Rpb24tc3VjY2Vzcy1jYWxsYmFjay1p c29sYXRlZC13b3JsZC5odG1sCiAKLSMgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBu b3QgaW1wbGVtZW50IHJlbW92ZUFsbFZpc2l0ZWRMaW5rcwotaHR0cC90ZXN0cy9nbG9iYWxoaXN0 b3J5L2hpc3RvcnktZGVsZWdhdGUtYmFzaWMtdmlzaXRlZC1saW5rcy5odG1sCi0KICMgRUZMJ3Mg TGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50IGNhbGxTaG91bGRDbG9zZU9u V2ViVmlldwogZmFzdC9ldmVudHMvb25iZWZvcmV1bmxvYWQtZm9jdXNlZC1pZnJhbWUuaHRtbAog CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjFk YjU5ZS4uMDQxMzFhOCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0No YW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEyLTAzLTMwICBNaWtoYWlsIFBvemRueWFrb3Yg IDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgogCisgICAgICAgIFtFRkxdIEVGTCdzIExh eW91dFRlc3RDb250cm9sbGVyIG5lZWRzIHJlbW92ZUFsbFZpc2l0ZWRMaW5rcyBpbXBsZW1lbnRh dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI3 MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxlckVmbC5jcHA6CisgICAgICAgIChM YXlvdXRUZXN0Q29udHJvbGxlcjo6cmVtb3ZlQWxsVmlzaXRlZExpbmtzKToKKworMjAxMi0wMy0z MCAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KKwog ICAgICAgICBbRUZMXSBHbG9iYWwgaGlzdG9yeSBkZWxlZ2F0ZSBzdXBwb3J0IGZvciBFRkwgcG9y dAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI1NzkK IApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRlc3RDb250cm9s bGVyRWZsLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxl ckVmbC5jcHAKaW5kZXggOTMwZDBiMi4uMjgzM2M1MSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvZWZsL0xheW91dFRlc3RDb250cm9sbGVyRWZsLmNwcAorKysgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwCkBAIC02OTQsNyArNjk0 LDExIEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OmV2YWx1YXRlU2NyaXB0SW5Jc29sYXRl ZFdvcmxkKHVuc2lnbmVkLCBKU09iamVjdFJlZiwKIAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6cmVtb3ZlQWxsVmlzaXRlZExpbmtzKCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAg IEV3a19IaXN0b3J5KiBoaXN0b3J5ID0gZXdrX3ZpZXdfaGlzdG9yeV9nZXQoYnJvd3Nlci0+bWFp blZpZXcoKSk7CisgICAgaWYgKCFoaXN0b3J5KQorICAgICAgICByZXR1cm47CisKKyAgICBld2tf aGlzdG9yeV9jbGVhcihoaXN0b3J5KTsKIH0KIAogYm9vbCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6 Y2FsbFNob3VsZENsb3NlT25XZWJWaWV3KCkK 156658 2012-08-06 04:32:20 -0700 2012-08-06 05:27:19 -0700 rebased bug82724 text/plain 2665 mikhail.pozdnyakov Y29tbWl0IGJmMDE5YzAzN2MyMTM3YmJmNTRiODM4N2VjYzgxMTQ2OGQ1YTM3YWEKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg RnJpIE1hciAzMCAxNTo0MTowNSAyMDEyICswMzAwCgogICAgYnVnODI3MjQKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzIx NzRjMS4uY2E1MWU5NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAzLTMwICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtF RkxdIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIG5lZWRzIHJlbW92ZUFsbFZpc2l0ZWRMaW5r cyBpbXBsZW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODI3MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2VmbC9Ta2lwcGVkOgorCiAyMDEyLTA4LTA2ICBUYWthc2hpIFRv eW9zaGltYSAgPHRveW9zaGltQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBy ZWJhc2VsaW5lIGZvciBjaHJvbWl1bSBnYXJkZW5pbmcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVk CmluZGV4IDg3MWM0ODAuLjc2OTVkMWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCkBAIC0x NjEsOSArMTYxLDYgQEAgaHR0cC90ZXN0cy9hcHBjYWNoZS9vcmlnaW4tdXNhZ2UuaHRtbAogIyBF RkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBkb2VzIG5vdCBpbXBsZW1lbnQgb3JpZ2luc1dpdGhB cHBsaWNhdGlvbkNhY2hlCiBodHRwL3Rlc3RzL2FwcGNhY2hlL29yaWdpbnMtd2l0aC1hcHBjYWNo ZS5odG1sCiAKLSMgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50 IHJlbW92ZUFsbFZpc2l0ZWRMaW5rcwotaHR0cC90ZXN0cy9nbG9iYWxoaXN0b3J5L2hpc3Rvcnkt ZGVsZWdhdGUtYmFzaWMtdmlzaXRlZC1saW5rcy5odG1sCi0KICMgRUZMJ3MgTGF5b3V0VGVzdENv bnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50IHNoYWRvd1BzZXVkb0lkCiBtZWRpYS92aWRlby1j b250cm9scy10cmFuc2Zvcm1lZC5odG1sCiBtZWRpYS92aWRlby1jb250cm9scy12aXNpYmxlLWF1 ZGlvLW9ubHkuaHRtbApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdl TG9nCmluZGV4IDVmNGNmOTEuLmQxMzliMzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZwor KysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMy0zMCAgTWlraGFp bCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KKworICAgICAgICBb RUZMXSBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBuZWVkcyByZW1vdmVBbGxWaXNpdGVkTGlu a3MgaW1wbGVtZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgyNzI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3Bw OgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnJlbW92ZUFsbFZpc2l0ZWRMaW5rcyk6 CisKIDIwMTItMDgtMDYgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtXSzJdW0dUS10gSW1wbGVtZW50IGEgbmV3IHNwZWxsIGNoZWNrZXIgQVBJ IGZvciBXZWJLaXQyR1RLKwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0xh eW91dFRlc3RDb250cm9sbGVyRWZsLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlv dXRUZXN0Q29udHJvbGxlckVmbC5jcHAKaW5kZXggYmY5ODZlMS4uNzE4OTFkYyAxMDA2NDQKLS0t IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRlc3RDb250cm9sbGVyRWZsLmNwcAor KysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3Bw CkBAIC03ODYsNyArNzg2LDExIEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OmV2YWx1YXRl U2NyaXB0SW5Jc29sYXRlZFdvcmxkKHVuc2lnbmVkIHdvcmxkSUQsIEpTT2JqCiAKIHZvaWQgTGF5 b3V0VGVzdENvbnRyb2xsZXI6OnJlbW92ZUFsbFZpc2l0ZWRMaW5rcygpCiB7Ci0gICAgbm90SW1w bGVtZW50ZWQoKTsKKyAgICBFd2tfSGlzdG9yeSogaGlzdG9yeSA9IGV3a192aWV3X2hpc3Rvcnlf Z2V0KGJyb3dzZXItPm1haW5WaWV3KCkpOworICAgIGlmICghaGlzdG9yeSkKKyAgICAgICAgcmV0 dXJuOworCisgICAgZXdrX2hpc3RvcnlfY2xlYXIoaGlzdG9yeSk7CiB9CiAKIGJvb2wgTGF5b3V0 VGVzdENvbnRyb2xsZXI6OmNhbGxTaG91bGRDbG9zZU9uV2ViVmlldygpCg==