82721 2012-03-30 04:57:00 -0700 [BlackBerry] Upstream local change of PlatformKeyboardEventBlackBerry.cpp 2012-03-31 05:33:22 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei leo.yang rwlbuis staikos tonikitoo webkit.review.bot xuewen.ok oldest_to_newest 592061 0 charles.wei 2012-03-30 04:57:00 -0700 PlatformKeyboardEventBlackBerry.cpp needs to be upstreamed of the following changes: 1. Now the PlatformKeyboardEvent needs a timestamp. 2. Fix the initialization sequence. 3. BackTab as Sift + Tab. 592084 1 134790 charles.wei 2012-03-30 05:25:31 -0700 Created attachment 134790 Patch v1 592088 2 webkit.review.bot 2012-03-30 05:28:35 -0700 Attachment 134790 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 592805 3 134946 charles.wei 2012-03-30 23:19:33 -0700 Created attachment 134946 Patch 592838 4 134946 rwlbuis 2012-03-31 05:21:32 -0700 Comment on attachment 134946 Patch Looks good. 592842 5 134946 charles.wei 2012-03-31 05:26:10 -0700 Comment on attachment 134946 Patch Thanks for the review, Rob. 592844 6 134946 webkit.review.bot 2012-03-31 05:33:17 -0700 Comment on attachment 134946 Patch Clearing flags on attachment: 134946 Committed r112789: <http://trac.webkit.org/changeset/112789> 592845 7 webkit.review.bot 2012-03-31 05:33:22 -0700 All reviewed patches have been landed. Closing bug. 134790 2012-03-30 05:25:31 -0700 2012-03-30 23:19:15 -0700 Patch v1 82721.patch text/plain 3491 charles.wei RnJvbSAxY2U1NTQwYTgyNzhmNmI1NDVlNjcxYzNhMTczZTc1M2M5ODM1OGUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBGcmksIDMwIE1hciAyMDEyIDIwOjI4OjA3ICswODAwClN1YmplY3Q6IFtQ QVRDSF0gW0JsYWNrQmVycnldIFVwc3RyZWFtIGxvY2FsIGNoYW5nZSBvZgogUGxhdGZvcm1LZXli b2FyZEV2ZW50QmxhY2tCZXJyeS5jcHAKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MjcyMQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpObyBuZXcgdGVzdHMs IGp1c3QgdXBzdHJlYW1pbmcgdGhlIGxvY2FsIGNoYW5nZSB0byBtYWtlCnRoZSB1cHN0ZWFtaW5n IGNvZGUgYnVpbGQgZm9yIEJsYWNrQmVycnkuCgoqIHBsYXRmb3JtL2JsYWNrYmVycnkvUGxhdGZv cm1LZXlib2FyZEV2ZW50QmxhY2tCZXJyeS5jcHA6CihXZWJDb3JlOjpQbGF0Zm9ybUtleWJvYXJk RXZlbnQ6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudCk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIC4uLi9i bGFja2JlcnJ5L1BsYXRmb3JtS2V5Ym9hcmRFdmVudEJsYWNrQmVycnkuY3BwIHwgICAgOCArKysr KystLQogMiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZTNlNGRmLi41NDhlOTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDMtMzAgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUuY29t LmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBVcHN0cmVhbSBsb2NhbCBjaGFuZ2Ugb2YgUGxh dGZvcm1LZXlib2FyZEV2ZW50QmxhY2tCZXJyeS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNzIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBqdXN0IHVwc3RyZWFtaW5nIHRo ZSBsb2NhbCBjaGFuZ2UgdG8gbWFrZQorICAgICAgICB0aGUgdXBzdGVhbWluZyBjb2RlIGJ1aWxk IGZvciBCbGFja0JlcnJ5LgorCisgICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9y bUtleWJvYXJkRXZlbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3Jt S2V5Ym9hcmRFdmVudDo6UGxhdGZvcm1LZXlib2FyZEV2ZW50KToKKwogMjAxMi0wMy0zMCAgVmlu ZWV0IENoYXVkaGFyeSAgPHJnZjc0OEBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAgSURMUGFyc2Vy LnBtIHNob3VsZCBiZSBhYmxlIHRvIHBhcnNlIHNlcXVlbmNlPFQ+IGFzIG1ldGhvZCBhcmd1bWVu dC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUGxhdGZv cm1LZXlib2FyZEV2ZW50QmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9i bGFja2JlcnJ5L1BsYXRmb3JtS2V5Ym9hcmRFdmVudEJsYWNrQmVycnkuY3BwCmluZGV4IDVkZDg1 YmMuLmNiNGQyYjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVy cnkvUGxhdGZvcm1LZXlib2FyZEV2ZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCbGFja0JlcnJ5LmNw cApAQCAtMjUsNiArMjUsNyBAQAogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUtleWJvYXJk RXZlbnQuaD4KICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1Mb2cuaD4KICNpbmNsdWRlIDx3 dGYvdGV4dC9DU3RyaW5nLmg+CisjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIApAQCAtNDM3LDEwICs0MzgsMTAgQEAgc3RhdGljIGlubGluZSBQbGF0 Zm9ybUtleWJvYXJkRXZlbnQ6OlR5cGUgdG9XZWJDb3JlUGxhdGZvcm1LZXlib2FyZEV2ZW50VHlw ZShjb24KIH0KIAogUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQo Y29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06OktleWJvYXJkRXZlbnQmIGV2ZW50KQotICAgIDog UGxhdGZvcm1FdmVudCh0b1dlYkNvcmVQbGF0Zm9ybUtleWJvYXJkRXZlbnRUeXBlKGV2ZW50LnR5 cGUoKSksIGV2ZW50LnNoaWZ0QWN0aXZlKCkgfHwgKGV2ZW50LmNoYXJhY3RlcigpID09IEtFWUNP REVfQkFDS19UQUIpLCBldmVudC5jdHJsQWN0aXZlKCksIGV2ZW50LmFsdEFjdGl2ZSgpLCBmYWxz ZSkKKyAgICA6IFBsYXRmb3JtRXZlbnQodG9XZWJDb3JlUGxhdGZvcm1LZXlib2FyZEV2ZW50VHlw ZShldmVudC50eXBlKCkpLCBldmVudC5zaGlmdEFjdGl2ZSgpIHx8IChldmVudC5jaGFyYWN0ZXIo KSA9PSBLRVlDT0RFX0JBQ0tfVEFCKSwgZXZlbnQuY3RybEFjdGl2ZSgpLCBldmVudC5hbHRBY3Rp dmUoKSwgZmFsc2UsIGN1cnJlbnRUaW1lKCkpCiAgICAgLCBtX2tleUlkZW50aWZpZXIoa2V5SWRl bnRpZmllckZvckJsYWNrQmVycnlDaGFyYWN0ZXIoZXZlbnQuY2hhcmFjdGVyKCkpKQotICAgICwg bV9hdXRvUmVwZWF0KGZhbHNlKQogICAgICwgbV93aW5kb3dzVmlydHVhbEtleUNvZGUod2luZG93 c0tleUNvZGVGb3JCbGFja0JlcnJ5Q2hhcmFjdGVyKGV2ZW50LmNoYXJhY3RlcigpKSkKKyAgICAs IG1fYXV0b1JlcGVhdChmYWxzZSkKICAgICAsIG1faXNLZXlwYWQoZmFsc2UpCiAgICAgLCBtX3Vu bW9kaWZpZWRDaGFyYWN0ZXIoZXZlbnQuY2hhcmFjdGVyKCkpCiB7CkBAIC00NDgsNiArNDQ5LDkg QEAgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQoY29uc3QgQmxh Y2tCZXJyeTo6UGxhdGZvcm06OktleWJvYXIKICAgICBtX3RleHQgPSBTdHJpbmcoJmNoYXJhY3Rl ciwgMSk7CiAgICAgbV91bm1vZGlmaWVkVGV4dCA9IG1fdGV4dDsKIAorICAgIGlmIChldmVudC5j aGFyYWN0ZXIoKSA9PSBLRVlDT0RFX0JBQ0tfVEFCKQorICAgICAgICBtX21vZGlmaWVycyB8PSBT aGlmdEtleTsgLy8gQmFja1RhYiBzaG91bGQgYmUgdHJlYXRlZCBhcyBTaGlmdCArIFRhYi4KKwog ICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpsb2coQmxhY2tCZXJyeTo6UGxhdGZvcm06OkxvZ0xl dmVsSW5mbywgIktleWJvYXJkIGV2ZW50IHJlY2VpdmVkIHRleHQ9JWxjLCBrZXlJZGVudGlmaWVy PSVzLCB3aW5kb3dzVmlydHVhbEtleUNvZGU9JWQiLCBldmVudC5jaGFyYWN0ZXIoKSwgbV9rZXlJ ZGVudGlmaWVyLmxhdGluMSgpLmRhdGEoKSwgbV93aW5kb3dzVmlydHVhbEtleUNvZGUpOwogfQog Ci0tIAoxLjcuOS4xCgo= 134946 2012-03-30 23:19:33 -0700 2012-03-31 05:33:17 -0700 Patch bug-82721-20120331142442.patch text/plain 2893 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2UzZTRkZmM4NGJlYWVh NjI1ZDY0ZTBlNTBmMTYyNGJmYjZjNjI0NC4uY2Y5MDc0NjZjYTYyYjcwMjQ3MDU4YmNlOTFjMGQy N2RmYWFhOWEzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTMwICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gVXBzdHJlYW0gbG9jYWwgY2hhbmdlIG9mIFBsYXRmb3JtS2V5Ym9hcmRFdmVudEJs YWNrQmVycnkuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04MjcyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywganVzdCB1cHN0cmVhbWluZyB0aGUgbG9jYWwgY2hhbmdlIHRvIG1h a2UgdGhlIHVwc3RyZWFtaW5nCisgICAgICAgIGJ1aWxkIGZvciBCbGFja0JlcnJ5LgorCisgICAg ICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCbGFja0JlcnJ5 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6UGxhdGZvcm1L ZXlib2FyZEV2ZW50KToKKwogMjAxMi0wMy0zMCAgVmluZWV0IENoYXVkaGFyeSAgPHJnZjc0OEBt b3Rvcm9sYS5jb20+CiAKICAgICAgICAgSURMUGFyc2VyLnBtIHNob3VsZCBiZSBhYmxlIHRvIHBh cnNlIHNlcXVlbmNlPFQ+IGFzIG1ldGhvZCBhcmd1bWVudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUGxhdGZvcm1LZXlib2FyZEV2ZW50QmxhY2tCZXJy eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1BsYXRmb3JtS2V5Ym9h cmRFdmVudEJsYWNrQmVycnkuY3BwCmluZGV4IDVkZDg1YmNmYTk3MmRhZTVjMTZkNzY5OWNiMzc0 YTU0ZGE4M2NjNTMuLjhmZmQ4ZTM2YjJiMzk1MDg1OGIyOWViZWJiNTRkZmIyY2M5NTFmMTYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUGxhdGZvcm1LZXli b2FyZEV2ZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxh Y2tiZXJyeS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCbGFja0JlcnJ5LmNwcApAQCAtMjQsNiArMjQs NyBAQAogCiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtS2V5Ym9hcmRFdmVudC5oPgogI2lu Y2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUxvZy5oPgorI2luY2x1ZGUgPHd0Zi9DdXJyZW50VGlt ZS5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUg ewpAQCAtNDM3LDEwICs0MzgsMTAgQEAgc3RhdGljIGlubGluZSBQbGF0Zm9ybUtleWJvYXJkRXZl bnQ6OlR5cGUgdG9XZWJDb3JlUGxhdGZvcm1LZXlib2FyZEV2ZW50VHlwZShjb24KIH0KIAogUGxh dGZvcm1LZXlib2FyZEV2ZW50OjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQoY29uc3QgQmxhY2tCZXJy eTo6UGxhdGZvcm06OktleWJvYXJkRXZlbnQmIGV2ZW50KQotICAgIDogUGxhdGZvcm1FdmVudCh0 b1dlYkNvcmVQbGF0Zm9ybUtleWJvYXJkRXZlbnRUeXBlKGV2ZW50LnR5cGUoKSksIGV2ZW50LnNo aWZ0QWN0aXZlKCkgfHwgKGV2ZW50LmNoYXJhY3RlcigpID09IEtFWUNPREVfQkFDS19UQUIpLCBl dmVudC5jdHJsQWN0aXZlKCksIGV2ZW50LmFsdEFjdGl2ZSgpLCBmYWxzZSkKKyAgICA6IFBsYXRm b3JtRXZlbnQodG9XZWJDb3JlUGxhdGZvcm1LZXlib2FyZEV2ZW50VHlwZShldmVudC50eXBlKCkp LCBldmVudC5zaGlmdEFjdGl2ZSgpIHx8IChldmVudC5jaGFyYWN0ZXIoKSA9PSBLRVlDT0RFX0JB Q0tfVEFCKSwgZXZlbnQuY3RybEFjdGl2ZSgpLCBldmVudC5hbHRBY3RpdmUoKSwgZmFsc2UsIGN1 cnJlbnRUaW1lKCkpCiAgICAgLCBtX2tleUlkZW50aWZpZXIoa2V5SWRlbnRpZmllckZvckJsYWNr QmVycnlDaGFyYWN0ZXIoZXZlbnQuY2hhcmFjdGVyKCkpKQotICAgICwgbV9hdXRvUmVwZWF0KGZh bHNlKQogICAgICwgbV93aW5kb3dzVmlydHVhbEtleUNvZGUod2luZG93c0tleUNvZGVGb3JCbGFj a0JlcnJ5Q2hhcmFjdGVyKGV2ZW50LmNoYXJhY3RlcigpKSkKKyAgICAsIG1fYXV0b1JlcGVhdChm YWxzZSkKICAgICAsIG1faXNLZXlwYWQoZmFsc2UpCiAgICAgLCBtX3VubW9kaWZpZWRDaGFyYWN0 ZXIoZXZlbnQuY2hhcmFjdGVyKCkpCiB7CkBAIC00NDgsNiArNDQ5LDkgQEAgUGxhdGZvcm1LZXli b2FyZEV2ZW50OjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQoY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZv cm06OktleWJvYXIKICAgICBtX3RleHQgPSBTdHJpbmcoJmNoYXJhY3RlciwgMSk7CiAgICAgbV91 bm1vZGlmaWVkVGV4dCA9IG1fdGV4dDsKIAorICAgIGlmIChldmVudC5jaGFyYWN0ZXIoKSA9PSBL RVlDT0RFX0JBQ0tfVEFCKQorICAgICAgICBtX21vZGlmaWVycyB8PSBTaGlmdEtleTsgLy8gQmFj a1RhYiBzaG91bGQgYmUgdHJlYXRlZCBhcyBTaGlmdCArIFRhYi4KKwogICAgIEJsYWNrQmVycnk6 OlBsYXRmb3JtOjpsb2coQmxhY2tCZXJyeTo6UGxhdGZvcm06OkxvZ0xldmVsSW5mbywgIktleWJv YXJkIGV2ZW50IHJlY2VpdmVkIHRleHQ9JWxjLCBrZXlJZGVudGlmaWVyPSVzLCB3aW5kb3dzVmly dHVhbEtleUNvZGU9JWQiLCBldmVudC5jaGFyYWN0ZXIoKSwgbV9rZXlJZGVudGlmaWVyLmxhdGlu MSgpLmRhdGEoKSwgbV93aW5kb3dzVmlydHVhbEtleUNvZGUpOwogfQogCg==