82720 2012-03-30 04:46:21 -0700 [Qt] WK1/WK2 layout test results are diverging 2012-04-05 09:13:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 79666 1 ossy pierre.rossi hausmann ossy pierre.rossi oldest_to_newest 592054 0 ossy 2012-03-30 04:46:21 -0700 After updating Qt5 on the bots from 7d0327830bb4768753cb0c14a23d98fed08be7d2 to 74f7b7f74c0e9ce99123fc836fd22f1f0b5688fe, most of the tests started to fail with Qt5-WK1. http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20-%20Qt5-WebKit1/r112651%20%285500%29/results.html So the test coverage is 0% now. :( 595418 1 135558 pierre.rossi 2012-04-04 04:47:59 -0700 Created attachment 135558 Patch 595421 2 135558 webkit-ews 2012-04-04 04:52:18 -0700 Comment on attachment 135558 Patch Attachment 135558 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12323701 595424 3 135558 webkit-ews 2012-04-04 04:53:28 -0700 Comment on attachment 135558 Patch Attachment 135558 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12324693 595452 4 135568 pierre.rossi 2012-04-04 05:39:05 -0700 Created attachment 135568 Patch 595464 5 135568 webkit-ews 2012-04-04 05:54:53 -0700 Comment on attachment 135568 Patch Attachment 135568 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12324729 595466 6 135572 pierre.rossi 2012-04-04 06:02:43 -0700 Created attachment 135572 Patch 595522 7 ossy 2012-04-04 07:28:46 -0700 There are still 234 failing tests with Qt5-WK1: https://gist.github.com/2301307 :( 596518 8 ossy 2012-04-05 05:58:56 -0700 I tried the latest Qt5 hash (51ca55ff29f53b909c3614b56609e067d2066124) with your patch and with updated testfonts and 232 tests still fail on Qt5-WK1. You can find the png diffs here: http://build.webkit.sed.hu/layout-test-results.tar.bz2 (expected results: Qt5-WK2 , actual results: Qt5-WK1) Could you check it, please? 596519 9 ossy 2012-04-05 06:02:02 -0700 Simon, what should we do now? - still wait with updating Qt5 - update Qt5 and skip the failing 232 tests on Qt5-WK1 - update Qt5 and try to maintain these 232 tests paralelly for Qt5-WK1 and Qt5-WK2 (==Qt4-WK1)? 596586 10 135572 ossy 2012-04-05 08:26:19 -0700 Comment on attachment 135572 Patch rs=me, I'll land it manually. After Pierre updated the fonts conf file in testfonts repo, it works fine. 596628 11 135572 ossy 2012-04-05 09:13:25 -0700 Comment on attachment 135572 Patch Landed in http://trac.webkit.org/changeset/113321 135558 2012-04-04 04:47:59 -0700 2012-04-04 05:38:58 -0700 Patch bug-82720-20120404134856.patch text/plain 2218 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMDQ3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2MxNGEyN2IxZTRiZDAzYjQ4NDhlYzUxN2MwODE2M2Ri YjI4NGE4My4uNzg2YmViZjJlNDYyYmQ3MzQ3MWZhNmQzM2Q5YWYzYTViMDUzYzg4NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA0LTA0ICBQaWVycmUgUm9zc2kgIDxwaWVycmUucm9zc2lAZ21haWwuY29tPgor CisgICAgICAgIFtRdF0gV0sxL1dLMiBsYXlvdXQgdGVzdCByZXN1bHRzIGFyZSBkaXZlcmdpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNzIwCisK KyAgICAgICAgVGhlIHJlc29sdmluZyBvZiBkZWZhdWx0IGZvbnQgZmFtaWxpZXMgd2FzIGFsdGVy ZWQgaW4gUXQ1LgorICAgICAgICBUaGlzIGRpcmVjdGx5IGFmZmVjdHMgdGhlIGZvbnQgcGlja2Vk IGJ5IERSVCBmb3IgbGF5b3V0CisgICAgICAgIHRlc3RzLiBTaW5jZSB3ZSB3YW50IHRvIGtlZXAg dGhlIFF0NCBhbmQgUXQ1IHJlc3VsdHMgaW4gbGluZSwKKyAgICAgICAgd2UgY2FuIHRyaWNrIERS VCBpbiBwaWNraW5nIHRoZSBzYW1lIGZvbnQgYXMgYmVmb3JlIGZvciBub3cuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9x dC9RdEluaXRpYWxpemVUZXN0Rm9udHMuY3BwOgorICAgICAgICAoV2ViS2l0Ojppbml0aWFsaXpl VGVzdEZvbnRzKToKKwogMjAxMi0wNC0wMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln YWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYW5vdGhlciB0ZXN0LXdlYmtpdHB5IGZp eC11cCBhZnRlciByMTEzMDM3LgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQv UXRJbml0aWFsaXplVGVzdEZvbnRzLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1F0SW5p dGlhbGl6ZVRlc3RGb250cy5jcHAKaW5kZXggYzY5MzQ3ZThkNjdiNTMzMTk5MWZjZDBjYTk1YzBi NzkxODk2ZTJkNy4uNTI5Y2VjYzc1NGVlYWVjN2NlMTQwMTAwZjYzZTFjNDJkOThkZGNkNiAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvUXRJbml0aWFsaXplVGVzdEZvbnRzLmNw cAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9RdEluaXRpYWxpemVUZXN0Rm9udHMuY3Bw CkBAIC02Miw3ICs2MiwxOCBAQCB2b2lkIGluaXRpYWxpemVUZXN0Rm9udHMoKQogICAgICAgICAg ICAgICAgKTsKICAgICB9CiAKLSAgICBRQnl0ZUFycmF5IGNvbmZpZ0ZpbGUgPSBmb250RGlyICsg Ii9mb250cy5jb25mIjsKKyAgICBRQnl0ZUFycmF5IGNvbmZpZ0ZpbGU7CisgICAgRmNDb25maWcq IGNvbmZpZyA9IEZjQ29uZmlnQ3JlYXRlKCk7CisgICAgLy8gVGhlIHJlc29sdmluZyBvZiBkZWZh dWx0IGZvbnQgZmFtaWxpZXMgd2FzIGFsdGVyZWQgaW4gUXQ1IHdpdGggMmNjNTQ0MiAocXRiYXNl KSwKKyAgICAvLyB3ZSB1c2UgdGhpcyBoYWNrIHRvIGtlZXAgcmVzb2x2aW5nIHRvIHRoZSBzYW1l IGZvbnQgUXQ0IGRpZCBmb3Igc2VyaWYgd2hpbGUKKyAgICAvLyBzdXBwb3J0aW5nIGJvdGggdmVy c2lvbnMuCisjaWYgUVRfVkVSU0lPTiA+PSBRVF9WRVJTSU9OX0NIRUNLKDUsIDAsIDApCisgICAg Y29uZmlnRmlsZSA9IGZvbnREaXIgKyAiL2ZvbnRzLXF0NS13azEuY29uZiI7CisgICAgcURlYnVn KCkgPDwgImxvYWRlZCIgPDwgY29uZmlnRmlsZTsKKyAgICBpZiAoIUZjQ29uZmlnUGFyc2VBbmRM b2FkKGNvbmZpZywgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBGY0NoYXI4Kj4oY29uZmlnRmlsZS5j b25zdERhdGEoKSksIEZjVHJ1ZSkpCisgICAgICAgIHFGYXRhbCgiQ291bGRuJ3QgbG9hZCBmb250 IGNvbmZpZ3VyYXRpb24gZmlsZSIpOworI2VuZGlmCisgICAgY29uZmlnRmlsZSA9IGZvbnREaXIg KyAiL2ZvbnRzLmNvbmYiOwogICAgIEZjQ29uZmlnKiBjb25maWcgPSBGY0NvbmZpZ0NyZWF0ZSgp OwogICAgIGlmICghRmNDb25maWdQYXJzZUFuZExvYWQoY29uZmlnLCByZWludGVycHJldF9jYXN0 PGNvbnN0IEZjQ2hhcjgqPihjb25maWdGaWxlLmNvbnN0RGF0YSgpKSwgRmNUcnVlKSkKICAgICAg ICAgcUZhdGFsKCJDb3VsZG4ndCBsb2FkIGZvbnQgY29uZmlndXJhdGlvbiBmaWxlIik7Cg== 135568 2012-04-04 05:39:05 -0700 2012-04-04 06:02:35 -0700 Patch bug-82720-20120404144002.patch text/plain 2267 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMDQ3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2MxNGEyN2IxZTRiZDAzYjQ4NDhlYzUxN2MwODE2M2Ri YjI4NGE4My4uNzg2YmViZjJlNDYyYmQ3MzQ3MWZhNmQzM2Q5YWYzYTViMDUzYzg4NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA0LTA0ICBQaWVycmUgUm9zc2kgIDxwaWVycmUucm9zc2lAZ21haWwuY29tPgor CisgICAgICAgIFtRdF0gV0sxL1dLMiBsYXlvdXQgdGVzdCByZXN1bHRzIGFyZSBkaXZlcmdpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNzIwCisK KyAgICAgICAgVGhlIHJlc29sdmluZyBvZiBkZWZhdWx0IGZvbnQgZmFtaWxpZXMgd2FzIGFsdGVy ZWQgaW4gUXQ1LgorICAgICAgICBUaGlzIGRpcmVjdGx5IGFmZmVjdHMgdGhlIGZvbnQgcGlja2Vk IGJ5IERSVCBmb3IgbGF5b3V0CisgICAgICAgIHRlc3RzLiBTaW5jZSB3ZSB3YW50IHRvIGtlZXAg dGhlIFF0NCBhbmQgUXQ1IHJlc3VsdHMgaW4gbGluZSwKKyAgICAgICAgd2UgY2FuIHRyaWNrIERS VCBpbiBwaWNraW5nIHRoZSBzYW1lIGZvbnQgYXMgYmVmb3JlIGZvciBub3cuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9x dC9RdEluaXRpYWxpemVUZXN0Rm9udHMuY3BwOgorICAgICAgICAoV2ViS2l0Ojppbml0aWFsaXpl VGVzdEZvbnRzKToKKwogMjAxMi0wNC0wMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln YWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYW5vdGhlciB0ZXN0LXdlYmtpdHB5IGZp eC11cCBhZnRlciByMTEzMDM3LgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQv UXRJbml0aWFsaXplVGVzdEZvbnRzLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1F0SW5p dGlhbGl6ZVRlc3RGb250cy5jcHAKaW5kZXggYzY5MzQ3ZThkNjdiNTMzMTk5MWZjZDBjYTk1YzBi NzkxODk2ZTJkNy4uZDZkMTBkOTc5OGY3MWQ2Zjc4YTA2ZmNjNGJhNWRjYWNmMTMxYWE2NSAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvUXRJbml0aWFsaXplVGVzdEZvbnRzLmNw cAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9RdEluaXRpYWxpemVUZXN0Rm9udHMuY3Bw CkBAIC02Miw4ICs2MiwxOCBAQCB2b2lkIGluaXRpYWxpemVUZXN0Rm9udHMoKQogICAgICAgICAg ICAgICAgKTsKICAgICB9CiAKLSAgICBRQnl0ZUFycmF5IGNvbmZpZ0ZpbGUgPSBmb250RGlyICsg Ii9mb250cy5jb25mIjsKKyAgICBRQnl0ZUFycmF5IGNvbmZpZ0ZpbGU7CiAgICAgRmNDb25maWcq IGNvbmZpZyA9IEZjQ29uZmlnQ3JlYXRlKCk7CisgICAgLy8gVGhlIHJlc29sdmluZyBvZiBkZWZh dWx0IGZvbnQgZmFtaWxpZXMgd2FzIGFsdGVyZWQgaW4gUXQ1IHdpdGggMmNjNTQ0MiAocXRiYXNl KSwKKyAgICAvLyB3ZSB1c2UgdGhpcyBoYWNrIHRvIGtlZXAgcmVzb2x2aW5nIHRvIHRoZSBzYW1l IGZvbnQgUXQ0IGRpZCBmb3Igc2VyaWYgd2hpbGUKKyAgICAvLyBzdXBwb3J0aW5nIGJvdGggdmVy c2lvbnMuCisjaWYgUVRfVkVSU0lPTiA+PSBRVF9WRVJTSU9OX0NIRUNLKDUsIDAsIDApCisgICAg Y29uZmlnRmlsZSA9IGZvbnREaXIgKyAiL2ZvbnRzLXF0NS13azEuY29uZiI7CisgICAgcURlYnVn KCkgPDwgImxvYWRlZCIgPDwgY29uZmlnRmlsZTsKKyAgICBpZiAoIUZjQ29uZmlnUGFyc2VBbmRM b2FkKGNvbmZpZywgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBGY0NoYXI4Kj4oY29uZmlnRmlsZS5j b25zdERhdGEoKSksIEZjVHJ1ZSkpCisgICAgICAgIHFGYXRhbCgiQ291bGRuJ3QgbG9hZCBmb250 IGNvbmZpZ3VyYXRpb24gZmlsZSIpOworI2VuZGlmCisgICAgY29uZmlnRmlsZSA9IGZvbnREaXIg KyAiL2ZvbnRzLmNvbmYiOwogICAgIGlmICghRmNDb25maWdQYXJzZUFuZExvYWQoY29uZmlnLCBy ZWludGVycHJldF9jYXN0PGNvbnN0IEZjQ2hhcjgqPihjb25maWdGaWxlLmNvbnN0RGF0YSgpKSwg RmNUcnVlKSkKICAgICAgICAgcUZhdGFsKCJDb3VsZG4ndCBsb2FkIGZvbnQgY29uZmlndXJhdGlv biBmaWxlIik7CiAgICAgaWYgKCFGY0NvbmZpZ0FwcEZvbnRBZGREaXIoY29uZmlnLCByZWludGVy cHJldF9jYXN0PGNvbnN0IEZjQ2hhcjgqPihmb250RGlyLmRhdGEoKSkpKQo= 135572 2012-04-04 06:02:43 -0700 2012-04-05 09:13:25 -0700 Patch bug-82720-20120404150340.patch text/plain 2226 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMDQ3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2MxNGEyN2IxZTRiZDAzYjQ4NDhlYzUxN2MwODE2M2Ri YjI4NGE4My4uNzg2YmViZjJlNDYyYmQ3MzQ3MWZhNmQzM2Q5YWYzYTViMDUzYzg4NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA0LTA0ICBQaWVycmUgUm9zc2kgIDxwaWVycmUucm9zc2lAZ21haWwuY29tPgor CisgICAgICAgIFtRdF0gV0sxL1dLMiBsYXlvdXQgdGVzdCByZXN1bHRzIGFyZSBkaXZlcmdpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNzIwCisK KyAgICAgICAgVGhlIHJlc29sdmluZyBvZiBkZWZhdWx0IGZvbnQgZmFtaWxpZXMgd2FzIGFsdGVy ZWQgaW4gUXQ1LgorICAgICAgICBUaGlzIGRpcmVjdGx5IGFmZmVjdHMgdGhlIGZvbnQgcGlja2Vk IGJ5IERSVCBmb3IgbGF5b3V0CisgICAgICAgIHRlc3RzLiBTaW5jZSB3ZSB3YW50IHRvIGtlZXAg dGhlIFF0NCBhbmQgUXQ1IHJlc3VsdHMgaW4gbGluZSwKKyAgICAgICAgd2UgY2FuIHRyaWNrIERS VCBpbiBwaWNraW5nIHRoZSBzYW1lIGZvbnQgYXMgYmVmb3JlIGZvciBub3cuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9x dC9RdEluaXRpYWxpemVUZXN0Rm9udHMuY3BwOgorICAgICAgICAoV2ViS2l0Ojppbml0aWFsaXpl VGVzdEZvbnRzKToKKwogMjAxMi0wNC0wMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln YWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYW5vdGhlciB0ZXN0LXdlYmtpdHB5IGZp eC11cCBhZnRlciByMTEzMDM3LgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQv UXRJbml0aWFsaXplVGVzdEZvbnRzLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1F0SW5p dGlhbGl6ZVRlc3RGb250cy5jcHAKaW5kZXggYzY5MzQ3ZThkNjdiNTMzMTk5MWZjZDBjYTk1YzBi NzkxODk2ZTJkNy4uY2E2YjY2YzQ5NjY1YzExMTI5ZWNjOGIxNGFhNTg0ZjBjZDJlNDgwNiAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvUXRJbml0aWFsaXplVGVzdEZvbnRzLmNw cAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9RdEluaXRpYWxpemVUZXN0Rm9udHMuY3Bw CkBAIC02Miw4ICs2MiwxNyBAQCB2b2lkIGluaXRpYWxpemVUZXN0Rm9udHMoKQogICAgICAgICAg ICAgICAgKTsKICAgICB9CiAKLSAgICBRQnl0ZUFycmF5IGNvbmZpZ0ZpbGUgPSBmb250RGlyICsg Ii9mb250cy5jb25mIjsKKyAgICBRQnl0ZUFycmF5IGNvbmZpZ0ZpbGU7CiAgICAgRmNDb25maWcq IGNvbmZpZyA9IEZjQ29uZmlnQ3JlYXRlKCk7CisgICAgLy8gVGhlIHJlc29sdmluZyBvZiBkZWZh dWx0IGZvbnQgZmFtaWxpZXMgd2FzIGFsdGVyZWQgaW4gUXQ1IHdpdGggMmNjNTQ0MiAocXRiYXNl KSwKKyAgICAvLyB3ZSB1c2UgdGhpcyBoYWNrIHRvIGtlZXAgcmVzb2x2aW5nIHRvIHRoZSBzYW1l IGZvbnQgUXQ0IGRpZCBmb3Igc2VyaWYgd2hpbGUKKyAgICAvLyBzdXBwb3J0aW5nIGJvdGggdmVy c2lvbnMuCisjaWYgUVRfVkVSU0lPTiA+PSBRVF9WRVJTSU9OX0NIRUNLKDUsIDAsIDApCisgICAg Y29uZmlnRmlsZSA9IGZvbnREaXIgKyAiL2ZvbnRzLXF0NS13azEuY29uZiI7CisgICAgaWYgKCFG Y0NvbmZpZ1BhcnNlQW5kTG9hZChjb25maWcsIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgRmNDaGFy OCo+KGNvbmZpZ0ZpbGUuY29uc3REYXRhKCkpLCBGY1RydWUpKQorICAgICAgICBxRmF0YWwoIkNv dWxkbid0IGxvYWQgZm9udCBjb25maWd1cmF0aW9uIGZpbGUiKTsKKyNlbmRpZgorICAgIGNvbmZp Z0ZpbGUgPSBmb250RGlyICsgIi9mb250cy5jb25mIjsKICAgICBpZiAoIUZjQ29uZmlnUGFyc2VB bmRMb2FkKGNvbmZpZywgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBGY0NoYXI4Kj4oY29uZmlnRmls ZS5jb25zdERhdGEoKSksIEZjVHJ1ZSkpCiAgICAgICAgIHFGYXRhbCgiQ291bGRuJ3QgbG9hZCBm b250IGNvbmZpZ3VyYXRpb24gZmlsZSIpOwogICAgIGlmICghRmNDb25maWdBcHBGb250QWRkRGly KGNvbmZpZywgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBGY0NoYXI4Kj4oZm9udERpci5kYXRhKCkp KSkK