82709 2012-03-30 02:51:25 -0700 [BlackBerry] EventLoop::platformInit() obsolete. 2012-03-30 18:53:25 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei webkit-unassigned leo.yang rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 591994 0 charles.wei 2012-03-30 02:51:25 -0700 EventLoop::platformInit() has been removed , we don't need to have an empty imp anymore. Remove it. 592003 1 134763 charles.wei 2012-03-30 03:07:38 -0700 Created attachment 134763 This patch removes EventLoop::platformInit() 592039 2 134763 rwlbuis 2012-03-30 04:27:13 -0700 Comment on attachment 134763 This patch removes EventLoop::platformInit() View in context: https://bugs.webkit.org/attachment.cgi?id=134763&action=review Ok. > Source/WebCore/ChangeLog:8 > + No new tests,build fix for BlackBerry porting. Add a space after ','. 592053 3 134777 charles.wei 2012-03-30 04:44:14 -0700 Created attachment 134777 Resubmit the patch after fixing comments from the reviewer. 592060 4 134777 webkit.review.bot 2012-03-30 04:55:46 -0700 Comment on attachment 134777 Resubmit the patch after fixing comments from the reviewer. Rejecting attachment 134777 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12291211 592069 5 134782 charles.wei 2012-03-30 05:06:47 -0700 Created attachment 134782 Resubmit after filling the reviewer info. 592113 6 134782 webkit.review.bot 2012-03-30 06:12:39 -0700 Comment on attachment 134782 Resubmit after filling the reviewer info. Clearing flags on attachment: 134782 Committed r112657: <http://trac.webkit.org/changeset/112657> 592725 7 charles.wei 2012-03-30 18:53:25 -0700 Resolved and patch landed. 134763 2012-03-30 03:07:38 -0700 2012-03-30 04:27:13 -0700 This patch removes EventLoop::platformInit() 0001-BlackBerry-EventLoop-platformInit-obsolete.patch text/plain 1673 charles.wei RnJvbSBkYzZlMDc3MjYyYTBiMGEwZTQyYTRjNjhlNjIyZDQ1NWU1OTYxNzQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBGcmksIDMwIE1hciAyMDEyIDE4OjEwOjQ1ICswODAwClN1YmplY3Q6IFtQ QVRDSF0gW0JsYWNrQmVycnldIEV2ZW50TG9vcDo6cGxhdGZvcm1Jbml0KCkgb2Jzb2xldGUuCiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI3MDkKClJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgoKTm8gbmV3IHRlc3RzLGJ1aWxkIGZpeCBmb3IgQmxhY2tCZXJyeSBw b3J0aW5nLgoKKiBwbGF0Zm9ybS9ibGFja2JlcnJ5L0V2ZW50TG9vcEJsYWNrQmVycnkuY3BwOgot LS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAxMSArKysrKysrKysrKwogLi4uL3BsYXRmb3JtL2JsYWNrYmVycnkvRXZlbnRMb29wQmxhY2tC ZXJyeS5jcHAgICAgfCAgICA0IC0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygr KSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODE2YmE2YS4uMWY3ZWU3NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTMwICBDaGFybGVzIFdlaSAgPGNoYXJsZXMu d2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRXZlbnRMb29w OjpwbGF0Zm9ybUluaXQoKSBvYnNvbGV0ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTgyNzA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLGJ1aWxkIGZpeCBmb3IgQmxhY2tCZXJyeSBw b3J0aW5nLgorCisgICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9FdmVudExvb3BCbGFja0Jl cnJ5LmNwcDoKKwogMjAxMi0wMy0zMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS10gV2ViQXVkaW8gY2hhbm5lbFNpemUgaXNzdWUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvRXZlbnRMb29wQmxhY2tC ZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0V2ZW50TG9vcEJs YWNrQmVycnkuY3BwCmluZGV4IDFiZmZiNDQuLjE4NTI4YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvRXZlbnRMb29wQmxhY2tCZXJyeS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9FdmVudExvb3BCbGFja0JlcnJ5LmNw cApAQCAtMjQsMTAgKzI0LDYgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi12b2lkIEV2ZW50 TG9vcDo6cGxhdGZvcm1Jbml0KCkKLXsKLX0KLQogdm9pZCBFdmVudExvb3A6OmN5Y2xlKCkKIHsK ICAgICBBU1NFUlQoQmxhY2tCZXJyeTo6UGxhdGZvcm06OndlYktpdFRocmVhZE1lc3NhZ2VDbGll bnQoKSk7Ci0tIAoxLjcuOS4xCgo= 134777 2012-03-30 04:44:14 -0700 2012-03-30 05:06:47 -0700 Resubmit the patch after fixing comments from the reviewer. 0001-BlackBerry-EventLoop-platformInit-obsolete.patch text/plain 1674 charles.wei RnJvbSBkYzZlMDc3MjYyYTBiMGEwZTQyYTRjNjhlNjIyZDQ1NWU1OTYxNzQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBGcmksIDMwIE1hciAyMDEyIDE4OjEwOjQ1ICswODAwClN1YmplY3Q6IFtQ QVRDSF0gW0JsYWNrQmVycnldIEV2ZW50TG9vcDo6cGxhdGZvcm1Jbml0KCkgb2Jzb2xldGUuCiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI3MDkKClJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgoKTm8gbmV3IHRlc3RzLCBidWlsZCBmaXggZm9yIEJsYWNrQmVycnkg cG9ydGluZy4KCiogcGxhdGZvcm0vYmxhY2tiZXJyeS9FdmVudExvb3BCbGFja0JlcnJ5LmNwcDoK LS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTEgKysrKysrKysrKysKIC4uLi9wbGF0Zm9ybS9ibGFja2JlcnJ5L0V2ZW50TG9vcEJsYWNr QmVycnkuY3BwICAgIHwgICAgNCAtLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMo KyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDgxNmJhNmEuLjFmN2VlNzYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wMy0zMCAgQ2hhcmxlcyBXZWkgIDxjaGFybGVz LndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEV2ZW50TG9v cDo6cGxhdGZvcm1Jbml0KCkgb2Jzb2xldGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04MjcwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyxidWlsZCBmaXggZm9yIEJsYWNrQmVycnkg cG9ydGluZy4KKworICAgICAgICAqIHBsYXRmb3JtL2JsYWNrYmVycnkvRXZlbnRMb29wQmxhY2tC ZXJyeS5jcHA6CisKIDIwMTItMDMtMzAgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdlYkF1ZGlvIGNoYW5uZWxTaXplIGlzc3VlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0V2ZW50TG9vcEJsYWNr QmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9FdmVudExvb3BC bGFja0JlcnJ5LmNwcAppbmRleCAxYmZmYjQ0Li4xODUyOGJjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0V2ZW50TG9vcEJsYWNrQmVycnkuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvRXZlbnRMb29wQmxhY2tCZXJyeS5j cHAKQEAgLTI0LDEwICsyNCw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotdm9pZCBFdmVu dExvb3A6OnBsYXRmb3JtSW5pdCgpCi17Ci19Ci0KIHZvaWQgRXZlbnRMb29wOjpjeWNsZSgpCiB7 CiAgICAgQVNTRVJUKEJsYWNrQmVycnk6OlBsYXRmb3JtOjp3ZWJLaXRUaHJlYWRNZXNzYWdlQ2xp ZW50KCkpOwotLSAKMS43LjkuMQoK 134782 2012-03-30 05:06:47 -0700 2012-03-30 06:12:39 -0700 Resubmit after filling the reviewer info. 0001-BlackBerry-EventLoop-platformInit-obsolete.patch text/plain 1669 charles.wei RnJvbSBkYzZlMDc3MjYyYTBiMGEwZTQyYTRjNjhlNjIyZDQ1NWU1OTYxNzQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBGcmksIDMwIE1hciAyMDEyIDE4OjEwOjQ1ICswODAwClN1YmplY3Q6IFtQ QVRDSF0gW0JsYWNrQmVycnldIEV2ZW50TG9vcDo6cGxhdGZvcm1Jbml0KCkgb2Jzb2xldGUuCiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI3MDkKClJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgoKTm8gbmV3IHRlc3RzLCBidWlsZCBmaXggZm9yIEJsYWNrQmVycnkg cG9ydGluZy4KCiogcGxhdGZvcm0vYmxhY2tiZXJyeS9FdmVudExvb3BCbGFja0JlcnJ5LmNwcDoK LS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTEgKysrKysrKysrKysKIC4uLi9wbGF0Zm9ybS9ibGFja2JlcnJ5L0V2ZW50TG9vcEJsYWNr QmVycnkuY3BwICAgIHwgICAgNCAtLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMo KyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDgxNmJhNmEuLjFmN2VlNzYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wMy0zMCAgQ2hhcmxlcyBXZWkgIDxjaGFybGVz LndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEV2ZW50TG9v cDo6cGxhdGZvcm1Jbml0KCkgb2Jzb2xldGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04MjcwOQorCisgICAgICAgIFJldmlld2VkIGJ5IFJvYiBCdWlz LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnVpbGQgZml4IGZvciBCbGFja0JlcnJ5IHBvcnRp bmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ibGFja2JlcnJ5L0V2ZW50TG9vcEJsYWNrQmVycnku Y3BwOgorCiAyMDEyLTAzLTMwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXSBXZWJBdWRpbyBjaGFubmVsU2l6ZSBpc3N1ZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9FdmVudExvb3BCbGFja0JlcnJ5 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvRXZlbnRMb29wQmxhY2tC ZXJyeS5jcHAKaW5kZXggMWJmZmI0NC4uMTg1MjhiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9FdmVudExvb3BCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0V2ZW50TG9vcEJsYWNrQmVycnkuY3BwCkBA IC0yNCwxMCArMjQsNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXZvaWQgRXZlbnRMb29w OjpwbGF0Zm9ybUluaXQoKQotewotfQotCiB2b2lkIEV2ZW50TG9vcDo6Y3ljbGUoKQogewogICAg IEFTU0VSVChCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6d2ViS2l0VGhyZWFkTWVzc2FnZUNsaWVudCgp KTsKLS0gCjEuNy45LjEKCg==