82706 2012-03-30 02:08:16 -0700 Need using namespace std for system calls in MIMESniffing.cpp 2012-04-04 20:43:43 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 591966 0 charles.wei 2012-03-30 02:08:16 -0700 Source/WebCore/platform/network/MIMESniffing.cpp uses many libc calls like memcmp, strcmp, etc, directly without a namespace, and that fails compilation for some compilers, like BlackBerry porting. Need using namespace std to get through. 591971 1 134750 charles.wei 2012-03-30 02:18:29 -0700 Created attachment 134750 Patch strcmp and memcmp are c library APIs and should be in std namespace. 595204 2 tonikitoo 2012-04-03 20:37:39 -0700 please adjust the new bug title in the changelog before landing... 596178 3 135736 charles.wei 2012-04-04 18:14:28 -0700 Created attachment 135736 Patch 596186 4 135736 charles.wei 2012-04-04 18:18:33 -0700 Comment on attachment 135736 Patch Thanks for the review, Antonio. 596268 5 135736 webkit.review.bot 2012-04-04 20:43:39 -0700 Comment on attachment 135736 Patch Clearing flags on attachment: 135736 Committed r113283: <http://trac.webkit.org/changeset/113283> 596269 6 webkit.review.bot 2012-04-04 20:43:43 -0700 All reviewed patches have been landed. Closing bug. 134750 2012-03-30 02:18:29 -0700 2012-04-04 18:14:08 -0700 Patch 0001-BlackBerry-Need-using-namespace-std-for-libc-calls-i.patch text/plain 1653 charles.wei RnJvbSBjMDNjNjJiMjYxZGY4MTlhOGIwNWFhMjBiYjllYmI0MWE5N2YxMzYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBGcmksIDMwIE1hciAyMDEyIDE3OjIwOjE4ICswODAwClN1YmplY3Q6IFtQ QVRDSF0gW0JsYWNrQmVycnldIE5lZWQgdXNpbmcgbmFtZXNwYWNlIHN0ZCBmb3IgbGliYyBjYWxs cyBpbgogTUlNRVNuaWZmaW5nLmNwcAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTgyNzA2CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkJ1aWxkIHN5c3RlbSBm aXgsIG5vIHRlc3QgY2FzZXMuCgoqIHBsYXRmb3JtL25ldHdvcmsvTUlNRVNuaWZmaW5nLmNwcDoK LS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgfCAg IDExICsrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL01JTUVTbmlm ZmluZy5jcHAgfCAgICAyICsrCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDAg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDgxNmJhNmEuLmE2YmRlYzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNCBAQAorMjAxMi0wMy0zMCAgQ2hhcmxlcyBXZWkgIDxjaGFybGVzLndlaUB0 b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIE5lZWQgdXNpbmcgbmFt ZXNwYWNlIHN0ZCBmb3IgbGliYyBjYWxscyBpbiBNSU1FU25pZmZpbmcuY3BwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjcwNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkIHN5c3RlbSBmaXgsIG5v IHRlc3QgY2FzZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL01JTUVTbmlmZmluZy5j cHA6CisKIDIwMTItMDMtMzAgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIFdlYkF1ZGlvIGNoYW5uZWxTaXplIGlzc3VlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL01JTUVTbmlmZmluZy5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL01JTUVTbmlmZmluZy5jcHAKaW5kZXggOWRlZWFi My4uMDk3Y2ZkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9N SU1FU25pZmZpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTUlN RVNuaWZmaW5nLmNwcApAQCAtMjMsNiArMjMsOCBAQAogI2luY2x1ZGUgPGNzdHJpbmc+CiAjaW5j bHVkZSA8c3RkaW50Lmg+CiAKK3VzaW5nIG5hbWVzcGFjZSBzdGQ7CisKIC8vIE1JTUUgdHlwZSBz bmlmZmluZyBpbXBsZW1lbnRhdGlvbiBiYXNlZCBvbiBodHRwOi8vdG9vbHMuaWV0Zi5vcmcvaHRt bC9kcmFmdC1hYmFydGgtbWltZS1zbmlmZi0wNgogCiBuYW1lc3BhY2UgewotLSAKMS43LjkuMQoK 135736 2012-04-04 18:14:28 -0700 2012-04-04 20:43:38 -0700 Patch bug-82706-20120405091956.patch text/plain 1288 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWZiMjA5MGNkYmQ4NTll MTYxYjQxN2IyMjRhM2M4ZjczYWY0NzExNy4uYTI4NWE2ZGY3MWZhMjc2ZWE2ZTJlNTJmYjYyNTQ4 MTQ3NTIxOTI1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA0LTA0ICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBOZWVk IHVzaW5nIG5hbWVzcGFjZSBzdGQgZm9yIHN5c3RlbSBjYWxscyBpbiBNSU1FU25pZmZpbmcuY3Bw CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjcwNgor CisgICAgICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29tZXMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBqdXN0IGZpeCB0aGUgY29tcGlsZSBlcnJvciBmb3IgQmxhY2tCZXJyeSBwb3J0aW5nLgor CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9NSU1FU25pZmZpbmcuY3BwOgorCiAyMDEyLTA0 LTA0ICBDaHJpcyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+CiAKICAgICAgICAgV2F2ZVRh YmxlOjp3YXZlRGF0YUZvckZ1bmRhbWVudGFsRnJlcXVlbmN5KCkgc2hvdWxkIHByb3Blcmx5IGlu dGVycHJldCBuZWdhdGl2ZSBmcmVxdWVuY3kKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvTUlNRVNuaWZmaW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvTUlNRVNuaWZmaW5nLmNwcAppbmRleCA5ZGVlYWIzMGRlZTUyN2ZjZDAwZjhiZDY4 ZTkzMjVkNDhjNjQxZGUxLi4wOTdjZmQ3MjQ2YWZiNWJkMTVhZGRlMWZmY2MzNjEwYWRjOTA2MjE0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL01JTUVTbmlmZmlu Zy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9NSU1FU25pZmZpbmcu Y3BwCkBAIC0yMyw2ICsyMyw4IEBACiAjaW5jbHVkZSA8Y3N0cmluZz4KICNpbmNsdWRlIDxzdGRp bnQuaD4KIAordXNpbmcgbmFtZXNwYWNlIHN0ZDsKKwogLy8gTUlNRSB0eXBlIHNuaWZmaW5nIGlt cGxlbWVudGF0aW9uIGJhc2VkIG9uIGh0dHA6Ly90b29scy5pZXRmLm9yZy9odG1sL2RyYWZ0LWFi YXJ0aC1taW1lLXNuaWZmLTA2CiAKIG5hbWVzcGFjZSB7Cg==