82689 2012-03-29 22:36:07 -0700 InsertHTML fails to insert h6 if the insertion point is before some text 2012-04-13 07:29:57 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED HasReduction P2 Normal --- 1 rniwa webkit-unassigned enrica max.hong.shen oldest_to_newest 591881 0 rniwa 2012-03-29 22:36:07 -0700 WebKit fails to execute document.execCommand("insertHTML", false, '<h6>hello world</h6>'); properly (loses h6) if the selection at the time is before some text. Reduction: http://jsbin.com/isibud/3/ (Click "Insert h6"). I suspect this is a bug in markup.cpp. The list of elements there is missing h6 for some reason. 591882 1 rniwa 2012-03-29 22:36:21 -0700 http://crbug.com/117966 596594 2 max.hong.shen 2012-04-05 08:35:24 -0700 The issue is the isHeaderElement() in ReplaceSelectionCommand doesn't include h6Tag. Will provide a patch with tests soon. 596787 3 135874 max.hong.shen 2012-04-05 12:19:03 -0700 Created attachment 135874 First try 601433 4 135874 cshu 2012-04-12 12:20:47 -0700 Comment on attachment 135874 First try The fix looks correct and neat. Did you run the entire layout tests? 601437 5 135874 rniwa 2012-04-12 12:24:11 -0700 Comment on attachment 135874 First try View in context: https://bugs.webkit.org/attachment.cgi?id=135874&action=review > LayoutTests/editing/execCommand/4128080-1.html:15 > + if (actual == expected) > + return "Success\n"; Can we output something for Success case as well so that it'll be easier to understand the output? 601446 6 max.hong.shen 2012-04-12 12:49:32 -0700 Thanks for reviewing. I will update the test case and commit the patch then. 602052 7 max.hong.shen 2012-04-13 07:29:12 -0700 Committed r114131: <http://trac.webkit.org/changeset/114131> 135874 2012-04-05 12:19:03 -0700 2012-04-13 07:29:57 -0700 First try 82689v1.patch text/plain 5859 max.hong.shen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzM1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTA1ICBZaSBTaGVu ICA8eWkuNC5zaGVuQG5va2lhLmNvbT4KKworICAgICAgICBJbnNlcnRIVE1MIGZhaWxzIHRvIGlu c2VydCBoNiBpZiB0aGUgaW5zZXJ0aW9uIHBvaW50IGlzIGJlZm9yZSBzb21lIHRleHQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjY4OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHRoZSBtaXNz aW5nIGg2IHRhZyBmb3IgdGhlIGlzSGVhZGVyRWxlbWVudC4KKworICAgICAgICBObyBuZXcgdGVz dHM6IHVwZGF0ZWQgZXhpc3RpbmcgdGVzdCAoZWRpdGluZy9leGVjQ29tbWFuZC80MTI4MDgwLTEu aHRtbCkKKworICAgICAgICAqIGVkaXRpbmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6aXNIZWFkZXJFbGVtZW50KToKKwogMjAxMi0wNC0wNSAgU2hlcmlm ZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjExMzI0MS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVw bGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwCShyZXZpc2lvbiAxMTMzMzgpCisrKyBT b3VyY2UvV2ViQ29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDQzLDExICs0NDMsMTIgQEAgc3RhdGljIGJvb2wgaXNIZWFkZXJFbGVtZW50 KE5vZGUqIGEpCiAgICAgaWYgKCFhKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIAot ICAgIHJldHVybiBhLT5oYXNUYWdOYW1lKGgxVGFnKSB8fAotICAgICAgICAgICBhLT5oYXNUYWdO YW1lKGgyVGFnKSB8fAotICAgICAgICAgICBhLT5oYXNUYWdOYW1lKGgzVGFnKSB8fAotICAgICAg ICAgICBhLT5oYXNUYWdOYW1lKGg0VGFnKSB8fAotICAgICAgICAgICBhLT5oYXNUYWdOYW1lKGg1 VGFnKTsKKyAgICByZXR1cm4gYS0+aGFzVGFnTmFtZShoMVRhZykKKyAgICAgICAgfHwgYS0+aGFz VGFnTmFtZShoMlRhZykKKyAgICAgICAgfHwgYS0+aGFzVGFnTmFtZShoM1RhZykKKyAgICAgICAg fHwgYS0+aGFzVGFnTmFtZShoNFRhZykKKyAgICAgICAgfHwgYS0+aGFzVGFnTmFtZShoNVRhZykK KyAgICAgICAgfHwgYS0+aGFzVGFnTmFtZShoNlRhZyk7CiB9CiAKIHN0YXRpYyBib29sIGhhdmVT YW1lVGFnTmFtZShOb2RlKiBhLCBOb2RlKiBiKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTEzMzUyKQor KysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTItMDQtMDUgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29tPgorCisgICAgICAgIElu c2VydEhUTUwgZmFpbHMgdG8gaW5zZXJ0IGg2IGlmIHRoZSBpbnNlcnRpb24gcG9pbnQgaXMgYmVm b3JlIHNvbWUgdGV4dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTgyNjg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkZWQgdGhlIG1pc3NpbmcgaDYgdGFnIGZvciB0aGUgaXNIZWFkZXJFbGVtZW50Lgor CisgICAgICAgICogZWRpdGluZy9leGVjQ29tbWFuZC80MTI4MDgwLTEtZXhwZWN0ZWQudHh0Ogor ICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvNDEyODA4MC0xLmh0bWw6CisKIDIwMTItMDQt MDUgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzI5MwpJbmRleDogTGF5 b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC80MTI4MDgwLTEtZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvNDEyODA4MC0xLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMTEzMzM4KQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29t bWFuZC80MTI4MDgwLTEtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKIFN1Y2Nlc3MKIFN1Y2Nlc3MKK1N1Y2Nlc3MKK1N1Y2Nlc3MKK1N1Y2Nlc3MKK1N1Y2Nlc3MK K1N1Y2Nlc3MKK1N1Y2Nlc3MKK1N1Y2Nlc3MKK1N1Y2Nlc3MKK1N1Y2Nlc3MKK1N1Y2Nlc3MKIApJ bmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC80MTI4MDgwLTEuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kLzQxMjgwODAtMS5odG1s CShyZXZpc2lvbiAxMTMzMzgpCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kLzQx MjgwODAtMS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDM1ICsxLDQyIEBACi08ZGl2IGlkPSJk aXYxIiBjb250ZW50RWRpdGFibGU9InRydWUiPmZvb2ZvbzwvZGl2PgotPGRpdiBpZD0iZGl2MiIg Y29udGVudEVkaXRhYmxlPSJ0cnVlIj5mb29mb288L2Rpdj4KLQorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxib2R5PgorPC9ib2R5PgogPHNjcmlwdD4KK2Z1bmN0aW9uIGluc2VydEhlYWRlckZv clRlc3QodGVzdENvbnRlbnQsIGV4cGVjdGVkKQoreworICAgIGRvY3VtZW50LmJvZHkuaW5uZXJI VE1MID0gIjxkaXYgaWQ9J3Rlc3REaXYnIGNvbnRlbnRFZGl0YWJsZT0ndHJ1ZSc+Zm9vZm9vPC9k aXY+IjsKKyAgICB2YXIgdGFyZ2V0RGl2ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RE aXYiKTsKKyAgICB2YXIgdGFyZ2V0VGV4dCA9IHRhcmdldERpdi5maXJzdENoaWxkOworICAgIHdp bmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbih0YXJnZXRUZXh0LCAzKTsKKyAgICBkb2N1 bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0SFRNTCIsIGZhbHNlLCB0ZXN0Q29udGVudCk7CisgICAg dmFyIGFjdHVhbCA9IHRhcmdldERpdi5pbm5lckhUTUw7CisgICAgaWYgKGFjdHVhbCA9PSBleHBl Y3RlZCkKKyAgICAgICAgcmV0dXJuICJTdWNjZXNzXG4iOworICAgIHJldHVybiAiRmFpbHVyZS4g UmVzdWx0IHdhczogIiArIGFjdHVhbCArICIsIHNob3VsZCBoYXZlIGJlZW46ICIgKyBleHBlY3Rl ZCArICJcbiI7Cit9CisKIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgd2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKLSAgICAKKwogb3V0cHV0ID0g IiI7CiAKIC8vIFRlc3QgMTogVmVyaWZ5IHRoYXQgYSBoZWFkZXIgYXQgdGhlIGJlZ2lubmluZyBv ZiBpbnNlcnRlZCBjb250ZW50IGlzIHByZXNlcnZlZC4KLWRpdiA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJkaXYxIik7Ci10ZXh0ID0gZGl2LmZpcnN0Q2hpbGQ7Ci13aW5kb3cuZ2V0U2VsZWN0 aW9uKCkuc2V0UG9zaXRpb24odGV4dCwgMyk7Ci1kb2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0 SFRNTCIsIGZhbHNlLCAiPGgxPmJhcjwvaDE+PGRpdj5iYXo8L2Rpdj4iKTsKLWV4cGVjdGVkID0g ImZvbzxoMT5iYXI8L2gxPmJhemZvbyI7Ci1hY3R1YWwgPSBkaXYuaW5uZXJIVE1MOwotaWYgKGFj dHVhbCA9PSBleHBlY3RlZCkKLSAgICBvdXRwdXQgKz0gIlN1Y2Nlc3NcbiI7Ci1lbHNlCi0gICAg b3V0cHV0ICs9ICJGYWlsdXJlLiBSZXN1bHQgd2FzOiAiICsgYWN0dWFsICsgIiwgc2hvdWxkIGhh dmUgYmVlbjogIiArIGV4cGVjdGVkICsgIlxuIjsKLSAgICAKK291dHB1dCArPSBpbnNlcnRIZWFk ZXJGb3JUZXN0KCI8aDE+YmFyPC9oMT48ZGl2PmJhejwvZGl2PiIsICJmb288aDE+YmFyPC9oMT5i YXpmb28iKTsKK291dHB1dCArPSBpbnNlcnRIZWFkZXJGb3JUZXN0KCI8aDI+YmFyPC9oMj48ZGl2 PmJhejwvZGl2PiIsICJmb288aDI+YmFyPC9oMj5iYXpmb28iKTsKK291dHB1dCArPSBpbnNlcnRI ZWFkZXJGb3JUZXN0KCI8aDM+YmFyPC9oMz48ZGl2PmJhejwvZGl2PiIsICJmb288aDM+YmFyPC9o Mz5iYXpmb28iKTsKK291dHB1dCArPSBpbnNlcnRIZWFkZXJGb3JUZXN0KCI8aDQ+YmFyPC9oND48 ZGl2PmJhejwvZGl2PiIsICJmb288aDQ+YmFyPC9oND5iYXpmb28iKTsKK291dHB1dCArPSBpbnNl cnRIZWFkZXJGb3JUZXN0KCI8aDU+YmFyPC9oNT48ZGl2PmJhejwvZGl2PiIsICJmb288aDU+YmFy PC9oNT5iYXpmb28iKTsKK291dHB1dCArPSBpbnNlcnRIZWFkZXJGb3JUZXN0KCI8aDY+YmFyPC9o Nj48ZGl2PmJhejwvZGl2PiIsICJmb288aDY+YmFyPC9oNj5iYXpmb28iKTsKKwogLy8gVGVzdCAy OiBWZXJpZnkgdGhhdCBhIGhlYWRlciBhdCB0aGUgZW5kIG9mIGluc2VydGVkIGNvbnRlbnQgaXMg cHJlc2VydmVkLgotZGl2ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRpdjIiKTsKLXRleHQg PSBkaXYuZmlyc3RDaGlsZDsKLXdpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbih0ZXh0 LCAzKTsKLWRvY3VtZW50LmV4ZWNDb21tYW5kKCJJbnNlcnRIVE1MIiwgZmFsc2UsICI8ZGl2PmJh cjwvZGl2PjxoMT5iYXo8L2gxPiIpOwotZXhwZWN0ZWQgPSAiZm9vYmFyPGgxPmJhejwvaDE+Zm9v IjsKLWFjdHVhbCA9IGRpdi5pbm5lckhUTUw7Ci1pZiAoYWN0dWFsID09IGV4cGVjdGVkKQotICAg IG91dHB1dCArPSAiU3VjY2Vzc1xuIjsKLWVsc2UKLSAgICBvdXRwdXQgKz0gIkZhaWx1cmUuIFJl c3VsdCB3YXM6ICIgKyBhY3R1YWwgKyAiLCBzaG91bGQgaGF2ZSBiZWVuOiAiICsgZXhwZWN0ZWQg KyAiXG4iOworb3V0cHV0ICs9IGluc2VydEhlYWRlckZvclRlc3QoIjxkaXY+YmFyPC9kaXY+PGgx PmJhejwvaDE+IiwgImZvb2JhcjxoMT5iYXo8L2gxPmZvbyIpOworb3V0cHV0ICs9IGluc2VydEhl YWRlckZvclRlc3QoIjxkaXY+YmFyPC9kaXY+PGgyPmJhejwvaDI+IiwgImZvb2JhcjxoMj5iYXo8 L2gyPmZvbyIpOworb3V0cHV0ICs9IGluc2VydEhlYWRlckZvclRlc3QoIjxkaXY+YmFyPC9kaXY+ PGgzPmJhejwvaDM+IiwgImZvb2JhcjxoMz5iYXo8L2gzPmZvbyIpOworb3V0cHV0ICs9IGluc2Vy dEhlYWRlckZvclRlc3QoIjxkaXY+YmFyPC9kaXY+PGg0PmJhejwvaDQ+IiwgImZvb2JhcjxoND5i YXo8L2g0PmZvbyIpOworb3V0cHV0ICs9IGluc2VydEhlYWRlckZvclRlc3QoIjxkaXY+YmFyPC9k aXY+PGg1PmJhejwvaDU+IiwgImZvb2JhcjxoNT5iYXo8L2g1PmZvbyIpOworb3V0cHV0ICs9IGlu c2VydEhlYWRlckZvclRlc3QoIjxkaXY+YmFyPC9kaXY+PGg2PmJhejwvaDY+IiwgImZvb2Jhcjxo Nj5iYXo8L2g2PmZvbyIpOwogCiBkb2N1bWVudC5ib2R5LmlubmVyVGV4dCA9IG91dHB1dDsKIDwv c2NyaXB0PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK