82673 2012-03-29 15:50:15 -0700 new-run-webkit-tests: crashes when it fails to decode a stack trace 2012-03-29 16:00:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric mrobinson ojan pnormand tony webkit.review.bot oldest_to_newest 591664 0 dpranke 2012-03-29 15:50:15 -0700 new-run-webkit-tests: crashes when it fails to decode a stack trace 591665 1 134685 dpranke 2012-03-29 15:51:34 -0700 Created attachment 134685 Patch 591666 2 dpranke 2012-03-29 15:52:33 -0700 landing w/o review because this is causing build crashes, but I'm still not 100% sure this is the best thing to do, or if we should even be assuming DRT/WTR emit utf-8 by default. 591669 3 dpranke 2012-03-29 15:53:51 -0700 Committed r112594: <http://trac.webkit.org/changeset/112594> 591670 4 134685 eric 2012-03-29 15:55:08 -0700 Comment on attachment 134685 Patch The output from the driver is not UTF8. The diffs can contain all sorts of non-utf8 characters, effectively binary. We shouldn't be decoding the output at all, assuming I'm remembering correctly. 591671 5 eric 2012-03-29 15:55:57 -0700 By "diffs" I meant, the output from the tests. It's common for a test to have non-utf8 characters rendered in it. At least that's my recollection. I'm surprised that we were interpreting the output from the drivers as utf8 in teh first place. 591674 6 dpranke 2012-03-29 16:00:22 -0700 (In reply to comment #5) > By "diffs" I meant, the output from the tests. It's common for a test to have non-utf8 characters rendered in it. At least that's my recollection. I'm surprised that we were interpreting the output from the drivers as utf8 in teh first place. You're correct, generally speaking. The case in question is what happens when we get a stack trace, though. pnormand thought we were getting utf-8, but that might be gtk-specific. It might be that we should decode utf-8 for stderr, but not decode stdout at all, or it might be that we should just do something port-specific. This patch is strictly better than what was there before (since we were trying to decode and crashing), but we should continue to look at the crash logs and perhaps change the implementation if there are issues. 134685 2012-03-29 15:51:34 -0700 2012-03-29 15:55:07 -0700 Patch bug-82673-20120329155132.patch text/plain 3204 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNTg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWI0MTA4OTg4ZDAzZTYyYWU5YjZlOGJiNzc0NmZiNjMx OWFjMTM1ZS4uYjMyZjIwZDc3YzZmNGUzZjZlMGQ5ODA5NDNkMmY4ZTY5YWQxYTc2ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTAzLTI5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzOiBjcmFzaGVzIHdoZW4gaXQgZmFpbHMgdG8gZGVj b2RlIGEgc3RhY2sgdHJhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgyNjczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2UgYXJlIGFzc3VtaW5nIHRoZSBzdGRvdXQvc3RkZXJyIG91dHB1dCBmcm9tIHRo ZSBkcml2ZXIgaXMgdXRmLTgKKyAgICAgICAgZW5jb2RlZCB3aGVuIHdlIGdldCBzdGFjayB0cmFj ZXM7IHRoaXMgbWF5IG5vdCBiZSBhIHZhbGlkCisgICAgICAgIGFzc3VtcHRpb24gZ2VuZXJhbGx5 LCBidXQgaWYgd2UgZG8gZ2V0IHN0cmluZ3MgdGhhdCBhcmVuJ3QgdmFsaWQKKyAgICAgICAgdXRm LTgsIHdlIHdvdWxkIGNyYXNoLiBOb3cgd2Ugd2lsbCBpZ25vcmUgYW55IGRlY29kaW5nIGVycm9y cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5w eToKKyAgICAgICAgKFBvcnQuX2dldF9jcmFzaF9sb2cpOgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2FzZS5weToKKyAgICAgICAgKFBvcnRU ZXN0Q2FzZS50ZXN0X2dldF9jcmFzaF9sb2cpOgorCiAyMDEyLTAzLTI5ICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFNjcmlwdHMgZmFpbCB0byBkZXRl Y3Qgd2hlbiBhIHRvb2wgY3Jhc2hlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9iYXNlLnB5CmluZGV4IDJiNTFiMzNjOGQyZDFhM2ZhNGVmM2ZhZGY5ZTk0 MzJkNThmNGI1NWMuLmNlZWZlYzc1YmQ2ZGQ5MWVlMjQ0MDVhNDhjY2JlY2UwYThkMDM4NTkgMTAw NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkK QEAgLTEwNTQsOCArMTA1NCw4IEBAIGNsYXNzIFBvcnQob2JqZWN0KToKICAgICBkZWYgX2dldF9j cmFzaF9sb2coc2VsZiwgbmFtZSwgcGlkLCBzdGRvdXQsIHN0ZGVycik6CiAgICAgICAgIG5hbWVf c3RyID0gbmFtZSBvciAnPHVua25vd24gcHJvY2VzcyBuYW1lPicKICAgICAgICAgcGlkX3N0ciA9 IHN0cihwaWQgb3IgJzx1bmtub3duPicpCi0gICAgICAgIHN0ZG91dF9saW5lcyA9IChzdGRvdXQg b3IgJzxlbXB0eT4nKS5kZWNvZGUoJ3V0ZjgnKS5zcGxpdGxpbmVzKCkKLSAgICAgICAgc3RkZXJy X2xpbmVzID0gKHN0ZGVyciBvciAnPGVtcHR5PicpLmRlY29kZSgndXRmOCcpLnNwbGl0bGluZXMo KQorICAgICAgICBzdGRvdXRfbGluZXMgPSAoc3Rkb3V0IG9yICc8ZW1wdHk+JykuZGVjb2RlKCd1 dGY4JywgJ3JlcGxhY2UnKS5zcGxpdGxpbmVzKCkKKyAgICAgICAgc3RkZXJyX2xpbmVzID0gKHN0 ZGVyciBvciAnPGVtcHR5PicpLmRlY29kZSgndXRmOCcsICdyZXBsYWNlJykuc3BsaXRsaW5lcygp CiAgICAgICAgIHJldHVybiAnY3Jhc2ggbG9nIGZvciAlcyAocGlkICVzKTpcbiVzXG4lc1xuJyAl IChuYW1lX3N0ciwgcGlkX3N0ciwKICAgICAgICAgICAgICdcbicuam9pbigoJ1NURE9VVDogJyAr IGwpIGZvciBsIGluIHN0ZG91dF9saW5lcyksCiAgICAgICAgICAgICAnXG4nLmpvaW4oKCdTVERF UlI6ICcgKyBsKSBmb3IgbCBpbiBzdGRlcnJfbGluZXMpKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5CmluZGV4 IDIyYjExNTY0MjY2ZjhjZDk5Nzc5ZTUxMGEyY2VjN2FiZGJhMDNkYTUuLjFiZTJiZTQzN2I1MDg5 MjcyZWQ3NmEwMzQ2ZWE3MGI4NWJjM2Q2OGMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2FzZS5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHkKQEAgLTMxNCw2 ICszMTQsMTggQEAgY2xhc3MgUG9ydFRlc3RDYXNlKHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAg ICAgICAgICdTVERPVVQ6IDxlbXB0eT5cbicKICAgICAgICAgICAgICdTVERFUlI6IDxlbXB0eT5c bicpKQogCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuX2dldF9jcmFzaF9sb2coJ2Zv bycsIDEyMzQsICdvdXQgYmFyXG5vdXQgYmF6JywgJ2VyciBiYXJcbmVyciBiYXpcbicpLAorICAg ICAgICAgICAgKCdjcmFzaCBsb2cgZm9yIGZvbyAocGlkIDEyMzQpOlxuJworICAgICAgICAgICAg ICdTVERPVVQ6IG91dCBiYXJcbicKKyAgICAgICAgICAgICAnU1RET1VUOiBvdXQgYmF6XG4nCisg ICAgICAgICAgICAgJ1NUREVSUjogZXJyIGJhclxuJworICAgICAgICAgICAgICdTVERFUlI6IGVy ciBiYXpcbicpKQorCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuX2dldF9jcmFzaF9s b2coJ2ZvbycsIDEyMzQsICdmb29ceGE2YmFyJywgJ2Zvb1x4YTZiYXInKSwKKyAgICAgICAgICAg ICh1J2NyYXNoIGxvZyBmb3IgZm9vIChwaWQgMTIzNCk6XG4nCisgICAgICAgICAgICAgdSdTVERP VVQ6IGZvb1x1ZmZmZGJhclxuJworICAgICAgICAgICAgIHUnU1RERVJSOiBmb29cdWZmZmRiYXJc bicpKQorCiAKICMgRklYTUU6IFRoaXMgY2xhc3MgYW5kIG1haW4oKSBzaG91bGQgYmUgbWVyZ2Vk IGludG8gdGVzdC13ZWJraXRweS4KIGNsYXNzIEVuaGFuY2VkVGVzdExvYWRlcih1bml0dGVzdC5U ZXN0TG9hZGVyKToK