82644 2012-03-29 12:48:39 -0700 InputType attribute changed functions should happen after the attribute change 2012-03-29 15:33:01 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned benjamin ddkilzer joepeck tkent webkit.review.bot oldest_to_newest 591457 0 joepeck 2012-03-29 12:48:39 -0700 InputType::disabledAttributeChanged and InputType::readonlyAttributeChanged should happen after the attribute has actually changed. This way if the InputType looks at the state, it would correctly get the new value, not the old value. 591461 1 134649 joepeck 2012-03-29 12:52:10 -0700 Created attachment 134649 [PATCH] Proposed Fix Saw this while looking at: <http://webkit.org/b/82558> Toggling <input type="range"> readonly or disabled state while active breaks all click events It doesn't really make sense to call the changed function until the value has actually changed! 591477 2 134649 eric 2012-03-29 13:13:06 -0700 Comment on attachment 134649 [PATCH] Proposed Fix OK. How do we observe this? 591509 3 joepeck 2012-03-29 13:39:28 -0700 (In reply to comment #2) > (From update of attachment 134649 [details]) > OK. How do we observe this? This doesn't change any existing behavior. The only user of these InputType functions doesn't turn around and change the readonly / disabled state of the input. But if someone wanted to do that than this ordering would matter. I had a patch that used these functions and this confused me. To fix the problem we did not go with that patch, but I still wanted to fix this issue. 591513 4 joepeck 2012-03-29 13:40:30 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 134649 [details] [details]) > > OK. How do we observe this? > > The only user of these InputType functions doesn't turn around and > change the readonly / disabled state of the input. I typo'd. This should have said, ".. doesn't turn around and check the state..." 591535 5 134649 benjamin 2012-03-29 14:04:03 -0700 Comment on attachment 134649 [PATCH] Proposed Fix This looks correct to me. I see why you cannot test this, no InputType rely on the attribute value in response to disabledAttributeChanged() or readonlyAttributeChanged(). 591645 6 134649 webkit.review.bot 2012-03-29 15:32:57 -0700 Comment on attachment 134649 [PATCH] Proposed Fix Clearing flags on attachment: 134649 Committed r112589: <http://trac.webkit.org/changeset/112589> 591646 7 webkit.review.bot 2012-03-29 15:33:01 -0700 All reviewed patches have been landed. Closing bug. 134649 2012-03-29 12:52:10 -0700 2012-03-29 15:32:57 -0700 [PATCH] Proposed Fix take-1.patch text/plain 1598 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZGE5ZDFjLi41OWI3NDgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTItMDMtMjkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBJbnB1dFR5cGUgYXR0cmlidXRlIGNoYW5nZWQgZnVuY3Rpb25zIHNob3VsZCBoYXBw ZW4gYWZ0ZXIgdGhlIGF0dHJpYnV0ZSBjaGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUpOgorCiAyMDEyLTAz LTI4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgPGh0 dHA6Ly93ZWJraXQub3JnL2IvODI1NTg+IFRvZ2dsaW5nIDxpbnB1dCB0eXBlPSJyYW5nZSI+IHJl YWRvbmx5IG9yIGRpc2FibGVkIHN0YXRlIHdoaWxlIGFjdGl2ZSBicmVha3MgYWxsIGNsaWNrIGV2 ZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKaW5kZXggYWQ0ZjM4 Yy4uOTBlMGQzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBA IC03NzEsMTEgKzc3MSwxMSBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRl KEF0dHJpYnV0ZSogYXR0cikKICAgICB9IGVsc2UgaWYgKGF0dHItPm5hbWUoKSA9PSBwYXR0ZXJu QXR0ciB8fCBhdHRyLT5uYW1lKCkgPT0gcHJlY2lzaW9uQXR0cikKICAgICAgICAgc2V0TmVlZHNW YWxpZGl0eUNoZWNrKCk7CiAgICAgZWxzZSBpZiAoYXR0ci0+bmFtZSgpID09IGRpc2FibGVkQXR0 cikgeworICAgICAgICBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUo YXR0cik7CiAgICAgICAgIG1faW5wdXRUeXBlLT5kaXNhYmxlZEF0dHJpYnV0ZUNoYW5nZWQoKTsK LSAgICAgICAgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKGF0dHIp OwogICAgIH0gZWxzZSBpZiAoYXR0ci0+bmFtZSgpID09IHJlYWRvbmx5QXR0cikgeworICAgICAg ICBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUoYXR0cik7CiAgICAg ICAgIG1faW5wdXRUeXBlLT5yZWFkb25seUF0dHJpYnV0ZUNoYW5nZWQoKTsKLSAgICAgICAgSFRN TFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKGF0dHIpOwogICAgIH0KICNp ZiBFTkFCTEUoREFUQUxJU1QpCiAgICAgZWxzZSBpZiAoYXR0ci0+bmFtZSgpID09IGxpc3RBdHRy KQo=