82625 2012-03-29 09:59:26 -0700 Web Inspector: improve window selection accuracy in vertical overview of timeline panel 2012-03-29 11:35:27 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 591270 0 caseq 2012-03-29 09:59:26 -0700 This fixes a number of small errors when calculating window boundaries for vertical overview mode. 591272 1 134608 caseq 2012-03-29 10:01:23 -0700 Created attachment 134608 Patch 591346 2 134608 vsevik 2012-03-29 11:19:00 -0700 Comment on attachment 134608 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134608&action=review > Source/WebCore/ChangeLog:7 > + Please add: This fixes a number of small errors when calculating window boundaries for vertical overview mode. > Source/WebCore/inspector/front-end/TimelineOverviewPane.js:992 > + this._actualBarWidth = Math.min((this.element.width - 2 * this._outerPadding) / allBarHeights.length, this._maxInnerBarWidth + maxPadding); _actualOuterBarWidth 591376 3 caseq 2012-03-29 11:35:27 -0700 Committed r112554: <http://trac.webkit.org/changeset/112554> 134608 2012-03-29 10:01:23 -0700 2012-03-29 11:19:00 -0700 Patch bug-82625-20120329210121.patch text/plain 4054 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGZjMzQ1YjI0ZDExYzdl NDg0ODRiYjJmNzE2MjJjMzFhMDQzZGZjYy4uMWM2NmQxZjBlNjljZGU2Y2FlY2QyZmU1NmYzMzBh NTM3ZDdhZjk4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEyLTAzLTI5ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogaW1wcm92ZSB3aW5kb3cgc2VsZWN0aW9uIGFjY3VyYWN5IGluIHZlcnRpY2FsIG92ZXJ2aWV3 IG9mIHRpbWVsaW5lIHBhbmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MjYyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFuZS5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVZlcnRpY2FsT3ZlcnZpZXcpOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lVmVydGljYWxPdmVydmlldy5wcm90b3R5cGUuX3JlbmRl ckJhcnMpOiBwcmVzZXJ2ZSBhY3R1YWwgcGFkZGluZyB1c2VkIHdoaWxlIHJlbmRlcmluZyBiYXJz LgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lVmVydGljYWxPdmVydmlldy5wcm90b3R5 cGUuZ2V0V2luZG93VGltZXMpOiBhY2NvdW50IGZvciBvdXRlciBhbmQgaW50ZXItYmFycyBwYWRk aW5nIHdoZW4gY2FsY3VsYXRpbmcgYmFyIG9mZnNldHMuCisKKzIwMTItMDMtMjkgIEFuZHJleSBL b3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBv biBhIHNpbmdsZSBjbGljayBpbiBUaW1lbGluZSBvdmVydmlldywgbWFrZSBhIG1pbmltYWwgc2Vs ZWN0aW9uIGNlbnRlcmVkIGFyb3VuZCBjdXJzb3IKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNjE2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVPdmVydmlld1BhbmUuanMgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lT3ZlcnZpZXdQYW5lLmpzCmluZGV4IGNm NGM5ODFiNmQyZGQ4MGIxYjkxOGVhNGQyZDZmODgxNmViZmM1MzMuLjY5MzNkYzEwYjQ0N2E4MGZi YTQxZTBjODcwNGZmZGViMzJhNDczNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvVGltZWxpbmVPdmVydmlld1BhbmUuanMKKysrIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFuZS5qcwpAQCAtODE1LDcg KzgxNSwxMyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVWZXJ0aWNhbE92ZXJ2aWV3ID0gZnVuY3Rp b24obW9kZWwpIHsKICAgICB0aGlzLl9tb2RlbCA9IG1vZGVsOwogICAgIHRoaXMucmVzZXQoKTsK IAorICAgIHRoaXMuX291dGVyUGFkZGluZyA9IDQ7CiAgICAgdGhpcy5fbWF4SW5uZXJCYXJXaWR0 aCA9IDEwOworCisgICAgLy8gVGhlIGJlbG93IHR3byBhcmUgcmVhbGx5IGNvbXB1dGVkIGJ5IHVw ZGF0ZSgpIC0tIGJ1dCBsZXQncyBoYXZlIHNvbWV0aGluZyBzbyB0aGF0IGdldFdpbmRvd1RpbWVz KCkgaXMgaGFwcHkuCisgICAgdGhpcy5fYWN0dWFsQmFyV2lkdGggPSB0aGlzLl9tYXhJbm5lckJh cldpZHRoOworICAgIHRoaXMuX2FjdHVhbFBhZGRpbmcgPSA1OworCiAgICAgdGhpcy5fY29udGV4 dCA9IHRoaXMuZWxlbWVudC5nZXRDb250ZXh0KCIyZCIpOwogICAgIHRoaXMuX2ZpbGxTdHlsZXMg PSB7fTsKICAgICB0aGlzLl9maWxsU3R5bGVzLmxvYWRpbmcgPSB0aGlzLl9jb250ZXh0LmNyZWF0 ZUxpbmVhckdyYWRpZW50KDAsIDAsIHRoaXMuX21heElubmVyQmFyV2lkdGgsIDApOwpAQCAtOTgz LDExICs5ODksMTEgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lVmVydGljYWxPdmVydmlldy5wcm90 b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuZWxlbWVudC5oZWlnaHQgPSB0aGlzLmVsZW1lbnQuY2xp ZW50SGVpZ2h0OwogCiAgICAgICAgIGNvbnN0IG1heFBhZGRpbmcgPSA1OwotICAgICAgICB0aGlz Ll9hY3R1YWxCYXJXaWR0aCA9IE1hdGgubWluKCh0aGlzLmVsZW1lbnQud2lkdGggLSAyICogbWF4 UGFkZGluZykgLyBhbGxCYXJIZWlnaHRzLmxlbmd0aCwgdGhpcy5fbWF4SW5uZXJCYXJXaWR0aCAr IG1heFBhZGRpbmcpOwotICAgICAgICB2YXIgcGFkZGluZyA9IE1hdGgubWluKE1hdGguZmxvb3Io dGhpcy5fYWN0dWFsQmFyV2lkdGggLyAzKSwgbWF4UGFkZGluZyk7CisgICAgICAgIHRoaXMuX2Fj dHVhbEJhcldpZHRoID0gTWF0aC5taW4oKHRoaXMuZWxlbWVudC53aWR0aCAtIDIgKiB0aGlzLl9v dXRlclBhZGRpbmcpIC8gYWxsQmFySGVpZ2h0cy5sZW5ndGgsIHRoaXMuX21heElubmVyQmFyV2lk dGggKyBtYXhQYWRkaW5nKTsKKyAgICAgICAgdGhpcy5fYWN0dWFsUGFkZGluZyA9IE1hdGgubWlu KE1hdGguZmxvb3IodGhpcy5fYWN0dWFsQmFyV2lkdGggLyAzKSwgbWF4UGFkZGluZyk7CiAKICAg ICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBhbGxCYXJIZWlnaHRzLmxlbmd0aDsgKytpKQotICAg ICAgICAgICAgdGhpcy5fcmVuZGVyQmFyKG1heFBhZGRpbmcgKyB0aGlzLl9hY3R1YWxCYXJXaWR0 aCAqIGksIHRoaXMuX2FjdHVhbEJhcldpZHRoIC0gcGFkZGluZyAsIGFsbEJhckhlaWdodHNbaV0s IHNjYWxlKTsKKyAgICAgICAgICAgIHRoaXMuX3JlbmRlckJhcih0aGlzLl9vdXRlclBhZGRpbmcg KyB0aGlzLl9hY3R1YWxCYXJXaWR0aCAqIGksIHRoaXMuX2FjdHVhbEJhcldpZHRoIC0gdGhpcy5f YWN0dWFsUGFkZGluZywgYWxsQmFySGVpZ2h0c1tpXSwgc2NhbGUpOwogICAgIH0sCiAKICAgICBf cmVuZGVyQmFyOiBmdW5jdGlvbihsZWZ0LCB3aWR0aCwgYmFySGVpZ2h0cywgc2NhbGUpCkBAIC0x MDE5LDExICsxMDI1LDExIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVZlcnRpY2FsT3ZlcnZpZXcu cHJvdG90eXBlID0gewogICAgIGdldFdpbmRvd1RpbWVzOiBmdW5jdGlvbih3aW5kb3dMZWZ0LCB3 aW5kb3dSaWdodCkKICAgICB7CiAgICAgICAgIHZhciB3aW5kb3dTcGFuID0gdGhpcy5lbGVtZW50 LmNsaWVudFdpZHRoCi0gICAgICAgIHZhciBsZWZ0T2Zmc2V0ID0gd2luZG93TGVmdCAqIHdpbmRv d1NwYW47Ci0gICAgICAgIHZhciByaWdodE9mZnNldCA9IHdpbmRvd1JpZ2h0ICogd2luZG93U3Bh bjsKKyAgICAgICAgdmFyIGxlZnRPZmZzZXQgPSB3aW5kb3dMZWZ0ICogd2luZG93U3BhbiAtIHRo aXMuX291dGVyUGFkZGluZyArIHRoaXMuX2FjdHVhbFBhZGRpbmc7CisgICAgICAgIHZhciByaWdo dE9mZnNldCA9IHdpbmRvd1JpZ2h0ICogd2luZG93U3BhbiAtIHRoaXMuX291dGVyUGFkZGluZzsK ICAgICAgICAgdmFyIGJhcnMgPSB0aGlzLmVsZW1lbnQuY2hpbGRyZW47CiAgICAgICAgIHZhciBm aXJzdEJhciA9IE1hdGguZmxvb3IoTWF0aC5tYXgobGVmdE9mZnNldCwgMCkgLyB0aGlzLl9hY3R1 YWxCYXJXaWR0aCk7Ci0gICAgICAgIHZhciBsYXN0QmFyID0gTWF0aC5taW4oTWF0aC5jZWlsKChy aWdodE9mZnNldCAtIDIpIC8gdGhpcy5fYWN0dWFsQmFyV2lkdGgpLCB0aGlzLl9iYXJUaW1lcy5s ZW5ndGggLSAxKTsKKyAgICAgICAgdmFyIGxhc3RCYXIgPSBNYXRoLm1pbihNYXRoLmZsb29yKHJp Z2h0T2Zmc2V0IC8gdGhpcy5fYWN0dWFsQmFyV2lkdGgpLCB0aGlzLl9iYXJUaW1lcy5sZW5ndGgg LSAxKTsKICAgICAgICAgY29uc3Qgc25hcFRvUmlnaHRUb2xlcmFuY2VQaXhlbHMgPSAzOwogICAg ICAgICByZXR1cm4gewogICAgICAgICAgICAgc3RhcnRUaW1lOiBmaXJzdEJhciA+PSB0aGlzLl9i YXJUaW1lcy5sZW5ndGggPyBJbmZpbml0eSA6IHRoaXMuX2JhclRpbWVzW2ZpcnN0QmFyXS5zdGFy dFRpbWUsCg==