82619 2012-03-29 08:49:17 -0700 Web Inspector: SnippetsScriptMapping should process existing snippets on load. 2012-03-29 09:46:10 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 591219 0 vsevik 2012-03-29 08:49:17 -0700 Otherwise scripts panel shows snippets created during current session only. 591221 1 134595 vsevik 2012-03-29 08:51:46 -0700 Created attachment 134595 Patch 591245 2 134595 pfeldman 2012-03-29 09:21:25 -0700 Comment on attachment 134595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134595&action=review > Source/WebCore/inspector/front-end/SnippetsModel.js:67 > + var result = []; Nit: you could introduce Object.prototype.valuesArray 591257 3 vsevik 2012-03-29 09:46:10 -0700 Committed r112541: <http://trac.webkit.org/changeset/112541> 134595 2012-03-29 08:51:46 -0700 2012-03-29 09:21:24 -0700 Patch bug-82619-20120329195145.patch text/plain 3608 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk0NzAzZTY4M2FkZjI4 MWQ2NGE3NmMwOWIyNjJkODVmMzYyMWFhZS4uYzk3MzhmNDdhZTU3OTkzNmJkYmRjOGZjMDgxMDY3 ZGEyZDhlYzM0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTAzLTI5ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFNuaXBwZXRzU2NyaXB0TWFwcGluZyBzaG91bGQgcHJvY2VzcyBleGlzdGluZyBzbmlwcGV0 cyBvbiBsb2FkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODI2MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTbmlwcGV0c1NjcmlwdE1hcHBpbmcgbm93IGxvYWRzIGV4aXN0aW5nIHNuaXBwZXRzIG9uIGNy ZWF0aW9uLgorICAgICAgICBPdGhlcndpc2Ugc2NyaXB0cyBwYW5lbCBzaG93cyBzbmlwcGV0cyBj cmVhdGVkIGR1cmluZyBjdXJyZW50IHNlc3Npb24gb25seS4KKworICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvU25pcHBldHNNb2RlbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tbmlw cGV0c01vZGVsLnByb3RvdHlwZS5zZXQgZ2V0IHNuaXBwZXRzKToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5TbmlwcGV0c1NjcmlwdE1hcHBpbmcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNuaXBw ZXRzU2NyaXB0TWFwcGluZy5wcm90b3R5cGUuX2hhbmRsZVNuaXBwZXRBZGRlZCk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuU25pcHBldHNTY3JpcHRNYXBwaW5nLnByb3RvdHlwZS5fc25pcHBldEFk ZGVkKToKKworMjAxMi0wMy0yOSAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9y Zz4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBFeGlzdGluZyBVSVNvdXJjZUNvZGUgc2hvdWxk IGJlIGxvYWRlZCBvbiBzY3JpcHRzIHBhbmVsIGNyZWF0aW9uL3Jlc2V0LgogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI2MTQKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TbmlwcGV0c01vZGVsLmpzIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TbmlwcGV0c01vZGVsLmpzCmluZGV4IDAx NzA3MTExNDYwNDg1YTM2NGZjODJjZTBiZjk5YTZmMTU1NWNlNWQuLjY4ZTkyYzVkMGY4N2IwNjM2 OTk1OTA5MTY4YjdhYTRhNjU1Y2IxMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvU25pcHBldHNNb2RlbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1NuaXBwZXRzTW9kZWwuanMKQEAgLTU5LDYgKzU5LDE3IEBAIFdlYklu c3BlY3Rvci5TbmlwcGV0c01vZGVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5fc25pcHBl dHNTZXR0aW5nLnNldChzYXZlZFNuaXBwZXRzKTsKICAgICB9LAogCisgICAgLyoqCisgICAgICog QHR5cGUge0FycmF5LjxXZWJJbnNwZWN0b3IuU25pcHBldD59CisgICAgICovCisgICAgZ2V0IHNu aXBwZXRzKCkKKyAgICB7CisgICAgICAgIHZhciByZXN1bHQgPSBbXTsKKyAgICAgICAgZm9yICh2 YXIgaWQgaW4gdGhpcy5fc25pcHBldHMpCisgICAgICAgICAgICByZXN1bHQucHVzaCh0aGlzLl9z bmlwcGV0c1tpZF0pOworICAgICAgICByZXR1cm4gcmVzdWx0OworICAgIH0sCisKICAgICBfbG9h ZFNldHRpbmdzOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICB2YXIgc2F2ZWRTbmlwcGV0cyA9 IHRoaXMuX3NuaXBwZXRzU2V0dGluZy5nZXQoKTsKQEAgLTI3Nyw5ICsyODgsMTEgQEAgV2ViSW5z cGVjdG9yLlNuaXBwZXRzU2NyaXB0TWFwcGluZyA9IGZ1bmN0aW9uKCkKICAgICB0aGlzLl9zY3Jp cHRGb3JVSVNvdXJjZUNvZGUgPSBuZXcgTWFwKCk7CiAgICAgdGhpcy5fdWlTb3VyY2VDb2RlRm9y U25pcHBldCA9IG5ldyBNYXAoKTsKIAotICAgIFdlYkluc3BlY3Rvci5zbmlwcGV0c01vZGVsLmFk ZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlNuaXBwZXRzTW9kZWwuRXZlbnRUeXBlcy5Tbmlw cGV0QWRkZWQsIHRoaXMuX3NuaXBwZXRBZGRlZC5iaW5kKHRoaXMpKTsKKyAgICBXZWJJbnNwZWN0 b3Iuc25pcHBldHNNb2RlbC5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5TbmlwcGV0c01v ZGVsLkV2ZW50VHlwZXMuU25pcHBldEFkZGVkLCB0aGlzLl9oYW5kbGVTbmlwcGV0QWRkZWQuYmlu ZCh0aGlzKSk7CiAgICAgV2ViSW5zcGVjdG9yLnNuaXBwZXRzTW9kZWwuYWRkRXZlbnRMaXN0ZW5l cihXZWJJbnNwZWN0b3IuU25pcHBldHNNb2RlbC5FdmVudFR5cGVzLlNuaXBwZXRXaWxsQmVFdmFs dWF0ZWQsIHRoaXMuX3NuaXBwZXRXaWxsQmVFdmFsdWF0ZWQuYmluZCh0aGlzKSk7CiAgICAgV2Vi SW5zcGVjdG9yLnNuaXBwZXRzTW9kZWwuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuU25p cHBldHNNb2RlbC5FdmVudFR5cGVzLlNuaXBwZXRSZW1vdmVkLCB0aGlzLl9zbmlwcGV0UmVtb3Zl ZC5iaW5kKHRoaXMpKTsKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IFdlYkluc3BlY3Rvci5zbmlw cGV0c01vZGVsLnNuaXBwZXRzLmxlbmd0aDsgKytpKQorICAgICAgICB0aGlzLl9zbmlwcGV0QWRk ZWQoV2ViSW5zcGVjdG9yLnNuaXBwZXRzTW9kZWwuc25pcHBldHNbaV0pOwogfQogCiBXZWJJbnNw ZWN0b3IuU25pcHBldHNTY3JpcHRNYXBwaW5nLnByb3RvdHlwZSA9IHsKQEAgLTM2OCw5ICszODEs MTcgQEAgV2ViSW5zcGVjdG9yLlNuaXBwZXRzU2NyaXB0TWFwcGluZy5wcm90b3R5cGUgPSB7CiAg ICAgLyoqCiAgICAgICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuRXZlbnR9IGV2ZW50CiAgICAgICov Ci0gICAgX3NuaXBwZXRBZGRlZDogZnVuY3Rpb24oZXZlbnQpCisgICAgX2hhbmRsZVNuaXBwZXRB ZGRlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAgICAgICB2YXIgc25pcHBldCA9IC8qKiBA dHlwZSB7V2ViSW5zcGVjdG9yLlNuaXBwZXR9ICovIGV2ZW50LmRhdGE7CisgICAgICAgIHRoaXMu X3NuaXBwZXRBZGRlZChzbmlwcGV0KTsKKyAgICB9LAorCisgICAgLyoqCisgICAgICogQHBhcmFt IHtXZWJJbnNwZWN0b3IuU25pcHBldH0gc25pcHBldAorICAgICAqLworICAgIF9zbmlwcGV0QWRk ZWQ6IGZ1bmN0aW9uKHNuaXBwZXQpCisgICAgewogICAgICAgICB2YXIgdWlTb3VyY2VDb2RlSWQg PSAiIjsgLy8gRklYTUU6IHRvIGJlIGltcGxlbWVudGVkLgogICAgICAgICB2YXIgdWlTb3VyY2VD b2RlVVJMID0gIiI7IC8vIEZJWE1FOiB0byBiZSBpbXBsZW1lbnRlZC4KICAgICAgICAgdmFyIHVp U291cmNlQ29kZSA9IG5ldyBXZWJJbnNwZWN0b3IuVUlTb3VyY2VDb2RlSW1wbCh1aVNvdXJjZUNv ZGVJZCwgdWlTb3VyY2VDb2RlVVJMLCBuZXcgV2ViSW5zcGVjdG9yLlNuaXBwZXRDb250ZW50UHJv dmlkZXIoc25pcHBldCkpOwo=