82618 2012-03-29 08:20:30 -0700 CSS Shaders: Use u_texture instead of s_texture. It was updated in the spec 2012-04-25 17:25:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html P2 Normal --- 1 achicu achicu dino webkit.review.bot oldest_to_newest 591206 0 achicu 2012-03-29 08:20:30 -0700 The spec updated s_texture uniform for the element texture to u_texture. Change that in the implementation and test files. 610060 1 138876 achicu 2012-04-25 14:45:16 -0700 Created attachment 138876 Patch V1 610199 2 138876 webkit.review.bot 2012-04-25 17:25:22 -0700 Comment on attachment 138876 Patch V1 Clearing flags on attachment: 138876 Committed r115263: <http://trac.webkit.org/changeset/115263> 610200 3 webkit.review.bot 2012-04-25 17:25:32 -0700 All reviewed patches have been landed. Closing bug. 138876 2012-04-25 14:45:16 -0700 2012-04-25 17:25:21 -0700 Patch V1 bug82618.patch text/plain 5530 achicu ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3MjMwNzMyLi5hZDhiZmFjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDQt MjUgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgorCisgICAgICAgIENT UyBTaGFkZXJzOiBVc2UgdV90ZXh0dXJlIGluc3RlYWQgb2Ygc190ZXh0dXJlLiBJdCB3YXMgdXBk YXRlZCBpbiB0aGUgc3BlYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODI2MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDaGFuZ2VkIHRoZSB1bmlmb3JtIG5hbWUgcGFzc2VkIHRvIHRoZSBDU1MgU2hhZGVy cyBmcm9tIHNfdGV4dHVyZSB0byB1X3RleHR1cmUuCisgICAgICAgIGh0dHBzOi8vZHZjcy53My5v cmcvaGcvRlhURi9yYXctZmlsZS90aXAvZmlsdGVycy9pbmRleC5odG1sCisKKyAgICAgICAgKiBj c3MzL2ZpbHRlcnMvcmVzb3VyY2VzL2NvbG9yLWFkZC5mczoKKyAgICAgICAgKiBjc3MzL2ZpbHRl cnMvcmVzb3VyY2VzL2NvbG9yLW9mZnNldC1wYXJhbWV0ZXJzLmZzOgorICAgICAgICAqIGNzczMv ZmlsdGVycy9yZXNvdXJjZXMvY29sb3Itb2Zmc2V0LmZzOgorCiAyMDEyLTA0LTI1ICBTdGVwaGVu IENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmViYXNlbGluZSBj aHJvbWl1bSB0ZXN0IHJlc3VsdHMgYWZ0ZXIgYnVnIDcyNzk2IGlzIGZpeGVkCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvcmVzb3VyY2VzL2NvbG9yLWFkZC5mcyBiL0xheW91 dFRlc3RzL2NzczMvZmlsdGVycy9yZXNvdXJjZXMvY29sb3ItYWRkLmZzCmluZGV4IDE5MzVhYzku LmZjMmU4ZTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9yZXNvdXJjZXMv Y29sb3ItYWRkLmZzCisrKyBiL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9yZXNvdXJjZXMvY29s b3ItYWRkLmZzCkBAIC0xLDEwICsxLDEwIEBACiBwcmVjaXNpb24gbWVkaXVtcCBmbG9hdDsKIHZh cnlpbmcgdmVjMiB2X3RleENvb3JkOwotdW5pZm9ybSBzYW1wbGVyMkQgc190ZXh0dXJlOwordW5p Zm9ybSBzYW1wbGVyMkQgdV90ZXh0dXJlOwogdW5pZm9ybSBmbG9hdCBhZGQ7CiAKIHZvaWQgbWFp bigpCiB7CiAgICAgLy8gT2Zmc2V0IHRoZSBjb2xvciB2YWx1ZSB3aXRoICJhZGQiIG9uIGVhY2gg Y29sb3IgY2hhbm5lbC4KLSAgICBnbF9GcmFnQ29sb3IgPSB0ZXh0dXJlMkQoc190ZXh0dXJlLCB2 X3RleENvb3JkKSArIGFkZDsKKyAgICBnbF9GcmFnQ29sb3IgPSB0ZXh0dXJlMkQodV90ZXh0dXJl LCB2X3RleENvb3JkKSArIGFkZDsKIH0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvcmVzb3VyY2VzL2NvbG9yLW9mZnNldC1w YXJhbWV0ZXJzLmZzIGIvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL3Jlc291cmNlcy9jb2xvci1v ZmZzZXQtcGFyYW1ldGVycy5mcwppbmRleCA4ZWY1NjNlLi5iZWRhMzFmIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvcmVzb3VyY2VzL2NvbG9yLW9mZnNldC1wYXJhbWV0ZXJz LmZzCisrKyBiL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9yZXNvdXJjZXMvY29sb3Itb2Zmc2V0 LXBhcmFtZXRlcnMuZnMKQEAgLTEsMTAgKzEsMTAgQEAKIHByZWNpc2lvbiBtZWRpdW1wIGZsb2F0 OwogdmFyeWluZyB2ZWMyIHZfdGV4Q29vcmQ7Ci11bmlmb3JtIHNhbXBsZXIyRCBzX3RleHR1cmU7 Cit1bmlmb3JtIHNhbXBsZXIyRCB1X3RleHR1cmU7CiB1bmlmb3JtIHZlYzQgY29sb3Jfb2Zmc2V0 OwogCiB2b2lkIG1haW4oKQogewogICAgIC8vIE9mZnNldCB0aGUgY29sb3IgdmFsdWUgdXNpbmcg dGhlIHVuaWZvcm0gcGFyYW1ldGVyIHRoYXQgd2UgZ2V0IGZyb20gQ1NTLgotICAgIGdsX0ZyYWdD b2xvciA9IHRleHR1cmUyRChzX3RleHR1cmUsIHZfdGV4Q29vcmQpICsgY29sb3Jfb2Zmc2V0Owor ICAgIGdsX0ZyYWdDb2xvciA9IHRleHR1cmUyRCh1X3RleHR1cmUsIHZfdGV4Q29vcmQpICsgY29s b3Jfb2Zmc2V0OwogfQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2NzczMvZmlsdGVycy9yZXNvdXJjZXMvY29sb3Itb2Zmc2V0LmZzIGIvTGF5b3V0 VGVzdHMvY3NzMy9maWx0ZXJzL3Jlc291cmNlcy9jb2xvci1vZmZzZXQuZnMKaW5kZXggNGY1NzA0 OS4uYThkMThiMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL3Jlc291cmNl cy9jb2xvci1vZmZzZXQuZnMKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL3Jlc291cmNl cy9jb2xvci1vZmZzZXQuZnMKQEAgLTEsOCArMSw4IEBACiBwcmVjaXNpb24gbWVkaXVtcCBmbG9h dDsKIHZhcnlpbmcgdmVjMiB2X3RleENvb3JkOwotdW5pZm9ybSBzYW1wbGVyMkQgc190ZXh0dXJl OwordW5pZm9ybSBzYW1wbGVyMkQgdV90ZXh0dXJlOwogdm9pZCBtYWluKCkKIHsKICAgICAvLyBP ZmZzZXQgdGhlIGNvbG9yIHZhbHVlIHdpdGggMC4zIG9uIGVhY2ggY29sb3IgY2hhbm5lbC4KLSAg ICBnbF9GcmFnQ29sb3IgPSB0ZXh0dXJlMkQoc190ZXh0dXJlLCB2X3RleENvb3JkKSArIDAuMzsK KyAgICBnbF9GcmFnQ29sb3IgPSB0ZXh0dXJlMkQodV90ZXh0dXJlLCB2X3RleENvb3JkKSArIDAu MzsKIH0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjM2NGM0OC4u OGI3NzA1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTI1ICBBbGV4YW5k cnUgQ2hpY3VsaXRhICA8YWNoaWN1QGFkb2JlLmNvbT4KKworICAgICAgICBDU1MgU2hhZGVyczog VXNlIHVfdGV4dHVyZSBpbnN0ZWFkIG9mIHNfdGV4dHVyZS4gSXQgd2FzIHVwZGF0ZWQgaW4gdGhl IHNwZWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgy NjE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAg ICAgICBDaGFuZ2VkIHRoZSB1bmlmb3JtIG5hbWUgcGFzc2VkIHRvIHRoZSBDU1MgU2hhZGVycyBm cm9tIHNfdGV4dHVyZSB0byB1X3RleHR1cmUuCisgICAgICAgIGh0dHBzOi8vZHZjcy53My5vcmcv aGcvRlhURi9yYXctZmlsZS90aXAvZmlsdGVycy9pbmRleC5odG1sCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCBqdXN0IHVwZGF0aW5nIGV4aXN0aW5nIG9uZXMuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9maWx0ZXJzL0N1c3RvbUZpbHRlclNoYWRlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpDdXN0b21GaWx0ZXJTaGFkZXI6OmRlZmF1bHRGcmFnbWVudFNoYWRlclN0cmluZyk6Cisg ICAgICAgIChXZWJDb3JlOjpDdXN0b21GaWx0ZXJTaGFkZXI6OmluaXRpYWxpemVQYXJhbWV0ZXJM b2NhdGlvbnMpOgorCiAyMDEyLTA0LTI1ICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgQ3Jhc2ggaW4gQ2FjaGVkUmF3UmVzb3VyY2U6OmRpZEFkZENsaWVudCgp IGR1ZSB0byBtaXNzaW5nIHByb3RlY3Rvci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvQ3VzdG9tRmlsdGVyU2hhZGVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvQ3VzdG9tRmlsdGVyU2hhZGVyLmNwcApp bmRleCA4ZWY2NmNmLi41MTFjMjI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9maWx0ZXJzL0N1c3RvbUZpbHRlclNoYWRlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9DdXN0b21GaWx0ZXJTaGFkZXIuY3BwCkBA IC01OSwxMCArNTksMTAgQEAgU3RyaW5nIEN1c3RvbUZpbHRlclNoYWRlcjo6ZGVmYXVsdEZyYWdt ZW50U2hhZGVyU3RyaW5nKCkKICAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgZnJhZ21l bnRTaGFkZXJTdHJpbmcsIFNIQURFUigKICAgICAgICAgcHJlY2lzaW9uIG1lZGl1bXAgZmxvYXQ7 CiAgICAgICAgIHZhcnlpbmcgdmVjMiB2X3RleENvb3JkOwotICAgICAgICB1bmlmb3JtIHNhbXBs ZXIyRCBzX3RleHR1cmU7CisgICAgICAgIHVuaWZvcm0gc2FtcGxlcjJEIHVfdGV4dHVyZTsKICAg ICAgICAgdm9pZCBtYWluKCkKICAgICAgICAgewotICAgICAgICAgICAgZ2xfRnJhZ0NvbG9yID0g dGV4dHVyZTJEKHNfdGV4dHVyZSwgdl90ZXhDb29yZCk7CisgICAgICAgICAgICBnbF9GcmFnQ29s b3IgPSB0ZXh0dXJlMkQodV90ZXh0dXJlLCB2X3RleENvb3JkKTsKICAgICAgICAgfQogICAgICkp OwogICAgIHJldHVybiBmcmFnbWVudFNoYWRlclN0cmluZzsKQEAgLTE1Niw5ICsxNTYsOSBAQCB2 b2lkIEN1c3RvbUZpbHRlclNoYWRlcjo6aW5pdGlhbGl6ZVBhcmFtZXRlckxvY2F0aW9ucygpCiAg ICAgbV90aWxlU2l6ZUxvY2F0aW9uID0gbV9jb250ZXh0LT5nZXRVbmlmb3JtTG9jYXRpb24obV9w cm9ncmFtLCAidV90aWxlU2l6ZSIpOwogICAgIG1fbWVzaFNpemVMb2NhdGlvbiA9IG1fY29udGV4 dC0+Z2V0VW5pZm9ybUxvY2F0aW9uKG1fcHJvZ3JhbSwgInVfbWVzaFNpemUiKTsKICAgICBtX3By b2plY3Rpb25NYXRyaXhMb2NhdGlvbiA9IG1fY29udGV4dC0+Z2V0VW5pZm9ybUxvY2F0aW9uKG1f cHJvZ3JhbSwgInVfcHJvamVjdGlvbk1hdHJpeCIpOwotICAgIG1fc2FtcGxlckxvY2F0aW9uID0g bV9jb250ZXh0LT5nZXRVbmlmb3JtTG9jYXRpb24obV9wcm9ncmFtLCAic190ZXh0dXJlIik7Ci0g ICAgbV9zYW1wbGVyU2l6ZUxvY2F0aW9uID0gbV9jb250ZXh0LT5nZXRVbmlmb3JtTG9jYXRpb24o bV9wcm9ncmFtLCAic190ZXh0dXJlU2l6ZSIpOwotICAgIG1fY29udGVudFNhbXBsZXJMb2NhdGlv biA9IG1fY29udGV4dC0+Z2V0VW5pZm9ybUxvY2F0aW9uKG1fcHJvZ3JhbSwgInNfY29udGVudFRl eHR1cmUiKTsKKyAgICBtX3NhbXBsZXJMb2NhdGlvbiA9IG1fY29udGV4dC0+Z2V0VW5pZm9ybUxv Y2F0aW9uKG1fcHJvZ3JhbSwgInVfdGV4dHVyZSIpOworICAgIG1fc2FtcGxlclNpemVMb2NhdGlv biA9IG1fY29udGV4dC0+Z2V0VW5pZm9ybUxvY2F0aW9uKG1fcHJvZ3JhbSwgInVfdGV4dHVyZVNp emUiKTsKKyAgICBtX2NvbnRlbnRTYW1wbGVyTG9jYXRpb24gPSBtX2NvbnRleHQtPmdldFVuaWZv cm1Mb2NhdGlvbihtX3Byb2dyYW0sICJ1X2NvbnRlbnRUZXh0dXJlIik7CiB9CiAKIGludCBDdXN0 b21GaWx0ZXJTaGFkZXI6OnVuaWZvcm1Mb2NhdGlvbkJ5TmFtZShjb25zdCBTdHJpbmcmIG5hbWUp Cg==