82616 2012-03-29 07:37:28 -0700 Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor 2012-04-06 09:05:15 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 591178 0 caseq 2012-03-29 07:37:28 -0700 We used to make a minimal selection in Timeline overview as a side effect of window selection logic -- however, it wasn't centered on a cursor, which is irritating. Let's handle single click explicitly, creating a minimal overview centered around cursor. 591180 1 134581 caseq 2012-03-29 07:40:21 -0700 Created attachment 134581 Patch 591183 2 caseq 2012-03-29 07:44:13 -0700 Committed r112531: <http://trac.webkit.org/changeset/112531> 591243 3 caseq 2012-03-29 09:20:51 -0700 Reverted at r112538: http://trac.webkit.org/changeset/112538 (regressed window selection) 597392 4 136030 caseq 2012-04-06 08:56:35 -0700 Created attachment 136030 Patch 597395 5 caseq 2012-04-06 09:05:15 -0700 Committed r113443: <http://trac.webkit.org/changeset/113443> 134581 2012-03-29 07:40:21 -0700 2012-04-06 08:56:30 -0700 Patch bug-82616-20120329184019.patch text/plain 2676 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDc3NWU5NDhmNGQ5ODY0 NDAxM2EwZmUwMjRkZGU4YWI0ZjA1OTEwOC4uODIxMTMwYTVhOWMxNjA1YTA5NzNlZTE2YWFhMTlh ZTkyNmNlYmJhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDEyLTAzLTI5ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogb24gYSBzaW5nbGUgY2xpY2sgaW4gVGltZWxpbmUgb3ZlcnZpZXcsIG1ha2UgYSBtaW5pbWFs IHNlbGVjdGlvbiBjZW50ZXJlZCBhcm91bmQgY3Vyc29yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjYxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92 ZXJ2aWV3UGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3V2lu ZG93KTogRXhwbGljaXRseSBoYW5kbGUgc2luZ2xlIGNsaWNrIG9uIG92ZXJ2aWV3IGJ5IGNyZWF0 aW5nIGEgbWluaW1hbCB3aW5kb3cgYXJvdW5kIGN1cnNvci4KKyAgICAgICAgKFdlYkluc3BlY3Rv ci5UaW1lbGluZU92ZXJ2aWV3V2luZG93LnByb3RvdHlwZS5fcmVzaXplV2luZG93TWluaW11bSk6 CisKKzIwMTItMDMtMjkgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKwog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBldmVudCBkZXRhaWxzIHBvcG92ZXIgaW4gVGltZWxpbmUg cGFuZWwgZGlzcGxheXMgaW52YWxpZCB0aW1lIG9mZnNldAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI2MTEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFuZS5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVPdmVydmlld1BhbmUuanMKaW5k ZXggNGZjMzI4YzViNWFhZWUyMjVkNGQ2NDg4YjFhNjkwNzFmYWY4YTU5Yy4uY2Y0Yzk4MWI2ZDJk ZDgwYjFiOTE4ZWE0ZDJkNmY4ODE2ZWJmYzUzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFuZS5qcworKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lT3ZlcnZpZXdQYW5lLmpzCkBAIC0z NjgsNiArMzY4LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXdXaW5kb3cgPSBmdW5j dGlvbihwYXJlbnRFbGVtZW50KQogICAgIHRoaXMuX3BhcmVudEVsZW1lbnQuYWRkRXZlbnRMaXN0 ZW5lcigibW91c2Vkb3duIiwgdGhpcy5fZHJhZ1dpbmRvdy5iaW5kKHRoaXMpLCB0cnVlKTsKICAg ICB0aGlzLl9wYXJlbnRFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNld2hlZWwiLCB0aGlz LnNjcm9sbFdpbmRvdy5iaW5kKHRoaXMpLCB0cnVlKTsKICAgICB0aGlzLl9wYXJlbnRFbGVtZW50 LmFkZEV2ZW50TGlzdGVuZXIoImRibGNsaWNrIiwgdGhpcy5fcmVzaXplV2luZG93TWF4aW11bS5i aW5kKHRoaXMpLCB0cnVlKTsKKyAgICB0aGlzLl9wYXJlbnRFbGVtZW50LmFkZEV2ZW50TGlzdGVu ZXIoImNsaWNrIiwgdGhpcy5fcmVzaXplV2luZG93TWluaW11bS5iaW5kKHRoaXMpLCB0cnVlKTsK IAogICAgIHRoaXMuX292ZXJ2aWV3V2luZG93RWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoImRpdiIpOwogICAgIHRoaXMuX292ZXJ2aWV3V2luZG93RWxlbWVudC5jbGFzc05hbWUgPSAi dGltZWxpbmUtb3ZlcnZpZXctd2luZG93IjsKQEAgLTUxMSw2ICs1MTIsMTUgQEAgV2ViSW5zcGVj dG9yLlRpbWVsaW5lT3ZlcnZpZXdXaW5kb3cucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9z ZXRXaW5kb3dQb3NpdGlvbigwLCB0aGlzLl9wYXJlbnRFbGVtZW50LmNsaWVudFdpZHRoKTsKICAg ICB9LAogCisgICAgX3Jlc2l6ZVdpbmRvd01pbmltdW06IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsK KyAgICAgICAgV2ViSW5zcGVjdG9yLmVsZW1lbnREcmFnRW5kKGV2ZW50KTsKKyAgICAgICAgdmFy IG1pZGRsZSA9IGV2ZW50LnBhZ2VYIC0gdGhpcy5fcGFyZW50RWxlbWVudC5vZmZzZXRMZWZ0Owor ICAgICAgICB2YXIgc3RhcnQgPSBNYXRoLm1heChtaWRkbGUgLSBXZWJJbnNwZWN0b3IuVGltZWxp bmVPdmVydmlld1BhbmUuTWluU2VsZWN0YWJsZVNpemUgLyAyLCAwKTsKKyAgICAgICAgdmFyIGVu ZCA9IE1hdGgubWluKG1pZGRsZSArIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZS5N aW5TZWxlY3RhYmxlU2l6ZSAvIDIsIHRoaXMuX3BhcmVudEVsZW1lbnQuY2xpZW50V2lkdGgpOwor ICAgICAgICB0aGlzLl9zZXRXaW5kb3dQb3NpdGlvbihzdGFydCwgZW5kKTsKKyAgICB9LAorCiAg ICAgX3NldFdpbmRvd1Bvc2l0aW9uOiBmdW5jdGlvbihzdGFydCwgZW5kKQogICAgIHsKICAgICAg ICAgdmFyIGNsaWVudFdpZHRoID0gdGhpcy5fcGFyZW50RWxlbWVudC5jbGllbnRXaWR0aDsK 136030 2012-04-06 08:56:35 -0700 2012-04-06 08:57:34 -0700 Patch bug-82616-20120406195634.patch text/plain 2387 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2JlNjkyNTcyN2VmNzM2 NDA4OTg5NDI0MjIzMWQ5ZmFiNTNlZmRhYy4uYzgxZjJmMDUzZmQxNjAyNmMxMjY1YmU0MTliM2Ez MDAzMWMzZDBhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEyLTA0LTA2ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogb24gYSBzaW5nbGUgY2xpY2sgaW4gVGltZWxpbmUgb3ZlcnZpZXcsIG1ha2UgYSBtaW5pbWFs IHNlbGVjdGlvbiBjZW50ZXJlZCBhcm91bmQgY3Vyc29yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjYxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gY2VudGVyIG1pbmltYWwgc2VsZWN0aW9uIG9uIG1v dXNlIGN1cnNvciBpZiB0aGUgbW91c2UgaGFzbid0IG1vdmVkIChpLmUuIHdlIGhhZCBhIGNsaWNr LCBub3QgZHJhZykKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVPdmVy dmlld1BhbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlld1dpbmRv dy5wcm90b3R5cGUuX2VuZFdpbmRvd1NlbGVjdG9yRHJhZ2dpbmcpOgorCisyMDEyLTA0LTA2ICBB bmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogZGlzcGxheSBmcmFtZSBkZXRhaWxzIGluIHBvcG92ZXIgb24gZnJhbWUgc3RyaXAgaW4g VGltZWxpbmUgcGFuZWwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTgzMzY1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvVGltZWxpbmVPdmVydmlld1BhbmUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1RpbWVsaW5lT3ZlcnZpZXdQYW5lLmpzCmluZGV4IDk1MGM0Y2QzNzAzZGU3ZmEx NzgyMjYzNThjOTE1YjM1Y2EzZDczNjUuLjhjNmFiNDRiOGQ4YzM3NTU5YTc0MjgzOWU4N2YwNTlm ZGJhY2NlOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv VGltZWxpbmVPdmVydmlld1BhbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFuZS5qcwpAQCAtNDg3LDcgKzQ4NywxMSBAQCBXZWJJ bnNwZWN0b3IuVGltZWxpbmVPdmVydmlld1dpbmRvdy5wcm90b3R5cGUgPSB7CiAgICAgICAgIFdl Ykluc3BlY3Rvci5lbGVtZW50RHJhZ0VuZChldmVudCk7CiAgICAgICAgIHZhciB3aW5kb3cgPSB0 aGlzLl9vdmVydmlld1dpbmRvd1NlbGVjdG9yLl9jbG9zZShldmVudC5wYWdlWCAtIHRoaXMuX3Bh cmVudEVsZW1lbnQub2Zmc2V0TGVmdCk7CiAgICAgICAgIGRlbGV0ZSB0aGlzLl9vdmVydmlld1dp bmRvd1NlbGVjdG9yOwotICAgICAgICBpZiAod2luZG93LmVuZCAtIHdpbmRvdy5zdGFydCA8IFdl Ykluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZS5NaW5TZWxlY3RhYmxlU2l6ZSkgeworICAg ICAgICBpZiAod2luZG93LmVuZCA9PT0gd2luZG93LnN0YXJ0KSB7IC8vIENsaWNrLCBub3QgZHJh Zy5cCisgICAgICAgICAgICB2YXIgbWlkZGxlID0gd2luZG93LmVuZDsKKyAgICAgICAgICAgIHdp bmRvdy5zdGFydCA9IE1hdGgubWF4KDAsIG1pZGRsZSAtIFdlYkluc3BlY3Rvci5UaW1lbGluZU92 ZXJ2aWV3UGFuZS5NaW5TZWxlY3RhYmxlU2l6ZSAvIDIpOworICAgICAgICAgICAgd2luZG93LmVu ZCA9IE1hdGgubWluKHRoaXMuX3BhcmVudEVsZW1lbnQuY2xpZW50V2lkdGgsIG1pZGRsZSArIFdl Ykluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZS5NaW5TZWxlY3RhYmxlU2l6ZSAvIDIpOwor ICAgICAgICB9IGVsc2UgaWYgKHdpbmRvdy5lbmQgLSB3aW5kb3cuc3RhcnQgPCBXZWJJbnNwZWN0 b3IuVGltZWxpbmVPdmVydmlld1BhbmUuTWluU2VsZWN0YWJsZVNpemUpIHsKICAgICAgICAgICAg IGlmICh0aGlzLl9wYXJlbnRFbGVtZW50LmNsaWVudFdpZHRoIC0gd2luZG93LmVuZCA+IFdlYklu c3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZS5NaW5TZWxlY3RhYmxlU2l6ZSkKICAgICAgICAg ICAgICAgICB3aW5kb3cuZW5kID0gd2luZG93LnN0YXJ0ICsgV2ViSW5zcGVjdG9yLlRpbWVsaW5l T3ZlcnZpZXdQYW5lLk1pblNlbGVjdGFibGVTaXplOwogICAgICAgICAgICAgZWxzZQo=