82608 2012-03-29 06:21:59 -0700 Chromium: DRT --no-timeout option doesn't work 2012-03-29 17:58:26 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy tkent webkit.review.bot yurys oldest_to_newest 591110 0 loislo 2012-03-29 06:21:59 -0700 %subj% 591112 1 134562 loislo 2012-03-29 06:24:51 -0700 Created attachment 134562 Patch 591120 2 134562 yurys 2012-03-29 06:34:06 -0700 Comment on attachment 134562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134562&action=review > Tools/ChangeLog:5 > + Please provide some description. > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:251 > + shell.initialize(); Why initialize is called after all the setters above? 591137 3 134568 loislo 2012-03-29 06:51:44 -0700 Created attachment 134568 Patch 591156 4 134573 loislo 2012-03-29 07:12:21 -0700 Created attachment 134573 Patch 591169 5 134579 loislo 2012-03-29 07:27:47 -0700 Created attachment 134579 Patch 591362 6 134579 loislo 2012-03-29 11:28:06 -0700 Comment on attachment 134579 Patch Clearing flags on attachment: 134579 Committed r112552: <http://trac.webkit.org/changeset/112552> 591363 7 loislo 2012-03-29 11:28:15 -0700 All reviewed patches have been landed. Closing bug. 134562 2012-03-29 06:24:51 -0700 2012-03-29 06:51:35 -0700 Patch bug-82608-20120329172449.patch text/plain 1553 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNTI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDU5ZGVjYTg5NmRkODc1ZDBhYjViMzBkN2FiZTcwODE4 MjMwNDY0Zi4uZmUzMzY1MmJkMzU0YjE4MmU3M2NkZDFjOWE0Y2JjMWQwMmYyODM0ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTAzLTI5ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBjaHJvbWl1bTogRFJUIC0tbm8tdGltZW91dCBvcHRp b24gZG9lc24ndCB3b3JrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODI2MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAg ICAgICAgKG1haW4pOgorCiAyMDEyLTAzLTI5ICBWaW5lZXQgQ2hhdWRoYXJ5ICA8cmdmNzQ4QG1v dG9yb2xhLmNvbT4KIAogICAgICAgICBSZW1vdmUgY3VzdG9tIGJpbmRpbmdzIGZvcm0gSW50ZXJu YWxzLmlkbCBvZiBhdHRyaWJ1dGUgdHlwZSBBcnJheS4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCA0OTYzYzc5ZDRhNTBkNDJjMDQz OGM4Yzg1YzAyMWU4MTBiODg0MzM3Li40MDZmNjcxOTY0MmNlNGE1Y2E0MTM3MTkwMWRmY2IxNzMw YzhhMGU1IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVu ZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRHVtcFJlbmRl clRyZWUuY3BwCkBAIC0yNDgsMTEgKzI0OCwxMSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciog YXJndltdKQogICAgICAgICBzaGVsbC5zZXRKYXZhU2NyaXB0RmxhZ3MoamF2YVNjcmlwdEZsYWdz KTsKICAgICAgICAgc2hlbGwuc2V0U3RyZXNzT3B0KHN0cmVzc09wdCk7CiAgICAgICAgIHNoZWxs LnNldFN0cmVzc0Rlb3B0KHN0cmVzc0Rlb3B0KTsKKyAgICAgICAgc2hlbGwuaW5pdGlhbGl6ZSgp OwogICAgICAgICBpZiAobm9UaW1lb3V0KSB7CiAgICAgICAgICAgICAvLyAweDIwMDAwMDAwbXMg aXMgYmlnIGVub3VnaCBmb3IgdGhlIHB1cnBvc2UgdG8gYXZvaWQgdGltZW91dCBpbiBkZWJ1Z2dp bmcuCiAgICAgICAgICAgICBzaGVsbC5zZXRMYXlvdXRUZXN0VGltZW91dCgweDIwMDAwMDAwKTsK ICAgICAgICAgfQotICAgICAgICBzaGVsbC5pbml0aWFsaXplKCk7CiAgICAgICAgIGlmIChzZXJ2 ZXJNb2RlICYmICF0ZXN0cy5zaXplKCkpIHsKICNpZiBPUyhBTkRST0lEKQogICAgICAgICAgICAg Ly8gU2VuZCBhIHNpZ25hbCB0byBob3N0IHRvIGluZGljYXRlIERSVCBpcyByZWFkeSB0byBwcm9j ZXNzIGNvbW1hbmRzLgo= 134568 2012-03-29 06:51:44 -0700 2012-03-29 07:12:11 -0700 Patch bug-82608-20120329175142.patch text/plain 1728 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNTI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDU5ZGVjYTg5NmRkODc1ZDBhYjViMzBkN2FiZTcwODE4 MjMwNDY0Zi4uM2IxZjU3YWUxNGViM2UzZjI2ZDMzZDgwYzcwMmIzZThjNzhjOGQwMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTAzLTI5ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBjaHJvbWl1bTogRFJUIC0tbm8tdGltZW91dCBvcHRp b24gZG9lc24ndCB3b3JrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODI2MDgKKworICAgICAgICBJbml0aWFsIHZhbHVlIGZvciBtX3RpbWVvdXQgd2Fz IGluaXRpYWxpemVkIGluIGNvbnN0cnVjdG9yIGFuZCB3YXMgb3ZlcndyaXR0ZW4gaW4gRFJUOjpt YWluLgorICAgICAgICBUaGlzIHdhcyBicm9rZW4gYnkgcjExMjQ4MSBhbmQgdGhlIHNlcXVlbmNl IGJlY2FtZSBvcHBvc2l0ZS4gCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5jcHA6 CisgICAgICAgIChtYWluKToKKwogMjAxMi0wMy0yOSAgVmluZWV0IENoYXVkaGFyeSAgPHJnZjc0 OEBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGN1c3RvbSBiaW5kaW5ncyBmb3JtIElu dGVybmFscy5pZGwgb2YgYXR0cmlidXRlIHR5cGUgQXJyYXkuCmRpZmYgLS1naXQgYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggNDk2M2M3OWQ0YTUwZDQy YzA0MzhjOGM4NWMwMjFlODEwYjg4NDMzNy4uNDA2ZjY3MTk2NDJjZTRhNWNhNDEzNzE5MDFkZmNi MTczMGM4YTBlNSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRHVt cFJlbmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0R1bXBS ZW5kZXJUcmVlLmNwcApAQCAtMjQ4LDExICsyNDgsMTEgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNo YXIqIGFyZ3ZbXSkKICAgICAgICAgc2hlbGwuc2V0SmF2YVNjcmlwdEZsYWdzKGphdmFTY3JpcHRG bGFncyk7CiAgICAgICAgIHNoZWxsLnNldFN0cmVzc09wdChzdHJlc3NPcHQpOwogICAgICAgICBz aGVsbC5zZXRTdHJlc3NEZW9wdChzdHJlc3NEZW9wdCk7CisgICAgICAgIHNoZWxsLmluaXRpYWxp emUoKTsKICAgICAgICAgaWYgKG5vVGltZW91dCkgewogICAgICAgICAgICAgLy8gMHgyMDAwMDAw MG1zIGlzIGJpZyBlbm91Z2ggZm9yIHRoZSBwdXJwb3NlIHRvIGF2b2lkIHRpbWVvdXQgaW4gZGVi dWdnaW5nLgogICAgICAgICAgICAgc2hlbGwuc2V0TGF5b3V0VGVzdFRpbWVvdXQoMHgyMDAwMDAw MCk7CiAgICAgICAgIH0KLSAgICAgICAgc2hlbGwuaW5pdGlhbGl6ZSgpOwogICAgICAgICBpZiAo c2VydmVyTW9kZSAmJiAhdGVzdHMuc2l6ZSgpKSB7CiAjaWYgT1MoQU5EUk9JRCkKICAgICAgICAg ICAgIC8vIFNlbmQgYSBzaWduYWwgdG8gaG9zdCB0byBpbmRpY2F0ZSBEUlQgaXMgcmVhZHkgdG8g cHJvY2VzcyBjb21tYW5kcy4K 134573 2012-03-29 07:12:21 -0700 2012-03-29 07:27:39 -0700 Patch bug-82608-20120329181218.patch text/plain 1727 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNTI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDU5ZGVjYTg5NmRkODc1ZDBhYjViMzBkN2FiZTcwODE4 MjMwNDY0Zi4uNzg5Nzg5ZmViZTQ0Y2RiOTYwZjQ1ODAwOGU1NGRhOGU3ZWEwOTE3YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTAzLTI5ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBjaHJvbWl1bTogRFJUIC0tbm8tdGltZW91dCBvcHRp b24gZG9lc24ndCB3b3JrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODI2MDgKKworICAgICAgICBJbml0aWFsIHZhbHVlIGZvciBtX3RpbWVvdXQgd2Fz IGluaXRpYWxpemVkIGluIGNvbnN0cnVjdG9yIGFuZCB3YXMgb3ZlcndyaXR0ZW4gaW4gRFJUOjpt YWluLgorICAgICAgICBUaGlzIHdhcyBicm9rZW4gYnkgcjExMjM1NCBhbmQgdGhlIHNlcXVlbmNl IGJlY2FtZSBvcHBvc2l0ZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcDoK KyAgICAgICAgKG1haW4pOgorCiAyMDEyLTAzLTI5ICBWaW5lZXQgQ2hhdWRoYXJ5ICA8cmdmNzQ4 QG1vdG9yb2xhLmNvbT4KIAogICAgICAgICBSZW1vdmUgY3VzdG9tIGJpbmRpbmdzIGZvcm0gSW50 ZXJuYWxzLmlkbCBvZiBhdHRyaWJ1dGUgdHlwZSBBcnJheS4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCA0OTYzYzc5ZDRhNTBkNDJj MDQzOGM4Yzg1YzAyMWU4MTBiODg0MzM3Li40MDZmNjcxOTY0MmNlNGE1Y2E0MTM3MTkwMWRmY2Ix NzMwYzhhMGU1IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1w UmVuZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRHVtcFJl bmRlclRyZWUuY3BwCkBAIC0yNDgsMTEgKzI0OCwxMSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hh ciogYXJndltdKQogICAgICAgICBzaGVsbC5zZXRKYXZhU2NyaXB0RmxhZ3MoamF2YVNjcmlwdEZs YWdzKTsKICAgICAgICAgc2hlbGwuc2V0U3RyZXNzT3B0KHN0cmVzc09wdCk7CiAgICAgICAgIHNo ZWxsLnNldFN0cmVzc0Rlb3B0KHN0cmVzc0Rlb3B0KTsKKyAgICAgICAgc2hlbGwuaW5pdGlhbGl6 ZSgpOwogICAgICAgICBpZiAobm9UaW1lb3V0KSB7CiAgICAgICAgICAgICAvLyAweDIwMDAwMDAw bXMgaXMgYmlnIGVub3VnaCBmb3IgdGhlIHB1cnBvc2UgdG8gYXZvaWQgdGltZW91dCBpbiBkZWJ1 Z2dpbmcuCiAgICAgICAgICAgICBzaGVsbC5zZXRMYXlvdXRUZXN0VGltZW91dCgweDIwMDAwMDAw KTsKICAgICAgICAgfQotICAgICAgICBzaGVsbC5pbml0aWFsaXplKCk7CiAgICAgICAgIGlmIChz ZXJ2ZXJNb2RlICYmICF0ZXN0cy5zaXplKCkpIHsKICNpZiBPUyhBTkRST0lEKQogICAgICAgICAg ICAgLy8gU2VuZCBhIHNpZ25hbCB0byBob3N0IHRvIGluZGljYXRlIERSVCBpcyByZWFkeSB0byBw cm9jZXNzIGNvbW1hbmRzLgo= 134579 2012-03-29 07:27:47 -0700 2012-03-29 11:28:06 -0700 Patch bug-82608-20120329182745.patch text/plain 2071 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNTI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDU5ZGVjYTg5NmRkODc1ZDBhYjViMzBkN2FiZTcwODE4 MjMwNDY0Zi4uMWIyMThjYWI1ZTc5MThkMDA4NDI3MDA0MDg5MTBhYzQ3YjA2YzUzYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTAzLTI5ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBjaHJvbWl1bTogRFJUIC0tbm8tdGltZW91dCBvcHRp b24gZG9lc24ndCB3b3JrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODI2MDgKKworICAgICAgICBJbml0aWFsIHZhbHVlIGZvciBtX3RpbWVvdXQgd2Fz IGluaXRpYWxpemVkIGluIGNvbnN0cnVjdG9yIGFuZCB3YXMgb3ZlcndyaXR0ZW4gaW4gRFJUOjpt YWluLgorICAgICAgICBUaGlzIHdhcyBicm9rZW4gYnkgcjExMjM1NCBhbmQgdGhlIHNlcXVlbmNl IGJlY2FtZSBvcHBvc2l0ZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHA6CisgICAg ICAgIChUZXN0U2hlbGw6OlRlc3RTaGVsbCk6CisgICAgICAgIChUZXN0U2hlbGw6OmluaXRpYWxp emUpOgorCiAyMDEyLTAzLTI5ICBWaW5lZXQgQ2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xhLmNv bT4KIAogICAgICAgICBSZW1vdmUgY3VzdG9tIGJpbmRpbmdzIGZvcm0gSW50ZXJuYWxzLmlkbCBv ZiBhdHRyaWJ1dGUgdHlwZSBBcnJheS4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9U ZXN0U2hlbGwuY3BwCmluZGV4IDM3MDEyM2JiN2ZlMjA4MzQ3NzczOTAwZjA5NmZhNDlkZDhkN2Q3 NzAuLmY2NTM5MjMwZTZiNjFhMTFmMjMxMzc1YTVjZGYxODFlZmYzZjFkNWYgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKKysrIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcApAQCAtMTMxLDYgKzEzMSwxMiBA QCBUZXN0U2hlbGw6OlRlc3RTaGVsbCgpCiAgICAgV2ViUnVudGltZUZlYXR1cmVzOjplbmFibGVT aGFkb3dET00odHJ1ZSk7CiAgICAgV2ViUnVudGltZUZlYXR1cmVzOjplbmFibGVTdHlsZVNjb3Bl ZCh0cnVlKTsKICAgICBXZWJSdW50aW1lRmVhdHVyZXM6OmVuYWJsZVNjcmlwdGVkU3BlZWNoKHRy dWUpOworCisgICAgLy8gMzAgc2Vjb25kIGlzIHRoZSBzYW1lIGFzIHRoZSB2YWx1ZSBpbiBNYWMg RFJULgorICAgIC8vIElmIHdlIHVzZSBhIHZhbHVlIHNtYWxsZXIgdGhhbiB0aGUgdGltZW91dCB2 YWx1ZSBvZgorICAgIC8vIChuZXctKXJ1bi13ZWJraXQtdGVzdHMsIChuZXctKXJ1bi13ZWJraXQt dGVzdHMgbWlzdW5kZXJzdGFuZHMgdGhhdCBhCisgICAgLy8gdGltZWQtb3V0IERSVCBwcm9jZXNz IHdhcyBjcmFzaGVkLgorICAgIG1fdGltZW91dCA9IDMwICogMTAwMDsKIH0KIAogdm9pZCBUZXN0 U2hlbGw6OmluaXRpYWxpemUoKQpAQCAtMTU0LDEyICsxNjAsNiBAQCB2b2lkIFRlc3RTaGVsbDo6 aW5pdGlhbGl6ZSgpCiAgICAgfSBlbHNlCiAgICAgICAgIFdlYkNvbXBvc2l0b3I6OmluaXRpYWxp emUoMCk7CiAKLSAgICAvLyAzMCBzZWNvbmQgaXMgdGhlIHNhbWUgYXMgdGhlIHZhbHVlIGluIE1h YyBEUlQuCi0gICAgLy8gSWYgd2UgdXNlIGEgdmFsdWUgc21hbGxlciB0aGFuIHRoZSB0aW1lb3V0 IHZhbHVlIG9mCi0gICAgLy8gKG5ldy0pcnVuLXdlYmtpdC10ZXN0cywgKG5ldy0pcnVuLXdlYmtp dC10ZXN0cyBtaXN1bmRlcnN0YW5kcyB0aGF0IGEKLSAgICAvLyB0aW1lZC1vdXQgRFJUIHByb2Nl c3Mgd2FzIGNyYXNoZWQuCi0gICAgbV90aW1lb3V0ID0gMzAgKiAxMDAwOwotCiAgICAgY3JlYXRl TWFpbldpbmRvdygpOwogfQogCg==