8260 2006-04-07 23:31:42 -0700 REGRESSION: Assertion failure: ![_private->iconsToSaveWithURLs containsObject:iconURLString] in WebIconDatabase.m:695-[WebIconDatabase(WebInternal) _retainIconForIconURLString:] 2006-04-08 09:45:54 -0700 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 mitz sullivan sullivan oldest_to_newest 38776 0 mitz 2006-04-07 23:31:42 -0700 I hit this assert when I go to a URL that has no favorite icon and then follow a link to another (icon-less) page on the same domain: ASSERTION FAILED: ![_private->iconsToSaveWithURLs containsObject:iconURLString] (WebKit/Misc/WebIconDatabase.m:695 -[WebIconDatabase(WebInternal) _retainIconForIconURLString:]) 38780 1 7578 sullivan 2006-04-08 08:29:36 -0700 Created attachment 7578 Patch to quiet assertion I added a too-general assertion yesterday; this patch makes it less general. 7578 2006-04-08 08:29:36 -0700 2006-04-08 09:37:06 -0700 Patch to quiet assertion diffs.txt text/plain 1748 sullivan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzM4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMDQt MDggIEpvaG4gU3VsbGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwktIGZpeGVkIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFy d2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI2MAorCVJFR1JFU1NJT046IEFzc2VydGlvbiBmYWls dXJlOiAhW19wcml2YXRlLT5pY29uc1RvU2F2ZVdpdGhVUkxzIGNvbnRhaW5zT2JqZWN0Omljb25V UkxTdHJpbmddIAorCWluIFdlYkljb25EYXRhYmFzZS5tOjY5NS1bV2ViSWNvbkRhdGFiYXNlKFdl YkludGVybmFsKSBfcmV0YWluSWNvbkZvckljb25VUkxTdHJpbmc6XQorCisgICAgICAgICogTWlz Yy9XZWJJY29uRGF0YWJhc2UubToKKyAgICAgICAgKC1bV2ViSWNvbkRhdGFiYXNlIF9yZXRhaW5J Y29uRm9ySWNvblVSTFN0cmluZzpdKToKKwlUaGlzIG5ldyBhc3NlcnRpb24gd2FzIG9uZSBibG9j ayB0b28gaGlnaDsgbW92ZWQgaXQgaW4uCisKIDIwMDYtMDQtMDcgIERhdmlkIEh5YXR0ICA8aHlh dHRAYXBwbGUuY29tPgogCiAgICAgICAgIEEgZml4IHRoYXQgbWFrZXMgY29hbGVzY2VkIHVwZGF0 ZXMgd29yayBtdWNoIGJldHRlciAoYW5kIG1ha2VzIG91cgpJbmRleDogTWlzYy9XZWJJY29uRGF0 YWJhc2UubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBNaXNjL1dlYkljb25EYXRhYmFzZS5tCShyZXZpc2lvbiAx MzczOCkKKysrIE1pc2MvV2ViSWNvbkRhdGFiYXNlLm0JKHdvcmtpbmcgY29weSkKQEAgLTY5Miwx MSArNjkyLDExIEBACiAgICAgQ0ZEaWN0aW9uYXJ5U2V0VmFsdWUoX3ByaXZhdGUtPmljb25VUkxU b0V4dHJhUmV0YWluQ291bnQsIGljb25VUkxTdHJpbmcsICh2b2lkICopbmV3UmV0YWluQ291bnQp OwogCiAgICAgaWYgKG5ld1JldGFpbkNvdW50ID09IDEpIHsKLSAgICAgICAgQVNTRVJUKCFbX3By aXZhdGUtPmljb25zVG9TYXZlV2l0aFVSTHMgY29udGFpbnNPYmplY3Q6aWNvblVSTFN0cmluZ10p OwogCiAgICAgICAgIC8vIEVpdGhlciB3ZSBrbm93IG5vdGhpbmcgYWJvdXQgdGhpcyBpY29uIGFu ZCBuZWVkIHRvIHNhdmUgaXQgdG8gZGlzaywgb3Igd2Ugd2VyZSBwbGFubmluZyB0byByZW1vdmUg aXQKICAgICAgICAgLy8gZnJvbSBkaXNrIChhcyBzZXQgdXAgaW4gX2ZvcmdldEljb25Gb3JJY29u VVJMU3RyaW5nOikgYW5kIHNob3VsZCBzdG9wIHRoYXQgcHJvY2Vzcy4KICAgICAgICAgaWYgKFtf cHJpdmF0ZS0+aWNvbnNPbkRpc2tXaXRoVVJMcyBjb250YWluc09iamVjdDppY29uVVJMU3RyaW5n XSkgeworICAgICAgICAgICAgQVNTRVJUKCFbX3ByaXZhdGUtPmljb25zVG9TYXZlV2l0aFVSTHMg Y29udGFpbnNPYmplY3Q6aWNvblVSTFN0cmluZ10pOwogICAgICAgICAgICAgW19wcml2YXRlLT5p Y29uc1RvRXJhc2VXaXRoVVJMcyByZW1vdmVPYmplY3Q6aWNvblVSTFN0cmluZ107CiAgICAgICAg IH0gZWxzZSB7CiAgICAgICAgICAgICBBU1NFUlQoIVtfcHJpdmF0ZS0+aWNvbnNUb0VyYXNlV2l0 aFVSTHMgY29udGFpbnNPYmplY3Q6aWNvblVSTFN0cmluZ10pOwo=