82597 2012-03-29 04:30:13 -0700 [BlackBerry] Add Internal test support for blackberry porting. 2012-03-29 06:56:15 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei webkit-unassigned mxie rakuco rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 591033 0 charles.wei 2012-03-29 04:30:13 -0700 Need to add the internal testing IDLs for blackberry porting. 591035 1 134546 charles.wei 2012-03-29 04:35:44 -0700 Created attachment 134546 Patch that enables Internal testing support for BlackBerry 591036 2 134546 rwlbuis 2012-03-29 04:39:17 -0700 Comment on attachment 134546 Patch that enables Internal testing support for BlackBerry View in context: https://bugs.webkit.org/attachment.cgi?id=134546&action=review > Source/WebCore/ChangeLog:8 > + No new tests, just the build system ehancement for BlackBerry porting. Typo ehancement :) > Source/WebCore/UseJSC.cmake:22 > +ENDIF () Is there anything in WebKit/blackberry cmake file that involves internal test support? 591047 3 134546 charles.wei 2012-03-29 04:55:21 -0700 Comment on attachment 134546 Patch that enables Internal testing support for BlackBerry View in context: https://bugs.webkit.org/attachment.cgi?id=134546&action=review >> Source/WebCore/ChangeLog:8 >> + No new tests, just the build system ehancement for BlackBerry porting. > > Typo ehancement :) Thanks, will fix it with next patch. >> Source/WebCore/UseJSC.cmake:22 >> +ENDIF () > > Is there anything in WebKit/blackberry cmake file that involves internal test support? I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ? 591050 4 134550 charles.wei 2012-03-29 04:57:57 -0700 Created attachment 134550 Patch V2 that fixes some typo in last patch. 591057 5 134550 rwlbuis 2012-03-29 05:05:53 -0700 Comment on attachment 134550 Patch V2 that fixes some typo in last patch. Looks good. 591066 6 rwlbuis 2012-03-29 05:07:51 -0700 (In reply to comment #3) > > Is there anything in WebKit/blackberry cmake file that involves internal test support? > > I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ? I just thought we had some lines in our WebKit specific CMakelists.txt for internal testing API, but was not sure. I can check later once I am in the office. Cheers, Rob. 591068 7 charles.wei 2012-03-29 05:11:22 -0700 (In reply to comment #6) > (In reply to comment #3) > > > Is there anything in WebKit/blackberry cmake file that involves internal test support? > > > > I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ? > > I just thought we had some lines in our WebKit specific CMakelists.txt for internal testing API, but was not sure. I can check later once I am in the office. > Cheers, > > Rob. Thanks, Rob. I didn't find any related cmake change in WebKit/blackberry, but we can have another patch for that if you do find any. 591090 8 134550 webkit.review.bot 2012-03-29 05:45:54 -0700 Comment on attachment 134550 Patch V2 that fixes some typo in last patch. Clearing flags on attachment: 134550 Committed r112525: <http://trac.webkit.org/changeset/112525> 591091 9 webkit.review.bot 2012-03-29 05:46:00 -0700 All reviewed patches have been landed. Closing bug. 591144 10 rwlbuis 2012-03-29 06:56:15 -0700 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #3) > > > > Is there anything in WebKit/blackberry cmake file that involves internal test support? > > > > > > I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ? > > > > I just thought we had some lines in our WebKit specific CMakelists.txt for internal testing API, but was not sure. I can check later once I am in the office. > > Cheers, > > > > Rob. > > Thanks, Rob. I didn't find any related cmake change in WebKit/blackberry, but we can have another patch for that if you do find any. My intuition was good :) We missed this in Source/WebKit/PlatformBlackBerry.cmake: "${WEBCORE_DIR}/testing/js" However we can do a bug fix to bring the whole file up to date later, I am sure there are more changes we need to sync. 134546 2012-03-29 04:35:44 -0700 2012-03-29 04:57:57 -0700 Patch that enables Internal testing support for BlackBerry 0001-BlackBerry-Add-Internal-test-support-for-blackberry-.patch text/plain 1771 charles.wei RnJvbSAwOTczNGE3Mjg5MjZiZTc2MjUyYWFmMjQxN2VkOTkxMmFlZmRlMWYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBUaHUsIDI5IE1hciAyMDEyIDE5OjM4OjU4ICswODAwClN1YmplY3Q6IFtQ QVRDSF0gW0JsYWNrQmVycnldIEFkZCBJbnRlcm5hbCB0ZXN0IHN1cHBvcnQgZm9yIGJsYWNrYmVy cnkKIHBvcnRpbmcuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjU5 NwoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpObyBuZXcgdGVzdHMsIGp1c3QgdGhlIGJ1 aWxkIHN5c3RlbSBlaGFuY2VtZW50IGZvciBCbGFja0JlcnJ5IHBvcnRpbmcuCgoqIFVzZUpTQy5j bWFrZToKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgfCAgIDExICsrKysrKysrKysr CiBTb3VyY2UvV2ViQ29yZS9Vc2VKU0MuY21ha2UgfCAgIDEwICsrKysrKysrKysKIDIgZmlsZXMg Y2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTRkN2YyZi4uZmMwY2RhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTI5 ICBDaGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAg ICBbQmxhY2tCZXJyeV0gQWRkIEludGVybmFsIHRlc3Qgc3VwcG9ydCBmb3IgYmxhY2tiZXJyeSBw b3J0aW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODI1OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBuZXcgdGVzdHMsIGp1c3QgdGhlIGJ1aWxkIHN5c3RlbSBlaGFuY2VtZW50IGZvciBCbGFja0Jl cnJ5IHBvcnRpbmcuCisKKyAgICAgICAgKiBVc2VKU0MuY21ha2U6CisKIDIwMTItMDMtMjggIEFu dHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFNwbGl0IFdlYktpdENT U0tleWZyYW1lUnVsZSBpbnRvIGludGVybmFsIGFuZCBDU1NPTSB0eXBlcyAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL1VzZUpTQy5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1VzZUpTQy5jbWFr ZQppbmRleCAwNjQ5N2E0Li4wNzRjNzRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Vc2VK U0MuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvVXNlSlNDLmNtYWtlCkBAIC0xMSw2ICsxMSwx NiBAQCBMSVNUKEFQUEVORCBXZWJDb3JlX0lETF9JTkNMVURFUwogICAgIGJpbmRpbmdzL2pzCiAp CiAKK0lGIChQT1JUIE1BVENIRVMgIkJsYWNrQmVycnkiKQorICAgIExJU1QoQVBQRU5EIFdlYkNv cmVfSURMX0lOQ0xVREVTCisgICAgICAgIHRlc3RpbmcvanMKKyAgICApCisgICAgTElTVChBUFBF TkQgV2ViQ29yZV9JRExfRklMRVMKKyAgICAgICAgdGVzdGluZy9JbnRlcm5hbHMuaWRsCisgICAg ICAgIHRlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5pZGwKKyAgICApCitFTkRJRiAoKQorCiBMSVNU KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKICAgICBiaW5kaW5ncy9qcy9DYWxsYmFja0Z1bmN0aW9u LmNwcAogICAgIGJpbmRpbmdzL2pzL0RPTU9iamVjdEhhc2hUYWJsZU1hcC5jcHAKLS0gCjEuNy45 LjEKCg== 134550 2012-03-29 04:57:57 -0700 2012-03-29 10:36:51 -0700 Patch V2 that fixes some typo in last patch. 0001-BlackBerry-Add-Internal-test-support-for-blackberry-.patch text/plain 1772 charles.wei RnJvbSAwOTczNGE3Mjg5MjZiZTc2MjUyYWFmMjQxN2VkOTkxMmFlZmRlMWYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBUaHUsIDI5IE1hciAyMDEyIDE5OjM4OjU4ICswODAwClN1YmplY3Q6IFtQ QVRDSF0gW0JsYWNrQmVycnldIEFkZCBJbnRlcm5hbCB0ZXN0IHN1cHBvcnQgZm9yIGJsYWNrYmVy cnkKIHBvcnRpbmcuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjU5 NwoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpObyBuZXcgdGVzdHMsIGp1c3QgdGhlIGJ1 aWxkIHN5c3RlbSBlaGFuY2VtZW50IGZvciBCbGFja0JlcnJ5IHBvcnRpbmcuCgoqIFVzZUpTQy5j bWFrZToKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgfCAgIDExICsrKysrKysrKysr CiBTb3VyY2UvV2ViQ29yZS9Vc2VKU0MuY21ha2UgfCAgIDEwICsrKysrKysrKysKIDIgZmlsZXMg Y2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTRkN2YyZi4uZmMwY2RhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTI5 ICBDaGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAg ICBbQmxhY2tCZXJyeV0gQWRkIEludGVybmFsIHRlc3Qgc3VwcG9ydCBmb3IgYmxhY2tiZXJyeSBw b3J0aW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODI1OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBuZXcgdGVzdHMsIGp1c3QgdGhlIGJ1aWxkIHN5c3RlbSBlbmhhbmNlbWVudCBmb3IgQmxhY2tC ZXJyeSBwb3J0aW5nLgorCisgICAgICAgICogVXNlSlNDLmNtYWtlOgorCiAyMDEyLTAzLTI4ICBB bnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBTcGxpdCBXZWJLaXRD U1NLZXlmcmFtZVJ1bGUgaW50byBpbnRlcm5hbCBhbmQgQ1NTT00gdHlwZXMgCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Vc2VKU0MuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9Vc2VKU0MuY21h a2UKaW5kZXggMDY0OTdhNC4uMDc0Yzc0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvVXNl SlNDLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1VzZUpTQy5jbWFrZQpAQCAtMTEsNiArMTEs MTYgQEAgTElTVChBUFBFTkQgV2ViQ29yZV9JRExfSU5DTFVERVMKICAgICBiaW5kaW5ncy9qcwog KQogCitJRiAoUE9SVCBNQVRDSEVTICJCbGFja0JlcnJ5IikKKyAgICBMSVNUKEFQUEVORCBXZWJD b3JlX0lETF9JTkNMVURFUworICAgICAgICB0ZXN0aW5nL2pzCisgICAgKQorICAgIExJU1QoQVBQ RU5EIFdlYkNvcmVfSURMX0ZJTEVTCisgICAgICAgIHRlc3RpbmcvSW50ZXJuYWxzLmlkbAorICAg ICAgICB0ZXN0aW5nL0ludGVybmFsU2V0dGluZ3MuaWRsCisgICAgKQorRU5ESUYgKCkKKwogTElT VChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAgICAgYmluZGluZ3MvanMvQ2FsbGJhY2tGdW5jdGlv bi5jcHAKICAgICBiaW5kaW5ncy9qcy9ET01PYmplY3RIYXNoVGFibGVNYXAuY3BwCi0tIAoxLjcu OS4xCgo=