82588 2012-03-29 02:35:55 -0700 MediaStream API: Adding better comments for the WebRTC methods in WebKitPlatformSupport.h 2012-03-29 03:25:31 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 tommyw tommyw abarth dglazkov fishd jamesr tkent webkit.review.bot oldest_to_newest 590980 0 tommyw 2012-03-29 02:35:55 -0700 This addresses outstanding review comments on bug 82450. 590983 1 134533 tommyw 2012-03-29 02:39:03 -0700 Created attachment 134533 Patch 590984 2 webkit.review.bot 2012-03-29 02:41:53 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 590987 3 134533 abarth 2012-03-29 02:45:27 -0700 Comment on attachment 134533 Patch Thanks! 591011 4 134533 webkit.review.bot 2012-03-29 03:25:25 -0700 Comment on attachment 134533 Patch Clearing flags on attachment: 134533 Committed r112517: <http://trac.webkit.org/changeset/112517> 591012 5 webkit.review.bot 2012-03-29 03:25:31 -0700 All reviewed patches have been landed. Closing bug. 134533 2012-03-29 02:39:03 -0700 2012-03-29 03:25:24 -0700 Patch bug-82588-20120329113901.patch text/plain 2295 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDUwZTc4NjRiYWU1MTBhZWFkOWUzY2NhZGU0ZWQ5ZTNmNmYxYjBjODYuLjRkNjY1MTVmNmFkYTg1 ZGMwYmMzNjkyY2FmOWVkMTQyMjAwZWU1ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDMtMjkgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdv b2dsZS5jb20+CisKKyAgICAgICAgTWVkaWFTdHJlYW0gQVBJOiBBZGRpbmcgYmV0dGVyIGNvbW1l bnRzIGZvciB0aGUgV2ViUlRDIG1ldGhvZHMgaW4gV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNTg4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvcGxh dGZvcm0vV2ViS2l0UGxhdGZvcm1TdXBwb3J0Lmg6CisgICAgICAgIChXZWJLaXRQbGF0Zm9ybVN1 cHBvcnQpOgorCiAyMDEyLTAzLTI4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgW0Nocm9taXVtXSBNb3ZlIEFQSXMgcmVsYXRlZCB0byBSZXNvdXJjZUhhbmRsZSBp bnRvIFBsYXRmb3JtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9w bGF0Zm9ybS9XZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL3BsYXRmb3JtL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oCmluZGV4IDJlZmEzNTMxMDU1 ODU4MGYxODM0MGI0NzhjYjA2OWMxYmZiMTEwN2QuLmE2MTU1MDBjZjRlY2NmOThjMDhjOWMyYmY3 M2M1YWY3NThmZjczMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L3BsYXRmb3JtL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL3BsYXRmb3JtL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oCkBAIC00MDgsMTEg KzQwOCwyMSBAQCBwdWJsaWM6CiAKICAgICAvLyBXZWJSVEMgLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCisgICAgLy8gREVQUkVDQVRF RAorICAgIC8vIENyZWF0ZXMgYW4gV2ViUGVlckNvbm5lY3Rpb25IYW5kbGVyIGZvciBEZXByZWNh dGVkUGVlckNvbm5lY3Rpb24uCiAgICAgLy8gTWF5IHJldHVybiBudWxsIGlmIFdlYlJUQyBmdW5j dGlvbmFsaXR5IGlzIG5vdCBhdmFsaWFibGUgb3Igb3V0IG9mIHJlc291cmNlcy4KICAgICB2aXJ0 dWFsIFdlYlBlZXJDb25uZWN0aW9uSGFuZGxlciogY3JlYXRlUGVlckNvbm5lY3Rpb25IYW5kbGVy KFdlYlBlZXJDb25uZWN0aW9uSGFuZGxlckNsaWVudCopIHsgcmV0dXJuIDA7IH0KKworICAgIC8v IENyZWF0ZXMgYW4gV2ViUGVlckNvbm5lY3Rpb24wMEhhbmRsZXIgZm9yIFBlZXJDb25uZWN0aW9u MDAuCisgICAgLy8gVGhpcyBpcyBhbiBoaWdobHkgZXhwZXJpbWVudGFsIGZlYXR1cmUgbm90IHll dCBpbiB0aGUgV2ViUlRDIHN0YW5kYXJkLgorICAgIC8vIE1heSByZXR1cm4gbnVsbCBpZiBXZWJS VEMgZnVuY3Rpb25hbGl0eSBpcyBub3QgYXZhbGlhYmxlIG9yIG91dCBvZiByZXNvdXJjZXMuCiAg ICAgdmlydHVhbCBXZWJQZWVyQ29ubmVjdGlvbjAwSGFuZGxlciogY3JlYXRlUGVlckNvbm5lY3Rp b24wMEhhbmRsZXIoV2ViUGVlckNvbm5lY3Rpb24wMEhhbmRsZXJDbGllbnQqKSB7IHJldHVybiAw OyB9CisKKyAgICAvLyBNYXkgcmV0dXJuIG51bGwgaWYgV2ViUlRDIGZ1bmN0aW9uYWxpdHkgaXMg bm90IGF2YWxpYWJsZSBvciBvdXQgb2YgcmVzb3VyY2VzLgogICAgIHZpcnR1YWwgV2ViTWVkaWFT dHJlYW1DZW50ZXIqIGNyZWF0ZU1lZGlhU3RyZWFtQ2VudGVyKFdlYk1lZGlhU3RyZWFtQ2VudGVy Q2xpZW50KikgeyByZXR1cm4gMDsgfQogCisgICAgLy8gV2ViV29ya2VyIC0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKwogICAgIHZpcnR1 YWwgdm9pZCBkaWRTdGFydFdvcmtlclJ1bkxvb3AoY29uc3QgV2ViV29ya2VyUnVuTG9vcCYpIHsg fQogICAgIHZpcnR1YWwgdm9pZCBkaWRTdG9wV29ya2VyUnVuTG9vcChjb25zdCBXZWJXb3JrZXJS dW5Mb29wJikgeyB9CiAK