82587 2012-03-29 02:31:37 -0700 [Chromium] Move createURLLoader() into Platform 2012-03-29 12:48:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dglazkov fishd jamesr tkent webkit.review.bot oldest_to_newest 590975 0 abarth 2012-03-29 02:31:37 -0700 Move createURLLoader() into Platform 590978 1 134532 abarth 2012-03-29 02:35:09 -0700 Created attachment 134532 Patch 590981 2 webkit.review.bot 2012-03-29 02:38:37 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 591309 3 134532 jamesr 2012-03-29 10:51:25 -0700 Comment on attachment 134532 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134532&action=review R=me but one question about headers in the comments. > Source/WebKit/chromium/public/platform/Platform.h:26 > +#include "../../../../Platform/chromium/public/Platform.h" do we need this forwarding header? I've been assuming that we only need a forwarding header in here if we expect users of the client API to need to see the header and don't want them to have to put both APIs on their include path. I don't think that's true here, since we don't expect users of the API to be using Platform.h directly, right? If we do need this to be exposed for users of the client API then I think it should live in WebKit/chromium/public/ > Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:34 > +#include "Platform.h" could this be #include <public/Platform.h> or "../../../Platform/chromium/public/Platform.h" to avoid the forwarding header? 591319 4 abarth 2012-03-29 10:59:48 -0700 (In reply to comment #3) > (From update of attachment 134532 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134532&action=review > > R=me but one question about headers in the comments. > > > Source/WebKit/chromium/public/platform/Platform.h:26 > > +#include "../../../../Platform/chromium/public/Platform.h" > > do we need this forwarding header? I've been assuming that we only need a forwarding header in here if we expect users of the client API to need to see the header and don't want them to have to put both APIs on their include path. I don't think that's true here, since we don't expect users of the API to be using Platform.h directly, right? The issue is that Platform is a base class for WebKitPlatformSupport, so embedders need to see the header so that they can see all of WebKitPlatformSupport. > If we do need this to be exposed for users of the client API then I think it should live in WebKit/chromium/public/ > > > Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:34 > > +#include "Platform.h" > > could this be #include <public/Platform.h> or "../../../Platform/chromium/public/Platform.h" to avoid the forwarding header? #include <public/Platform.h> doesn't work because clients who include WebKitPlatformSupport.h wouldn't be able to use this include path. The second thing works, but I thought it was cleaner to use a forwarding header. I'm not 100% sure what we want to do with these forwarding headers in the long term. My thinking was that I'd just make this one fit the pattern used by the others and we can worry about what to do with the forwarding headers once we're further along. 591331 5 jamesr 2012-03-29 11:05:53 -0700 The other headers have that pattern because they are part of the client API - i.e. someone who wants to talk to WebKit needs to be able to see the WebString header. Right now Platform.h is just an implementation detail for people using the client API, so I think it makes more sense for now to "hide" it inside WebKitPlatformSupport.h instead of having a dedicated forwarding header. 591386 6 abarth 2012-03-29 11:41:45 -0700 Ok. Will do. 591456 7 abarth 2012-03-29 12:48:31 -0700 Committed r112563: <http://trac.webkit.org/changeset/112563> 134532 2012-03-29 02:35:09 -0700 2012-03-29 10:51:25 -0700 Patch bug-82587-20120329023507.patch text/plain 12172 abarth SW5kZXg6IFNvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1Bs YXRmb3JtL0NoYW5nZUxvZwkocmV2aXNpb24gMTEyNTA5KQorKysgU291cmNlL1BsYXRmb3JtL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDEyLTAzLTI5ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBNb3ZlIGNy ZWF0ZVVSTExvYWRlcigpIGludG8gUGxhdGZvcm0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBpbnRyb2R1Y2VzIGEgYmFzZSBjbGFzcyBm b3IgV2ViS2l0UGxhdGZvcm1TdXBwb3J0IHRoYXQgd2UKKyAgICAgICAgY2FuIHVzZSB0byBpbmNy ZW1lbnRhbGx5IG1vcmUgQVBJcyBmcm9tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0K KyAgICAgICAgaW50byBQbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMuIFVzaW5nIHRoaXMgdGVjaG5p cXVlIGxldHMgdXMgYXZvaWQKKyAgICAgICAgbWFraW5nIGNoYW5nZXMgaW4gdGhlIGVtYmVkZGVy IGR1cmluZyB0aGUgdHJhbnNpdGlvbi4KKworICAgICAgICBUaGlzIHBhdGNoIG1vdmVzIGNyZWF0 ZVVSTExvYWRlcigpIGJlY2F1c2UgaXQncyBuZWNlc3NhcnkgZm9yCisgICAgICAgIFJlc291cmNl SGFuZGxlLiAgVGhpcyBpcyB0aGUgdGhpcmQgcGF0Y2ggaW4gdGhpcyBzZXF1ZW5jZToKKyAgICAg ICAgaHR0cHM6Ly9naXRodWIuY29tL2FiYXJ0aC93ZWJraXQvY29tcGFyZS9tYXN0ZXIuLi53ZWJj b3JlLXBsYXRmb3JtCisKKyAgICAgICAgKiBQbGF0Zm9ybS5neXBpOgorICAgICAgICAqIGNocm9t aXVtL3B1YmxpYy9QbGF0Zm9ybS5oOiBBZGRlZC4KKyAgICAgICAgKFdlYktpdCk6CisgICAgICAg IChQbGF0Zm9ybSk6CisgICAgICAgIChXZWJLaXQ6OlBsYXRmb3JtOjpjcmVhdGVVUkxMb2FkZXIp OgorICAgICAgICAoV2ViS2l0OjpQbGF0Zm9ybTo6flBsYXRmb3JtKToKKyAgICAgICAgKiBjaHJv bWl1bS9zcmMvUGxhdGZvcm0uY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYktpdCk6CisgICAgICAg IChXZWJLaXQ6OlBsYXRmb3JtOjppbml0aWFsaXplKToKKyAgICAgICAgKFdlYktpdDo6UGxhdGZv cm06OnNodXRkb3duKToKKyAgICAgICAgKFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQpOgorCiAy MDEyLTAzLTI4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0No cm9taXVtXSBNb3ZlIEFQSXMgcmVsYXRlZCB0byBSZXNvdXJjZUhhbmRsZSBpbnRvIFBsYXRmb3Jt CkluZGV4OiBTb3VyY2UvUGxhdGZvcm0vUGxhdGZvcm0uZ3lwaQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvUGxhdGZvcm0vUGxhdGZvcm0uZ3lwaQkocmV2aXNpb24gMTEyNTA1KQorKysgU291cmNlL1Bs YXRmb3JtL1BsYXRmb3JtLmd5cGkJKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDcgQEAKIHsK ICAgICAndmFyaWFibGVzJzogewogICAgICAgICAncGxhdGZvcm1fZmlsZXMnOiBbCisgICAgICAg ICAgICAnY2hyb21pdW0vcHVibGljL1BsYXRmb3JtLmgnLAogICAgICAgICAgICAgJ2Nocm9taXVt L3B1YmxpYy9XZWJDU3RyaW5nLmgnLAogICAgICAgICAgICAgJ2Nocm9taXVtL3B1YmxpYy9XZWJD YW52YXMuaCcsCiAgICAgICAgICAgICAnY2hyb21pdW0vcHVibGljL1dlYkNvbG9yLmgnLApAQCAt NjUsNiArNjYsNyBAQAogICAgICAgICAgICAgJ2Nocm9taXVtL3B1YmxpYy9XZWJVUkxMb2FkZXJD bGllbnQuaCcsCiAgICAgICAgICAgICAnY2hyb21pdW0vcHVibGljL1dlYlVSTFJlcXVlc3QuaCcs CiAgICAgICAgICAgICAnY2hyb21pdW0vcHVibGljL1dlYlVSTFJlc3BvbnNlLmgnLAorICAgICAg ICAgICAgJ2Nocm9taXVtL3NyYy9QbGF0Zm9ybS5jcHAnLAogICAgICAgICAgICAgJ2Nocm9taXVt L3NyYy9XZWJDU3RyaW5nLmNwcCcsCiAgICAgICAgICAgICAnY2hyb21pdW0vc3JjL1dlYkZsb2F0 UXVhZC5jcHAnLAogICAgICAgICAgICAgJ2Nocm9taXVtL3NyYy9XZWJTdHJpbmcuY3BwJywKSW5k ZXg6IFNvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1BsYXRmb3JtLmgJKHJldmlzaW9u IDApCisrKyBTb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1BsYXRmb3JtLmgJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsNTcgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTIgR29vZ2xl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cyBhcmUKKyAqIG1ldDoKKyAqCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNv ZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogbm90aWNlLCB0aGlzIGxpc3Qg b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogICAgICogUmVk aXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorICog Y29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dp bmcgZGlzY2xhaW1lcgorICogaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVy aWFscyBwcm92aWRlZCB3aXRoIHRoZQorICogZGlzdHJpYnV0aW9uLgorICogICAgICogTmVpdGhl ciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cworICogY29udHJp YnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVk IGZyb20KKyAqIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBl cm1pc3Npb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJ R0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1Mg T1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8s IFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZP UgorICogQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNI QUxMIFRIRSBDT1BZUklHSFQKKyAqIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9S IEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorICogU1BFQ0lBTCwgRVhFTVBMQVJZ LCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRF RCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBP RiBVU0UsCisgKiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhP V0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIg SU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVH TElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQor ICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBP RiBTVUNIIERBTUFHRS4KKyAqLworCisjaWZuZGVmIFBsYXRmb3JtX2gKKyNkZWZpbmUgUGxhdGZv cm1faAorCisjaW5jbHVkZSAiV2ViQ29tbW9uLmgiCisKK25hbWVzcGFjZSBXZWJLaXQgeworCitj bGFzcyBXZWJVUkxMb2FkZXI7CisKK2NsYXNzIFBsYXRmb3JtIHsKK3B1YmxpYzoKKyAgICBXRUJL SVRfRVhQT1JUIHN0YXRpYyB2b2lkIGluaXRpYWxpemUoUGxhdGZvcm0qKTsKKyAgICBXRUJLSVRf RVhQT1JUIHN0YXRpYyB2b2lkIHNodXRkb3duKCk7CisgICAgV0VCS0lUX0VYUE9SVCBzdGF0aWMg UGxhdGZvcm0qIGN1cnJlbnQoKTsKKworICAgIC8vIE5ldHdvcmsgLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorCisgICAgLy8gUmV0 dXJucyBhIG5ldyBXZWJVUkxMb2FkZXIgaW5zdGFuY2UuCisgICAgdmlydHVhbCBXZWJVUkxMb2Fk ZXIqIGNyZWF0ZVVSTExvYWRlcigpIHsgcmV0dXJuIDA7IH0KKworcHJvdGVjdGVkOgorICAgIH5Q bGF0Zm9ybSgpIHsgfQorfTsKKworfSAvLyBuYW1lc3BhY2UgV2ViS2l0CisKKyNlbmRpZgpJbmRl eDogU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3NyYy9QbGF0Zm9ybS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3NyYy9QbGF0Zm9ybS5jcHAJKHJldmlzaW9uIDAp CisrKyBTb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vc3JjL1BsYXRmb3JtLmNwcAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSw1MyBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMiBHb29nbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4g c291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9u LCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFy ZQorICogbWV0OgorICoKKyAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBt dXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBj b25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAgICAgKiBSZWRpc3Ry aWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCisgKiBjb3B5 cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBk aXNjbGFpbWVyCisgKiBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxz IHByb3ZpZGVkIHdpdGggdGhlCisgKiBkaXN0cmlidXRpb24uCisgKiAgICAgKiBOZWl0aGVyIHRo ZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCisgKiBjb250cmlidXRv cnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJv bQorICogdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlz c2lvbi4KKyAqCisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQg SE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisgKiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJ TVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgVEhF IElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisg KiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwg VEhFIENPUFlSSUdIVAorICogT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5Z IERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCisgKiBTUEVDSUFMLCBFWEVNUExBUlksIE9S IENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRP LCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVT RSwKKyAqIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZF UiBDQVVTRUQgQU5EIE9OIEFOWQorICogVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBD T05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdF TkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBP RiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNV Q0ggREFNQUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlIDxwdWJsaWMv UGxhdGZvcm0uaD4KKworbmFtZXNwYWNlIFdlYktpdCB7CisKK3N0YXRpYyBQbGF0Zm9ybSogc19w bGF0Zm9ybSA9IDA7CisKK3ZvaWQgUGxhdGZvcm06OmluaXRpYWxpemUoUGxhdGZvcm0qIHBsYXRm b3JtKQoreworICAgIHNfcGxhdGZvcm0gPSBwbGF0Zm9ybTsKK30KKwordm9pZCBQbGF0Zm9ybTo6 c2h1dGRvd24oKQoreworICAgIHNfcGxhdGZvcm0gPSAwOworfQorCitQbGF0Zm9ybSogUGxhdGZv cm06OmN1cnJlbnQoKQoreworICAgIHJldHVybiBzX3BsYXRmb3JtOworfQorCit9IC8vIG5hbWVz cGFjZSBXZWJLaXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTI1 MDkpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTI5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CisKKyAgICAgICAgTW92ZSBjcmVhdGVVUkxMb2FkZXIoKSBpbnRvIFBsYXRmb3JtCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjU4NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVibGljL3BsYXRm b3JtL1BsYXRmb3JtLmg6IEFkZGVkLgorICAgICAgICAqIHB1YmxpYy9wbGF0Zm9ybS9XZWJLaXRQ bGF0Zm9ybVN1cHBvcnQuaDoKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChXZWJLaXRQbGF0 Zm9ybVN1cHBvcnQpOgorICAgICAgICAqIHNyYy9XZWJLaXQuY3BwOgorICAgICAgICAoV2ViS2l0 Ojppbml0aWFsaXplV2l0aG91dFY4KToKKyAgICAgICAgKFdlYktpdDo6c2h1dGRvd24pOgorCiAy MDEyLTAzLTI5ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkOyByb2xsaW5nIGNocm9taXVtIGRlcHMgdG8gMTI5NTgzLgpJbmRleDogU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0vUGxhdGZvcm0uaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS9QbGF0Zm9ybS5oCShy ZXZpc2lvbiAwKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0vUGxh dGZvcm0uaAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyNiBAQAorLyoKKyAqIENvcHlyaWdodCAo QykgMjAxMiBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJp YnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91 dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxv d2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICoKKyAqIDEuICBSZWRpc3RyaWJ1dGlvbnMg b2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgIG5v dGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1l ci4KKyAqIDIuICBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2Ug dGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgICBkb2N1bWVudGF0 aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9u LgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgQU5EIElUUyBDT05U UklCVVRPUlMgIkFTIElTIiBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElF UywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVECisgKiBXQVJSQU5U SUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBP U0UgQVJFCisgKiBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBPUiBJVFMgQ09O VFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZCisgKiBESVJFQ1QsIElORElSRUNULCBJTkNJREVO VEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUworICogKElO Q0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdP T0RTIE9SIFNFUlZJQ0VTOworICogTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJV U0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5ECisgKiBPTiBBTlkgVEhFT1JZ IE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1Ig VE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBB TlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GCisgKiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklT RUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpbmNsdWRlICIu Li8uLi8uLi8uLi9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaCIKSW5kZXg6IFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL3BsYXRmb3JtL1dlYktpdFBsYXRmb3JtU3VwcG9y dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL3BsYXRmb3Jt L1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oCShyZXZpc2lvbiAxMTI1MDUpCisrKyBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS9XZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaAkod29y a2luZyBjb3B5KQpAQCAtMzEsNiArMzEsNyBAQAogI2lmbmRlZiBXZWJLaXRQbGF0Zm9ybVN1cHBv cnRfaAogI2RlZmluZSBXZWJLaXRQbGF0Zm9ybVN1cHBvcnRfaAogCisjaW5jbHVkZSAiUGxhdGZv cm0uaCIKICNpbmNsdWRlICJXZWJBdWRpb0J1cy5oIgogI2luY2x1ZGUgIldlYkF1ZGlvRGV2aWNl LmgiCiAjaW5jbHVkZSAiV2ViQ29tbW9uLmgiCkBAIC00Miw3ICs0Myw2IEBACiAjaW5jbHVkZSAi V2ViU3RyaW5nLmgiCiAjaW5jbHVkZSAiV2ViVVJMLmgiCiAjaW5jbHVkZSAiV2ViVmVjdG9yLmgi Ci0KICNpbmNsdWRlIDx0aW1lLmg+CiAKICNpZmRlZiBXSU4zMgpAQCAtNzUsMTAgKzc1LDEwIEBA IGNsYXNzIFdlYlNvY2tldFN0cmVhbUhhbmRsZTsKIGNsYXNzIFdlYlN0b3JhZ2VOYW1lc3BhY2U7 IC8vIEZJWE1FOiBEb2VzIHRoaXMgYmVsb25nIGluIHBsYXRmb3JtPwogY2xhc3MgV2ViVGhlbWVF bmdpbmU7CiBjbGFzcyBXZWJUaHJlYWQ7Ci1jbGFzcyBXZWJVUkxMb2FkZXI7CiBjbGFzcyBXZWJX b3JrZXJSdW5Mb29wOwogCi1jbGFzcyBXZWJLaXRQbGF0Zm9ybVN1cHBvcnQgeworLy8gRklYTUU6 IEV2ZW50dWFsbHkgYWxsIHRoZXNlIEFQSSB3aWxsIG5lZWQgdG8gbW92ZSB0byBXZWJLaXQ6OlBs YXRmb3JtLgorY2xhc3MgV2ViS2l0UGxhdGZvcm1TdXBwb3J0IDogcHVibGljIFBsYXRmb3JtIHsK IHB1YmxpYzoKICAgICAvLyBNdXN0IHJldHVybiBub24tbnVsbC4KICAgICB2aXJ0dWFsIFdlYkNs aXBib2FyZCogY2xpcGJvYXJkKCkgeyByZXR1cm4gMDsgfQpAQCAtMjE2LDkgKzIxNiw2IEBAIHB1 YmxpYzoKICAgICAvLyBBIHN1Z2dlc3Rpb24gdG8gcHJlZmV0Y2ggSVAgaW5mb3JtYXRpb24gZm9y IHRoZSBnaXZlbiBob3N0bmFtZS4KICAgICB2aXJ0dWFsIHZvaWQgcHJlZmV0Y2hIb3N0TmFtZShj b25zdCBXZWJTdHJpbmcmKSB7IH0KIAotICAgIC8vIFJldHVybnMgYSBuZXcgV2ViVVJMTG9hZGVy IGluc3RhbmNlLgotICAgIHZpcnR1YWwgV2ViVVJMTG9hZGVyKiBjcmVhdGVVUkxMb2FkZXIoKSB7 IHJldHVybiAwOyB9Ci0KICAgICAvLyBSZXR1cm5zIGEgbmV3IFdlYlNvY2tldFN0cmVhbUhhbmRs ZSBpbnN0YW5jZS4KICAgICB2aXJ0dWFsIFdlYlNvY2tldFN0cmVhbUhhbmRsZSogY3JlYXRlU29j a2V0U3RyZWFtSGFuZGxlKCkgeyByZXR1cm4gMDsgfQogCkluZGV4OiBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJLaXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYktpdC5jcHAJKHJldmlzaW9uIDExMjUwNSkKKysrIFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYktpdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4LDIyICszOCwyMiBAQAog I2luY2x1ZGUgIlRleHRFbmNvZGluZy5oIgogI2luY2x1ZGUgIlY4QmluZGluZy5oIgogI2luY2x1 ZGUgIldlYktpdE11dGF0aW9uT2JzZXJ2ZXIuaCIKLSNpbmNsdWRlICJwbGF0Zm9ybS9XZWJLaXRQ bGF0Zm9ybVN1cHBvcnQuaCIKICNpbmNsdWRlICJXZWJNZWRpYVBsYXllckNsaWVudEltcGwuaCIK ICNpbmNsdWRlICJXZWJTb2NrZXQuaCIKLSNpbmNsdWRlICJwbGF0Zm9ybS9XZWJUaHJlYWQuaCIK ICNpbmNsdWRlICJXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuaCIKKyNpbmNsdWRlICJwbGF0 Zm9ybS9QbGF0Zm9ybS5oIgorI2luY2x1ZGUgInBsYXRmb3JtL1dlYktpdFBsYXRmb3JtU3VwcG9y dC5oIgorI2luY2x1ZGUgInBsYXRmb3JtL1dlYlRocmVhZC5oIgogI2luY2x1ZGUgInY4LmgiCi0K LSNpZiBPUyhEQVJXSU4pCi0jaW5jbHVkZSAiV2ViU3lzdGVtSW50ZXJmYWNlLmgiCi0jZW5kaWYK LQogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQu aD4KICNpbmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQXRvbWlj U3RyaW5nLmg+CiAKKyNpZiBPUyhEQVJXSU4pCisjaW5jbHVkZSAiV2ViU3lzdGVtSW50ZXJmYWNl LmgiCisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYktpdCB7CiAKICNpZiBFTkFCTEUoTVVUQVRJT05f T0JTRVJWRVJTKQpAQCAtMTE4LDYgKzExOCw3IEBAIHZvaWQgaW5pdGlhbGl6ZVdpdGhvdXRWOChX ZWJLaXRQbGF0Zm9ybVMKICAgICBBU1NFUlQod2ViS2l0UGxhdGZvcm1TdXBwb3J0KTsKICAgICBB U1NFUlQoIXNfd2ViS2l0UGxhdGZvcm1TdXBwb3J0KTsKICAgICBzX3dlYktpdFBsYXRmb3JtU3Vw cG9ydCA9IHdlYktpdFBsYXRmb3JtU3VwcG9ydDsKKyAgICBQbGF0Zm9ybTo6aW5pdGlhbGl6ZShz X3dlYktpdFBsYXRmb3JtU3VwcG9ydCk7CiAKICAgICBXVEY6OmluaXRpYWxpemVUaHJlYWRpbmco KTsKICAgICBXVEY6OmluaXRpYWxpemVNYWluVGhyZWFkKCk7CkBAIC0xNDUsNiArMTQ2LDcgQEAg dm9pZCBzaHV0ZG93bigpCiAgICAgfQogI2VuZGlmCiAgICAgc193ZWJLaXRQbGF0Zm9ybVN1cHBv cnQgPSAwOworICAgIFBsYXRmb3JtOjpzaHV0ZG93bigpOwogfQogCiBXZWJLaXRQbGF0Zm9ybVN1 cHBvcnQqIHdlYktpdFBsYXRmb3JtU3VwcG9ydCgpCg==