82585 2012-03-29 01:55:02 -0700 Cross-platform processor core counter: fix build on OpenBSD/NetBSD. 2012-04-25 16:01:43 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 landry webkit-unassigned rakuco zherczeg oldest_to_newest 590951 0 landry 2012-03-29 01:55:02 -0700 Followup to #81482, as stated in comment #5 on OpenBSD/NetBSD you need to include sys/param.h to use sysctl(), otherwise some #defines are missing. Is it a problem to also include it on darwin/freebsd, or should it be made for all 4 oses ? 591160 1 rakuco 2012-03-29 07:22:35 -0700 Using sys/param.h should be fine on FreeBSD as well (it includes sys/types.h if LOCORE is not defined). Dunno about OS X, as I don't have access to a Mac. You could try sending a patch and checking if the bots complain. 609145 2 138667 landry 2012-04-24 15:27:15 -0700 Created attachment 138667 Include sys/param.h to use sysctl() on Open/NetBSD Dunno if setting review to ? will be enough to trigger the bots... 609181 3 rakuco 2012-04-24 15:54:40 -0700 You need to submit a patch against the top-level tree, it looks like you've diff'ed against Source/WTF. 609546 4 landry 2012-04-25 01:39:36 -0700 Yeah, i don't have the full repo, only Source/. You guys have an insanely huge repo, i tried to svn co trunk once and gave up. 609548 5 138760 landry 2012-04-25 01:43:04 -0700 Created attachment 138760 Include sys/param.h to use sysctl() on Open/NetBSD Lets retry 609696 6 rakuco 2012-04-25 06:29:02 -0700 (In reply to comment #4) > Yeah, i don't have the full repo, only Source/. You guys have an insanely huge repo, i tried to svn co trunk once and gave up. The largest part of it is the LayoutTests/ directory, which you can ignore. $ svn co -N http://svn.webkit.org/repository/webkit/trunk WebKit $ cd WebKit $ svn up Source Additionally, the Tools/ directory has some useful scripts to help generate the ChangeLog entries and things like that. 609915 7 landry 2012-04-25 11:06:33 -0700 All green on the bots.. anyone care to review/commit ? 610083 8 138760 zherczeg 2012-04-25 15:15:28 -0700 Comment on attachment 138760 Include sys/param.h to use sysctl() on Open/NetBSD r=me 610120 9 138760 rakuco 2012-04-25 16:01:34 -0700 Comment on attachment 138760 Include sys/param.h to use sysctl() on Open/NetBSD Clearing flags on attachment: 138760 Committed r115254: <http://trac.webkit.org/changeset/115254> 610122 10 rakuco 2012-04-25 16:01:43 -0700 All reviewed patches have been landed. Closing bug. 138667 2012-04-24 15:27:15 -0700 2012-04-25 01:43:04 -0700 Include sys/param.h to use sysctl() on Open/NetBSD webkit-bug-82585.diff text/plain 1077 landry SW5kZXg6IHd0Zi9OdW1iZXJPZkNvcmVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB3dGYvTnVtYmVyT2ZD b3Jlcy5jcHAJKHJldmlzaW9uIDExNDg4MSkKKysrIHd0Zi9OdW1iZXJPZkNvcmVzLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjcsNiArMjcsNyBAQAogI2luY2x1ZGUgIk51bWJlck9mQ29yZXMuaCIK IAogI2lmIE9TKERBUldJTikgfHwgT1MoT1BFTkJTRCkgfHwgT1MoTkVUQlNEKSB8fCBPUyhGUkVF QlNEKQorI2luY2x1ZGUgPHN5cy9wYXJhbS5oPgogLy8gc3lzL3R5cGVzLmggbXVzdCBjb21lIGJl Zm9yZSBzeXMvc3lzY3RsLmggYmVjYXVzZSB0aGUgbGF0dGVyIHVzZXMKIC8vIGRhdGEgdHlwZXMg ZGVmaW5lZCBpbiB0aGUgZm9ybWVyLiBTZWUgc3lzY3RsKDMpIGFuZCBzdHlsZSg5KS4KICNpbmNs dWRlIDxzeXMvdHlwZXMuaD4KSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VM b2cJKHJldmlzaW9uIDExNTEyMSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDEyLTA0LTI0ICBMYW5kcnkgQnJldWlsICA8bGFuZHJ5QG9wZW5ic2Qub3Jn PgorCisgICAgICAgIEluY2x1ZGUgPHN5cy9wYXJhbS5oPiwgbmVlZGVkIGZvciBzeXNjdGwoKSBv biBPcGVuQlNEL05ldEJTRAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODI1ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHd0Zi9OdW1iZXJPZkNvcmVzLmNwcDogaW5jbHVkZSA8c3lzL3BhcmFtLmg+IG9u IHRoZSBCU0RzCisKIDIwMTItMDQtMjQgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgog CiAgICAgICAgIEl0ZXJhdGluZyBhIEhhc2hNYXA8U3RyaW5nLCBYPiBpbnZvbHZlcyBhIHN0cmlu ZyBlcXVhbGl0eSBjb21wYXJpc29uIHRvIGNoZWNrIGZvciB0aGUgZW1wdHkgdmFsdWUK 138760 2012-04-25 01:43:04 -0700 2012-04-25 16:01:34 -0700 Include sys/param.h to use sysctl() on Open/NetBSD webkit-bug-82585.diff text/plain 1143 landry SW5kZXg6IFNvdXJjZS9XVEYvd3RmL051bWJlck9mQ29yZXMuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XVEYvd3RmL051bWJlck9mQ29yZXMuY3BwCShyZXZpc2lvbiAxMTQ4ODEpCisrKyBTb3Vy Y2UvV1RGL3d0Zi9OdW1iZXJPZkNvcmVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcsNiArMjcs NyBAQAogI2luY2x1ZGUgIk51bWJlck9mQ29yZXMuaCIKIAogI2lmIE9TKERBUldJTikgfHwgT1Mo T1BFTkJTRCkgfHwgT1MoTkVUQlNEKSB8fCBPUyhGUkVFQlNEKQorI2luY2x1ZGUgPHN5cy9wYXJh bS5oPgogLy8gc3lzL3R5cGVzLmggbXVzdCBjb21lIGJlZm9yZSBzeXMvc3lzY3RsLmggYmVjYXVz ZSB0aGUgbGF0dGVyIHVzZXMKIC8vIGRhdGEgdHlwZXMgZGVmaW5lZCBpbiB0aGUgZm9ybWVyLiBT ZWUgc3lzY3RsKDMpIGFuZCBzdHlsZSg5KS4KICNpbmNsdWRlIDxzeXMvdHlwZXMuaD4KSW5kZXg6 IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hhbmdlTG9n CShyZXZpc2lvbiAxMTUxMjEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA0LTI0ICBMYW5kcnkgQnJldWlsICA8bGFuZHJ5QG9w ZW5ic2Qub3JnPgorCisgICAgICAgIEluY2x1ZGUgPHN5cy9wYXJhbS5oPiwgbmVlZGVkIGZvciBz eXNjdGwoKSBvbiBPcGVuQlNEL05ldEJTRAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODI1ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHd0Zi9OdW1iZXJPZkNvcmVzLmNwcDogaW5jbHVkZSA8c3lzL3Bh cmFtLmg+IG9uIHRoZSBCU0RzCisKIDIwMTItMDQtMjQgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw bGUuY29tPgogCiAgICAgICAgIEl0ZXJhdGluZyBhIEhhc2hNYXA8U3RyaW5nLCBYPiBpbnZvbHZl cyBhIHN0cmluZyBlcXVhbGl0eSBjb21wYXJpc29uIHRvIGNoZWNrIGZvciB0aGUgZW1wdHkgdmFs dWUK