82572 2012-03-28 21:43:27 -0700 Add TextFieldDecorationElement::decorate() 2012-03-28 23:00:44 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82143 1 tkent tkent dglazkov morrita webkit.review.bot oldest_to_newest 590830 0 tkent 2012-03-28 21:43:27 -0700 Add TextFieldDecorationElement::decorate() 590832 1 134495 tkent 2012-03-28 21:48:00 -0700 Created attachment 134495 Patch 590839 2 134495 morrita 2012-03-28 22:00:47 -0700 Comment on attachment 134495 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134495&action=review > Source/WebCore/dom/ShadowRoot.cpp:-116 > - ASSERT(purpose != CreatingUserAgentShadowRoot || !element->hasShadowRoot()); Looks like this assertion should be corrected instead of removed. ASSERT(purpose == CreatingUserAgentShadowRoot || !element->hasShadowRoot()) will be an expected form. > Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:80 > + ASSERT(existingRoot->firstChild() == existingRoot->lastChild()); You mean existingRoot->childNodeCount() == 1 ? > Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:82 > + static_cast<HTMLElement*>(existingRoot->firstChild())->setInlineStyleProperty(CSSPropertyWebkitBoxFlex, 1.0, CSSPrimitiveValue::CSS_NUMBER); toHTMLElement() has captured this assert-and-cast pattern. 590843 3 134495 tkent 2012-03-28 22:11:13 -0700 Comment on attachment 134495 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134495&action=review >> Source/WebCore/dom/ShadowRoot.cpp:-116 >> - ASSERT(purpose != CreatingUserAgentShadowRoot || !element->hasShadowRoot()); > > Looks like this assertion should be corrected instead of removed. > ASSERT(purpose == CreatingUserAgentShadowRoot || !element->hasShadowRoot()) will be an expected form. Really? Your expected form means that one can't add multiple author shadow roots to an element. >> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:80 >> + ASSERT(existingRoot->firstChild() == existingRoot->lastChild()); > > You mean existingRoot->childNodeCount() == 1 ? Yes. I thought I should have avoided childNodeCount because it's O(N), but it's acceptable because the child node count should be 1. I'll change it to childNodeCount()==1. >> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:82 >> + static_cast<HTMLElement*>(existingRoot->firstChild())->setInlineStyleProperty(CSSPropertyWebkitBoxFlex, 1.0, CSSPrimitiveValue::CSS_NUMBER); > > toHTMLElement() has captured this assert-and-cast pattern. will do. 590847 4 134499 tkent 2012-03-28 22:17:14 -0700 Created attachment 134499 Patch 2 590857 5 morrita 2012-03-28 22:42:13 -0700 (In reply to comment #3) > (From update of attachment 134495 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134495&action=review > > >> Source/WebCore/dom/ShadowRoot.cpp:-116 > >> - ASSERT(purpose != CreatingUserAgentShadowRoot || !element->hasShadowRoot()); > > > > Looks like this assertion should be corrected instead of removed. > > ASSERT(purpose == CreatingUserAgentShadowRoot || !element->hasShadowRoot()) will be an expected form. > > Really? >> Your expected form means that one can't add multiple author shadow roots to an element. You're right. I was confused. > > >> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:80 > >> + ASSERT(existingRoot->firstChild() == existingRoot->lastChild()); > > > > You mean existingRoot->childNodeCount() == 1 ? > > Yes. I thought I should have avoided childNodeCount because it's O(N), but it's acceptable because the child node count should be 1. I'll change it to childNodeCount()==1. > > >> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:82 > >> + static_cast<HTMLElement*>(existingRoot->firstChild())->setInlineStyleProperty(CSSPropertyWebkitBoxFlex, 1.0, CSSPrimitiveValue::CSS_NUMBER); > > > > toHTMLElement() has captured this assert-and-cast pattern. > > will do. 590863 6 134499 webkit.review.bot 2012-03-28 23:00:40 -0700 Comment on attachment 134499 Patch 2 Clearing flags on attachment: 134499 Committed r112503: <http://trac.webkit.org/changeset/112503> 590864 7 webkit.review.bot 2012-03-28 23:00:44 -0700 All reviewed patches have been landed. Closing bug. 134495 2012-03-28 21:48:00 -0700 2012-03-28 22:17:09 -0700 Patch bug-82572-20120329134758.patch text/plain 4759 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmE5ZWQyYTczYTY4Y2Ux YzQ4NDQ1N2E3YmQ1ZDQzOWM1MWQ2MWZiMC4uZjk3MDE1ZDhkZTUwYTA5NDBmZTI0Y2UwZWJlMDI1 NTY1YTVhMjYyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAzLTI4ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgVGV4dEZpZWxkRGVj b3JhdGlvbkVsZW1lbnQ6OmRlY29yYXRlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTgyNTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2Ugd2lsbCBiZSBuZWVkZWQgZm9yIEJ1ZyA4MjE0 My4KKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugb2Ygbm8gYmVoYXZpb3IgY2hhbmdlcyB5 ZXQuIFRoaXMgY29kZSBjaGFuZ2UKKyAgICAgICAgZG9lc24ndCBhZmZlY3Qgbm9uLUNocm9taXVt IHBvcnRzIGZvciBub3cuCisKKyAgICAgICAgKiBkb20vU2hhZG93Um9vdC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTaGFkb3dSb290OjpjcmVhdGUpOgorICAgICAgICBSZW1vdmUgdW5uZWNlc3Nh cnkgYXNzZXJ0aW9uLiBXZSBzaG91bGQgYWxsb3cgbXVsdGlwbGUgVUEgc2hhZG93IHJvb3RzLgor ICAgICAgICAqIGh0bWwvc2hhZG93L1RleHRGaWVsZERlY29yYXRpb25FbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlRleHRGaWVsZERlY29yYXRpb25FbGVtZW50OjpkZWNvcmF0ZSk6Cisg ICAgICAgIEFkZGVkLgorICAgICAgICBUaGlzIGZ1bmN0aW9uIGFkZHMgYW5vdGhlciBTaGFkb3dS b290LCBhbmQgaXQgY29udGFpbnMgb25lIGZsZXhpYmxlIGJveCBjb250YWluZXIuCisgICAgICAg IFRoZSBjb250YWluZXIgY29udGFpbnMgZXhpc3RpbiBTaGFkb3dSb290IGNvbnRlbnQgYW5kIHRo ZSBkZWNvcmF0aW9uIGVsZW1lbnQuCisgICAgICAgICogaHRtbC9zaGFkb3cvVGV4dEZpZWxkRGVj b3JhdGlvbkVsZW1lbnQuaDoKKyAgICAgICAgKFRleHRGaWVsZERlY29yYXRpb25FbGVtZW50KTog QWRkIHRoZSBkZWNsYXJhdGlvbiBvZiBkZWNvcmF0ZSgpLgorCiAyMDEyLTAzLTI3ICBLYXVzYWx5 YSBNYWRodXN1ZGhhbmFuICA8a21hZGh1c3VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDb3Zl cml0eV0gQWRkcmVzcyBzb21lIHVuaW5pdGlhbGl6ZWQgY29uc3RydWN0b3IgdmFsdWVzLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuY3BwIGIvU291cmNlL1dlYkNv cmUvZG9tL1NoYWRvd1Jvb3QuY3BwCmluZGV4IDk3Y2VjOTUyMjZhODgwMWU2NzNhYzIyNTMzYjhl MTVhNDQ4NTE0YmMuLmRhMjE1ZWRjYzNlMTA3MWM3MDJkOTdkMDU3ZDRjMjUyOWYyOWFkNGEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAKQEAgLTExMyw3ICsxMTMsNiBAQCBQYXNzUmVmUHRy PFNoYWRvd1Jvb3Q+IFNoYWRvd1Jvb3Q6OmNyZWF0ZShFbGVtZW50KiBlbGVtZW50LCBTaGFkb3dS b290Q3JlYXRpb25QdQogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKLSAgICBBU1NFUlQocHVy cG9zZSAhPSBDcmVhdGluZ1VzZXJBZ2VudFNoYWRvd1Jvb3QgfHwgIWVsZW1lbnQtPmhhc1NoYWRv d1Jvb3QoKSk7CiAgICAgUmVmUHRyPFNoYWRvd1Jvb3Q+IHNoYWRvd1Jvb3QgPSBhZG9wdFJlZihu ZXcgU2hhZG93Um9vdChlbGVtZW50LT5kb2N1bWVudCgpKSk7CiAKICAgICBlYyA9IDA7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0RmllbGREZWNvcmF0aW9uRWxl bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0RmllbGREZWNvcmF0aW9u RWxlbWVudC5jcHAKaW5kZXggMjZiNTg4Y2M1ZjIyNWJjODcxNTk2ZmM1ZWRhNmFmMWFkZTllNGY2 ZC4uYjYxOWVmZDc1YTEyZWM5MTU3NTdhMTg5YmQxZTQyMmMzYjFkOTQ1NyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRGaWVsZERlY29yYXRpb25FbGVt ZW50LmNwcApAQCAtMzEsMTAgKzMxLDE1IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVk ZSAiVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQuaCIKIAorI2luY2x1ZGUgIkNTU1Byb3BlcnR5 TmFtZXMuaCIKKyNpbmNsdWRlICJDU1NWYWx1ZUtleXdvcmRzLmgiCiAjaW5jbHVkZSAiRXZlbnQu aCIKICNpbmNsdWRlICJIVE1MSW5wdXRFbGVtZW50LmgiCisjaW5jbHVkZSAiSFRNTFNoYWRvd0Vs ZW1lbnQuaCIKICNpbmNsdWRlICJOb2RlUmVuZGVyU3R5bGUuaCIKICNpbmNsdWRlICJSZW5kZXJJ bWFnZS5oIgorI2luY2x1ZGUgIlNoYWRvd1Jvb3QuaCIKKyNpbmNsdWRlICJTaGFkb3dUcmVlLmgi CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtNjEsNiArNjYsMjYgQEAgUGFzc1JlZlB0cjxU ZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudD4gVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQ6OmNy ZWF0ZShEb2N1bWUKICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFRleHRGaWVsZERlY29yYXRpb25F bGVtZW50KGRvY3VtZW50LCBkZWNvcmF0b3IpKTsKIH0KIAordm9pZCBUZXh0RmllbGREZWNvcmF0 aW9uRWxlbWVudDo6ZGVjb3JhdGUoSFRNTElucHV0RWxlbWVudCogaW5wdXQpCit7CisgICAgQVNT RVJUKGlucHV0KTsKKyAgICBTaGFkb3dSb290KiBleGlzdGluZ1Jvb3QgPSBpbnB1dC0+c2hhZG93 VHJlZSgpLT55b3VuZ2VzdFNoYWRvd1Jvb3QoKTsKKyAgICBSZWZQdHI8U2hhZG93Um9vdD4gbmV3 Um9vdCA9IFNoYWRvd1Jvb3Q6OmNyZWF0ZShpbnB1dCwgU2hhZG93Um9vdDo6Q3JlYXRpbmdVc2Vy QWdlbnRTaGFkb3dSb290LCBBU1NFUlRfTk9fRVhDRVBUSU9OKTsKKyAgICBSZWZQdHI8SFRNTERp dkVsZW1lbnQ+IGJveCA9IEhUTUxEaXZFbGVtZW50OjpjcmVhdGUoaW5wdXQtPmRvY3VtZW50KCkp OworICAgIG5ld1Jvb3QtPmFwcGVuZENoaWxkKGJveCk7CisgICAgYm94LT5zZXRJbmxpbmVTdHls ZVByb3BlcnR5KENTU1Byb3BlcnR5RGlzcGxheSwgQ1NTVmFsdWVXZWJraXRCb3gpOworICAgIGJv eC0+c2V0SW5saW5lU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0eVdlYmtpdEJveEFsaWduLCBDU1NW YWx1ZUNlbnRlcik7CisgICAgQVNTRVJUKGV4aXN0aW5nUm9vdCk7CisgICAgQVNTRVJUKGV4aXN0 aW5nUm9vdC0+Zmlyc3RDaGlsZCgpKTsKKyAgICBBU1NFUlQoZXhpc3RpbmdSb290LT5maXJzdENo aWxkKCkgPT0gZXhpc3RpbmdSb290LT5sYXN0Q2hpbGQoKSk7CisgICAgQVNTRVJUKGV4aXN0aW5n Um9vdC0+Zmlyc3RDaGlsZCgpLT5pc0hUTUxFbGVtZW50KCkpOworICAgIHN0YXRpY19jYXN0PEhU TUxFbGVtZW50Kj4oZXhpc3RpbmdSb290LT5maXJzdENoaWxkKCkpLT5zZXRJbmxpbmVTdHlsZVBy b3BlcnR5KENTU1Byb3BlcnR5V2Via2l0Qm94RmxleCwgMS4wLCBDU1NQcmltaXRpdmVWYWx1ZTo6 Q1NTX05VTUJFUik7CisgICAgYm94LT5hcHBlbmRDaGlsZChIVE1MU2hhZG93RWxlbWVudDo6Y3Jl YXRlKEhUTUxOYW1lczo6c2hhZG93VGFnLCBpbnB1dC0+ZG9jdW1lbnQoKSkpOworCisgICAgc2V0 SW5saW5lU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0eVdlYmtpdEJveEZsZXgsIDAuMCwgQ1NTUHJp bWl0aXZlVmFsdWU6OkNTU19OVU1CRVIpOworICAgIGJveC0+YXBwZW5kQ2hpbGQodGhpcyk7Cit9 CisKIGlubGluZSBIVE1MSW5wdXRFbGVtZW50KiBUZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudDo6 aG9zdElucHV0KCkKIHsKICAgICBBU1NFUlQoc2hhZG93QW5jZXN0b3JOb2RlKCkpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1l bnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRGaWVsZERlY29yYXRpb25FbGVt ZW50LmgKaW5kZXggNWZhZWIxNzBlN2QwMDcwZTc0OWYzZTk2MzBiMjY5NWRkODA2ZDYzYi4uMDIw ZjJhNTBhYThhODM1NWM2ZjQwODBlNTRkYzcxODRhYTM0ZDcyZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudC5oCkBA IC02Myw2ICs2Myw3IEBAIGNsYXNzIFRleHRGaWVsZERlY29yYXRpb25FbGVtZW50IDogcHVibGlj IEhUTUxEaXZFbGVtZW50IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxUZXh0Rmll bGREZWNvcmF0aW9uRWxlbWVudD4gY3JlYXRlKERvY3VtZW50KiwgVGV4dEZpZWxkRGVjb3JhdG9y Kik7CiAgICAgVGV4dEZpZWxkRGVjb3JhdG9yKiB0ZXh0RmllbGREZWNvcmF0b3IoKSB7IHJldHVy biBtX3RleHRGaWVsZERlY29yYXRvcjsgfQorICAgIHZvaWQgZGVjb3JhdGUoSFRNTElucHV0RWxl bWVudCopOwogCiBwcml2YXRlOgogICAgIFRleHRGaWVsZERlY29yYXRpb25FbGVtZW50KERvY3Vt ZW50KiwgVGV4dEZpZWxkRGVjb3JhdG9yKik7Cg== 134499 2012-03-28 22:17:14 -0700 2012-03-28 23:00:39 -0700 Patch 2 bug-82572-20120329141713.patch text/plain 4628 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmE5ZWQyYTczYTY4Y2Ux YzQ4NDQ1N2E3YmQ1ZDQzOWM1MWQ2MWZiMC4uZjk3MDE1ZDhkZTUwYTA5NDBmZTI0Y2UwZWJlMDI1 NTY1YTVhMjYyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAzLTI4ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgVGV4dEZpZWxkRGVj b3JhdGlvbkVsZW1lbnQ6OmRlY29yYXRlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTgyNTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2Ugd2lsbCBiZSBuZWVkZWQgZm9yIEJ1ZyA4MjE0 My4KKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugb2Ygbm8gYmVoYXZpb3IgY2hhbmdlcyB5 ZXQuIFRoaXMgY29kZSBjaGFuZ2UKKyAgICAgICAgZG9lc24ndCBhZmZlY3Qgbm9uLUNocm9taXVt IHBvcnRzIGZvciBub3cuCisKKyAgICAgICAgKiBkb20vU2hhZG93Um9vdC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTaGFkb3dSb290OjpjcmVhdGUpOgorICAgICAgICBSZW1vdmUgdW5uZWNlc3Nh cnkgYXNzZXJ0aW9uLiBXZSBzaG91bGQgYWxsb3cgbXVsdGlwbGUgVUEgc2hhZG93IHJvb3RzLgor ICAgICAgICAqIGh0bWwvc2hhZG93L1RleHRGaWVsZERlY29yYXRpb25FbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlRleHRGaWVsZERlY29yYXRpb25FbGVtZW50OjpkZWNvcmF0ZSk6Cisg ICAgICAgIEFkZGVkLgorICAgICAgICBUaGlzIGZ1bmN0aW9uIGFkZHMgYW5vdGhlciBTaGFkb3dS b290LCBhbmQgaXQgY29udGFpbnMgb25lIGZsZXhpYmxlIGJveCBjb250YWluZXIuCisgICAgICAg IFRoZSBjb250YWluZXIgY29udGFpbnMgZXhpc3RpbiBTaGFkb3dSb290IGNvbnRlbnQgYW5kIHRo ZSBkZWNvcmF0aW9uIGVsZW1lbnQuCisgICAgICAgICogaHRtbC9zaGFkb3cvVGV4dEZpZWxkRGVj b3JhdGlvbkVsZW1lbnQuaDoKKyAgICAgICAgKFRleHRGaWVsZERlY29yYXRpb25FbGVtZW50KTog QWRkIHRoZSBkZWNsYXJhdGlvbiBvZiBkZWNvcmF0ZSgpLgorCiAyMDEyLTAzLTI3ICBLYXVzYWx5 YSBNYWRodXN1ZGhhbmFuICA8a21hZGh1c3VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDb3Zl cml0eV0gQWRkcmVzcyBzb21lIHVuaW5pdGlhbGl6ZWQgY29uc3RydWN0b3IgdmFsdWVzLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuY3BwIGIvU291cmNlL1dlYkNv cmUvZG9tL1NoYWRvd1Jvb3QuY3BwCmluZGV4IDk3Y2VjOTUyMjZhODgwMWU2NzNhYzIyNTMzYjhl MTVhNDQ4NTE0YmMuLmRhMjE1ZWRjYzNlMTA3MWM3MDJkOTdkMDU3ZDRjMjUyOWYyOWFkNGEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAKQEAgLTExMyw3ICsxMTMsNiBAQCBQYXNzUmVmUHRy PFNoYWRvd1Jvb3Q+IFNoYWRvd1Jvb3Q6OmNyZWF0ZShFbGVtZW50KiBlbGVtZW50LCBTaGFkb3dS b290Q3JlYXRpb25QdQogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKLSAgICBBU1NFUlQocHVy cG9zZSAhPSBDcmVhdGluZ1VzZXJBZ2VudFNoYWRvd1Jvb3QgfHwgIWVsZW1lbnQtPmhhc1NoYWRv d1Jvb3QoKSk7CiAgICAgUmVmUHRyPFNoYWRvd1Jvb3Q+IHNoYWRvd1Jvb3QgPSBhZG9wdFJlZihu ZXcgU2hhZG93Um9vdChlbGVtZW50LT5kb2N1bWVudCgpKSk7CiAKICAgICBlYyA9IDA7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0RmllbGREZWNvcmF0aW9uRWxl bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0RmllbGREZWNvcmF0aW9u RWxlbWVudC5jcHAKaW5kZXggMjZiNTg4Y2M1ZjIyNWJjODcxNTk2ZmM1ZWRhNmFmMWFkZTllNGY2 ZC4uNDQ3MTVlNGIzNzM3ZmE4ZTBiN2VkYjkyMjQ0YTc5YmRhYWQwYzgzMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRGaWVsZERlY29yYXRpb25FbGVt ZW50LmNwcApAQCAtMzEsMTAgKzMxLDE1IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVk ZSAiVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQuaCIKIAorI2luY2x1ZGUgIkNTU1Byb3BlcnR5 TmFtZXMuaCIKKyNpbmNsdWRlICJDU1NWYWx1ZUtleXdvcmRzLmgiCiAjaW5jbHVkZSAiRXZlbnQu aCIKICNpbmNsdWRlICJIVE1MSW5wdXRFbGVtZW50LmgiCisjaW5jbHVkZSAiSFRNTFNoYWRvd0Vs ZW1lbnQuaCIKICNpbmNsdWRlICJOb2RlUmVuZGVyU3R5bGUuaCIKICNpbmNsdWRlICJSZW5kZXJJ bWFnZS5oIgorI2luY2x1ZGUgIlNoYWRvd1Jvb3QuaCIKKyNpbmNsdWRlICJTaGFkb3dUcmVlLmgi CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtNjEsNiArNjYsMjQgQEAgUGFzc1JlZlB0cjxU ZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudD4gVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQ6OmNy ZWF0ZShEb2N1bWUKICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFRleHRGaWVsZERlY29yYXRpb25F bGVtZW50KGRvY3VtZW50LCBkZWNvcmF0b3IpKTsKIH0KIAordm9pZCBUZXh0RmllbGREZWNvcmF0 aW9uRWxlbWVudDo6ZGVjb3JhdGUoSFRNTElucHV0RWxlbWVudCogaW5wdXQpCit7CisgICAgQVNT RVJUKGlucHV0KTsKKyAgICBTaGFkb3dSb290KiBleGlzdGluZ1Jvb3QgPSBpbnB1dC0+c2hhZG93 VHJlZSgpLT55b3VuZ2VzdFNoYWRvd1Jvb3QoKTsKKyAgICBSZWZQdHI8U2hhZG93Um9vdD4gbmV3 Um9vdCA9IFNoYWRvd1Jvb3Q6OmNyZWF0ZShpbnB1dCwgU2hhZG93Um9vdDo6Q3JlYXRpbmdVc2Vy QWdlbnRTaGFkb3dSb290LCBBU1NFUlRfTk9fRVhDRVBUSU9OKTsKKyAgICBSZWZQdHI8SFRNTERp dkVsZW1lbnQ+IGJveCA9IEhUTUxEaXZFbGVtZW50OjpjcmVhdGUoaW5wdXQtPmRvY3VtZW50KCkp OworICAgIG5ld1Jvb3QtPmFwcGVuZENoaWxkKGJveCk7CisgICAgYm94LT5zZXRJbmxpbmVTdHls ZVByb3BlcnR5KENTU1Byb3BlcnR5RGlzcGxheSwgQ1NTVmFsdWVXZWJraXRCb3gpOworICAgIGJv eC0+c2V0SW5saW5lU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0eVdlYmtpdEJveEFsaWduLCBDU1NW YWx1ZUNlbnRlcik7CisgICAgQVNTRVJUKGV4aXN0aW5nUm9vdCk7CisgICAgQVNTRVJUKGV4aXN0 aW5nUm9vdC0+Y2hpbGROb2RlQ291bnQoKSA9PSAxKTsKKyAgICB0b0hUTUxFbGVtZW50KGV4aXN0 aW5nUm9vdC0+Zmlyc3RDaGlsZCgpKS0+c2V0SW5saW5lU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0 eVdlYmtpdEJveEZsZXgsIDEuMCwgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVIpOworICAg IGJveC0+YXBwZW5kQ2hpbGQoSFRNTFNoYWRvd0VsZW1lbnQ6OmNyZWF0ZShIVE1MTmFtZXM6OnNo YWRvd1RhZywgaW5wdXQtPmRvY3VtZW50KCkpKTsKKworICAgIHNldElubGluZVN0eWxlUHJvcGVy dHkoQ1NTUHJvcGVydHlXZWJraXRCb3hGbGV4LCAwLjAsIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1Nf TlVNQkVSKTsKKyAgICBib3gtPmFwcGVuZENoaWxkKHRoaXMpOworfQorCiBpbmxpbmUgSFRNTElu cHV0RWxlbWVudCogVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQ6Omhvc3RJbnB1dCgpCiB7CiAg ICAgQVNTRVJUKHNoYWRvd0FuY2VzdG9yTm9kZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvc2hhZG93L1RleHRGaWVsZERlY29yYXRpb25FbGVtZW50LmggYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL3NoYWRvdy9UZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudC5oCmluZGV4IDVmYWVi MTcwZTdkMDA3MGU3NDlmM2U5NjMwYjI2OTVkZDgwNmQ2M2IuLjAyMGYyYTUwYWE4YTgzNTVjNmY0 MDgwZTU0ZGM3MTg0YWEzNGQ3MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hh ZG93L1RleHRGaWVsZERlY29yYXRpb25FbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9zaGFkb3cvVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQuaApAQCAtNjMsNiArNjMsNyBAQCBj bGFzcyBUZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudCA6IHB1YmxpYyBIVE1MRGl2RWxlbWVudCB7 CiBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8VGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1l bnQ+IGNyZWF0ZShEb2N1bWVudCosIFRleHRGaWVsZERlY29yYXRvciopOwogICAgIFRleHRGaWVs ZERlY29yYXRvciogdGV4dEZpZWxkRGVjb3JhdG9yKCkgeyByZXR1cm4gbV90ZXh0RmllbGREZWNv cmF0b3I7IH0KKyAgICB2b2lkIGRlY29yYXRlKEhUTUxJbnB1dEVsZW1lbnQqKTsKIAogcHJpdmF0 ZToKICAgICBUZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudChEb2N1bWVudCosIFRleHRGaWVsZERl Y29yYXRvciopOwo=