82567 2012-03-28 20:35:48 -0700 [BlackBerry] Sync up PlatformMouseEvent 2012-03-29 20:32:08 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73144 1 leo.yang leo.yang charles.wei rwlbuis staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 590799 0 leo.yang 2012-03-28 20:35:48 -0700 This is to upstream the blackberry specific changes to PlatformMouseEvent.h and sync up the blackberry specific PlatformMouseEventBlackBerry. 590809 1 134490 leo.yang 2012-03-28 21:05:16 -0700 Created attachment 134490 Patch 591024 2 134490 rwlbuis 2012-03-29 04:13:05 -0700 Comment on attachment 134490 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134490&action=review > Source/WebCore/platform/PlatformMouseEvent.h:60 > + enum MouseInputMethod { PointingDevice, TouchScreen }; Don't we have TouchEvent for TouchScreen? 591816 3 leo.yang 2012-03-29 19:10:21 -0700 (In reply to comment #2) > (From update of attachment 134490 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134490&action=review > > > Source/WebCore/platform/PlatformMouseEvent.h:60 > > + enum MouseInputMethod { PointingDevice, TouchScreen }; > > Don't we have TouchEvent for TouchScreen? For single touch events (touch point press/release, etc), we convert them to PlatformMouse events and send them to WebCore. This is reasonable since single touch is very like mouse click. 591821 4 134490 rwlbuis 2012-03-29 19:29:25 -0700 Comment on attachment 134490 Patch Looks good. 591822 5 leo.yang 2012-03-29 19:32:55 -0700 (In reply to comment #4) > (From update of attachment 134490 [details]) > Looks good. Thanks for your review. 591846 6 134490 webkit.review.bot 2012-03-29 20:32:03 -0700 Comment on attachment 134490 Patch Clearing flags on attachment: 134490 Committed r112641: <http://trac.webkit.org/changeset/112641> 591847 7 webkit.review.bot 2012-03-29 20:32:08 -0700 All reviewed patches have been landed. Closing bug. 134490 2012-03-28 21:05:16 -0700 2012-03-29 20:32:03 -0700 Patch 0001-BlackBerry-Sync-up-PlatformMouseEvent.patch text/plain 4937 leo.yang RnJvbSBkNzdmNGYyNjJmYzlmMDcxZjcxNmE5MmQ3MzNiMDBmN2YwOWYxMmY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBUaHUsIDI5IE1hciAyMDEyIDExOjU2OjU4ICswODAwClN1YmplY3Q6IFtQQVRDSF0g W0JsYWNrQmVycnldIFN5bmMgdXAgUGxhdGZvcm1Nb3VzZUV2ZW50CiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI1NjcKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgoKVGhpcyBwYXRjaCBpcyBhZGRpbmcgYmxhY2tiZXJyeSBzcGVjaWZpYyBtZW1iZXJzIHRvIFBs YXRmb3JtTW91c2VFdmVudC4KQWxzbyByZS1iYXNlIFBsYXRmb3JtTW91c2VFdmVudEJsYWNrQmVy cnkgdG8gYWRhcHQgdG8gdGhlIHJlLWZhY3RvcgpvZiBQbGF0Zm9ybU1vdXNlRXZlbnQuCgoqIHBs YXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5oOgooUGxhdGZvcm1Nb3VzZUV2ZW50KTogQmxhY2tC ZXJyeSBzcGVjaWZpYyBjb25zdHJ1Y3Rvci4KKFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudDo6 aW5wdXRNZXRob2QpOiBJbnB1dCBzb3VyY2Ugb2YgbW91c2UgZXZlbnQKZm9yIGJsYWNrYmVycnkg cGxhdGZvcm0uCiogcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9ybU1vdXNlRXZlbnRCbGFja0Jl cnJ5LmNwcDoKKFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50 KTogUmUtYmFzZSB0aGUgY29uc3RydWN0b3IKdG8gYWRhcHQgdGhlIHJlLWZhY3RvciBvZiBQbGF0 Zm9ybU1vdXNlRXZlbnQuCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE5ICsrKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5oICAgICAgIHwgICAxMCArKysrKysrKysrCiAu Li4vYmxhY2tiZXJyeS9QbGF0Zm9ybU1vdXNlRXZlbnRCbGFja0JlcnJ5LmNwcCAgICB8ICAgMTUg KysrKystLS0tLS0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDEwIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMmE0NDkzLi40NzNiOTRhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMDMtMjggIExlbyBZYW5nICA8bGVvLnlhbmdAdG9yY2htb2Jp bGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTeW5jIHVwIFBsYXRmb3JtTW91c2VF dmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI1 NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IHBhdGNoIGlzIGFkZGluZyBibGFja2JlcnJ5IHNwZWNpZmljIG1lbWJlcnMgdG8gUGxhdGZvcm1N b3VzZUV2ZW50LgorICAgICAgICBBbHNvIHJlLWJhc2UgUGxhdGZvcm1Nb3VzZUV2ZW50QmxhY2tC ZXJyeSB0byBhZGFwdCB0byB0aGUgcmUtZmFjdG9yCisgICAgICAgIG9mIFBsYXRmb3JtTW91c2VF dmVudC4KKworICAgICAgICAqIHBsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5oOgorICAgICAg ICAoUGxhdGZvcm1Nb3VzZUV2ZW50KTogQmxhY2tCZXJyeSBzcGVjaWZpYyBjb25zdHJ1Y3Rvci4K KyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudDo6aW5wdXRNZXRob2QpOiBJbnB1 dCBzb3VyY2Ugb2YgbW91c2UgZXZlbnQKKyAgICAgICAgZm9yIGJsYWNrYmVycnkgcGxhdGZvcm0u CisgICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9ybU1vdXNlRXZlbnRCbGFja0Jl cnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudDo6UGxhdGZvcm1N b3VzZUV2ZW50KTogUmUtYmFzZSB0aGUgY29uc3RydWN0b3IKKyAgICAgICAgdG8gYWRhcHQgdGhl IHJlLWZhY3RvciBvZiBQbGF0Zm9ybU1vdXNlRXZlbnQuCisKIDIwMTItMDMtMjggIEphc29uIExp dSAgPGphc29uLmxpdUB0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnld TWlzc2luZyBjb29raWVzIGZyb20gSFRUUCByZXNwb25zZSBoZWFkZXIgaW4gTmV0d29yayB0YWIg b2YgV2ViIEluc3BlY3Rvci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Bs YXRmb3JtTW91c2VFdmVudC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1Nb3Vz ZUV2ZW50LmgKaW5kZXggMjBhZWNmMS4uNDRjOWY1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vUGxhdGZvcm1Nb3VzZUV2ZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vUGxhdGZvcm1Nb3VzZUV2ZW50LmgKQEAgLTU1LDYgKzU1LDEwIEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICAKICAgICAvLyBUaGVzZSBidXR0b24gbnVtYmVycyBtYXRjaCB0aGUgb25l cyB1c2VkIGluIHRoZSBET00gQVBJLCAwIHRocm91Z2ggMiwgZXhjZXB0IGZvciBOb0J1dHRvbiB3 aGljaCBpc24ndCBzcGVjaWZpZWQuCiAgICAgZW51bSBNb3VzZUJ1dHRvbiB7IE5vQnV0dG9uID0g LTEsIExlZnRCdXR0b24sIE1pZGRsZUJ1dHRvbiwgUmlnaHRCdXR0b24gfTsKKworI2lmIFBMQVRG T1JNKEJMQUNLQkVSUlkpCisgICAgZW51bSBNb3VzZUlucHV0TWV0aG9kIHsgUG9pbnRpbmdEZXZp Y2UsIFRvdWNoU2NyZWVuIH07CisjZW5kaWYKICAgICAKICAgICBjbGFzcyBQbGF0Zm9ybU1vdXNl RXZlbnQgOiBwdWJsaWMgUGxhdGZvcm1FdmVudCB7CiAgICAgcHVibGljOgpAQCAtMTI1LDYgKzEy OSwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFBsYXRmb3JtTW91c2VFdmVudChj b25zdCB3eE1vdXNlRXZlbnQmLCBjb25zdCB3eFBvaW50JiBnbG9iYWxQb2ludCwgaW50IGNsaWNr Q291bnQpOwogI2VuZGlmCiAKKyNpZiBQTEFURk9STShCTEFDS0JFUlJZKQorICAgICAgICBQbGF0 Zm9ybU1vdXNlRXZlbnQoY29uc3QgSW50UG9pbnQmIGV2ZW50UG9zaXRpb24sIGNvbnN0IEludFBv aW50JiBnbG9iYWxQb3NpdGlvbiwgY29uc3QgUGxhdGZvcm1FdmVudDo6VHlwZSwgaW50IGNsaWNr Q291bnQsIE1vdXNlQnV0dG9uLCBNb3VzZUlucHV0TWV0aG9kID0gUG9pbnRpbmdEZXZpY2UpOwor ICAgICAgICBNb3VzZUlucHV0TWV0aG9kIGlucHV0TWV0aG9kKCkgY29uc3QgeyByZXR1cm4gbV9p bnB1dE1ldGhvZDsgfQorI2VuZGlmCiAgICAgcHJvdGVjdGVkOgogICAgICAgICBJbnRQb2ludCBt X3Bvc2l0aW9uOwogICAgICAgICBJbnRQb2ludCBtX2dsb2JhbFBvc2l0aW9uOwpAQCAtMTM5LDYg KzE0Nyw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgaW50IG1fZXZlbnROdW1iZXI7 CiAjZWxpZiBQTEFURk9STShXSU4pCiAgICAgICAgIGJvb2wgbV9kaWRBY3RpdmF0ZVdlYlZpZXc7 CisjZWxpZiBQTEFURk9STShCTEFDS0JFUlJZKQorICAgICAgICBNb3VzZUlucHV0TWV0aG9kIG1f aW5wdXRNZXRob2Q7CiAjZW5kaWYKICAgICB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1BsYXRmb3JtTW91c2VFdmVudEJsYWNrQmVycnkuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9ybU1vdXNlRXZlbnRCbGFj a0JlcnJ5LmNwcAppbmRleCBhMjRhMWQzLi5hOGQ5NjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1BsYXRmb3JtTW91c2VFdmVudEJsYWNrQmVycnkuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUGxhdGZvcm1Nb3VzZUV2 ZW50QmxhY2tCZXJyeS5jcHAKQEAgLTIzLDIwICsyMywxNSBAQAogCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKLVBsYXRmb3JtTW91c2VFdmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50KGNvbnN0IEludFBv aW50JiBldmVudFBvcywgY29uc3QgSW50UG9pbnQmIGdsb2JhbFBvcywgY29uc3QgTW91c2VFdmVu dFR5cGUgdHlwZSwgaW50IGNsaWNrQ291bnQsIE1vdXNlQnV0dG9uIGJ1dHRvbiwgTW91c2VJbnB1 dE1ldGhvZCBtZXRob2QpCi0gICAgOiBtX3Bvc2l0aW9uKGV2ZW50UG9zKQotICAgICwgbV9nbG9i YWxQb3NpdGlvbihnbG9iYWxQb3MpCitQbGF0Zm9ybU1vdXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VF dmVudChjb25zdCBJbnRQb2ludCYgZXZlbnRQb3NpdGlvbiwgY29uc3QgSW50UG9pbnQmIGdsb2Jh bFBvc2l0aW9uLCBjb25zdCBQbGF0Zm9ybUV2ZW50OjpUeXBlIHR5cGUsIGludCBjbGlja0NvdW50 LCBNb3VzZUJ1dHRvbiBidXR0b24sIE1vdXNlSW5wdXRNZXRob2QgbWV0aG9kKQorICAgIDogUGxh dGZvcm1FdmVudCh0eXBlLCBmYWxzZSwgZmFsc2UsIGZhbHNlLCBmYWxzZSwgY3VycmVudFRpbWUo KSkKKyAgICAsIG1fcG9zaXRpb24oZXZlbnRQb3NpdGlvbikKKyAgICAsIG1fZ2xvYmFsUG9zaXRp b24oZ2xvYmFsUG9zaXRpb24pCiAgICAgLCBtX2J1dHRvbihidXR0b24pCi0gICAgLCBtX2V2ZW50 VHlwZSh0eXBlKQogICAgICwgbV9jbGlja0NvdW50KGNsaWNrQ291bnQpCi0gICAgLCBtX3NoaWZ0 S2V5KGZhbHNlKQotICAgICwgbV9jdHJsS2V5KGZhbHNlKQotICAgICwgbV9hbHRLZXkoZmFsc2Up Ci0gICAgLCBtX21ldGFLZXkoZmFsc2UpCi0gICAgLCBtX3RpbWVzdGFtcChjdXJyZW50VGltZSgp KQogICAgICwgbV9pbnB1dE1ldGhvZChtZXRob2QpCiB7Ci0gICAgQVNTRVJUKHR5cGUgIT0gTW91 c2VFdmVudFNjcm9sbCk7CisgICAgQVNTRVJUKHR5cGUgIT0gTW91c2VTY3JvbGwpOwogfQogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCi0tIAoxLjcuNS40Cgo=