82561 2012-03-28 18:43:33 -0700 Fix return type for virtual borderBoundingBox method 2012-03-30 17:53:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 eae eae eric leviw webkit.review.bot oldest_to_newest 590720 0 eae 2012-03-28 18:43:33 -0700 The pure virtual definition of borderBoundingBox currently has it return a LayoutRect yet the actualv implementation returns an IntRect. 590742 1 134476 eae 2012-03-28 19:02:50 -0700 Created attachment 134476 Patch 592659 2 134476 eric 2012-03-30 16:55:16 -0700 Comment on attachment 134476 Patch OK. 592692 3 134476 webkit.review.bot 2012-03-30 17:53:08 -0700 Comment on attachment 134476 Patch Clearing flags on attachment: 134476 Committed r112756: <http://trac.webkit.org/changeset/112756> 592693 4 webkit.review.bot 2012-03-30 17:53:12 -0700 All reviewed patches have been landed. Closing bug. 134476 2012-03-28 19:02:50 -0700 2012-03-30 17:53:08 -0700 Patch bug-82561-20120328190249.patch text/plain 5263 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjQ4OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBACisyMDEyLTAzLTI4ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggcmV0dXJuIHR5cGUgZm9y IHZpcnR1YWwgYm9yZGVyQm91bmRpbmdCb3ggbWV0aG9kCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjU2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGZ1bmN0 aW9uYWxpdHkuCisKKyAgICAgICAgKiBlZGl0aW5nL0RlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6aXNEZWxldGFibGVFbGVtZW50KToKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyQm94Lmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OmJvcmRlckJv eFJlY3QpOgorICAgICAgICBSZW5hbWUgcGl4ZWxTbmFwcGVkQm9yZGVyQm94UmVjdCB0byBib3Jk ZXJCb3hSZWN0IGFuZCByZW1vdmUgTGF5b3V0UmVjdAorICAgICAgICB2ZXJzaW9uIG9mIHNhbWUg YXMgd2UgYWx3YXlzIHdhbnQgdG8gdXNlIHRoZSBwaXhlbCBzbmFwcGVkIHZlcnNpb24gdG8KKyAg ICAgICAgZW5zdXJlIHByb3BlciByb3VuZGluZyBhbmQgYWxpZ25tZW50IHRvIGRldmljZSBwaXhl bHMuCisgICAgICAgIChUaGUgd2F5IHRoaXMgcmVjdCBpcyBwaXhlbCBzbmFwcGVkLCB1c2luZyB0 aGUgbV9mcmFtZVJlY3QgbG9jYXRpb24sCisgICAgICAgIG1ha2VzIGl0IGhhcmQgZm9yIGNhbGxp bmcgY29kZSB0byB0YWtlIHRoZSBzdWJwaXhlbCByZWN0IGFuZCBjb3JyZWN0bHkKKyAgICAgICAg c25hcCBpdCkuCisKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6Ym9yZGVyQm91bmRpbmdC b3gpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oOgorICAgICAg ICBDaGFuZ2UgcHVyZSB2aXJ0dWFsIGRlZmluaXRpb24gb2YgYm9yZGVyQm91bmRpbmdCb3ggdG8g cmV0dXJuIGFuIEludFJlY3QKKyAgICAgICAgdG8gbWF0Y2ggaW1wbGVtZW50YXRpb24gaW4gUmVu ZGVyQm94LgorICAgICAgICAKKyAgICAgICAgKFJlbmRlckJveE1vZGVsT2JqZWN0KToKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVySW5saW5lLmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJJ bmxpbmU6OmJvcmRlckJvdW5kaW5nQm94KToKKyAgICAgICAgQ2hhbmdlIG92ZXJsb2FkZWQgbWV0 aG9kIHRvIEludFJlY3QgdG8gbWF0Y2ggUmVuZGVyQm94IGltcGxlbWVudGF0aW9uLgorCiAyMDEy LTAzLTI4ICBLZW5pY2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXNwZWN0cyBmb250IGZhbGxiYWNrIGxpc3QgZHVyaW5nIHdlYmZvbnRzIGFyZSBsb2FkaW5n CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRlQnV0dG9uQ29udHJv bGxlci5jcHAJKHJldmlzaW9uIDExMjQ1MykKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVs ZXRlQnV0dG9uQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkyLDcgKzkyLDcgQEAg c3RhdGljIGJvb2wgaXNEZWxldGFibGVFbGVtZW50KGNvbnN0IE5vZAogICAgICAgICByZXR1cm4g ZmFsc2U7CiAKICAgICBSZW5kZXJCb3gqIGJveCA9IHRvUmVuZGVyQm94KHJlbmRlcmVyKTsKLSAg ICBMYXlvdXRSZWN0IGJvcmRlckJvdW5kaW5nQm94ID0gYm94LT5ib3JkZXJCb3VuZGluZ0JveCgp OworICAgIEludFJlY3QgYm9yZGVyQm91bmRpbmdCb3ggPSBib3gtPmJvcmRlckJvdW5kaW5nQm94 KCk7CiAgICAgaWYgKGJvcmRlckJvdW5kaW5nQm94LndpZHRoKCkgPCBtaW5pbXVtV2lkdGggfHwg Ym9yZGVyQm91bmRpbmdCb3guaGVpZ2h0KCkgPCBtaW5pbXVtSGVpZ2h0KQogICAgICAgICByZXR1 cm4gZmFsc2U7CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgJKHJldmlz aW9uIDExMjQ1MykKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaAkod29y a2luZyBjb3B5KQpAQCAtMTMyLDEwICsxMzIsOCBAQCBwdWJsaWM6CiAgICAgTGF5b3V0UmVjdCBm cmFtZVJlY3QoKSBjb25zdCB7IHJldHVybiBtX2ZyYW1lUmVjdDsgfQogICAgIHZvaWQgc2V0RnJh bWVSZWN0KGNvbnN0IExheW91dFJlY3QmIHJlY3QpIHsgbV9mcmFtZVJlY3QgPSByZWN0OyB9CiAK LSAgICAvLyBGSVhNRTogV2Ugc2hvdWxkbid0IGJlIHJldHVybmluZyB0aGlzIGFzIGEgTGF5b3V0 UmVjdCwgc2luY2UgaXQgbG9zZXMgaXRzIHBvc2l0aW9uIGFuZCB3b24ndCBwcm9wZXJseSBwaXhl bCBzbmFwLgotICAgIExheW91dFJlY3QgYm9yZGVyQm94UmVjdCgpIGNvbnN0IHsgcmV0dXJuIExh eW91dFJlY3QoTGF5b3V0UG9pbnQoKSwgc2l6ZSgpKTsgfQotICAgIEludFJlY3QgcGl4ZWxTbmFw cGVkQm9yZGVyQm94UmVjdCgpIGNvbnN0IHsgcmV0dXJuIEludFJlY3QoSW50UG9pbnQoKSwgSW50 U2l6ZShtX2ZyYW1lUmVjdC5waXhlbFNuYXBwZWRXaWR0aCgpLCBtX2ZyYW1lUmVjdC5waXhlbFNu YXBwZWRIZWlnaHQoKSkpOyB9Ci0gICAgdmlydHVhbCBJbnRSZWN0IGJvcmRlckJvdW5kaW5nQm94 KCkgY29uc3QgeyByZXR1cm4gcGl4ZWxTbmFwcGVkQm9yZGVyQm94UmVjdCgpOyB9CisgICAgSW50 UmVjdCBib3JkZXJCb3hSZWN0KCkgY29uc3QgeyByZXR1cm4gSW50UmVjdChJbnRQb2ludCgpLCBJ bnRTaXplKG1fZnJhbWVSZWN0LnBpeGVsU25hcHBlZFdpZHRoKCksIG1fZnJhbWVSZWN0LnBpeGVs U25hcHBlZEhlaWdodCgpKSk7IH0KKyAgICB2aXJ0dWFsIEludFJlY3QgYm9yZGVyQm91bmRpbmdC b3goKSBjb25zdCB7IHJldHVybiBib3JkZXJCb3hSZWN0KCk7IH0gCiAKICAgICAvLyBUaGUgY29u dGVudCBhcmVhIG9mIHRoZSBib3ggKGV4Y2x1ZGVzIHBhZGRpbmcgYW5kIGJvcmRlcikuCiAgICAg TGF5b3V0UmVjdCBjb250ZW50Qm94UmVjdChQYWRkaW5nT3B0aW9ucyBwYWRkaW5nT3B0aW9uID0g RXhjbHVkZUludHJpbnNpY1BhZGRpbmcpIGNvbnN0IHsgcmV0dXJuIExheW91dFJlY3QoYm9yZGVy TGVmdCgpICsgcGFkZGluZ0xlZnQocGFkZGluZ09wdGlvbiksIGJvcmRlclRvcCgpICsgcGFkZGlu Z1RvcChwYWRkaW5nT3B0aW9uKSwgY29udGVudFdpZHRoKHBhZGRpbmdPcHRpb24pLCBjb250ZW50 SGVpZ2h0KHBhZGRpbmdPcHRpb24pKTsgfQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveE1vZGVsT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmgJKHJldmlzaW9uIDExMjQ1MykKKysrIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oCSh3b3JraW5nIGNvcHkp CkBAIC03Nyw3ICs3Nyw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgcmVxdWlyZXNMYXll cigpIGNvbnN0IHsgcmV0dXJuIGlzUm9vdCgpIHx8IGlzUG9zaXRpb25lZCgpIHx8IGlzUmVsUG9z aXRpb25lZCgpIHx8IGlzVHJhbnNwYXJlbnQoKSB8fCBoYXNUcmFuc2Zvcm0oKSB8fCBoYXNIaWRk ZW5CYWNrZmFjZSgpIHx8IGhhc01hc2soKSB8fCBoYXNSZWZsZWN0aW9uKCkgfHwgaGFzRmlsdGVy KCkgfHwgc3R5bGUoKS0+c3BlY2lmaWVzQ29sdW1ucygpOyB9CiAKICAgICAvLyBUaGlzIHdpbGwg d29yayBvbiBpbmxpbmVzIHRvIHJldHVybiB0aGUgYm91bmRpbmcgYm94IG9mIGFsbCBvZiB0aGUg bGluZXMnIGJvcmRlciBib3hlcy4KLSAgICB2aXJ0dWFsIExheW91dFJlY3QgYm9yZGVyQm91bmRp bmdCb3goKSBjb25zdCA9IDA7CisgICAgdmlydHVhbCBJbnRSZWN0IGJvcmRlckJvdW5kaW5nQm94 KCkgY29uc3QgPSAwOwogCiAgICAgLy8gVmlydHVhbCBzaW5jZSB0YWJsZSBjZWxscyBvdmVycmlk ZQogICAgIHZpcnR1YWwgTGF5b3V0VW5pdCBwYWRkaW5nVG9wKFBhZGRpbmdPcHRpb25zID0gSW5j bHVkZUludHJpbnNpY1BhZGRpbmcpIGNvbnN0OwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlcklubGluZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJJbmxpbmUuaAkocmV2aXNpb24gMTEyNDUzKQorKysgU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlcklubGluZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzQsMTAgKzEzNCwxMCBA QCBwcml2YXRlOgogCiAgICAgdmlydHVhbCBWaXNpYmxlUG9zaXRpb24gcG9zaXRpb25Gb3JQb2lu dChjb25zdCBMYXlvdXRQb2ludCYpOwogCi0gICAgdmlydHVhbCBMYXlvdXRSZWN0IGJvcmRlckJv dW5kaW5nQm94KCkgY29uc3QKKyAgICB2aXJ0dWFsIEludFJlY3QgYm9yZGVyQm91bmRpbmdCb3go KSBjb25zdAogICAgIHsKLSAgICAgICAgTGF5b3V0UmVjdCBib3VuZGluZ0JveCA9IGxpbmVzQm91 bmRpbmdCb3goKTsKLSAgICAgICAgcmV0dXJuIExheW91dFJlY3QoMCwgMCwgYm91bmRpbmdCb3gu d2lkdGgoKSwgYm91bmRpbmdCb3guaGVpZ2h0KCkpOworICAgICAgICBJbnRSZWN0IGJvdW5kaW5n Qm94ID0gbGluZXNCb3VuZGluZ0JveCgpOworICAgICAgICByZXR1cm4gSW50UmVjdCgwLCAwLCBi b3VuZGluZ0JveC53aWR0aCgpLCBib3VuZGluZ0JveC5oZWlnaHQoKSk7CiAgICAgfQogCiAgICAg dmlydHVhbCBJbmxpbmVGbG93Qm94KiBjcmVhdGVJbmxpbmVGbG93Qm94KCk7IC8vIFN1YmNsYXNz ZWQgYnkgU1ZHIGFuZCBSdWJ5Cg==