82559 2012-03-28 18:07:44 -0700 Fix a crash and an assertion when recovering from a web process crash 2012-03-28 18:51:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 590688 0 andersca 2012-03-28 18:07:44 -0700 Fix a crash and an assertion when recovering from a web process crash 590690 1 134459 andersca 2012-03-28 18:08:49 -0700 Created attachment 134459 Patch 590693 2 134459 mrowe 2012-03-28 18:10:13 -0700 Comment on attachment 134459 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134459&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:2932 > + if (_data->_page->drawingArea()) > + _data->_page->drawingArea()->waitForPossibleGeometryUpdate(); Maybe introduce a local to avoid dereferencing / calling _data->_page->drawingArea() twice in a row? 590726 3 andersca 2012-03-28 18:51:03 -0700 Committed r112491: <http://trac.webkit.org/changeset/112491> 134459 2012-03-28 18:08:49 -0700 2012-03-28 18:10:12 -0700 Patch bug-82559-20120328180955.patch text/plain 1911 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2YyODQyZjhhMmFmYjhi NzlhYjBhMDQzYjRlN2FjZjJlMjhlNTFhYy4uMjMzYTU0NDI2ZTJhZDExMmJlNTNiZmZjZjQxMmQ5 NDMwODUzNTJiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTAzLTI4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IGEgY3Jhc2gg YW5kIGFuIGFzc2VydGlvbiB3aGVuIHJlY292ZXJpbmcgZnJvbSBhIHdlYiBwcm9jZXNzIGNyYXNo CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjU1OQor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTA5MDI1NzQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06 CisgICAgICAgICgtW1dLVmlldyBfcHJvY2Vzc0RpZENyYXNoXSk6CisgICAgICAgIElmIHdlJ3Jl IGN1cnJlbnRseSBpbiBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBtb2RlLCBleGl0LgorCisgICAg ICAgICgtW1dLVmlldyB1cGRhdGVMYXllcl0pOgorICAgICAgICBHdWFyZCBhZ2FpbnN0IGEgbnVs bCBkcmF3aW5nIGFyZWEuCisKKzIwMTItMDMtMjggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KKwogICAgICAgICBNYXNzaXZlIGxhZyBvcGVuaW5nIGEgbGluayBpbiBhIG5l dyBiYWNrZ3JvdW5kIHRhYgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODI1NDIKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExMDA0NTAyPgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCmluZGV4IDE4NWJhOGYzZGZiMjJh NzJkN2VjMjlkZGE1ZDBhZjBjODliNTRhNjkuLmNiYmFmMDYxOTY0YjIyMzZmYmRiMmMyNTNjMThk MDY3OGI3MmVmYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFj L1dLVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcu bW0KQEAgLTIyMTYsNiArMjIxNiw5IEBAIHN0YXRpYyB2b2lkIGRyYXdQYWdlQmFja2dyb3VuZChD R0NvbnRleHRSZWYgY29udGV4dCwgV2ViUGFnZVByb3h5KiBwYWdlLCBjb25zdCBJCiAKIC0gKHZv aWQpX3Byb2Nlc3NEaWRDcmFzaAogeworICAgIGlmIChfZGF0YS0+X2xheWVySG9zdGluZ1ZpZXcp CisgICAgICAgIFtzZWxmIF9leGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGVdOworCiAgICAg W3NlbGYgX3VwZGF0ZVJlbW90ZUFjY2Vzc2liaWxpdHlSZWdpc3RyYXRpb246Tk9dOwogfQogCkBA IC0yOTI0LDcgKzI5MjcsOSBAQCBzdGF0aWMgTlNTdHJpbmcgKnBhdGhXaXRoVW5pcXVlRmlsZW5h bWVGb3JQYXRoKE5TU3RyaW5nICpwYXRoKQogLSAodm9pZCl1cGRhdGVMYXllcgogewogICAgIHNl bGYubGF5ZXIuYmFja2dyb3VuZENvbG9yID0gQ0dDb2xvckdldENvbnN0YW50Q29sb3Ioa0NHQ29s b3JXaGl0ZSk7Ci0gICAgX2RhdGEtPl9wYWdlLT5kcmF3aW5nQXJlYSgpLT53YWl0Rm9yUG9zc2li bGVHZW9tZXRyeVVwZGF0ZSgpOworCisgICAgaWYgKF9kYXRhLT5fcGFnZS0+ZHJhd2luZ0FyZWEo KSkKKyAgICAgICAgX2RhdGEtPl9wYWdlLT5kcmF3aW5nQXJlYSgpLT53YWl0Rm9yUG9zc2libGVH ZW9tZXRyeVVwZGF0ZSgpOwogfQogI2VuZGlmCiAK