82558 2012-03-28 18:06:03 -0700 Toggling <input type="range"> readonly or disabled state while active breaks all click events 2017-04-05 08:36:45 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170447 P2 Normal --- 1 joepeck joepeck dglazkov joepeck tkent webkit.review.bot oldest_to_newest 590685 0 134458 joepeck 2012-03-28 18:06:03 -0700 Created attachment 134458 [REDUCTION] Test Case See attached reduction. If a user is actively dragging a slider and it toggles its readonly / disabled state buttons, other sliders, etc. stop working. 590686 1 joepeck 2012-03-28 18:07:25 -0700 My guess is that we miss a call to SliderThumbElement::stopDragging at some point to clear the global capturing mouse events node: frame->eventHandler()->setCapturingMouseEventsNode(0); 590714 2 joepeck 2012-03-28 18:37:53 -0700 Yep, calling stopDragging() when fixes the issue. There are a couple different ways to fix this. I'm going to put up a few patches and let you know which one I recommend. I'm in the process of doing a build. 590737 3 134472 joepeck 2012-03-28 19:00:37 -0700 Created attachment 134472 [PATCH] Proposed Fix 1: Stop Dragging when readonly / disabled state toggles 590739 4 134474 joepeck 2012-03-28 19:01:18 -0700 Created attachment 134474 [PATCH] Proposed Fix 2: Stop Dragging in the early bail 590741 5 webkit.review.bot 2012-03-28 19:02:41 -0700 Attachment 134472 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:10: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 590743 6 tkent 2012-03-28 19:04:04 -0700 I like Proposed Fix 2 because of simplicity. 590750 7 joepeck 2012-03-28 19:11:24 -0700 (In reply to comment #6) > I like Proposed Fix 2 because of simplicity. I wonder if we should take both. • Proposed Fix 1 - this would stop an active drag if the input is changed to disabled and back quickly. • Proposed Fix 2 - any early return should logically stop the drag. Should I spend time trying to make a test for this? 590755 8 joepeck 2012-03-28 19:13:42 -0700 I see there is: LayoutTests/fast/forms/range/range-drag.html I'll see if I can make a test for this. 590780 9 134483 joepeck 2012-03-28 20:11:43 -0700 Created attachment 134483 [PATCH] Fix with test Now with test! The question now is if we want the following scenario to work. 1. User starts dragging 2. <input> becomes disabled 3. <input> becomes enabled 4. User continues dragging. The test does not really test this scenario, it only really tests that mouse events don't stop working when a toggle during an active drag happens. 590783 10 134484 joepeck 2012-03-28 20:13:10 -0700 Created attachment 134484 [TEXT] Expected Results Before Patch This is to show that the test does change from before and after. This is the before, note that the attempt to drag the second slider fails. 590906 11 134483 tkent 2012-03-29 00:29:12 -0700 Comment on attachment 134483 [PATCH] Fix with test ok 591337 12 134483 webkit.review.bot 2012-03-29 11:11:57 -0700 Comment on attachment 134483 [PATCH] Fix with test Clearing flags on attachment: 134483 Committed r112547: <http://trac.webkit.org/changeset/112547> 591338 13 webkit.review.bot 2012-03-29 11:12:03 -0700 All reviewed patches have been landed. Closing bug. 134458 2012-03-28 18:06:03 -0700 2012-03-28 18:06:03 -0700 [REDUCTION] Test Case slider-toggle-reduction.html text/html 1206 joepeck PHByZT4KU1RFUFMgVE8gUkVQUk9EVUNFOgoxLiBDbGljayBlaXRoZXIgb2YgdGhlIHRvZ2dsZSBi dXR0b25zLiBUaGV5IHdpbGwgc2V0IGByZWFkb25seWAgb3IgYGRpc2FibGVkYCBvbiB0aGUgc2xp ZGVyIGFmdGVyIDEgc2Vjb25kLgoyLiBRdWlja2x5IHN0YXJ0IGRyYWdnaW5nIHRoZSBzbGlkZXIg YW5kIGtlZXAgZHJhZ2dpbmcgaXQgdW50aWwgdGhlIGlucHV0IGhhcyBpdHMgc3RhdGUgdG9nZ2xl ZC4KMy4gVGhlIEFMRVJUIGJ1dHRvbiBubyBsb25nZXIgd29ya3MuIEFsbCBjbGljayBldmVudHMg YXJlIGJyb2tlbi4uLgo8L3ByZT4KCjxidXR0b24gb25jbGljaz0iYWxlcnQoMSkiPkFMRVJUPC9i dXR0b24+Cgo8aW5wdXQgaWQ9IngiIHR5cGU9InJhbmdlIj4KPGJ1dHRvbiBpZD0idG9nZ2xlLXIi PlRvZ2dsZSByZWFkb25seSBEZWxheWVkPC9idXR0b24+CjxidXR0b24gaWQ9InRvZ2dsZS1kIj5U b2dnbGUgZGlzYWJsZWQgRGVsYXllZDwvYnV0dG9uPgo8cHJlPgpyZWFkb25seTogPHNwYW4gaWQ9 InIiPjwvc3Bhbj4KZGlzYWJsZWQ6IDxzcGFuIGlkPSJkIj48L3NwYW4+CjwvcHJlPgoKPHNjcmlw dD4KY29uc3QgREVMQVkgPSAxMDAwOwp2YXIgc2xpZGVyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ3gnKTsKCmRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0b2dnbGUtcicpLm9uY2xpY2sgPSBm dW5jdGlvbigpIHsKICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CiAgICAgICAgc2xpZGVyLnJl YWRPbmx5ID0gIXNsaWRlci5yZWFkT25seTsKICAgICAgICB1cGRhdGVTdHJpbmdzKCk7CiAgICB9 LCBERUxBWSk7Cn0KCmRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0b2dnbGUtZCcpLm9uY2xpY2sg PSBmdW5jdGlvbigpIHsKICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CiAgICAgICAgc2xpZGVy LmRpc2FibGVkID0gIXNsaWRlci5kaXNhYmxlZDsKICAgICAgICB1cGRhdGVTdHJpbmdzKCk7CiAg ICB9LCBERUxBWSk7Cn0KCmZ1bmN0aW9uIHVwZGF0ZVN0cmluZ3MoKSB7CiAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgncicpLnRleHRDb250ZW50ID0gc2xpZGVyLnJlYWRPbmx5ID8gInRydWUi IDogImZhbHNlIjsKICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdkJykudGV4dENvbnRlbnQg PSBzbGlkZXIuZGlzYWJsZWQgPyAidHJ1ZSIgOiAiZmFsc2UiOwp9CnVwZGF0ZVN0cmluZ3MoKTsK PC9zY3JpcHQ+ 134472 2012-03-28 19:00:37 -0700 2012-03-28 20:11:43 -0700 [PATCH] Proposed Fix 1: Stop Dragging when readonly / disabled state toggles possible-fix-1.patch text/plain 3471 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5YTdjODUzLi4zODExN2RlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTItMDMtMjggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi84MjU1OD4gVG9nZ2xpbmcgPGlucHV0IHR5cGU9 InJhbmdlIj4gcmVhZG9ubHkgb3IgZGlzYWJsZWQgc3RhdGUgd2hpbGUgYWN0aXZlIGJyZWFrcyBh bGwgY2xpY2sgZXZlbnRzCisKKyAgICAgICAgRW5zdXJlIHdlIHN0b3AgYW5kIGNsZWFuIHVwIGRy YWdnaW5nIHByb3Blcmx5IHdoZW4gcmVhZG9ubHkgb3IKKyAgICAgICAgZGlzYWJsZWQgc3RhdGUg Y2hhbmdlcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGh0bWwvUmFuZ2VJbnB1dFR5cGUu aDoKKyAgICAgICAgKiBodG1sL1JhbmdlSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJhbmdlSW5wdXRUeXBlOjpkaXNhYmxlZEF0dHJpYnV0ZUNoYW5nZWQpOgorICAgICAgICAoV2Vi Q29yZTo6UmFuZ2VJbnB1dFR5cGU6OnJlYWRvbmx5QXR0cmlidXRlQ2hhbmdlZCk6CisgICAgICAg IFdoZW4gdG9nZ2xpbmcgcmVhZG9ubHkgb3IgZGlzYWJsZWQgc3RhdGVzIG9uIGEgcmFuZ2UgaW5w dXQsIGxldCB0aGUgc2xpZGVyIGtub3cuCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9TbGlkZXJU aHVtYkVsZW1lbnQuaDoKKyAgICAgICAgKiBodG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U2xpZGVyVGh1bWJFbGVtZW50OjpkaXNhYmxlZE9yUmVh ZG9ubHlBdHRyaWJ1dGVDaGFuZ2VkKToKKyAgICAgICAgV2hlbiByZWFkb25seSBvciBkaXNhYmxl ZCBzdGF0ZXMgdG9nZ2xlIGNhbmNlbCBhbnkgYWN0aXZlIGRyYWdzLgorCiAyMDEyLTAzLTI3ICBE YW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0g UmVuYW1lIG9wYXF1ZUNvbnRlbnRzUmVnaW9uKCkgdG8gdmlzaWJsZUNvbnRlbnRPcGFxdWVSZWdp b24oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9SYW5nZUlucHV0VHlwZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL1JhbmdlSW5wdXRUeXBlLmNwcAppbmRleCA0ZmFmNzg2Li41 NTI0NjE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1JhbmdlSW5wdXRUeXBlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1JhbmdlSW5wdXRUeXBlLmNwcApAQCAtMzE2LDQg KzMxNiwxNCBAQCBib29sIFJhbmdlSW5wdXRUeXBlOjpzaG91bGRSZXNwZWN0TGlzdEF0dHJpYnV0 ZSgpCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKK3ZvaWQgUmFuZ2VJbnB1dFR5cGU6OmRpc2FibGVk QXR0cmlidXRlQ2hhbmdlZCgpCit7CisgICAgc2xpZGVyVGh1bWJFbGVtZW50T2YoZWxlbWVudCgp KS0+ZGlzYWJsZWRPclJlYWRvbmx5QXR0cmlidXRlQ2hhbmdlZCgpOworfQorCit2b2lkIFJhbmdl SW5wdXRUeXBlOjpyZWFkb25seUF0dHJpYnV0ZUNoYW5nZWQoKQoreworICAgIHNsaWRlclRodW1i RWxlbWVudE9mKGVsZW1lbnQoKSktPmRpc2FibGVkT3JSZWFkb25seUF0dHJpYnV0ZUNoYW5nZWQo KTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9SYW5nZUlucHV0VHlwZS5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9SYW5nZUlucHV0 VHlwZS5oCmluZGV4IGFiZjJlYTYuLjUwNmE2OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvUmFuZ2VJbnB1dFR5cGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1JhbmdlSW5w dXRUeXBlLmgKQEAgLTcwLDYgKzcwLDggQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIFN0cmluZyBm YWxsYmFja1ZhbHVlKCkgY29uc3QgT1ZFUlJJREU7CiAgICAgdmlydHVhbCBTdHJpbmcgc2FuaXRp emVWYWx1ZShjb25zdCBTdHJpbmcmIHByb3Bvc2VkVmFsdWUpIGNvbnN0IE9WRVJSSURFOwogICAg IHZpcnR1YWwgYm9vbCBzaG91bGRSZXNwZWN0TGlzdEF0dHJpYnV0ZSgpIE9WRVJSSURFOworICAg IHZpcnR1YWwgdm9pZCBkaXNhYmxlZEF0dHJpYnV0ZUNoYW5nZWQoKSBPVkVSUklERTsKKyAgICB2 aXJ0dWFsIHZvaWQgcmVhZG9ubHlBdHRyaWJ1dGVDaGFuZ2VkKCkgT1ZFUlJJREU7CiB9OwogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3No YWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cv U2xpZGVyVGh1bWJFbGVtZW50LmNwcAppbmRleCAxNjRjYmZiLi4yMWI4MmIzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1NsaWRlclRodW1iRWxlbWVudC5jcHAKQEAgLTE3 OCw2ICsxNzgsMTEgQEAgdm9pZCBTbGlkZXJUaHVtYkVsZW1lbnQ6OnNldFBvc2l0aW9uRnJvbVZh bHVlKCkKICAgICAgICAgcmVuZGVyZXIoKS0+c2V0TmVlZHNMYXlvdXQodHJ1ZSk7CiB9CiAKK3Zv aWQgU2xpZGVyVGh1bWJFbGVtZW50OjpkaXNhYmxlZE9yUmVhZG9ubHlBdHRyaWJ1dGVDaGFuZ2Vk KCkKK3sKKyAgICBzdG9wRHJhZ2dpbmcoKTsKK30KKwogUmVuZGVyT2JqZWN0KiBTbGlkZXJUaHVt YkVsZW1lbnQ6OmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5hKiBhcmVuYSwgUmVuZGVyU3R5bGUq KQogewogICAgIHJldHVybiBuZXcgKGFyZW5hKSBSZW5kZXJTbGlkZXJUaHVtYih0aGlzKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1NsaWRlclRodW1iRWxlbWVudC5o IGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmgKaW5kZXgg ZTJkOGI2Ni4uODljZWU2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cv U2xpZGVyVGh1bWJFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvU2xp ZGVyVGh1bWJFbGVtZW50LmgKQEAgLTUxLDYgKzUxLDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBQ YXNzUmVmUHRyPFNsaWRlclRodW1iRWxlbWVudD4gY3JlYXRlKERvY3VtZW50Kik7CiAKICAgICB2 b2lkIHNldFBvc2l0aW9uRnJvbVZhbHVlKCk7CisgICAgdm9pZCBkaXNhYmxlZE9yUmVhZG9ubHlB dHRyaWJ1dGVDaGFuZ2VkKCk7CiAKICAgICB2b2lkIGRyYWdGcm9tKGNvbnN0IExheW91dFBvaW50 Jik7CiAgICAgdmlydHVhbCB2b2lkIGRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqKTsK 134474 2012-03-28 19:01:18 -0700 2012-03-28 20:11:43 -0700 [PATCH] Proposed Fix 2: Stop Dragging in the early bail possible-fix-2.patch text/plain 1476 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5YTdjODUzLi4wNmY3OGZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTItMDMtMjggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi84MjU1OD4gVG9nZ2xpbmcgPGlucHV0IHR5cGU9 InJhbmdlIj4gcmVhZG9ubHkgb3IgZGlzYWJsZWQgc3RhdGUgd2hpbGUgYWN0aXZlIGJyZWFrcyBh bGwgY2xpY2sgZXZlbnRzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBodG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U2xpZGVyVGh1bWJFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKToKKyAgICAg ICAgQSBzbGlkZXIgY2FuIHRvZ2dsZSBpdHMgcmVhZG9ubHkgb3IgZGlzYWJsZWQgc3RhdGUgd2hp bGUgaW4gdGhlIG1pZGRsZQorICAgICAgICBvZiBkcmFnZ2luZywgaW4gdGhvc2UgY2FzZXMgd2Ug c2hvdWxkIGNhbmNlbCB0aGUgZHJhZyBhbmQgcGVyZm9ybSBjbGVhbnVwLgorCiAyMDEyLTAzLTI3 ICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1 bV0gUmVuYW1lIG9wYXF1ZUNvbnRlbnRzUmVnaW9uKCkgdG8gdmlzaWJsZUNvbnRlbnRPcGFxdWVS ZWdpb24oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvU2xpZGVyVGh1 bWJFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1NsaWRlclRodW1iRWxl bWVudC5jcHAKaW5kZXggMTY0Y2JmYi4uZjhhZjM5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuY3BwCkBAIC0yNzgsNiArMjc4LDcgQEAg dm9pZCBTbGlkZXJUaHVtYkVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2ZW50 KQogICAgIC8vIE1pc3NpbmcgdGhpcyBraW5kIG9mIGNoZWNrIGlzIGxpa2VseSB0byBvY2N1ciBl bHNld2hlcmUgaWYgYWRkaW5nIGl0IGluIGVhY2ggc2hhZG93IGVsZW1lbnQuCiAgICAgSFRNTElu cHV0RWxlbWVudCogaW5wdXQgPSBob3N0SW5wdXQoKTsKICAgICBpZiAoIWlucHV0IHx8IGlucHV0 LT5pc1JlYWRPbmx5Rm9ybUNvbnRyb2woKSB8fCAhaW5wdXQtPmlzRW5hYmxlZEZvcm1Db250cm9s KCkpIHsKKyAgICAgICAgc3RvcERyYWdnaW5nKCk7CiAgICAgICAgIEhUTUxEaXZFbGVtZW50Ojpk ZWZhdWx0RXZlbnRIYW5kbGVyKGV2ZW50KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K 134483 2012-03-28 20:11:43 -0700 2012-03-29 11:11:57 -0700 [PATCH] Fix with test fix-with-test.patch text/plain 6456 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1ZGY1N2M3Li5lOWQ2OWEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDMt MjggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICA8aHR0 cDovL3dlYmtpdC5vcmcvYi84MjU1OD4gVG9nZ2xpbmcgPGlucHV0IHR5cGU9InJhbmdlIj4gcmVh ZG9ubHkgb3IgZGlzYWJsZWQgc3RhdGUgd2hpbGUgYWN0aXZlIGJyZWFrcyBhbGwgY2xpY2sgZXZl bnRzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBm YXN0L2Zvcm1zL3JhbmdlL3JhbmdlLWRyYWctd2hlbi10b2dnbGVkLWRpc2FibGVkLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9yYW5nZS9yYW5nZS1kcmFnLXdoZW4t dG9nZ2xlZC1kaXNhYmxlZC5odG1sOiBBZGRlZC4KKwogMjAxMi0wMy0yNyAgRGlyayBQcmFua2Ug IDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgYSBidW5jaCBvZiBsaW5l cyB0aGF0IGFyZSBubyBsb25nZXIgZmFpbGluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvcmFuZ2UvcmFuZ2UtZHJhZy13aGVuLXRvZ2dsZWQtZGlzYWJsZWQtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yYW5nZS9yYW5nZS1kcmFnLXdoZW4tdG9nZ2xl ZC1kaXNhYmxlZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MC4uZjQ4NWEwYQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFu Z2UvcmFuZ2UtZHJhZy13aGVuLXRvZ2dsZWQtZGlzYWJsZWQtZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsMjYgQEAKK1Rlc3QgZm9yIGRyYWdnaW5nIG9wZXJhdGlvbnMgb2YgPGlucHV0IHR5cGU9cmFu Z2U+IHdoZW4gcmVhZG9ubHkgb3IgZGlzYWJsZWQgYXJlIHRvZ2dsZWQuCisKK1Rlc3RzIGZvciBy YW5nZSBkcmFnZ2luZyB3aGlsZSBpdCB0b2dnbGVzIHRvIGJlIHJlYWRvbmx5LgorcmVhZE9ubHk9 ZmFsc2UsIGRpc2FibGVkPWZhbHNlCitQQVNTIGlucHV0LnZhbHVlIGlzICIxMDAiCitQQVNTIGNo YW5nZUV2ZW50Q291bnRlciBpcyA+PSBsYXN0Q2hhbmdlRXZlbnRDb3VudGVyICsgMQorUEFTUyBp bnB1dC52YWx1ZSBpcyAiMCIKK1BBU1MgY2hhbmdlRXZlbnRDb3VudGVyIGlzID49IGxhc3RDaGFu Z2VFdmVudENvdW50ZXIgKyAxCityZWFkT25seT10cnVlCitQQVNTIGlucHV0LnZhbHVlIGlzICIw IgorUEFTUyBsYXN0Q2hhbmdlRXZlbnRDb3VudGVyIGlzIGNoYW5nZUV2ZW50Q291bnRlcgorCitU ZXN0cyBmb3IgcmFuZ2UgZHJhZ2dpbmcgd2hpbGUgaXQgdG9nZ2xlcyB0byBiZSBkaXNhYmxlZC4K K3JlYWRPbmx5PWZhbHNlLCBkaXNhYmxlZD1mYWxzZQorUEFTUyBpbnB1dC52YWx1ZSBpcyAiMTAw IgorUEFTUyBjaGFuZ2VFdmVudENvdW50ZXIgaXMgPj0gbGFzdENoYW5nZUV2ZW50Q291bnRlciAr IDEKK1BBU1MgaW5wdXQudmFsdWUgaXMgIjAiCitQQVNTIGNoYW5nZUV2ZW50Q291bnRlciBpcyA+ PSBsYXN0Q2hhbmdlRXZlbnRDb3VudGVyICsgMQorZGlzYWJsZWQ9dHJ1ZQorUEFTUyBpbnB1dC52 YWx1ZSBpcyAiMCIKK1BBU1MgbGFzdENoYW5nZUV2ZW50Q291bnRlciBpcyBjaGFuZ2VFdmVudENv dW50ZXIKKworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRF CisgCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3JhbmdlL3JhbmdlLWRyYWct d2hlbi10b2dnbGVkLWRpc2FibGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Jhbmdl L3JhbmdlLWRyYWctd2hlbi10b2dnbGVkLWRpc2FibGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMC4uMzA3ZTA1NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvcmFuZ2UvcmFuZ2UtZHJhZy13aGVuLXRvZ2dsZWQtZGlzYWJsZWQuaHRtbApA QCAtMCwwICsxLDg5IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1M Ly9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9q cy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlw dGlvbiI+VGVzdCBmb3IgZHJhZ2dpbmcgb3BlcmF0aW9ucyBvZiAmbHQ7aW5wdXQgdHlwZT1yYW5n ZSZndDsgd2hlbiA8Y29kZT5yZWFkb25seTwvY29kZT4gb3IgPGNvZGU+ZGlzYWJsZWQ8L2NvZGU+ IGFyZSB0b2dnbGVkLjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPGlucHV0IHR5cGU9 InJhbmdlIiBpZD0icmFuZ2UxIiBtaW49IjAiIG1heD0iMTAwIiB2YWx1ZT0iNTAiPgorPGlucHV0 IHR5cGU9InJhbmdlIiBpZD0icmFuZ2UyIiBtaW49IjAiIG1heD0iMTAwIiB2YWx1ZT0iNTAiPgor PHNjcmlwdD4KKwordmFyIGNoYW5nZUV2ZW50Q291bnRlciA9IDA7Cit2YXIgbGFzdENoYW5nZUV2 ZW50Q291bnRlciA9IGNoYW5nZUV2ZW50Q291bnRlcjsKK2Z1bmN0aW9uIGhhbmRsZUNoYW5nZSgp IHsKKyAgICBjaGFuZ2VFdmVudENvdW50ZXIrKzsKK30KKwordmFyIGlucHV0ID0gbnVsbDsKKwor ZnVuY3Rpb24gdGVzdElucHV0KGlkLCBmaWVsZCkgeworICAgIGlmICghd2luZG93LmV2ZW50U2Vu ZGVyKQorICAgICAgICByZXR1cm47CisKKyAgICBpbnB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKGlkKTsKKyAgICBpbnB1dC5vbmNoYW5nZSA9IGhhbmRsZUNoYW5nZTsKKyAgICBpbnB1dC5m b2N1cygpOworCisgICAgdmFyIGNlbnRlclkgPSBpbnB1dC5vZmZzZXRUb3AgKyBpbnB1dC5vZmZz ZXRIZWlnaHQgLyAyOworICAgIHZhciBjZW50ZXJYID0gaW5wdXQub2Zmc2V0TGVmdCArIGlucHV0 Lm9mZnNldFdpZHRoIC8gMjsKKyAgICB2YXIgbGVmdEVkZ2VYID0gaW5wdXQub2Zmc2V0TGVmdCAr IDE7CisgICAgdmFyIHJpZ2h0RWRnZVggPSBpbnB1dC5vZmZzZXRMZWZ0ICsgaW5wdXQub2Zmc2V0 V2lkdGggLSAxOworCisgICAgZnVuY3Rpb24gZHJhZ1RvTGVmdEVkZ2UoKSB7IGV2ZW50U2VuZGVy Lm1vdXNlTW92ZVRvKGxlZnRFZGdlWCwgY2VudGVyWSk7IH0KKyAgICBmdW5jdGlvbiBkcmFnVG9S aWdodEVkZ2UoKSB7IGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHJpZ2h0RWRnZVgsIGNlbnRlclkp OyB9CisgICAgZnVuY3Rpb24gZHJhZ1RvQ2VudGVyKCkgeyBldmVudFNlbmRlci5tb3VzZU1vdmVU byhjZW50ZXJYLCBjZW50ZXJZKTsgfQorCisgICAgZnVuY3Rpb24gc3RhcnREcmFnRnJvbUNlbnRl cigpIHsKKyAgICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oY2VudGVyWCwgY2VudGVyWSk7 CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworICAgIH0KKworICAgIGZ1bmN0aW9u IHN0b3BEcmFnKCkgeworICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAgfQorCisg ICAgc3RhcnREcmFnRnJvbUNlbnRlcigpOworCisgICAgLy8gRHJhZyBmcm9tIGNlbnRlciwgdG8g cmlnaHQgZWRnZSwgdG8gbGVmdCBlZGdlLgorICAgIGRlYnVnKCdyZWFkT25seT1mYWxzZSwgZGlz YWJsZWQ9ZmFsc2UnKTsKKyAgICBpbnB1dC52YWx1ZUFzTnVtYmVyID0gNTA7CisgICAgbGFzdENo YW5nZUV2ZW50Q291bnRlciA9IGNoYW5nZUV2ZW50Q291bnRlcjsKKyAgICBkcmFnVG9SaWdodEVk Z2UoKTsKKyAgICBzaG91bGRCZSgnaW5wdXQudmFsdWUnLCAnIjEwMCInKTsKKyAgICBzaG91bGRC ZUdyZWF0ZXJUaGFuT3JFcXVhbCgnY2hhbmdlRXZlbnRDb3VudGVyJywgJ2xhc3RDaGFuZ2VFdmVu dENvdW50ZXIgKyAxJyk7CisgICAgbGFzdENoYW5nZUV2ZW50Q291bnRlciA9IGNoYW5nZUV2ZW50 Q291bnRlcjsKKyAgICBkcmFnVG9MZWZ0RWRnZSgpOworICAgIHNob3VsZEJlKCdpbnB1dC52YWx1 ZScsICciMCInKTsKKyAgICBzaG91bGRCZUdyZWF0ZXJUaGFuT3JFcXVhbCgnY2hhbmdlRXZlbnRD b3VudGVyJywgJ2xhc3RDaGFuZ2VFdmVudENvdW50ZXIgKyAxJyk7CisKKyAgICAvLyBUb2dnbGUg KHJlYWRvbmx5IHwgZGlzYWJsZWQpLgorICAgIGRlYnVnKGZpZWxkICsgJz10cnVlJyk7CisgICAg aW5wdXRbZmllbGRdID0gdHJ1ZTsKKworICAgIC8vIEF0dGVtcHQgdG8gZHJhZyB0byByaWdodCBl ZGdlLiBTaG91bGQgbm90IGNoYW5nZS4KKyAgICBsYXN0Q2hhbmdlRXZlbnRDb3VudGVyID0gY2hh bmdlRXZlbnRDb3VudGVyOworICAgIGRyYWdUb1JpZ2h0RWRnZSgpOworICAgIHNob3VsZEJlKCdp bnB1dC52YWx1ZScsICciMCInKTsKKyAgICBzaG91bGRCZSgnbGFzdENoYW5nZUV2ZW50Q291bnRl cicsICdjaGFuZ2VFdmVudENvdW50ZXInKTsKKworICAgIHN0b3BEcmFnKCk7Cit9CisKKworLy8g V2Ugd2FudCBhbGwgbW91c2UgbW92ZXMgc2VudCBpbW1lZGlhdGVseS4KK3dpbmRvdy5ldmVudFNl bmRlci5kcmFnTW9kZSA9IGZhbHNlOworCitkZWJ1ZygnVGVzdHMgZm9yIHJhbmdlIGRyYWdnaW5n IHdoaWxlIGl0IHRvZ2dsZXMgdG8gYmUgcmVhZG9ubHkuJyk7Cit0ZXN0SW5wdXQoJ3JhbmdlMScs ICdyZWFkT25seScpOworZGVidWcoJycpOworCitkZWJ1ZygnVGVzdHMgZm9yIHJhbmdlIGRyYWdn aW5nIHdoaWxlIGl0IHRvZ2dsZXMgdG8gYmUgZGlzYWJsZWQuJyk7Cit0ZXN0SW5wdXQoJ3Jhbmdl MicsICdkaXNhYmxlZCcpOworZGVidWcoJycpOworCis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIu Li8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwv aHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCA5YTdjODUzLi4zZGE5ZDFjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTItMDMtMjggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KKworICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi84MjU1OD4gVG9nZ2xpbmcgPGlucHV0 IHR5cGU9InJhbmdlIj4gcmVhZG9ubHkgb3IgZGlzYWJsZWQgc3RhdGUgd2hpbGUgYWN0aXZlIGJy ZWFrcyBhbGwgY2xpY2sgZXZlbnRzCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9yYW5nZS9y YW5nZS1kcmFnLXdoZW4tdG9nZ2xlZC1kaXNhYmxlZC5odG1sCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2xpZGVyVGh1bWJFbGVtZW50OjpkZWZhdWx0 RXZlbnRIYW5kbGVyKToKKyAgICAgICAgQSBzbGlkZXIgY2FuIHRvZ2dsZSBpdHMgcmVhZG9ubHkg b3IgZGlzYWJsZWQgc3RhdGUgd2hpbGUgaW4gdGhlIG1pZGRsZQorICAgICAgICBvZiBkcmFnZ2lu ZywgaW4gdGhvc2UgY2FzZXMgd2Ugc2hvdWxkIGNhbmNlbCB0aGUgZHJhZyBhbmQgcGVyZm9ybSBj bGVhbnVwLgorCiAyMDEyLTAzLTI3ICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVuYW1lIG9wYXF1ZUNvbnRlbnRzUmVnaW9uKCkgdG8g dmlzaWJsZUNvbnRlbnRPcGFxdWVSZWdpb24oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv c2hhZG93L1NsaWRlclRodW1iRWxlbWVudC5jcHAKaW5kZXggMTY0Y2JmYi4uZjhhZjM5ZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuY3Bw CkBAIC0yNzgsNiArMjc4LDcgQEAgdm9pZCBTbGlkZXJUaHVtYkVsZW1lbnQ6OmRlZmF1bHRFdmVu dEhhbmRsZXIoRXZlbnQqIGV2ZW50KQogICAgIC8vIE1pc3NpbmcgdGhpcyBraW5kIG9mIGNoZWNr IGlzIGxpa2VseSB0byBvY2N1ciBlbHNld2hlcmUgaWYgYWRkaW5nIGl0IGluIGVhY2ggc2hhZG93 IGVsZW1lbnQuCiAgICAgSFRNTElucHV0RWxlbWVudCogaW5wdXQgPSBob3N0SW5wdXQoKTsKICAg ICBpZiAoIWlucHV0IHx8IGlucHV0LT5pc1JlYWRPbmx5Rm9ybUNvbnRyb2woKSB8fCAhaW5wdXQt PmlzRW5hYmxlZEZvcm1Db250cm9sKCkpIHsKKyAgICAgICAgc3RvcERyYWdnaW5nKCk7CiAgICAg ICAgIEhUTUxEaXZFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKGV2ZW50KTsKICAgICAgICAg cmV0dXJuOwogICAgIH0K 134484 2012-03-28 20:13:10 -0700 2012-03-28 20:13:10 -0700 [TEXT] Expected Results Before Patch before-fix-output.txt text/plain 930 joepeck VGVzdCBmb3IgZHJhZ2dpbmcgb3BlcmF0aW9ucyBvZiA8aW5wdXQgdHlwZT1yYW5nZT4gd2hlbiBy ZWFkb25seSBvciBkaXNhYmxlZCBhcmUgdG9nZ2xlZC4KClRlc3RzIGZvciByYW5nZSBkcmFnZ2lu ZyB3aGlsZSBpdCB0b2dnbGVzIHRvIGJlIHJlYWRvbmx5LgpyZWFkT25seT1mYWxzZSwgZGlzYWJs ZWQ9ZmFsc2UKUEFTUyBpbnB1dC52YWx1ZSBpcyAiMTAwIgpQQVNTIGNoYW5nZUV2ZW50Q291bnRl ciBpcyA+PSBsYXN0Q2hhbmdlRXZlbnRDb3VudGVyICsgMQpQQVNTIGlucHV0LnZhbHVlIGlzICIw IgpQQVNTIGNoYW5nZUV2ZW50Q291bnRlciBpcyA+PSBsYXN0Q2hhbmdlRXZlbnRDb3VudGVyICsg MQpyZWFkT25seT10cnVlClBBU1MgaW5wdXQudmFsdWUgaXMgIjAiClBBU1MgbGFzdENoYW5nZUV2 ZW50Q291bnRlciBpcyBjaGFuZ2VFdmVudENvdW50ZXIKClRlc3RzIGZvciByYW5nZSBkcmFnZ2lu ZyB3aGlsZSBpdCB0b2dnbGVzIHRvIGJlIGRpc2FibGVkLgpyZWFkT25seT1mYWxzZSwgZGlzYWJs ZWQ9ZmFsc2UKRkFJTCBpbnB1dC52YWx1ZSBzaG91bGQgYmUgMTAwLiBXYXMgNTAuCkZBSUwgY2hh bmdlRXZlbnRDb3VudGVyIHNob3VsZCBiZSA+PSBsYXN0Q2hhbmdlRXZlbnRDb3VudGVyICsgMS4g V2FzIDIgKG9mIHR5cGUgbnVtYmVyKS4KRkFJTCBpbnB1dC52YWx1ZSBzaG91bGQgYmUgMC4gV2Fz IDUwLgpGQUlMIGNoYW5nZUV2ZW50Q291bnRlciBzaG91bGQgYmUgPj0gbGFzdENoYW5nZUV2ZW50 Q291bnRlciArIDEuIFdhcyAyIChvZiB0eXBlIG51bWJlcikuCmRpc2FibGVkPXRydWUKRkFJTCBp bnB1dC52YWx1ZSBzaG91bGQgYmUgMC4gV2FzIDUwLgpQQVNTIGxhc3RDaGFuZ2VFdmVudENvdW50 ZXIgaXMgY2hhbmdlRXZlbnRDb3VudGVyCgpQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVl CgpURVNUIENPTVBMRVRFCiAK