82552 2012-03-28 16:55:28 -0700 run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed 2012-04-02 16:10:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar, MakingBotsRed P2 Normal --- 82961 1 slewis webkit-unassigned abarth dpranke ojan slewis webkit-bug-importer webkit.review.bot oldest_to_newest 590604 0 slewis 2012-03-28 16:55:28 -0700 run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed. The fix is to set DYLD_LIBRARY_PATH in addition to DYLD_FRAMEWORK_PATH 590606 1 webkit-bug-importer 2012-03-28 16:56:16 -0700 <rdar://problem/11143199> 590614 2 134448 slewis 2012-03-28 16:59:10 -0700 Created attachment 134448 patch uploaded patch. 590624 3 134448 rniwa 2012-03-28 17:07:59 -0700 Comment on attachment 134448 patch View in context: https://bugs.webkit.org/attachment.cgi?id=134448&action=review > Tools/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). This line should appear before the description (but after bug title & bug url). > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:484 > + environment['DYLD_LIBRARY_PATH'] = self._port._build_path() There's no way to test this? 590640 4 134448 abarth 2012-03-28 17:14:26 -0700 Comment on attachment 134448 patch Eric would know. I thought we had a unit test for these environment overrides. 592767 5 134448 dpranke 2012-03-30 20:25:29 -0700 Comment on attachment 134448 patch I don't think this is worth testing ... The changelog should be fixed, though. 592769 6 dpranke 2012-03-30 20:27:41 -0700 You could test this w/ MockExecutive and then look at the env that is passed to it, it's not going to tell you much. I suppose you could assert that it was at least set to something, but I wouldn't bother. 593899 7 slewis 2012-04-02 15:08:11 -0700 Committed http://trac.webkit.org/projects/webkit/changeset/112948 593946 8 mrowe 2012-04-02 15:53:33 -0700 Take a look at the diff at <http://trac.webkit.org/changeset/112948/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py>. And then please roll out this change. 593971 9 slewis 2012-04-02 16:10:29 -0700 rolled out my change in http://trac.webkit.org/changeset/112958. Simon committed the same thing here: http://trac.webkit.org/changeset/112739 134448 2012-03-28 16:59:10 -0700 2012-03-30 20:25:29 -0700 patch dyld_library_fix.txt text/plain 1588 slewis SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMjQ3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTAzLTI4ICBTdGVwaGFuaWUgTGV3aXMgIDxzbGV3aXNAYXBwbGUuY29t PgorCisgICAgICAgIHJ1bi13ZWJraXQtdGVzdHMgLS1yb290IGZhaWxzIGlmIC91c3IvbG9jYWwv bGliL2xpYldlYkNvcmVUZXN0U3VwcG9ydC5keWxpYiBpcyBub3QgaW5zdGFsbGVkLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI1NTIKKworICAgICAg ICBVc2UgRFlMRF9MSUJSQVJZX1BBVEggc28gd2UgcGljayB1cCB0aGUgbGliV2ViQ29yZVRlc3RT dXBwb3J0LmR5bGliIGxvY2F0ZWQgaW4gdGhlIHJvb3QuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L3dlYmtpdC5weToKKyAgICAgICAgKFdlYktpdERyaXZlci5fc3RhcnQpOgorCiAyMDEy LTAzLTI4ICBTdHVhcnQgRWljaGVydCAgPHN0dWFydC5laWNoZXJ0QHBhbG0uY29tPgogCiAgICAg ICAgIGJ1aWxkLXdlYmtpdCA6IHRoZSB3b3JkICJwYXNzIiBpcyBzcGVsbGVkIGluY29ycmVjdGx5 IGFzICJwYXNzcyIKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvd2Via2l0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvd2Via2l0LnB5CShyZXZpc2lvbiAxMTIzNTApCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQkod29ya2luZyBjb3B5KQpAQCAt NDgxLDYgKzQ4MSw3IEBAIGNsYXNzIFdlYktpdERyaXZlcihEcml2ZXIpOgogICAgICAgICBzZXJ2 ZXJfbmFtZSA9IHNlbGYuX3BvcnQuZHJpdmVyX25hbWUoKQogICAgICAgICBlbnZpcm9ubWVudCA9 IHNlbGYuX3BvcnQuc2V0dXBfZW52aXJvbl9mb3Jfc2VydmVyKHNlcnZlcl9uYW1lKQogICAgICAg ICBlbnZpcm9ubWVudFsnRFlMRF9GUkFNRVdPUktfUEFUSCddID0gc2VsZi5fcG9ydC5fYnVpbGRf cGF0aCgpCisgICAgICAgIGVudmlyb25tZW50WydEWUxEX0xJQlJBUllfUEFUSCddID0gc2VsZi5f cG9ydC5fYnVpbGRfcGF0aCgpCiAgICAgICAgICMgRklYTUU6IFdlJ3JlIGFzc3VtaW5nIHRoYXQg V2ViS2l0VGVzdFJ1bm5lciBjaGVja3MgdGhpcyBEdW1wUmVuZGVyVHJlZS1uYW1lZCBlbnZpcm9u bWVudCB2YXJpYWJsZS4KICAgICAgICAgZW52aXJvbm1lbnRbJ0RVTVBSRU5ERVJUUkVFX1RFTVAn XSA9IHN0cihzZWxmLl9kcml2ZXJfdGVtcGRpcikKICAgICAgICAgZW52aXJvbm1lbnRbJ0xPQ0FM X1JFU09VUkNFX1JPT1QnXSA9IHNlbGYuX3BvcnQubGF5b3V0X3Rlc3RzX2RpcigpCg==