82535 2012-03-28 15:04:05 -0700 Change FilterOperations::getOutsets to use integers 2012-04-03 10:07:28 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 83041 1 eae eae eric krit leviw webkit.review.bot oldest_to_newest 590482 0 eae 2012-03-28 15:04:05 -0700 FilterOperations::getOutsets calculates the outset based on integers and then upcasts the values to LayoutUnits. 590493 1 134413 eae 2012-03-28 15:08:38 -0700 Created attachment 134413 Patch 590542 2 134413 eric 2012-03-28 15:47:07 -0700 Comment on attachment 134413 Patch Ha! Yes, these make no sense as LayoutUnits. :) 590545 3 krit 2012-03-28 15:51:30 -0700 wouldn't it be easier to replace the 4 ints by one IntRect? 590551 4 eae 2012-03-28 15:56:05 -0700 (In reply to comment #3) > wouldn't it be easier to replace the 4 ints by one IntRect? Would be easier but as the numbers don't really represent a rectangle it would be a bit confusing. Perhaps we need some new data type for things like borders, outsets, margins and paddings where you have a value for each edge. 590610 5 134413 webkit.review.bot 2012-03-28 16:57:32 -0700 Comment on attachment 134413 Patch Clearing flags on attachment: 134413 Committed r112475: <http://trac.webkit.org/changeset/112475> 590611 6 webkit.review.bot 2012-03-28 16:57:36 -0700 All reviewed patches have been landed. Closing bug. 134413 2012-03-28 15:08:38 -0700 2012-03-28 16:57:32 -0700 Patch bug-82535-20120328150837.patch text/plain 5523 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjQ0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDEyLTAzLTI4ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaGFuZ2UgRmlsdGVyT3BlcmF0 aW9uczo6Z2V0T3V0c2V0cyB0byB1c2UgaW50ZWdlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRmlsdGVyT3BlcmF0aW9uczo6Z2V0T3V0c2V0cyBjYWxj dWxhdGVzIHRoZSBvdXRzZXRzIHVzaW5nIGludGVnZXJzIGFuZAorICAgICAgICB0aGUgdmFsdWVz IGFyZSBndXJhbnRlZWQgdG8gYmUgc2V0IHRvIGZ1bGwtcGl4ZWwgdmFsdWVzLiBCeSBjaGFuZ2lu ZyB0aGUKKyAgICAgICAgZnVuY3Rpb24gc2lnbmF0dXJlIHdlIGNvbW11bmljYXRlIHRoaXMgZmFj dCBiZXR0ZXIgYW5kIGF2b2lkIHVubmVjZXNzYXJ5CisgICAgICAgIHR5cGUgY29udmVyc2lvbnMg aW4gc29tZSBjYXNlcy4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlck9wZXJhdGlvbnMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RmlsdGVyT3BlcmF0aW9uczo6Z2V0T3V0c2V0cyk6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvZmlsdGVycy9GaWx0ZXJPcGVyYXRpb25zLmg6CisgICAgICAgIChGaWx0ZXJPcGVy YXRpb25zKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckJveDo6Y29tcHV0ZVJlY3RGb3JSZXBhaW50KToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckJveDo6YWRkVmlzdWFsRWZmZWN0T3ZlcmZsb3cpOgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJJbmxpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVySW5saW5lOjpj b21wdXRlUmVjdEZvclJlcGFpbnQpOgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9SZW5kZXJT dHlsZS5oOgorCiAyMDEyLTAzLTI4ICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBbY2hyb21pdW1dIFNjaGVkdWxlciBzaG91bGQgbm90IHRlbGwgRnJhbWVSYXRlQ29u dHJvbGxlciB0byBiZWdpbiBhIGZyYW1lIHdoZW4gd2UgZG9udCBzd2FwCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlck9wZXJhdGlvbnMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmls dGVyT3BlcmF0aW9ucy5jcHAJKHJldmlzaW9uIDExMjMyOSkKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyT3BlcmF0aW9ucy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTk3LDcgKzk3LDcgQEAgYm9vbCBGaWx0ZXJPcGVyYXRpb25zOjpoYXNPdXRzZXRzKCkg Y29ucwogICAgIHJldHVybiBmYWxzZTsKIH0KIAotdm9pZCBGaWx0ZXJPcGVyYXRpb25zOjpnZXRP dXRzZXRzKExheW91dFVuaXQmIHRvcCwgTGF5b3V0VW5pdCYgcmlnaHQsIExheW91dFVuaXQmIGJv dHRvbSwgTGF5b3V0VW5pdCYgbGVmdCkgY29uc3QKK3ZvaWQgRmlsdGVyT3BlcmF0aW9uczo6Z2V0 T3V0c2V0cyhpbnQmIHRvcCwgaW50JiByaWdodCwgaW50JiBib3R0b20sIGludCYgbGVmdCkgY29u c3QKIHsKICAgICB0b3AgPSAwOwogICAgIHJpZ2h0ID0gMDsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyT3BlcmF0aW9ucy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyT3BlcmF0 aW9ucy5oCShyZXZpc2lvbiAxMTIzMjkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9maWx0ZXJzL0ZpbHRlck9wZXJhdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtNjQsNyAr NjQsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBvcGVyYXRpb25zTWF0Y2goY29uc3QgRmlsdGVyT3Bl cmF0aW9ucyYpIGNvbnN0OwogCiAgICAgYm9vbCBoYXNPdXRzZXRzKCkgY29uc3Q7Ci0gICAgdm9p ZCBnZXRPdXRzZXRzKExheW91dFVuaXQmIHRvcCwgTGF5b3V0VW5pdCYgcmlnaHQsIExheW91dFVu aXQmIGJvdHRvbSwgTGF5b3V0VW5pdCYgbGVmdCkgY29uc3Q7CisgICAgdm9pZCBnZXRPdXRzZXRz KGludCYgdG9wLCBpbnQmIHJpZ2h0LCBpbnQmIGJvdHRvbSwgaW50JiBsZWZ0KSBjb25zdDsKIAog ICAgIGJvb2wgaGFzRmlsdGVyVGhhdEFmZmVjdHNPcGFjaXR5KCkgY29uc3Q7CiAgICAgYm9vbCBo YXNGaWx0ZXJUaGF0TW92ZXNQaXhlbHMoKSBjb25zdDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCb3guY3BwCShyZXZpc2lvbiAxMTIzMjkpCisrKyBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTY0NSwxMCArMTY0NSwx MCBAQCB2b2lkIFJlbmRlckJveDo6Y29tcHV0ZVJlY3RGb3JSZXBhaW50KFJlCiAKICNpZiBFTkFC TEUoQ1NTX0ZJTFRFUlMpCiAgICAgaWYgKHN0eWxlVG9Vc2UtPmhhc0ZpbHRlck91dHNldHMoKSkg ewotICAgICAgICBMYXlvdXRVbml0IHRvcE91dHNldDsKLSAgICAgICAgTGF5b3V0VW5pdCByaWdo dE91dHNldDsKLSAgICAgICAgTGF5b3V0VW5pdCBib3R0b21PdXRzZXQ7Ci0gICAgICAgIExheW91 dFVuaXQgbGVmdE91dHNldDsKKyAgICAgICAgaW50IHRvcE91dHNldDsKKyAgICAgICAgaW50IHJp Z2h0T3V0c2V0OworICAgICAgICBpbnQgYm90dG9tT3V0c2V0OworICAgICAgICBpbnQgbGVmdE91 dHNldDsKICAgICAgICAgc3R5bGVUb1VzZS0+ZmlsdGVyKCkuZ2V0T3V0c2V0cyh0b3BPdXRzZXQs IHJpZ2h0T3V0c2V0LCBib3R0b21PdXRzZXQsIGxlZnRPdXRzZXQpOwogICAgICAgICByZWN0Lm1v dmUoLWxlZnRPdXRzZXQsIC10b3BPdXRzZXQpOwogICAgICAgICByZWN0LmV4cGFuZChsZWZ0T3V0 c2V0ICsgcmlnaHRPdXRzZXQsIHRvcE91dHNldCArIGJvdHRvbU91dHNldCk7CkBAIC0zNjgxLDEw ICszNjgxLDEwIEBAIHZvaWQgUmVuZGVyQm94OjphZGRWaXN1YWxFZmZlY3RPdmVyZmxvdygKICNp ZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpCiAgICAgLy8gQ29tcHV0ZSBhbnkgZmlsdGVyIG91dHNldCBv dmVyZmxvdy4KICAgICBpZiAoc3R5bGUoKS0+aGFzRmlsdGVyT3V0c2V0cygpKSB7Ci0gICAgICAg IExheW91dFVuaXQgZmlsdGVyT3V0c2V0TGVmdDsKLSAgICAgICAgTGF5b3V0VW5pdCBmaWx0ZXJP dXRzZXRSaWdodDsKLSAgICAgICAgTGF5b3V0VW5pdCBmaWx0ZXJPdXRzZXRUb3A7Ci0gICAgICAg IExheW91dFVuaXQgZmlsdGVyT3V0c2V0Qm90dG9tOworICAgICAgICBpbnQgZmlsdGVyT3V0c2V0 TGVmdDsKKyAgICAgICAgaW50IGZpbHRlck91dHNldFJpZ2h0OworICAgICAgICBpbnQgZmlsdGVy T3V0c2V0VG9wOworICAgICAgICBpbnQgZmlsdGVyT3V0c2V0Qm90dG9tOwogICAgICAgICBzdHls ZSgpLT5nZXRGaWx0ZXJPdXRzZXRzKGZpbHRlck91dHNldFRvcCwgZmlsdGVyT3V0c2V0UmlnaHQs IGZpbHRlck91dHNldEJvdHRvbSwgZmlsdGVyT3V0c2V0TGVmdCk7CiAgICAgICAgIAogICAgICAg ICBvdmVyZmxvd01pblggPSBtaW4ob3ZlcmZsb3dNaW5YLCBib3JkZXJCb3gueCgpIC0gZmlsdGVy T3V0c2V0TGVmdCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5l LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5l LmNwcAkocmV2aXNpb24gMTEyMzI5KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl cklubGluZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMTQsMTAgKzExMTQsMTAgQEAgdm9pZCBS ZW5kZXJJbmxpbmU6OmNvbXB1dGVSZWN0Rm9yUmVwYWludAogCiAjaWYgRU5BQkxFKENTU19GSUxU RVJTKQogICAgIGlmIChzdHlsZSgpLT5oYXNGaWx0ZXJPdXRzZXRzKCkpIHsKLSAgICAgICAgTGF5 b3V0VW5pdCB0b3BPdXRzZXQ7Ci0gICAgICAgIExheW91dFVuaXQgcmlnaHRPdXRzZXQ7Ci0gICAg ICAgIExheW91dFVuaXQgYm90dG9tT3V0c2V0OwotICAgICAgICBMYXlvdXRVbml0IGxlZnRPdXRz ZXQ7CisgICAgICAgIGludCB0b3BPdXRzZXQ7CisgICAgICAgIGludCByaWdodE91dHNldDsKKyAg ICAgICAgaW50IGJvdHRvbU91dHNldDsKKyAgICAgICAgaW50IGxlZnRPdXRzZXQ7CiAgICAgICAg IHN0eWxlKCktPmZpbHRlcigpLmdldE91dHNldHModG9wT3V0c2V0LCByaWdodE91dHNldCwgYm90 dG9tT3V0c2V0LCBsZWZ0T3V0c2V0KTsKICAgICAgICAgcmVjdC5tb3ZlKC1sZWZ0T3V0c2V0LCAt dG9wT3V0c2V0KTsKICAgICAgICAgcmVjdC5leHBhbmQobGVmdE91dHNldCArIHJpZ2h0T3V0c2V0 LCB0b3BPdXRzZXQgKyBib3R0b21PdXRzZXQpOwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL1JlbmRlclN0eWxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmgJKHJldmlzaW9uIDExMjMyOSkKKysrIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00 NjUsNyArNDY1LDcgQEAgcHVibGljOgogICAgIH0KIAogI2lmIEVOQUJMRShDU1NfRklMVEVSUykK LSAgICB2b2lkIGdldEZpbHRlck91dHNldHMoTGF5b3V0VW5pdCYgdG9wLCBMYXlvdXRVbml0JiBy aWdodCwgTGF5b3V0VW5pdCYgYm90dG9tLCBMYXlvdXRVbml0JiBsZWZ0KSBjb25zdAorICAgIHZv aWQgZ2V0RmlsdGVyT3V0c2V0cyhpbnQmIHRvcCwgaW50JiByaWdodCwgaW50JiBib3R0b20sIGlu dCYgbGVmdCkgY29uc3QKICAgICB7CiAgICAgICAgIGlmIChoYXNGaWx0ZXIoKSkKICAgICAgICAg ICAgIGZpbHRlcigpLmdldE91dHNldHModG9wLCByaWdodCwgYm90dG9tLCBsZWZ0KTsK