82524 2012-03-28 14:01:13 -0700 [CSS Filters] Avoid rebuilding FEFilters when RenderLayer is destroyed 2012-03-28 20:43:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achicu achicu dino webkit-bug-importer webkit.review.bot oldest_to_newest 590401 0 achicu 2012-03-28 14:01:13 -0700 RenderLayer::updateOrRemoveFilterEffect is called in clearBacking(), which is called from RenderLayer::~RenderLayer, meaning that the filters are rebuild when deleting a layer, but they are not going to be used anyway. Avoid creating new filters when the RenderLayer is going out of scope. 590461 1 webkit-bug-importer 2012-03-28 14:44:40 -0700 <rdar://problem/11141839> 590513 2 134422 achicu 2012-03-28 15:25:19 -0700 Created attachment 134422 Patch V1 590801 3 134422 webkit.review.bot 2012-03-28 20:43:06 -0700 Comment on attachment 134422 Patch V1 Clearing flags on attachment: 134422 Committed r112497: <http://trac.webkit.org/changeset/112497> 590802 4 webkit.review.bot 2012-03-28 20:43:10 -0700 All reviewed patches have been landed. Closing bug. 134422 2012-03-28 15:25:19 -0700 2012-03-28 20:43:06 -0700 Patch V1 bug82524.patch text/plain 2807 achicu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNDRkOTc4Li41MDNjYjIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMDMtMjggIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgor CisgICAgICAgIFtDU1MgRmlsdGVyc10gQXZvaWQgcmVidWlsZGluZyBGRUZpbHRlcnMgd2hlbiBS ZW5kZXJMYXllciBpcyBkZXN0cm95ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTgyNTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVuZGVyTGF5ZXI6On5SZW5kZXJMYXllciBpcyBjYWxsaW5nIGNsZWFy QmFja2luZyB3aGljaCB1cGRhdGVkIHRoZSBtX2ZpbHRlciB3aXRoIG5ldyBmaWx0ZXJzLAorICAg ICAgICBldmVuIHRob3VnaCB0aGV5IHdlcmUgdG8gYmUgZGVsZXRlZCBhIGNvdXBsZSBvZiBsaW5l cyBiZWxvdy4gVGhpcyBjaGFuZ2UgYXZvaWRzIHVwZGF0aW5nIHRoZSBmaWx0ZXJzLAorICAgICAg ICBpZiB3ZSBhcmUgaW4gdGhlICJkZXN0cm95ZWQiIHN0YXRlLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gVGhpcyBjaGFuZ2UgaGFzIG5vIHZpc2libGUgcmVzdWx0cyB0byBIVE1MIG9yIEphdmFT Y3JpcHQsIHNvIGl0IGNhbm5vdCBiZSB0ZXN0ZWQgd2l0aG91dCBhIGRlYnVnZ2VyLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckxheWVyOjp+UmVuZGVyTGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmNs ZWFyQmFja2luZyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmg6CisgICAgICAg IChSZW5kZXJMYXllcik6CisKIDIwMTItMDMtMjggIEZsb3JpbiBNYWxpdGEgIDxmbWFsaXRhQGdv b2dsZS5jb20+CiAKICAgICAgICAgSW5jb3JyZWN0IGZvcmVpZ25PYmplY3QgaGl0IHRlc3QgcmVz dWx0cyB3aGVuIG92ZXJsYXBwaW5nIG90aGVyIFNWRyBlbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggYTFjY2NiNS4uYTVmNmJjZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0yMjMsNyArMjIzLDcgQEAgUmVu ZGVyTGF5ZXI6On5SZW5kZXJMYXllcigpCiAgICAgZGVsZXRlIG1fbWFycXVlZTsKIAogI2lmIFVT RShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICBjbGVhckJhY2tpbmcoKTsKKyAgICBjbGVh ckJhY2tpbmcodHJ1ZSk7CiAjZW5kaWYKICAgICAKICAgICAvLyBNYWtlIHN1cmUgd2UgaGF2ZSBu byBsaW5nZXJpbmcgY2xpcCByZWN0cy4KQEAgLTM5ODQsMTYgKzM5ODQsMTggQEAgUmVuZGVyTGF5 ZXJCYWNraW5nKiBSZW5kZXJMYXllcjo6ZW5zdXJlQmFja2luZygpCiAgICAgcmV0dXJuIG1fYmFj a2luZy5nZXQoKTsKIH0KIAotdm9pZCBSZW5kZXJMYXllcjo6Y2xlYXJCYWNraW5nKCkKK3ZvaWQg UmVuZGVyTGF5ZXI6OmNsZWFyQmFja2luZyhib29sIGxheWVyQmVpbmdEZXN0cm95ZWQpCiB7CiAg ICAgaWYgKG1fYmFja2luZyAmJiAhcmVuZGVyZXIoKS0+ZG9jdW1lbnRCZWluZ0Rlc3Ryb3llZCgp KQogICAgICAgICBjb21wb3NpdG9yKCktPmxheWVyQmVjYW1lTm9uQ29tcG9zaXRlZCh0aGlzKTsK ICAgICBtX2JhY2tpbmcuY2xlYXIoKTsKIAogI2lmIEVOQUJMRShDU1NfRklMVEVSUykKLSAgICB1 cGRhdGVPclJlbW92ZUZpbHRlckVmZmVjdCgpOworICAgIGlmICghbGF5ZXJCZWluZ0Rlc3Ryb3ll ZCkKKyAgICAgICAgdXBkYXRlT3JSZW1vdmVGaWx0ZXJFZmZlY3QoKTsKKyNlbHNlCisgICAgVU5V U0VEX1BBUkFNKGxheWVyQmVpbmdEZXN0cm95ZWQpOwogI2VuZGlmCi0gICAgCiB9CiAKIGJvb2wg UmVuZGVyTGF5ZXI6Omhhc0NvbXBvc2l0ZWRNYXNrKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyLmgKaW5kZXggYTJmZjVjNi4uNDYzMmJkNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTU0MCw3ICs1NDAsNyBAQCBwdWJsaWM6CiAgICAg Ym9vbCBoYXNDb21wb3NpdGVkTWFzaygpIGNvbnN0OwogICAgIFJlbmRlckxheWVyQmFja2luZyog YmFja2luZygpIGNvbnN0IHsgcmV0dXJuIG1fYmFja2luZy5nZXQoKTsgfQogICAgIFJlbmRlckxh eWVyQmFja2luZyogZW5zdXJlQmFja2luZygpOwotICAgIHZvaWQgY2xlYXJCYWNraW5nKCk7Cisg ICAgdm9pZCBjbGVhckJhY2tpbmcoYm9vbCBsYXllckJlaW5nRGVzdHJveWVkID0gZmFsc2UpOwog ICAgIHZpcnR1YWwgR3JhcGhpY3NMYXllciogbGF5ZXJGb3JIb3Jpem9udGFsU2Nyb2xsYmFyKCkg Y29uc3Q7CiAgICAgdmlydHVhbCBHcmFwaGljc0xheWVyKiBsYXllckZvclZlcnRpY2FsU2Nyb2xs YmFyKCkgY29uc3Q7CiAgICAgdmlydHVhbCBHcmFwaGljc0xheWVyKiBsYXllckZvclNjcm9sbENv cm5lcigpIGNvbnN0Owo=