<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>82517</bug_id>
          
          <creation_ts>2012-03-28 13:39:09 -0700</creation_ts>
          <short_desc>Bugzilla should provide diffs between two patches</short_desc>
          <delta_ts>2014-12-20 12:07:08 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Website</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>burg</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>eric</cc>
    
    <cc>ojan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>590361</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-03-28 13:39:09 -0700</bug_when>
    <thetext>Sometimes, only thing I want to see on the review tool is the difference between two patches because I had already reviewed the previous one.

Bugzilla should provide provide some way to do this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>590364</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-03-28 13:40:47 -0700</bug_when>
    <thetext>it does!  Click on the &quot;diff&quot; link isntad of pretty diff sometime.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>590367</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-03-28 13:41:56 -0700</bug_when>
    <thetext>I can&apos;t say it works very well... (it often fails for me), but it is supposed to solve this exact question. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>590372</commentid>
    <comment_count>3</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2012-03-28 13:46:03 -0700</bug_when>
    <thetext>In theory, bugzilla lets you do this via https://bugs.webkit.org/attachment.cgi?oldid=129509&amp;action=interdiff&amp;newid=133186&amp;headers=1. But I find that it rarely actually works. Also, what you really want is for it to be integrated into the code review tool so it can show you both the diff between the patches and the comments on the old patch, so you can see that the comments were addressed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>590374</commentid>
    <comment_count>4</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-03-28 13:46:48 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; it does!  Click on the &quot;diff&quot; link isntad of pretty diff sometime.

Ah, I didn&apos;t realize that feature. We should probably integrate it with the review tool as well though. (Just adding links might be sufficient). Also, it doesn&apos;t seem to work well. e.g. try https://bugs.webkit.org/attachment.cgi?oldid=134350&amp;action=interdiff&amp;newid=134383&amp;headers=1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1055643</commentid>
    <comment_count>5</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2014-12-15 09:35:35 -0800</bug_when>
    <thetext>I just installed interdiff on bugs.webkit.org, so this should be working now.

For example:  https://bugs.webkit.org/attachment.cgi?oldid=243242&amp;action=interdiff&amp;newid=243295&amp;headers=1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1057280</commentid>
    <comment_count>6</comment_count>
    <who name="Brian Burg">burg</who>
    <bug_when>2014-12-20 12:07:08 -0800</bug_when>
    <thetext>Doesn&apos;t seem to work for this case: https://bugs.webkit.org/attachment.cgi?oldid=242968&amp;action=interdiff&amp;newid=243586&amp;headers=1</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>