82505 2012-03-28 12:32:27 -0700 several http tests are flaky and crashing on win, debug 2012-04-09 02:50:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke fischman abarth bbudge commit-queue fischman tony webkit.review.bot oldest_to_newest 590280 0 dpranke 2012-03-28 12:32:27 -0700 See: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fxmlhttprequest%2Fredirect-cross-origin-post.html Looks like this has been flaky on windows for a *long* time ... http://code.google.com/p/chromium/issues/detail?id=28092 590285 1 dpranke 2012-03-28 12:34:19 -0700 However, the failures actually appear to be stack traces ... I don't know why they're not being reported as crashes. I tried a bit to reproduce this yesterday on linux locally, but had no luck. Perhaps someone can take a look? 590437 2 bbudge 2012-03-28 14:26:26 -0700 I looked at this in the VS debugger by loading the page in TestShell. The test passes but hits a DCHECK in timer.cc (this also seems to be the case from a quick look at the flakiness dashboard logs) Here's the code: void Timer::AbandonScheduledTask() { DCHECK(thread_id_ == 0 || thread_id_ == static_cast<int>(PlatformThread::CurrentId())); if (scheduled_task_) { scheduled_task_->Abandon(); scheduled_task_ = NULL; } } Here's the stack trace. I don't know what's going on but hopefully someone can shed some light. test_shell.exe!base::debug::BreakDebugger() Line 107 C++ test_shell.exe!logging::LogMessage::~LogMessage() Line 642 C++ > test_shell.exe!base::Timer::AbandonScheduledTask() Line 145 C++ test_shell.exe!base::Timer::StopAndAbandon() Line 138 C++ test_shell.exe!base::Timer::~Timer() Line 81 C++ test_shell.exe!base::BaseTimerMethodPointer<`anonymous namespace'::RequestProxy,1>::~BaseTimerMethodPointer<`anonymous namespace'::RequestProxy,1>() + 0x16 bytes C++ test_shell.exe!base::RepeatingTimer<`anonymous namespace'::RequestProxy>::~RepeatingTimer<`anonymous namespace'::RequestProxy>() + 0x16 bytes C++ test_shell.exe!`anonymous namespace'::RequestProxy::~RequestProxy() Line 315 + 0x27 bytes C++ test_shell.exe!`anonymous namespace'::RequestProxy::`scalar deleting destructor'() + 0x16 bytes C++ test_shell.exe!base::RefCountedThreadSafe<`anonymous namespace'::RequestProxy,base::DefaultRefCountedThreadSafeTraits<`anonymous namespace'::RequestProxy> >::DeleteInternal(const `anonymous-namespace'::RequestProxy * x=0x0c707e48) Line 151 + 0x3e bytes C++ test_shell.exe!base::DefaultRefCountedThreadSafeTraits<`anonymous namespace'::RequestProxy>::Destruct(const `anonymous-namespace'::RequestProxy * x=0x0c707e48) Line 117 + 0x9 bytes C++ test_shell.exe!base::RefCountedThreadSafe<`anonymous namespace'::RequestProxy,base::DefaultRefCountedThreadSafeTraits<`anonymous namespace'::RequestProxy> >::Release() Line 145 + 0x21 bytes C++ test_shell.exe!base::internal::MaybeRefcount<1,`anonymous namespace'::RequestProxy *>::Release(`anonymous-namespace'::RequestProxy * o=0x0c707e48) Line 466 + 0xe bytes C++ test_shell.exe!base::internal::BindState<base::internal::RunnableAdapter<void (__thiscall `anonymous namespace'::RequestProxy::*)(net::URLRequestStatus const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::TimeTicks const &)>,void __cdecl(`anonymous namespace'::RequestProxy *,net::URLRequestStatus const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::TimeTicks const &),void __cdecl(`anonymous namespace'::RequestProxy *,net::URLRequestStatus,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::TimeTicks)>::~BindState<base::internal::RunnableAdapter<void (__thiscall `anonymous namespace'::RequestProxy::*)(net::URLRequestStatus const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::TimeTicks const &)>,void __cdecl(`anonymous namespace'::RequestProxy *,net::URLRequestStatus const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::TimeTicks const &),void __cdecl(`anonymous namespace'::RequestProxy *,net::URLRequestStatus,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::TimeTicks)>() Line 2655 + 0xc bytes C++ test_shell.exe!base::internal::BindState<base::internal::RunnableAdapter<void (__thiscall `anonymous namespace'::RequestProxy::*)(net::URLRequestStatus const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::TimeTicks const &)>,void __cdecl(`anonymous namespace'::RequestProxy *,net::URLRequestStatus const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::TimeTicks const &),void __cdecl(`anonymous namespace'::RequestProxy *,net::URLRequestStatus,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::TimeTicks)>::`scalar deleting destructor'() + 0x16 bytes C++ test_shell.exe!base::RefCountedThreadSafe<base::internal::BindStateBase,base::DefaultRefCountedThreadSafeTraits<base::internal::BindStateBase> >::DeleteInternal(const base::internal::BindStateBase * x=0x0c6e6098) Line 151 + 0x3e bytes C++ test_shell.exe!base::DefaultRefCountedThreadSafeTraits<base::internal::BindStateBase>::Destruct(const base::internal::BindStateBase * x=0x0c6e6098) Line 117 + 0x9 bytes C++ test_shell.exe!base::RefCountedThreadSafe<base::internal::BindStateBase,base::DefaultRefCountedThreadSafeTraits<base::internal::BindStateBase> >::Release() Line 145 + 0x21 bytes C++ test_shell.exe!scoped_refptr<base::internal::BindStateBase>::~scoped_refptr<base::internal::BindStateBase>() Line 244 C++ test_shell.exe!base::internal::CallbackBase::~CallbackBase() Line 33 + 0x8 bytes C++ test_shell.exe!base::Callback<void __cdecl(void)>::~Callback<void __cdecl(void)>() + 0x16 bytes C++ test_shell.exe!base::PendingTask::~PendingTask() Line 32 + 0xb bytes C++ test_shell.exe!MessageLoop::DoWork() Line 661 + 0xc bytes C++ test_shell.exe!base::MessagePumpForUI::DoRunLoop() Line 203 + 0x1d bytes C++ test_shell.exe!base::MessagePumpWin::RunWithDispatcher(base::MessagePump::Delegate * delegate=0x0029fc94, base::MessagePumpWin::Dispatcher * dispatcher=0x00000000) Line 51 + 0xf bytes C++ test_shell.exe!base::MessagePumpWin::Run(base::MessagePump::Delegate * delegate=0x0029fc94) Line 64 + 0x1c bytes C++ test_shell.exe!MessageLoop::RunInternal() Line 417 + 0x2a bytes C++ test_shell.exe!MessageLoop::RunHandler() Line 391 C++ test_shell.exe!MessageLoop::Run() Line 301 C++ test_shell.exe!main(int argc=4, char * * argv=0x003225d8) Line 334 C++ test_shell.exe!__tmainCRTStartup() Line 266 + 0x19 bytes C test_shell.exe!mainCRTStartup() Line 182 C kernel32.dll!76a73677() [Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll] ntdll.dll!77679f42() ntdll.dll!77679f15() 590471 3 tony 2012-03-28 14:53:31 -0700 It looks like this is because of the call to logging::SetLogAssertHandler(UnitTestAssertHandler); in webkit_support.cc. This causes us to not crash when we hit an assert. I think we're not supposed to set this for DRT or test_shell. It looks like the code has been this way for a long time (at least 18 months?). Maybe we've never properly crashed on ASSERTs in debug? 591623 4 dpranke 2012-03-29 15:16:18 -0700 Looks like a few other tests are hitting this as well: http/tests/xmlhttprequest/redirect-cross-origin-post.html http/tests/media/media-can-load-when-hidden.html http/tests/xmlhttprequest/upload-onloadend-event-after-abort.html http/tests/xmlhttprequest/upload-onprogress-event.html http/tests/xmlhttprequest/upload-onloadend-event-after-sync-requests.html Note that after tony's change in chromium r129689 we're at least getting proper crashes. 596726 5 fischman 2012-04-05 11:16:49 -0700 The crash is caused by a bug in chromium's simple_resource_loader_bridge.cc; opened http://crbug.com/122182 and sent CR for it in https://chromiumcodereview.appspot.com/10012010/ Also, the failing media test (http/tests/media/media-can-load-when-hidden.html) doesn't actually need to be an http test, so I'm moving it into LayoutTests/media (and de-racing it) in bug 83296. 597577 6 fischman 2012-04-06 12:55:56 -0700 The Timer check triggered by ~RequestProxy() is fixed in http://src.chromium.org/viewvc/chrome?view=rev&revision=131170 When this rolls into WebKit deps I'll post a patch to remove the failure expectations. 597780 7 136085 fischman 2012-04-06 16:02:30 -0700 Created attachment 136085 Patch 598198 8 136085 webkit.review.bot 2012-04-09 02:50:37 -0700 Comment on attachment 136085 Patch Clearing flags on attachment: 136085 Committed r113566: <http://trac.webkit.org/changeset/113566> 598199 9 webkit.review.bot 2012-04-09 02:50:42 -0700 All reviewed patches have been landed. Closing bug. 136085 2012-04-06 16:02:30 -0700 2012-04-09 02:50:37 -0700 Patch bug-82505-20120406160229.patch text/plain 3943 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNTE0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjNhYWY4Yjk2MTFjMmM2YzBmMmNh NjBiYzFhYWNkYTlhMDMyMjM1Yy4uMWE1NDAxZDY1ZDk1YTY1MDYyODI1ZjZmMTAwZDkzZjgwZTJk ODkzOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTA2ICBBbWkgRmlzY2htYW4gIDxm aXNjaG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgc2V2ZXJhbCBodHRwIHRlc3RzIGFyZSBm bGFreSBhbmQgY3Jhc2hpbmcgb24gd2luLCBkZWJ1ZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI1MDUKKworICAgICAgICBSZW1vdmUgdGhlIGV4cGVj dGF0aW9ucyBvZiBhIGNyYXNoIG5vdyB0aGF0IHRoZSBmaXggKGh0dHA6Ly9jcnJldi5jb20vMTMx MTcwKQorICAgICAgICBoYXMgcm9sbGVkIGludG8gd2Via2l0IGluIGh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0LzExMzUxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0 OgorCiAyMDEyLTA0LTA2ICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1hbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgQWxsb3cgc2l0ZSBhdXRob3JzIHRvIG92ZXJyaWRlIGF1dG9maWxsZWQgZmllbGRz JyBjb2xvcnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4 cGVjdGF0aW9ucy50eHQKaW5kZXggZTY2MGYzNTRhMDgxMzRlMmJjMzI0OTgyNDg4MzdmMGM5ZDJi ZGI4OS4uNmViMjAwMDBkOGMxYWNjMmY2ZTZlMWRlNDE0M2I2ZWI2NjBmMDgyMyAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0Cisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApA QCAtMTE4OCw4ICsxMTg4LDcgQEAgQlVHV0s4MzA1MSBXSU4gTElOVVggTElPTiA6IHN2Zy9jc3Mv Z3JvdXAtd2l0aC1zaGFkb3cuc3ZnID0gSU1BR0UgUEFTUwogCiAvLyBXaW5kb3dzIGFuZCBNYWMg bmVlZCByZWJhc2VsaW5pbmcgYWZ0ZXIgNTMzNzggcGF0Y2guCiBCVUdXSzUzMzc4IE1BQyA6IHN2 Zy9jbGlwLXBhdGgvY2xpcC1wYXRoLWNoaWxkcy1jbGlwcGVkLnN2ZyA9IElNQUdFCi0vLyBUaGUg Q1JBU0ggY29tZXMgZnJvbSBCVUdXSzgyNTA1Ci1CVUdXSzUzMzc4IE1BQyA6IHN2Zy96b29tL3Bh Z2Uvem9vbS1tYXNrLXdpdGgtcGVyY2VudGFnZXMuc3ZnID0gSU1BR0UgQ1JBU0gKK0JVR1dLNTMz NzggTUFDIDogc3ZnL3pvb20vcGFnZS96b29tLW1hc2std2l0aC1wZXJjZW50YWdlcy5zdmcgPSBJ TUFHRQogCiAvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQogLy8gRW5kIFNWRyBSZWdyZXNzaW9ucwpAQCAtMTYyNCw4ICsx NjIzLDcgQEAgQlVHQ1IxMTc3OTkgTUFDIDogZmFzdC9ncmFkaWVudHMvYmFja2dyb3VuZC1jbGlw cGVkLmh0bWwgPSBURVhUCiBCVUdDUjExNzc5OSA6IGZhc3QvcmVwYWludC9iYWNrZ3JvdW5kLW1p c2FsaWduZWQuaHRtbCA9IElNQUdFCiBCVUdDUjExNzc5OSA6IGZhc3QvcmVwYWludC9iYWNrZ3Jv dW5kU2l6ZVJlcGFpbnQuaHRtbCA9IElNQUdFCiBCVUdDUjExNzc5OSA6IHBsYXRmb3JtL2Nocm9t aXVtL3ZpcnR1YWwvZ3B1L2Zhc3QvY2FudmFzL2NhbnZhcy1iZy16b29tLmh0bWwgPSBJTUFHRQot Ly8gQ1JBU0ggaXMgZnJvbSBCVUdXSzgyNTA1Ci1CVUdDUjExNzc5OSA6IHN2Zy9hcy1ib3JkZXIt aW1hZ2Uvc3ZnLWFzLWJvcmRlci1pbWFnZS5odG1sID0gSU1BR0UgQ1JBU0gKK0JVR0NSMTE3Nzk5 IDogc3ZnL2FzLWJvcmRlci1pbWFnZS9zdmctYXMtYm9yZGVyLWltYWdlLmh0bWwgPSBJTUFHRQog QlVHQ1IxMTc3OTkgOiBzdmcvY3VzdG9tL3BhdHRlcm4taW4tZGVmcy5zdmcgPSBJTUFHRQogQlVH Q1IxMTc3OTkgTUFDIDogc3ZnL2N1c3RvbS9wYXR0ZXJuLXJvdGF0ZS5zdmcgPSBJTUFHRQogQlVH Q1IxMTc3OTkgOiBzdmcvY3VzdG9tL3BhdHRlcm4td2l0aC10cmFuc2Zvcm1hdGlvbi5zdmcgPSBJ TUFHRQpAQCAtMTcyOSwyMiArMTcyNywxMiBAQCBCVUdDUjExODQxMSBMRU9QQVJEIFNOT1dMRU9Q QVJEIDogc3ZnL2hpeGllL3BlcmYvMDAyLnhtbCA9IElNQUdFIFBBU1MKIC8vIEZhaWxzIG9uIFNu b3cgTGVvcGFyZCAtIHNlZSBCVUdXSzgyOTU0CiBCVUdDUjExODQxMSBTTE9XIDogc3ZnL2hpeGll L3BlcmYvMDA3LnhtbCA9IFBBU1MgRkFJTAogCi0KIEJVR0NSMjI3MDAgTElOVVggV0lOIDogZmFz dC9jYW52YXMvY2FudmFzLXNoYWRvdy5odG1sID0gVEVYVAogCiAvLyBGYWlsdXJlcyBmcm9tIG1l cmdlIDUwOTcyOjUxMDQyCiAvLyBUaGUgdGVzdCByZXF1aXJlcyBEUlQvVGVzdCBTaGVsbCB0byBz dXBwb3J0IGVycm9yIHBhZ2UgaGFuZGxpbmcuCiBCVUdDUjI3ODUwIDogZmFzdC9oaXN0b3J5L2Jh Y2stZm9yd2FyZC1yZXNldC1hZnRlci1lcnJvci1oYW5kbGluZy5odG1sID0gVEVYVAogCi1CVUdX SzgyNTA1IFNOT1dMRU9QQVJEIExFT1BBUkQgWFAgTElOVVggREVCVUcgOiBodHRwL3Rlc3RzL3ht bGh0dHByZXF1ZXN0L3JlZGlyZWN0LWNyb3NzLW9yaWdpbi1wb3N0Lmh0bWwgPSBQQVNTIFRFWFQg Q1JBU0gKLUJVR1dLODI1MDUgU05PV0xFT1BBUkQgTEVPUEFSRCBYUCBMSU5VWCBERUJVRyA6IG1l ZGlhL21lZGlhLWNhbi1sb2FkLXdoZW4taGlkZGVuLmh0bWwgPSBQQVNTIFRFWFQgQ1JBU0gKLUJV R1dLODI1MDUgU05PV0xFT1BBUkQgTEVPUEFSRCBYUCBMSU5VWCBERUJVRyA6IGh0dHAvdGVzdHMv eG1saHR0cHJlcXVlc3QvdXBsb2FkLW9ubG9hZGVuZC1ldmVudC1hZnRlci1hYm9ydC5odG1sID0g UEFTUyBURVhUIENSQVNICi1CVUdXSzgyNTA1IFNOT1dMRU9QQVJEIExFT1BBUkQgWFAgREVCVUcg OiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3VwbG9hZC1vbmxvYWRlbmQtZXZlbnQtYWZ0ZXIt bG9hZC5odG1sID0gUEFTUyBURVhUIENSQVNICi1CVUdXSzgyNTA1IFNOT1dMRU9QQVJEIExFT1BB UkQgWFAgTElOVVggREVCVUcgOiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3VwbG9hZC1vbnBy b2dyZXNzLWV2ZW50Lmh0bWwgPSBQQVNTIFRFWFQgQ1JBU0gKLUJVR1dLODI1MDUgU05PV0xFT1BB UkQgTEVPUEFSRCBYUCBMSU5VWCBERUJVRyA6IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvdXBs b2FkLW9ubG9hZGVuZC1ldmVudC1hZnRlci1zeW5jLXJlcXVlc3RzLmh0bWwgPSBQQVNTIFRFWFQg Q1JBU0gKLUJVR1dLODI1MDUgU05PV0xFT1BBUkQgTEVPUEFSRCBYUCBMSU5VWCBERUJVRyA6IGh0 dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvdXJpLXJlc29sdXRpb24tb3BlcmEtb3Blbi0wMDQuaHRt bCA9IFBBU1MgVEVYVCBDUkFTSAotQlVHV0s4MjUwNSBTTk9XTEVPUEFSRCBMRU9QQVJEIFhQIExJ TlVYIERFQlVHIDogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC91cGxvYWQtcHJvZ3Jlc3MtZXZl bnRzLmh0bWwgPSBQQVNTIENSQVNICi0KIC8vIFN0YXJ0ZWQgZmFpbGluZyB3aXRoIG1vdmUgZnJv bSBMaWdodHRwZCB0byBBcGFjaGUuCiAvLyBTaW5jZSB3ZSBoYXZlIHNvbWUgYm90cyBvbiBMaWdo dHRwZCBhbmQgc29tZSBvbiBBcGFjaGUsIG1hcmsgaXQgYXMgZmxha3kgZm9yCiAvLyBub3cuIE9u Y2Ugd2UgZGVjaWRlIG9uIG9uZSBvciB0aGUgb3RoZXIsIHRoZW4gd2UgY2FuIGFkZHJlc3MgdGhl c2UgdGVzdHMuCg==