82502 2012-03-28 12:12:19 -0700 Android mouse event factory doesn't allow specifying click count and modifier 2012-04-03 09:49:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Android Android RESOLVED FIXED P3 Normal --- 0 bhsu webkit-unassigned abarth dglazkov eric fishd jamesr peter tkent webkit.review.bot oldest_to_newest 590242 0 bhsu 2012-03-28 12:12:19 -0700 In file Source/WebKit/chromium/src/android/WebInputEventFactory.cpp, WebInputEventFactory::mouseEvent() doesn't allow caller to specify click count and modifiers. These are useful in specifying events like double click or Ctrl+click, etc. 591403 1 134635 bhsu 2012-03-29 11:56:47 -0700 Created attachment 134635 Patch 591408 2 webkit.review.bot 2012-03-29 12:01:52 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 591504 3 134635 eric 2012-03-29 13:35:53 -0700 Comment on attachment 134635 Patch OK. I assume this positively effects tests? 591582 4 bhsu 2012-03-29 14:40:04 -0700 I don't see this method called anywhere, so it shouldn't affect test. 591587 5 peter 2012-03-29 14:42:38 -0700 The relevant code has not been upstreamed to Chromium yet, so that is correct. However, our downstream branch doesn't actually know about these parameters, they seem to be specific to Google TV. I'd appreciate it if you could postpone landing this code until we can find a way to synchronize our upstreaming efforts, because this is bound to collide somewhere in the near future (in this case, our local branch would see compile errors following a merge, but that's not something we can ask you to keep in mind). I'll send you a follow up e-mail in the morning. 591607 6 bhsu 2012-03-29 15:01:52 -0700 Do I need to take any action? 591640 7 peter 2012-03-29 15:31:06 -0700 No, we'll discuss this via e-mail. Since Eric reviewed your patch I can put it on the commit queue after there's some more clarity :). 591642 8 eric 2012-03-29 15:31:54 -0700 Does the Android upstreaming project have documents/diffs anywhere I might see? I'm curious to see how far along ya'll are. 591648 9 peter 2012-03-29 15:35:35 -0700 Internally they're on go/upstreamdiff, publicly you could diff the source tarball against ToT (download: http://chromium-browser-source.commondatastorage.googleapis.com/chrome_android_tarball.html). 591698 10 eric 2012-03-29 16:41:47 -0700 Oh, I meant the Google TV upstreaming, since it sounded like this bug was Google-TV specific? 594545 11 134635 peter 2012-04-03 09:10:11 -0700 Comment on attachment 134635 Patch Putting this on the commit queue. 594574 12 134635 webkit.review.bot 2012-04-03 09:49:25 -0700 Comment on attachment 134635 Patch Clearing flags on attachment: 134635 Committed r113048: <http://trac.webkit.org/changeset/113048> 594575 13 webkit.review.bot 2012-04-03 09:49:31 -0700 All reviewed patches have been landed. Closing bug. 134635 2012-03-29 11:56:47 -0700 2012-04-03 09:49:25 -0700 Patch bug-82502-20120329115646.patch text/plain 2834 bhsu SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTI1NTQpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTAzLTI5ICBCb2xpbiBIc3UgIDxiaHN1QGdvb2dsZS5jb20+CisKKyAgICAgICAg W0Nocm9taXVtXSBBZGQgY2xpY2sgY291bnQgYW5kIG1vZGlmaWVycyB0byB0aGUgZmFjdG9yeSBt ZXRob2Qgb2YgbW91c2UgZXZlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MjUwMgorCisgICAgICAgIE1vZGlmeSBXZWJJbnB1dEV2ZW50RmFjdG9y eTo6bW91c2VFdmVudCgpIHRvIHRha2UgY2xpY2sgY291bnQKKyAgICAgICAgYW5kIG1vZGlmaWVy cyBmcm9tIGlucHV0IHBhcmFtZXRlcnMuIFNhbXBsZSB1c2UgY2FzZXMgb2YgdGhlc2UKKyAgICAg ICAgYXJlIGRvdWJsZSBjbGljaywgdHJpcGxlIGNsaWNrLCBDdHJsK2NsaWNrLCBldGMuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvYW5k cm9pZC9XZWJJbnB1dEV2ZW50RmFjdG9yeS5oOgorICAgICAgICAqIHNyYy9hbmRyb2lkL1dlYklu cHV0RXZlbnRGYWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5wdXRFdmVudEZhY3Rv cnk6Om1vdXNlRXZlbnQpOgorCiAyMDEyLTAzLTI5ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBHRU9MT0NBVElPTiBzaG91bGQgYmUgaW1wbGVtZW50ZWQg YXMgUGFnZSBTdXBwbGVtZW50CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9h bmRyb2lkL1dlYklucHV0RXZlbnRGYWN0b3J5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvYW5kcm9pZC9XZWJJbnB1dEV2ZW50RmFjdG9yeS5oCShyZXZpc2lv biAxMTI1NDQpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9hbmRyb2lkL1dlYklu cHV0RXZlbnRGYWN0b3J5LmgJKHdvcmtpbmcgY29weSkKQEAgLTU5LDYgKzU5LDggQEAgcHVibGlj OgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQg d2luZG93WSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgTW91c2VFdmVudFR5cGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGRvdWJsZSB0aW1lU3RhbXBTZWNvbmRzLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgbW9kaWZpZXJzLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgY2xpY2tDb3VudCwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV2ViTW91 c2VFdmVudDo6QnV0dG9uID0gV2ViTW91c2VFdmVudDo6QnV0dG9uTGVmdCk7CiB9OwogCkluZGV4 OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9hbmRyb2lkL1dlYklucHV0RXZlbnRGYWN0b3J5 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9hbmRyb2lkL1dl YklucHV0RXZlbnRGYWN0b3J5LmNwcAkocmV2aXNpb24gMTEyNTQ0KQorKysgU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvYW5kcm9pZC9XZWJJbnB1dEV2ZW50RmFjdG9yeS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTcwLDYgKzcwLDggQEAgV2ViTW91c2VFdmVudCBXZWJJbnB1dEV2ZW50RmFjdG9y eTo6bW91cwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBp bnQgd2luZG93WCwgaW50IHdpbmRvd1ksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIE1vdXNlRXZlbnRUeXBlIHR5cGUsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvdWJsZSB0aW1lU3RhbXBTZWNvbmRzLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgbW9kaWZpZXJz LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgY2xp Y2tDb3VudCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg V2ViTW91c2VFdmVudDo6QnV0dG9uIGJ1dHRvbikKIHsKICAgICBXZWJNb3VzZUV2ZW50IHJlc3Vs dDsKQEAgLTgyLDcgKzg0LDggQEAgV2ViTW91c2VFdmVudCBXZWJJbnB1dEV2ZW50RmFjdG9yeTo6 bW91cwogICAgIHJlc3VsdC5nbG9iYWxYID0gd2luZG93WDsKICAgICByZXN1bHQuZ2xvYmFsWSA9 IHdpbmRvd1k7CiAgICAgcmVzdWx0LnRpbWVTdGFtcFNlY29uZHMgPSB0aW1lU3RhbXBTZWNvbmRz OwotICAgIHJlc3VsdC5jbGlja0NvdW50ID0gMTsKKyAgICByZXN1bHQuY2xpY2tDb3VudCA9IGNs aWNrQ291bnQ7CisgICAgcmVzdWx0Lm1vZGlmaWVycyA9IG1vZGlmaWVyczsKIAogICAgIHN3aXRj aCAodHlwZSkgewogICAgIGNhc2UgTW91c2VFdmVudFR5cGVEb3duOgo=