82500 2012-03-28 12:06:46 -0700 Remove redundant updateViewportArguments() call when page is restored from page cache. 2012-03-29 05:53:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 1 zalan zalan kenneth webkit.review.bot oldest_to_newest 590232 0 zalan 2012-03-28 12:06:46 -0700 When the page is restored from the page cache, Document::updateViewportArguments() is called twice. Once when the document is set (restored) on the mainframe, and once the Page Cache signals restore complete. Viewport arguments don't change between the 2 calls, so it's enough to update them only once. Fix: remove updateViewportArguments() from Document::documentDidResumeFromPageCache() 590282 1 134372 zalan 2012-03-28 12:32:51 -0700 Created attachment 134372 Patch 591051 2 134372 kenneth 2012-03-29 04:58:22 -0700 Comment on attachment 134372 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134372&action=review > ManualTests/viewport-width-test-after-history-navigation.html:17 > + originalViewportWidth = window.innerWidth; Why not check that it is actually 700 ? > ManualTests/viewport-width-test-after-history-navigation.html:22 > + document.getElementById('anchor').dispatchEvent(evt); I would add a newline after this > Source/WebCore/dom/Document.cpp:4225 > m_frame->loader()->client()->dispatchDidBecomeFrameset(isFrameSet()); > - > - updateViewportArguments(); > } I am not convinced... This might fit well with the width etc, but what happens if I navigate back and I am in another orientation? this would break for width = device-width. Also I am not sure we will get all the right limits to our interaction engine, such as maximum-scale etc. 591095 3 134372 webkit.review.bot 2012-03-29 05:53:22 -0700 Comment on attachment 134372 Patch Clearing flags on attachment: 134372 Committed r112526: <http://trac.webkit.org/changeset/112526> 591096 4 webkit.review.bot 2012-03-29 05:53:28 -0700 All reviewed patches have been landed. Closing bug. 134372 2012-03-28 12:32:51 -0700 2012-03-29 05:53:22 -0700 Patch bug-82500-20120328213250.patch text/plain 4361 zalan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDExMjQy MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAz LTI4ICBaYWxhbiBCdWp0YXMgIDx6YnVqdGFzQGdtYWlsLmNvbT4KKworICAgICAgICBSZW1vdmUg cmVkdW5kYW50IHVwZGF0ZVZpZXdwb3J0QXJndW1lbnRzKCkgY2FsbCB3aGVuIHBhZ2UgaXMgcmVz dG9yZWQgZnJvbSBwYWdlIGNhY2hlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODI1MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgbWFudWFsIHRlc3QgZm9yIGhpc3RvcnkgbmF2aWdhdGlvbiB3aXRo IHZpZXdwb3J0IHdpZHRoIGNoZWNrLgorCisgICAgICAgICogTWFudWFsVGVzdHMvdmlld3BvcnQt d2lkdGgtdGVzdC1hZnRlci1oaXN0b3J5LW5hdmlnYXRpb24uaHRtbDogQWRkZWQuCisKIDIwMTIt MDMtMjggIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW1NvdXBdIEROUyBwcmVmZXRjaGluZyBzcGFtcyByZXNvbHZlciwgc2hvb3RzIHNlbGYgaW4g dGhlIGZvb3QKSW5kZXg6IE1hbnVhbFRlc3RzL3ZpZXdwb3J0LXdpZHRoLXRlc3QtYWZ0ZXItaGlz dG9yeS1uYXZpZ2F0aW9uLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTWFudWFsVGVzdHMvdmlld3BvcnQt d2lkdGgtdGVzdC1hZnRlci1oaXN0b3J5LW5hdmlnYXRpb24uaHRtbAkocmV2aXNpb24gMCkKKysr IE1hbnVhbFRlc3RzL3ZpZXdwb3J0LXdpZHRoLXRlc3QtYWZ0ZXItaGlzdG9yeS1uYXZpZ2F0aW9u Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDAgQEAKKzxodG1sPgorPGhlYWQ+CisgICAg PG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9IndpZHRoPTcwMCI+CisgICAgPHNjcmlwdD4K KyAgICAgICAgdmFyIG9yaWdpbmFsVmlld3BvcnRXaWR0aDsKKworICAgICAgICBmdW5jdGlvbiBj aGVja1ZpZXdwb3J0V2lkdGhBZnRlckhpc3RvcnlOYXZpZ2F0aW9uKCkgeworICAgICAgICAgICAg aWYgKG9yaWdpbmFsVmlld3BvcnRXaWR0aCA9PSB3aW5kb3cuaW5uZXJXaWR0aCkKKyAgICAgICAg ICAgICAgICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCA9ICI8ZGl2IHN0eWxlPSdjb2xvcjpncmVl bic+UEFTUywgdmlld3BvcnQgd2lkdGggaXMgT0sgYWZ0ZXIgaGlzdG9yeSBuYXZpZ2F0aW9uLjwv ZGl2PiI7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5p bm5lckhUTUwgPSAiPGRpdiBzdHlsZT0nY29sb3I6cmVkJz5GQUlMLCB2aWV3cG9ydCB3aWR0aCBp cyBkaWZmZXJlbnQgYWZ0ZXIgaGlzdG9yeSBuYXZpZ2F0aW9uLjwvZGl2PiI7CisgICAgICAgIH0K KworICAgICAgICBmdW5jdGlvbiBuYXZpZ2F0ZUF3YXlBbmRCYWNrKCkgeworICAgICAgICAgICAg Ly8gRm9yY2UgbGF5b3V0IGJlZm9yZSBnZXR0aW5nIHZpZXdwb3J0IHdpZHRoLgorICAgICAgICAg ICAgZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7CisgICAgICAgICAgICBvcmlnaW5hbFZpZXdwb3J0 V2lkdGggPSB3aW5kb3cuaW5uZXJXaWR0aDsKKworICAgICAgICAgICAgLy8gQXNzaWduaW5nIHRv IHdpbmRvdy5sb2NhdGlvbiBkb2VzIG5vdCBjcmVhdGUgYSBoaXN0b3J5IGVudHJ5LCBzbyBpbnN0 ZWFkIGxpbmsgY2xpY2sgaXMgc2ltdWxhdGVkLgorICAgICAgICAgICAgdmFyIGV2dCA9IGRvY3Vt ZW50LmNyZWF0ZUV2ZW50KCJNb3VzZUV2ZW50cyIpOworICAgICAgICAgICAgZXZ0LmluaXRNb3Vz ZUV2ZW50KCJjbGljayIsIHRydWUsIHRydWUsIHdpbmRvdywgMCwgMCwgMCwgMCwgMCwgZmFsc2Us IGZhbHNlLCBmYWxzZSwgZmFsc2UsIDAsIG51bGwpOworICAgICAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ2FuY2hvcicpLmRpc3BhdGNoRXZlbnQoZXZ0KTsKKyAgICAgICAgICAgIC8v IEluaXRpYXRlIHRpbWVyIHRvIGRvIGZpbmFsIHZlcmlmaWNhdGlvbiBhcyB3ZSBoYXZlIG5hdmln YXRlZCBiYWNrIHRvIHRoZSBjYWNoZWQgdmVyc2lvbiBvZiB0aGlzIHBhZ2UuCisgICAgICAgICAg ICAvLyBUaGlzIHRlc3QgbWFrZXMgdXNlIG9mIHRoZSBiZWhhdmlvciB3aGVyZSB0aW1lcnMgYXJl IHJlc3RvcmVkIG9uIGEgY2FjaGVkIHBhZ2UuCisgICAgICAgICAgICBzZXRUaW1lb3V0KCdjaGVj a1ZpZXdwb3J0V2lkdGhBZnRlckhpc3RvcnlOYXZpZ2F0aW9uKCknLCAxMDAwKTsKKworICAgICAg ICB9CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9J3NldFRpbWVvdXQoIm5h dmlnYXRlQXdheUFuZEJhY2soKSIsIDAgKTsnPgorICAgIDxhIGlkPSdhbmNob3InIGhyZWY9J2Rh dGE6dGV4dC9odG1sLAorICAgICAgICA8aHRtbD4KKyAgICAgICAgICAgIDxoZWFkPgorICAgICAg ICAgICAgICAgIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50PSJ3aWR0aD02MDAiPgorICAg ICAgICAgICAgPC9oZWFkPgorICAgICAgICAgICAgPGJvZHkgb25sb2FkPSJkb2N1bWVudC5ib2R5 Lm9mZnNldFRvcDsgaGlzdG9yeS5iYWNrKCk7Ij48L2JvZHk+CisgICAgICAgIDwvaHRtbD4nPgor ICAgIDwvYT4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjQy MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDIwIEBACisyMDEyLTAzLTI4ICBaYWxhbiBCdWp0YXMgIDx6YnVqdGFzQGdtYWlsLmNvbT4KKwor ICAgICAgICBSZW1vdmUgcmVkdW5kYW50IHVwZGF0ZVZpZXdwb3J0QXJndW1lbnRzKCkgY2FsbCB3 aGVuIHBhZ2UgaXMgcmVzdG9yZWQgZnJvbSBwYWdlIGNhY2hlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI1MDAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb2N1bWVudDo6dXBkYXRlVmlld3BvcnRBcmd1 bWVudHMoKSBpcyBjYWxsZWQgdHdpY2UsIHdoaWxlIHJlc3RvcmluZyBhIHBhZ2UgZnJvbSBwYWdl IGNhY2hlLgorICAgICAgICBGaXJzdCwgaXQgaXMgY2FsbGVkIHdoZW4gdGhlIGRvY3VtZW50IGlz IHNldCBvbiB0aGUgbWFpbmZyYW1lIGFuZCBsYXRlciwgaXQgaXMgY2FsbGVkCisgICAgICAgIHdo ZW4gcGFnZSBjYWNoZSBmaW5pc2hlZCB0aGUgcmVzdG9yYXRpb24uIFNpbmNlIHZpZXdwb3J0IGFy Z3VtZW50cyBkb24ndCBjaGFuZ2UgYmV0d2VlbgorICAgICAgICB0aGUgMiBjYWxscywgaXQncyBz YWZlIHRvIHJlbW92ZSB0aGUgc2Vjb25kLgorCisgICAgICAgIE1hbnVhbCB0ZXN0IGFkZGVkLiBW aWV3cG9ydCB2YWx1ZSB1cGRhdGVzIGhlYXZpbHkgZGVwZW5kIG9uIFVJIHByb2Nlc3MgY29kZS4K KworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVu dDo6ZG9jdW1lbnREaWRSZXN1bWVGcm9tUGFnZUNhY2hlKToKKwogMjAxMi0wMy0yOCAgVG9tbXkg V2lkZW5mbHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIE1l ZGlhU3RyZWFtIEFQSSAoSlNFUCk6IEludHJvZHVjaW5nIFdlYlBlZXJDb25uZWN0aW9uMDBIYW5k bGVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDExMjQyMikKKysrIFNv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyMjIsOCAr NDIyMiw2IEBAIHZvaWQgRG9jdW1lbnQ6OmRvY3VtZW50RGlkUmVzdW1lRnJvbVBhZ2UKIAogICAg IEFTU0VSVChtX2ZyYW1lKTsKICAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCktPmRpc3Bh dGNoRGlkQmVjb21lRnJhbWVzZXQoaXNGcmFtZVNldCgpKTsKLQotICAgIHVwZGF0ZVZpZXdwb3J0 QXJndW1lbnRzKCk7CiB9CiAKIHZvaWQgRG9jdW1lbnQ6OnJlZ2lzdGVyRm9yUGFnZUNhY2hlU3Vz cGVuc2lvbkNhbGxiYWNrcyhFbGVtZW50KiBlKQo=