82493 2012-03-28 11:33:00 -0700 extract-built-product build step should fail if unzipping fails 2012-03-28 14:21:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82494 1 simon.fraser rniwa lforschler rniwa oldest_to_newest 590198 0 simon.fraser 2012-03-28 11:33:00 -0700 http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/19311/steps/extract-built-product/logs/stdio This step appears to succeed, even though ditto returns an error (the file contents are actually a 404 HTML page). 590419 1 134396 rniwa 2012-03-28 14:17:20 -0700 Created attachment 134396 Return non-zero exit code when subprocesses fail 590430 2 rniwa 2012-03-28 14:21:55 -0700 Committed r112440: <http://trac.webkit.org/changeset/112440> 134396 2012-03-28 14:17:20 -0700 2012-03-28 14:17:42 -0700 Return non-zero exit code when subprocesses fail bug-82493-20120328141719.patch text/plain 1770 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMjQzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTAzLTI4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIGV4dHJhY3QtYnVpbHQtcHJvZHVjdCBidWlsZCBzdGVwIHNob3VsZCBmYWlsIGlm IHVuemlwcGluZyBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODI0OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGb3J3YXJkIG5vbi16ZXJvIGV4aXQgY29kZSBmcm9tIHN1YnByb2Nlc3NlcyBzbyB0 aGF0IHRoZSBtYXN0ZXIgY2FuIGRldGVjdCBhbnkgZmFpbHVyZXMKKyAgICAgICAgYW5kIGJhaWwg b3V0IGVhcmx5LgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1h cmNoaXZlOgorICAgICAgICAobWFpbik6CisKIDIwMTItMDMtMjggIERpcmsgUHJhbmtlICA8ZHBy YW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgdGVzdC13ZWJraXRweSBzaG91bGQgc3VwcG9y dCBmaWxlcywgZGlyZWN0b3JpZXMsIGFuZCBwYWNrYWdlcyBhcyBjb21tYW5kIGxpbmUgYXJncwpJ bmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZQko cmV2aXNpb24gMTEyMjgzKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVj dC1hcmNoaXZlCSh3b3JraW5nIGNvcHkpCkBAIC0zNiwxNSArMzYsMTggQEAgZGVmIG1haW4oKToK ICAgICBvcHRpb25zLCAoYWN0aW9uLCApID0gcGFyc2VyLnBhcnNlX2FyZ3MoKQogICAgIGlmIG5v dCBvcHRpb25zLnBsYXRmb3JtOgogICAgICAgICBwYXJzZXIuZXJyb3IoIlBsYXRmb3JtIGlzIHJl cXVpcmVkIikKKyAgICAgICAgcmV0dXJuIDEKICAgICBpZiBub3Qgb3B0aW9ucy5jb25maWd1cmF0 aW9uOgogICAgICAgICBwYXJzZXIuZXJyb3IoIkNvbmZpZ3VyYXRpb24gaXMgcmVxdWlyZWQiKQor ICAgICAgICByZXR1cm4gMQogICAgIGlmIGFjdGlvbiBub3QgaW4gKCdhcmNoaXZlJywgJ2V4dHJh Y3QnKToKICAgICAgICAgcGFyc2VyLmVycm9yKCJBY3Rpb24gaXMgcmVxdWlyZWQiKQorICAgICAg ICByZXR1cm4gMQogCiAgICAgaWYgYWN0aW9uID09ICdhcmNoaXZlJzoKLSAgICAgICAgYXJjaGl2 ZUJ1aWx0UHJvZHVjdChvcHRpb25zLmNvbmZpZ3VyYXRpb24sIG9wdGlvbnMucGxhdGZvcm0pCisg ICAgICAgIHJldHVybiBhcmNoaXZlQnVpbHRQcm9kdWN0KG9wdGlvbnMuY29uZmlndXJhdGlvbiwg b3B0aW9ucy5wbGF0Zm9ybSkKICAgICBlbHNlOgotICAgICAgICBleHRyYWN0QnVpbHRQcm9kdWN0 KG9wdGlvbnMuY29uZmlndXJhdGlvbiwgb3B0aW9ucy5wbGF0Zm9ybSkKKyAgICAgICAgcmV0dXJu IGV4dHJhY3RCdWlsdFByb2R1Y3Qob3B0aW9ucy5jb25maWd1cmF0aW9uLCBvcHRpb25zLnBsYXRm b3JtKQogCiAKIGRlZiBhcmNoaXZlQnVpbHRQcm9kdWN0KGNvbmZpZ3VyYXRpb24sIHBsYXRmb3Jt KToK