82491 2012-03-28 11:31:51 -0700 download-built-product build step should detect 404 errors 2012-03-30 15:30:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82494 1 simon.fraser simon.fraser jberlin lforschler rniwa simon.fraser oldest_to_newest 590192 0 simon.fraser 2012-03-28 11:31:51 -0700 http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/19311/steps/download-built-product/logs/stdio This shows no error, even though the file is missing. curl -f would spit out an error message: 76$ $ curl -f --output WebKitBuild/release.zip http://build.webkit.org/archives/mac-snowleopard-x86_64-release/112364.zip % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 590385 1 134389 simon.fraser 2012-03-28 13:55:02 -0700 Created attachment 134389 Patch 590403 2 134389 rniwa 2012-03-28 14:03:52 -0700 Comment on attachment 134389 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134389&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:237 > + command = ["curl", "--fail", "--output", WithProperties("WebKitBuild/%(configuration)s.zip"), WithProperties(c["buildbotURL"] + "archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(got_revision)s.zip")] On my SnowLeopard man curl says: (HTTP) Fail silently (no output at all) on server errors. This is mostly done to better enable scripts etc to better deal with failed attempts. In normal cases when a HTTP server fails to deliver a document, it returns an HTML document stating so (which often also describes why and more). This flag will prevent curl from outputting that and return error 22. This method is not fail-safe and there are occasions where non-successful response codes will slip through, especially when authentication is involved (response codes 401 and 407). It seems like the opposite of what we want. Or maybe the man page is wrong? 590408 3 simon.fraser 2012-03-28 14:08:05 -0700 I think the man page is confused: smfr$ curl -O http://www.webkit.org/nonexistant.html % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 214 100 214 0 0 10046 0 --:--:-- --:--:-- --:--:-- 17833 smfr$ echo $? 0 smfr$ curl -O --fail http://www.webkit.org/nonexistant.html % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 smfr$ echo $? 22 590421 4 134389 rniwa 2012-03-28 14:17:55 -0700 Comment on attachment 134389 Patch Okay. 592556 5 simon.fraser 2012-03-30 15:30:37 -0700 Fixed in r112443. Shown to be working. 134389 2012-03-28 13:55:02 -0700 2012-03-28 14:17:54 -0700 Patch bug-82491-20120328135501.patch text/plain 2655 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNDM1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDFlMjEzNzk5MmM5NWY1ZDI5MzUwMmViYTJiMWVlNmM3 MzkxZWNhMy4uODU5YTk2MjYwN2IwMjFiOWFmOGZlMDY0NjI2MzU3MmE0MGE4MzIwNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDEyLTAzLTI4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgog CisgICAgICAgIGRvd25sb2FkLWJ1aWx0LXByb2R1Y3QgYnVpbGQgc3RlcCBzaG91bGQgZGV0ZWN0 IDQwNCBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgyNDkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAg IAorICAgICAgICBQYXNzIC0tZmFpbCB0byBjdXJsIHNvIHRoYXQgaXQgcmVwb3J0cyA0MDQgZXJy b3JzLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvbWFzdGVyLmNmZzoKKyAgICAgICAgKERvd25sb2FkQnVpbHRQcm9kdWN0KTogUGFzcyAtLWZh aWwgdG8gY3VybCBzbyB0aGF0IGl0IHJlcG9ydHMgZXJyb3JzLgorICAgICAgICAqIEJ1aWxkU2xh dmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZToKKyAgICAgICAgKGV4dHJhY3RCdWlsdFBy b2R1Y3QpOiBSZW1vdmUgdHJhaWxpbmcgd2hpdGVzcGFjZS4KKworMjAxMi0wMy0yOCAgU2ltb24g RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBGaXggaW5zcGVjdG9y IHRlc3RzIHdoZW4gcnVubmluZyBpbiBpbnRlcm5hbCBidWlsZHMuCiAKICAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzExMDUwNjk0PgpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKaW5kZXggNDFiYzFiYWQ1YzZj YWMyMGE4M2U2ZjJjYWFmMWY5YzEzY2E2NjYxNC4uMmIwOTRkYmZlODYyNjlkMTdmYmQ2OGQ3MzZj MGYxNGVmODNlYTNiMSAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCkBAIC0yMzQsNyArMjM0LDcgQEAg Y2xhc3MgVXBsb2FkQnVpbHRQcm9kdWN0KHRyYW5zZmVyLkZpbGVVcGxvYWQpOgogCiAKIGNsYXNz IERvd25sb2FkQnVpbHRQcm9kdWN0KHNoZWxsLlNoZWxsQ29tbWFuZCk6Ci0gICAgY29tbWFuZCA9 IFsiY3VybCIsICItLW91dHB1dCIsIFdpdGhQcm9wZXJ0aWVzKCJXZWJLaXRCdWlsZC8lKGNvbmZp Z3VyYXRpb24pcy56aXAiKSwgV2l0aFByb3BlcnRpZXMoY1siYnVpbGRib3RVUkwiXSArICJhcmNo aXZlcy8lKGZ1bGxQbGF0Zm9ybSlzLSUoYXJjaGl0ZWN0dXJlKXMtJShjb25maWd1cmF0aW9uKXMv JShnb3RfcmV2aXNpb24pcy56aXAiKV0KKyAgICBjb21tYW5kID0gWyJjdXJsIiwgIi0tZmFpbCIs ICItLW91dHB1dCIsIFdpdGhQcm9wZXJ0aWVzKCJXZWJLaXRCdWlsZC8lKGNvbmZpZ3VyYXRpb24p cy56aXAiKSwgV2l0aFByb3BlcnRpZXMoY1siYnVpbGRib3RVUkwiXSArICJhcmNoaXZlcy8lKGZ1 bGxQbGF0Zm9ybSlzLSUoYXJjaGl0ZWN0dXJlKXMtJShjb25maWd1cmF0aW9uKXMvJShnb3RfcmV2 aXNpb24pcy56aXAiKV0KICAgICBuYW1lID0gImRvd25sb2FkLWJ1aWx0LXByb2R1Y3QiCiAgICAg ZGVzY3JpcHRpb24gPSBbImRvd25sb2FkaW5nIGJ1aWx0IHByb2R1Y3QiXQogICAgIGRlc2NyaXB0 aW9uRG9uZSA9IFsiZG93bmxvYWRlZCBidWlsdCBwcm9kdWN0Il0KZGlmZiAtLWdpdCBhL1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZSBiL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZQppbmRleCBmN2U1NmUzMTgzN2ZhZGMwYjQz Mjg2NGEyYTgxM2NkZmE3Y2NjODAyLi43ZjQ5OGVhOTZkNDJmZmMxM2MwYTMwN2MyN2QzMDBjYjhm N2U0ZmZhIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0 LWFyY2hpdmUKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNo aXZlCkBAIC0xMjQsNyArMTI0LDcgQEAgZGVmIGV4dHJhY3RCdWlsdFByb2R1Y3QoY29uZmlndXJh dGlvbiwgcGxhdGZvcm0pOgogICAgICAgICBvcy51bmxpbmsoYXJjaGl2ZUZpbGUpCiAKICAgICBl bGlmIHBsYXRmb3JtID09ICd3aW4nOgotICAgICAgICBiaW5EaXJlY3RvcnkgPSBvcy5wYXRoLmpv aW4oY29uZmlndXJhdGlvbkJ1aWxkRGlyZWN0b3J5LCAiYmluIikgICAgICAgIAorICAgICAgICBi aW5EaXJlY3RvcnkgPSBvcy5wYXRoLmpvaW4oY29uZmlndXJhdGlvbkJ1aWxkRGlyZWN0b3J5LCAi YmluIikKICAgICAgICAgaWYgb3MucGF0aC5pc2RpcihiaW5EaXJlY3RvcnkpOgogICAgICAgICAg ICAgc2h1dGlsLnJtdHJlZShiaW5EaXJlY3RvcnkpCiAK