82484 2012-03-28 10:55:59 -0700 [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92 2012-04-19 14:05:58 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar d-r danw d-r mrobinson pnormand rakuco svillar webkit.review.bot oldest_to_newest 590140 0 svillar 2012-03-28 10:55:59 -0700 These are the tests that timeout. fast/encoding/percent-escaping.html fast/loader/file-URL-with-port-number.html fast/loader/location-port.html I'm skipping them for the moment as it seems it's a bug in libsoup. The culprit seems to be this commit 38aab0e2b. 591203 1 danw 2012-03-29 08:16:54 -0700 fast/loader/file-URL-with-port-number.html passes for me 591704 2 134692 danw 2012-03-29 16:46:59 -0700 Created attachment 134692 libsoup patch to fix fast/encoding/percent-escaping Can you try this patch against libsoup? It definitely fixes the percent-escaping test, but I seem to get lots of other differences in the test output (mostly in -stderr.txt files) as well, but I can't be sure if that's because of an actual behavior change, or just random trying-to-run-tests-on-a-non-blessed-machine flakiness. 591964 3 svillar 2012-03-30 01:55:55 -0700 (In reply to comment #2) > Created an attachment (id=134692) [details] > libsoup patch to fix fast/encoding/percent-escaping > > Can you try this patch against libsoup? It definitely fixes the percent-escaping test, but I seem to get lots of other differences in the test output (mostly in -stderr.txt files) as well, but I can't be sure if that's because of an actual behavior change, or just random trying-to-run-tests-on-a-non-blessed-machine flakiness. It fixes that one indeed but the other two are still failing. Wouldn't it be simpler just to back to soup_uri_decode()/g_file_new_for_path() and put the windows code inside some guards? Yeah I know it isn't very beautiful and that libsoup code does not have things like that, but if the glib implementations behave in a different way ... I mention that because I asked the author of the commit and he kind of remembers some issues with slashes when using g_file_new_for_path(), that's why he switched to g_file_new_for_uri(). 599599 4 danw 2012-04-10 13:58:14 -0700 (In reply to comment #3) > It fixes that one indeed but the other two are still failing. Ah, I thought fast/loader/file-URL-with-port-number.html was passing, because it shows "SUCCESS" if you run it in GtkLauncher, but that's just because the test isn't distinguishing the requested resource from an error page... However, fast/loader/location-port.html is completely unrelated; it fails with any version of libsoup. Perhaps it's because of something that changed in ResourceHandleSoup.cpp rather than something that changed in libsoup? 600260 5 danw 2012-04-11 07:51:47 -0700 fast/encoding/percent-escaping.html and fast/loader/file-URL-with-port-number.html are now fixed with the latest libsoup, and the fix will also be in 2.38.1. I don't know if it's worth bumping the requirements over. (If we want to un-skip the tests we could just update the packages on the bots without changing the required minimum version.) 600266 6 mrobinson 2012-04-11 07:58:11 -0700 (In reply to comment #5) > fast/encoding/percent-escaping.html and fast/loader/file-URL-with-port-number.html are now fixed with the latest libsoup, and the fix will also be in 2.38.1. I don't know if it's worth bumping the requirements over. (If we want to un-skip the tests we could just update the packages on the bots without changing the required minimum version.) We can just update the version in the WebKit jhbuild and unskip. 605502 7 d-r 2012-04-19 04:53:09 -0700 Same failures in EFL of course, I'll take a look. 605537 8 137890 d-r 2012-04-19 06:29:00 -0700 Created attachment 137890 Bumping libsoup to 2.38.1 I tested the previously failing tests that were moved to the skip list as well as http/* On my machine, for GTK I got a couple of unexpected passes afterwards. Maybe Philippe can unskip them in a separate commit if that's verified on the buildbot? I figure these are related to bug 52798. Test / Expected Failure http/tests/loading/preload-append-scan.php fail http/tests/xmlhttprequest/redirect-cross-origin-sync.html timeout http/tests/xmlhttprequest/re-login-async.html fail http/tests/xmlhttprequest/redirect-cross-origin-post-sync.html timeout http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html timeout http/tests/xmlhttprequest/basic-auth-default.html fail http/tests/xmlhttprequest/cross-origin-authorization.html fail http/tests/xmlhttprequest/xmlhttprequest-contenttype-empty.html fail http/tests/xmlhttprequest/simple-cross-origin-progress-events.html timeout http/tests/media/video-cross-site.html fail http/tests/workers/text-encoding.html fail http/tests/cache/subresource-fragment-identifier.html fail http/tests/misc/dns-prefetch-control.html fail http/tests/misc/iframe-reparenting-id-collision.html fail http/tests/misc/favicon-loads-with-images-disabled.html fail http/tests/appcache/crash-when-navigating-away-then-back.html fail http/tests/appcache/auth.html fail http/tests/appcache/interrupted-update.html fail http/tests/incremental/split-hex-entities.pl timeout http/tests/security/cross-frame-access-object-getPrototypeOf.html fail http/tests/security/local-CSS-from-remote.html fail http/tests/security/local-iFrame-from-remote.html fail http/tests/security/local-user-CSS-from-remote.html fail http/tests/security/isolatedWorld/context-destroy.html fail http/tests/security/xssAuditor/xss-filter-bypass-sjis.html fail http/tests/security/xssAuditor/xss-filter-bypass-big5.html fail http/tests/security/local-image-from-remote.html fail http/tests/security/local-JavaScript-from-remote.html fail http/tests/security/drag-drop-same-unique-origin.html fail 605718 9 137890 webkit.review.bot 2012-04-19 11:18:15 -0700 Comment on attachment 137890 Bumping libsoup to 2.38.1 Clearing flags on attachment: 137890 Committed r114653: <http://trac.webkit.org/changeset/114653> 605719 10 webkit.review.bot 2012-04-19 11:18:20 -0700 All reviewed patches have been landed. Closing bug. 605721 11 rakuco 2012-04-19 11:18:47 -0700 Please remember to raise the libsoup versions in configure.ac and Source/cmake/OptionsEfl.cmake. 605863 12 mrobinson 2012-04-19 14:05:58 -0700 (In reply to comment #11) > Please remember to raise the libsoup versions in configure.ac and Source/cmake/OptionsEfl.cmake. This isn't actually a requirement in this case. The libsoup version in configure.ac is the necessary API level, whereas the version in jhbuild is what's necessary to pass the tests. 134692 2012-03-29 16:46:59 -0700 2012-03-29 16:46:59 -0700 libsoup patch to fix fast/encoding/percent-escaping 0001-SoupRequestFile-fix-up-bad-URIs.patch text/plain 1926 danw RnJvbSBhOTNkZGFjMWY4OTNhM2QxZDQ0OGU2MDc0NmQzOWMyYzRkN2YxMTVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW4gV2luc2hpcCA8ZGFud0Bnbm9tZS5vcmc+CkRhdGU6IFRo dSwgMjkgTWFyIDIwMTIgMTk6NDM6NDAgLTA0MDAKU3ViamVjdDogW1BBVENIXSBTb3VwUmVxdWVz dEZpbGU6IGZpeCB1cCBiYWQgVVJJcwoKU291cFVSSSBwcmVzZXJ2ZXMgbWFsZm9ybWVkIFVSSXMg YnkgZGVmYXVsdCwgYnV0IGdpbyB3aWxsIGNvbXBsYWluCmFib3V0IHRoZW0sIHNvIFNvdXBSZXF1 ZXN0RmlsZSBuZWVkcyB0byBmaXggdGhlbSB1cCBiZWZvcmUgcGFzc2luZwp0aGVtIG9uLgoKaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNDg0Ci0tLQogbGlic291cC9z b3VwLXJlcXVlc3QtZmlsZS5jIHwgICAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysKIDEgZmlsZSBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGli c291cC9zb3VwLXJlcXVlc3QtZmlsZS5jIGIvbGlic291cC9zb3VwLXJlcXVlc3QtZmlsZS5jCmlu ZGV4IGEyNmQ5OTQuLjEzODIxMDUgMTAwNjQ0Ci0tLSBhL2xpYnNvdXAvc291cC1yZXF1ZXN0LWZp bGUuYworKysgYi9saWJzb3VwL3NvdXAtcmVxdWVzdC1maWxlLmMKQEAgLTgwLDYgKzgwLDQwIEBA IHNvdXBfcmVxdWVzdF9maWxlX2NoZWNrX3VyaSAoU291cFJlcXVlc3QgICpyZXF1ZXN0LAogCXJl dHVybiBUUlVFOwogfQogCitzdGF0aWMgdm9pZAorbWF5YmVfZml4X3BlcmNlbnRfZW5jb2Rpbmcg KGNoYXIgKip1cmlfc3RyaW5nX3ApCit7CisJY2hhciAqdXJpX3N0cmluZyA9ICp1cmlfc3RyaW5n X3A7CisJY2hhciAqcDsKKwlHU3RyaW5nICpmaXhlZDsKKworCS8qIFNvdXBVUkkgcHJlc2VydmVz IGludmFsaWQgJS1lbmNvZGluZywgYmVjYXVzZSBzb21lIHdlYgorCSAqIHNpdGVzIGRlcGVuZCBv biB0aGlzLiBCdXQgZ2lvIHdpbGwgcmVqZWN0IGludmFsaWQgVVJJcy4KKwkgKi8KKwlmb3IgKHAg PSBzdHJjaHIgKHVyaV9zdHJpbmcsICclJyk7IHA7IHAgPSBzdHJjaHIgKHAgKyAxLCAnJScpKSB7 CisJCWlmICghZ19hc2NpaV9pc3hkaWdpdCAocFswXSkgfHwKKwkJICAgICFnX2FzY2lpX2lzeGRp Z2l0IChwWzFdKSkKKwkJCWJyZWFrOworCX0KKwlpZiAoIXApCisJCXJldHVybjsKKworCWZpeGVk ID0gZ19zdHJpbmdfbmV3IChOVUxMKTsKKwlnX3N0cmluZ19hcHBlbmRfbGVuIChmaXhlZCwgdXJp X3N0cmluZywgcCAtIHVyaV9zdHJpbmcpOworCXdoaWxlICgqcCkgeworCQlpZiAoKnAgPT0gJyUn ICYmCisJCSAgICAoIWdfYXNjaWlfaXN4ZGlnaXQgKHBbMV0pIHx8CisJCSAgICAgIWdfYXNjaWlf aXN4ZGlnaXQgKHBbMl0pKSkKKwkJCWdfc3RyaW5nX2FwcGVuZCAoZml4ZWQsICIlMjUiKTsKKwkJ ZWxzZQorCQkJZ19zdHJpbmdfYXBwZW5kX2MgKGZpeGVkLCAqcCk7CisJCXArKzsKKwl9CisKKwln X2ZyZWUgKHVyaV9zdHJpbmcpOworCSp1cmlfc3RyaW5nX3AgPSBnX3N0cmluZ19mcmVlIChmaXhl ZCwgRkFMU0UpOworfQorCiBzdGF0aWMgZ2Jvb2xlYW4KIHNvdXBfcmVxdWVzdF9maWxlX2Vuc3Vy ZV9maWxlIChTb3VwUmVxdWVzdEZpbGUgICpmaWxlLAogCQkJICAgICAgIEdDYW5jZWxsYWJsZSAg ICAgKmNhbmNlbGxhYmxlLApAQCAtMTAyLDYgKzEzNiw4IEBAIHNvdXBfcmVxdWVzdF9maWxlX2Vu c3VyZV9maWxlIChTb3VwUmVxdWVzdEZpbGUgICpmaWxlLAogCX0KIAogCXVyaV9zdHIgPSBzb3Vw X3VyaV90b19zdHJpbmcgKHVyaSwgRkFMU0UpOworCW1heWJlX2ZpeF9wZXJjZW50X2VuY29kaW5n ICgmdXJpX3N0cik7CisKIAlmaWxlLT5wcml2LT5nZmlsZSA9IGdfZmlsZV9uZXdfZm9yX3VyaSAo dXJpX3N0cik7CiAKIAlnX2ZyZWUgKHVyaV9zdHIpOwotLSAKMS43LjkuMwoK 137890 2012-04-19 06:29:00 -0700 2012-04-19 11:18:15 -0700 Bumping libsoup to 2.38.1 bug82484.patch text/plain 3286 d-r ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiNGQyNWE4Li45ODBiYjAyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDQt MTkgIERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsucm90dHNjaGVzQGxpbnV4LmludGVsLmNv bT4KKworICAgICAgICBbR1RLXSAzIGZhc3QvIGxheW91dCB0ZXN0cyBmYWlsaW5nIGFmdGVyIHVw Z3JhZGluZyBsaWJzb3VwIHRvIDIuMzcuOTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTgyNDg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVW5za2lwcGluZyB0ZXN0cyB0aGF0IHdlcmUgcHJldmlvdXNseSBm YWlsaW5nIGR1ZSB0byBhIGJ1ZyBpbiBsaWJzb3VwLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMi0wNC0xOCAgVGFrYXNoaSBUb3lvc2hpbWEg IDx0b3lvc2hpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYWRkIGV4cGVj dGVkLnR4dCBmb3IgY29va2llcy13cm9uZy1kb21haW4tcmVqZWN0ZWQtcmVzdWx0LnBocCAuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvdGVzdF9leHBlY3RhdGlvbnMudHh0 IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCA4 YzViZDBhLi5jMmE1NzliIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvdGVz dF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay90ZXN0X2V4 cGVjdGF0aW9ucy50eHQKQEAgLTUzMiwxMSArNTMyLDYgQEAgQlVHV0s3NDI3MCA6IGZhc3QvZm9y bXMvYmFzaWMtc2VsZWN0cy5odG1sID0gRkFJTAogCiBCVUdXSzc5NzU3IDogZmFzdC9zZWxlY3Rv cnMvc2VsZWN0aW9uLXdpbmRvdy1pbmFjdGl2ZS5odG1sID0gSU1BR0UgRkFJTAogCi0vLyBTdGFy dGVkIHRvIGZhaWwgYWZ0ZXIgdXBncmFkaW5nIGxpYnNvdXAgdG8gMi4zNy45MgotQlVHV0s4MjQ4 NCA6IGZhc3QvZW5jb2RpbmcvcGVyY2VudC1lc2NhcGluZy5odG1sID0gVEVYVAotQlVHV0s4MjQ4 NCA6IGZhc3QvbG9hZGVyL2ZpbGUtVVJMLXdpdGgtcG9ydC1udW1iZXIuaHRtbCA9IFRFWFQKLUJV R1dLODI0ODQgOiBmYXN0L2xvYWRlci9sb2NhdGlvbi1wb3J0Lmh0bWwgPSBURVhUCi0KIEJVR1dL R1RLIDogYWNjZXNzaWJpbGl0eS9hcmlhLWhpZGRlbi5odG1sID0gRkFJTAogQlVHV0tHVEsgOiBh Y2Nlc3NpYmlsaXR5L2FyaWEtaGlkZGVuLXdpdGgtZWxlbWVudHMuaHRtbCA9IEZBSUwKIEJVR1dL R1RLIDogYWNjZXNzaWJpbGl0eS9hcmlhLWludmFsaWQuaHRtbCA9IEZBSUwKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNWMyZGUwLi44YTZiYjk5 IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTItMDQtMTkgIERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsucm90 dHNjaGVzQGxpbnV4LmludGVsLmNvbT4KKworICAgICAgICBbR1RLXSAzIGZhc3QvIGxheW91dCB0 ZXN0cyBmYWlsaW5nIGFmdGVyIHVwZ3JhZGluZyBsaWJzb3VwIHRvIDIuMzcuOTIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNDg0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVtcGluZyBsaWJzb3VwIHRv IHZlcnNpb24gMi4zOC4xIHdoaWNoIGZpeGVzIHRoZSBhYm92ZSBXZWJLaXQgYnVnLgorCisgICAg ICAgICogZWZsL2poYnVpbGQubW9kdWxlczoKKyAgICAgICAgKiBndGsvamhidWlsZC5tb2R1bGVz OgorCiAyMDEyLTA0LTE4ICBIaXJvbm9yaSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFNwbGl0IFNwZWxsQ2hlY2tlcjo6ZGlkQ2hlY2soKSB0byBTcGVsbENoZWNrZXI6OmRp ZENoZWNrU3VjY2VlZGVkKCkgYW5kIFNwZWxsQ2hlY2tlcjo6ZGlkQ2hlY2tDYW5jZWxlZCgpCmRp ZmYgLS1naXQgYS9Ub29scy9lZmwvamhidWlsZC5tb2R1bGVzIGIvVG9vbHMvZWZsL2poYnVpbGQu bW9kdWxlcwppbmRleCAyZWI3Yzc5Li4zM2JmODY5IDEwMDY0NAotLS0gYS9Ub29scy9lZmwvamhi dWlsZC5tb2R1bGVzCisrKyBiL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMKQEAgLTE0Miw5ICsx NDIsOSBAQAogICAgIDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWItbmV0 d29ya2luZyIvPgogICAgIDwvZGVwZW5kZW5jaWVzPgotICAgIDxicmFuY2ggbW9kdWxlPSJsaWJz b3VwIiB2ZXJzaW9uPSIyLjM3LjkyIgorICAgIDxicmFuY2ggbW9kdWxlPSJsaWJzb3VwIiB2ZXJz aW9uPSIyLjM4LjEiCiAgICAgICAgICAgICByZXBvPSJnaXQuZ25vbWUub3JnIgotICAgICAgICAg ICAgdGFnPSJhZmNmZjcxMTVhNmMzNmNhM2RlNWJjODg5OTQxNzRmNWEwZTAxOTU2Ii8+CisgICAg ICAgICAgICB0YWc9IkxJQlNPVVBfMl8zOF8xIi8+CiAgIDwvYXV0b3Rvb2xzPgogCiAgIDxhdXRv dG9vbHMgaWQ9ImZvbnRjb25maWciIGF1dG9nZW4tc2g9ImNvbmZpZ3VyZSI+CmRpZmYgLS1naXQg YS9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzIGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwpp bmRleCBkYzQxYWEzLi5mODU1M2QyIDEwMDY0NAotLS0gYS9Ub29scy9ndGsvamhidWlsZC5tb2R1 bGVzCisrKyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKQEAgLTE2MCw5ICsxNjAsOSBAQAog ICAgIDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWItbmV0d29ya2luZyIv PgogICAgIDwvZGVwZW5kZW5jaWVzPgotICAgIDxicmFuY2ggbW9kdWxlPSJsaWJzb3VwIiB2ZXJz aW9uPSIyLjM3LjkyIgorICAgIDxicmFuY2ggbW9kdWxlPSJsaWJzb3VwIiB2ZXJzaW9uPSIyLjM4 LjEiCiAgICAgICAgICAgICByZXBvPSJnaXQuZ25vbWUub3JnIgotICAgICAgICAgICAgdGFnPSJh ZmNmZjcxMTVhNmMzNmNhM2RlNWJjODg5OTQxNzRmNWEwZTAxOTU2Ii8+CisgICAgICAgICAgICB0 YWc9IkxJQlNPVVBfMl8zOF8xIi8+CiAgIDwvYXV0b3Rvb2xzPgogCiAgIDxhdXRvdG9vbHMgaWQ9 ImZvbnRjb25maWciIGF1dG9nZW4tc2g9ImNvbmZpZ3VyZSI+Cg==