82477 2012-03-28 10:12:55 -0700 Web Inspector: Implement snippets renaming in scripts navigator. 2012-03-28 11:23:22 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 590078 0 vsevik 2012-03-28 10:12:55 -0700 Implement snippets renaming in scripts navigator. 590084 1 134325 vsevik 2012-03-28 10:16:38 -0700 Created attachment 134325 Patch 590090 2 134325 pfeldman 2012-03-28 10:19:06 -0700 Comment on attachment 134325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134325&action=review > Source/WebCore/inspector/front-end/ScriptsNavigator.js:366 > + WebInspector.markBeingEdited(scriptTreeElement.treeOutline.element, true); Adding comment here would not hurt. 590183 3 vsevik 2012-03-28 11:23:22 -0700 Committed r112416: <http://trac.webkit.org/changeset/112416> 134325 2012-03-28 10:16:38 -0700 2012-03-28 10:19:05 -0700 Patch bug-82477-20120328211636.patch text/plain 5765 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTIxMDU0YzczYjE2MTE4 MmQ5ZWFkNzI0MGViNmNiMWI1M2MxMTRjZC4uZjkzYjdmMTgyNGRmMjQyYTY0YjQ5ZTM5NjRhMmY4 NWI4NDlhODM0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTAzLTI4ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEltcGxlbWVudCBzbmlwcGV0cyByZW5hbWluZyBpbiBzY3JpcHRzIG5hdmlnYXRvci4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNDc3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU25pcHBldHMgcmVu YW1pbmcgaXMgaW1wbGVtZW50ZWQgYXMgZWRpdGluZyBvZiBzbmlwcGV0IG5hbWUgaW4gc2NyaXB0 cyBuYXZpZ2F0b3IuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNOYXZp Z2F0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0c05hdmlnYXRvci5wcm90b3R5 cGUuX2hhbmRsZVJlbmFtZVNuaXBwZXQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNO YXZpZ2F0b3IucHJvdG90eXBlLl9maWxlUmVuYW1lZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu U2NyaXB0c05hdmlnYXRvci5wcm90b3R5cGUucmVuYW1lLmNvbW1pdEhhbmRsZXIpOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNOYXZpZ2F0b3IucHJvdG90eXBlLnJlbmFtZS5jYW5jZWxI YW5kbGVyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRzTmF2aWdhdG9yLnByb3RvdHlw ZS5yZW5hbWUuYWZ0ZXJFZGl0aW5nKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5CYXNlTmF2aWdh dG9yVHJlZUVsZW1lbnQucHJvdG90eXBlLnNldCB0aXRsZVRleHQpOgorICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvc2NyaXB0c1BhbmVsLmNzczoKKyAgICAgICAgKCNzY3JpcHRzLW5hdmln YXRvci10YWJiZWQtcGFuZSAubmF2aWdhdG9yIC5iYXNlLW5hdmlnYXRvci10cmVlLWVsZW1lbnQt dGl0bGUuZWRpdGluZyk6CisKKzIwMTItMDMtMjggIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0Bj aHJvbWl1bS5vcmc+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIGNvbnRleHQgbWVudSBm b3Igc25pcHBldHMgY29udHJvbC4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgyNDc1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU2NyaXB0c05hdmlnYXRvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU2NyaXB0c05hdmlnYXRvci5qcwppbmRleCAzMmU2NTU4ZGM0NGRmZTRlYTVm NDhlZmU1OGQxZmZkNzFiMmIxYTRhLi5mNDdiYTkyYmRkZTczMzY3YzY1NmE5Y2FjNjYzNjk4MDU3 YWRlOWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Nj cmlwdHNOYXZpZ2F0b3IuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9TY3JpcHRzTmF2aWdhdG9yLmpzCkBAIC0xMzUsOSArMTM1LDkgQEAgV2ViSW5zcGVjdG9yLlNj cmlwdHNOYXZpZ2F0b3IucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy5fc2NyaXB0VHJl ZUVsZW1lbnRzQnlVSVNvdXJjZUNvZGUuZ2V0KHVpU291cmNlQ29kZSkpCiAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgIAotICAgICAgICB2YXIgc2NyaXB0VGl0bGUgPSB1aVNvdXJjZUNvZGUu ZmlsZU5hbWUgfHwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIocHJvZ3JhbSkiKTsKLSAgICAgICAg dmFyIHNjcmlwdFRyZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5OYXZpZ2F0b3JTY3JpcHRU cmVlRWxlbWVudCh0aGlzLCB1aVNvdXJjZUNvZGUsIHNjcmlwdFRpdGxlKTsKKyAgICAgICAgdmFy IHNjcmlwdFRyZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5OYXZpZ2F0b3JTY3JpcHRUcmVl RWxlbWVudCh0aGlzLCB1aVNvdXJjZUNvZGUsICIiKTsKICAgICAgICAgdGhpcy5fc2NyaXB0VHJl ZUVsZW1lbnRzQnlVSVNvdXJjZUNvZGUucHV0KHVpU291cmNlQ29kZSwgc2NyaXB0VHJlZUVsZW1l bnQpOworICAgICAgICB0aGlzLl91cGRhdGVTY3JpcHRUaXRsZSh1aVNvdXJjZUNvZGUpOwogCiAg ICAgICAgIHZhciBmb2xkZXJUcmVlRWxlbWVudCA9IHRoaXMuX2dldE9yQ3JlYXRlRm9sZGVyVHJl ZUVsZW1lbnQodWlTb3VyY2VDb2RlKTsKICAgICAgICAgZm9sZGVyVHJlZUVsZW1lbnQuYXBwZW5k Q2hpbGQoc2NyaXB0VHJlZUVsZW1lbnQpOwpAQCAtMTQ1LDYgKzE0NSwxOCBAQCBXZWJJbnNwZWN0 b3IuU2NyaXB0c05hdmlnYXRvci5wcm90b3R5cGUgPSB7CiAKICAgICAvKioKICAgICAgKiBAcGFy YW0ge1dlYkluc3BlY3Rvci5VSVNvdXJjZUNvZGV9IHVpU291cmNlQ29kZQorICAgICAqLworICAg IF91cGRhdGVTY3JpcHRUaXRsZTogZnVuY3Rpb24odWlTb3VyY2VDb2RlKQorICAgIHsKKyAgICAg ICAgdmFyIHNjcmlwdFRyZWVFbGVtZW50ID0gdGhpcy5fc2NyaXB0VHJlZUVsZW1lbnRzQnlVSVNv dXJjZUNvZGUuZ2V0KHVpU291cmNlQ29kZSk7CisgICAgICAgIGlmICghc2NyaXB0VHJlZUVsZW1l bnQpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIHZhciBzY3JpcHRUaXRsZSA9IHVpU291 cmNlQ29kZS5maWxlTmFtZSB8fCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIihwcm9ncmFtKSIpOwor ICAgICAgICBzY3JpcHRUcmVlRWxlbWVudC50aXRsZVRleHQgPSBzY3JpcHRUaXRsZTsKKyAgICB9 LAorCisgICAgLyoqCisgICAgICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuVUlTb3VyY2VDb2RlfSB1 aVNvdXJjZUNvZGUKICAgICAgKiBAcmV0dXJuIHtib29sZWFufQogICAgICAqLwogICAgIGlzU2Ny aXB0U291cmNlQWRkZWQ6IGZ1bmN0aW9uKHVpU291cmNlQ29kZSkKQEAgLTMxNyw3ICszMjksNyBA QCBXZWJJbnNwZWN0b3IuU2NyaXB0c05hdmlnYXRvci5wcm90b3R5cGUgPSB7CiAgICAgICovCiAg ICAgX2hhbmRsZVJlbmFtZVNuaXBwZXQ6IGZ1bmN0aW9uKHVpU291cmNlQ29kZSwgZXZlbnQpCiAg ICAgewotICAgICAgICAvLyBGSVhNRTogVG8gYmUgaW1wbGVtZW50ZWQuCisgICAgICAgIHRoaXMu cmVuYW1lKHVpU291cmNlQ29kZSk7CiAgICAgfSwKIAogICAgIC8qKgpAQCAtMzM3LDYgKzM0OSw0 NyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c05hdmlnYXRvci5wcm90b3R5cGUgPSB7CiAgICAgICAg IC8vIEZJWE1FOiBUbyBiZSBpbXBsZW1lbnRlZC4KICAgICB9LAogCisgICAgX2ZpbGVSZW5hbWVk OiBmdW5jdGlvbih1aVNvdXJjZUNvZGUsIG5ld1RpdGxlKQorICAgIHsKKyAgICAgICAgLy8gRklY TUU6IFRvIGJlIGltcGxlbWVudGVkLgorICAgIH0sCisKKyAgICAvKioKKyAgICAgKiBAcGFyYW0g e1dlYkluc3BlY3Rvci5VSVNvdXJjZUNvZGV9IHVpU291cmNlQ29kZQorICAgICAqLworICAgIHJl bmFtZTogZnVuY3Rpb24odWlTb3VyY2VDb2RlLCBjYWxsYmFjaykKKyAgICB7CisgICAgICAgIHZh ciBzY3JpcHRUcmVlRWxlbWVudCA9IHRoaXMuX3NjcmlwdFRyZWVFbGVtZW50c0J5VUlTb3VyY2VD b2RlLmdldCh1aVNvdXJjZUNvZGUpOworICAgICAgICBpZiAoIXNjcmlwdFRyZWVFbGVtZW50KQor ICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIFdlYkluc3BlY3Rvci5tYXJrQmVpbmdFZGl0 ZWQoc2NyaXB0VHJlZUVsZW1lbnQudHJlZU91dGxpbmUuZWxlbWVudCwgdHJ1ZSk7CisKKyAgICAg ICAgZnVuY3Rpb24gY29tbWl0SGFuZGxlcihlbGVtZW50LCBuZXdUaXRsZSwgb2xkVGl0bGUpCisg ICAgICAgIHsKKyAgICAgICAgICAgIGlmIChuZXdUaXRsZSAmJiBuZXdUaXRsZSAhPT0gb2xkVGl0 bGUpCisgICAgICAgICAgICAgICAgdGhpcy5fZmlsZVJlbmFtZWQodWlTb3VyY2VDb2RlLCBuZXdU aXRsZSk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgdGhpcy5fdXBkYXRlU2Ny aXB0VGl0bGUodWlTb3VyY2VDb2RlKTsKKyAgICAgICAgICAgIGFmdGVyRWRpdGluZygpOworICAg ICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gY2FuY2VsSGFuZGxlcigpCisgICAgICAgIHsKKyAg ICAgICAgICAgIGFmdGVyRWRpdGluZygpOworICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24g YWZ0ZXJFZGl0aW5nKCkKKyAgICAgICAgeworICAgICAgICAgICAgV2ViSW5zcGVjdG9yLm1hcmtC ZWluZ0VkaXRlZChzY3JpcHRUcmVlRWxlbWVudC50cmVlT3V0bGluZS5lbGVtZW50LCBmYWxzZSk7 CisgICAgICAgICAgICBjYWxsYmFjaygpOworICAgICAgICB9CisKKyAgICAgICAgdmFyIGVkaXRp bmdDb25maWcgPSBuZXcgV2ViSW5zcGVjdG9yLkVkaXRpbmdDb25maWcoY29tbWl0SGFuZGxlci5i aW5kKHRoaXMpLCBjYW5jZWxIYW5kbGVyLmJpbmQodGhpcykpOworICAgICAgICBXZWJJbnNwZWN0 b3Iuc3RhcnRFZGl0aW5nKHNjcmlwdFRyZWVFbGVtZW50LnRpdGxlRWxlbWVudCwgZWRpdGluZ0Nv bmZpZyk7CisgICAgICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRCYXNlQW5kRXh0ZW50KHNj cmlwdFRyZWVFbGVtZW50LnRpdGxlRWxlbWVudCwgMCwgc2NyaXB0VHJlZUVsZW1lbnQudGl0bGVF bGVtZW50LCAxKTsKKyAgICB9LAorCiAgICAgcmVzZXQ6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAg ICAgIHRoaXMuX3NjcmlwdHNUcmVlLnN0b3BTZWFyY2goKTsKQEAgLTU2NCw3ICs2MTcsOCBAQCBX ZWJJbnNwZWN0b3IuQmFzZU5hdmlnYXRvclRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICBz ZXQgdGl0bGVUZXh0KHRpdGxlVGV4dCkKICAgICB7CiAgICAgICAgIHRoaXMuX3RpdGxlVGV4dCA9 IHRpdGxlVGV4dCB8fCAiIjsKLSAgICAgICAgdGhpcy5fdGl0bGVUZXh0Tm9kZS50ZXh0Q29udGVu dCA9IHRoaXMuX3RpdGxlVGV4dDsKKyAgICAgICAgaWYgKHRoaXMudGl0bGVFbGVtZW50KQorICAg ICAgICAgICAgdGhpcy50aXRsZUVsZW1lbnQudGV4dENvbnRlbnQgPSB0aGlzLl90aXRsZVRleHQ7 CiAgICAgfSwKICAgICAKICAgICAvKioKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvc2NyaXB0c1BhbmVsLmNzcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvc2NyaXB0c1BhbmVsLmNzcwppbmRleCA5MGMxNzU0ODA0NDI1YWE4MTJjYWU2 ZjM2NWVjMTNhMzY2MDk5NGFjLi5iMDVhOWU1ZjVhNzI4ODk2NzYyM2IzZGQ4MTVkM2MzMzBlOGI5 NGIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3Njcmlw dHNQYW5lbC5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9zY3Jp cHRzUGFuZWwuY3NzCkBAIC0zNjIsNiArMzYyLDEwIEBACiAgICAgdG9wOiAxcHg7CiB9CiAKKyNz Y3JpcHRzLW5hdmlnYXRvci10YWJiZWQtcGFuZSAubmF2aWdhdG9yIC5iYXNlLW5hdmlnYXRvci10 cmVlLWVsZW1lbnQtdGl0bGUuZWRpdGluZyB7CisgICAgbWFyZ2luOiBhdXRvOworfQorCiAuZnVu Y3Rpb24tbG9jYXRpb24tbGluayB7CiAgICAgZmxvYXQ6IHJpZ2h0OwogICAgIG1hcmdpbi1sZWZ0 OiAxMHB4Owo=