82471 2012-03-28 08:23:20 -0700 Web Inspector: nuke HeapGraph.setSize(), do it automagically on update 2012-03-28 08:36:33 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 589981 0 caseq 2012-03-28 08:23:20 -0700 We used to call HeapGraph.setSize() before HeapGraph.update() anyway, so just move it inside update() and use outer element dimensions to calculate the size. 589983 1 134301 caseq 2012-03-28 08:24:53 -0700 Created attachment 134301 Patch 589988 2 caseq 2012-03-28 08:36:33 -0700 Committed r112403: <http://trac.webkit.org/changeset/112403> 134301 2012-03-28 08:24:53 -0700 2012-03-28 08:31:24 -0700 Patch bug-82471-20120328192452.patch text/plain 2384 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGNjMGRjNDIwZjVjYmEz OWZkM2MwMWMzNDBhMWJkZWY3ZTRmOGY0YS4uNmY4ODUzMzI2MTBmNzA0MTRhYWY1YjMwZDc3YTFj ODA0OTAxNTJiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTI4ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogbnVrZSBIZWFwR3JhcGguc2V0U2l6ZSgpLCBkbyBpdCBhdXRvbWFnaWNhbGx5IG9uIHVwZGF0 ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI0NzEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvVGltZWxpbmVPdmVydmlld1BhbmUuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVGltZWxpbmVPdmVydmlld1BhbmUucHJvdG90eXBlLnVwZGF0ZSk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuSGVhcEdyYXBoLnByb3RvdHlwZS51cGRhdGUpOgorCiAyMDEyLTAzLTI3ICBK YW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVt XSBUcmFuc2ZlciB3aGVlbCBmbGluZyB2aWEgV2ViQ29tcG9zaXRvcklucHV0SGFuZGxlckNsaWVu dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGlu ZU92ZXJ2aWV3UGFuZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGlt ZWxpbmVPdmVydmlld1BhbmUuanMKaW5kZXggNDMxODk4OWNmMTlkMTY3YzdiZTUxNDdiZDRmZmNh NDAxODc2Y2U3OS4uYzI1NDc3YzNmNzA2ZWI1MGJhY2YzN2RhN2JmNzdjMGIzMzkwZTNhZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2 aWV3UGFuZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVs aW5lT3ZlcnZpZXdQYW5lLmpzCkBAIC0xOTYsMTAgKzE5Niw5IEBAIFdlYkluc3BlY3Rvci5UaW1l bGluZU92ZXJ2aWV3UGFuZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciByZWNvcmRzID0gdGhp cy5fcHJlc2VudGF0aW9uTW9kZWwucm9vdFJlY29yZCgpLmNoaWxkcmVuOwogICAgICAgICBXZWJJ bnNwZWN0b3IuVGltZWxpbmVQYW5lbC5mb3JBbGxSZWNvcmRzKHJlY29yZHMsIHVwZGF0ZUJvdW5k YXJpZXMuYmluZCh0aGlzKSk7CiAKLSAgICAgICAgaWYgKHRoaXMuX2hlYXBHcmFwaC52aXNpYmxl KSB7Ci0gICAgICAgICAgICB0aGlzLl9oZWFwR3JhcGguc2V0U2l6ZSh0aGlzLl9vdmVydmlld0dy aWQuZWxlbWVudC5vZmZzZXRXaWR0aCwgNjApOworICAgICAgICBpZiAodGhpcy5faGVhcEdyYXBo LnZpc2libGUpCiAgICAgICAgICAgICB0aGlzLl9oZWFwR3JhcGgudXBkYXRlKHJlY29yZHMpOwot ICAgICAgICB9IGVsc2UgaWYgKHRoaXMuX3ZlcnRpY2FsT3ZlcnZpZXcpCisgICAgICAgIGVsc2Ug aWYgKHRoaXMuX3ZlcnRpY2FsT3ZlcnZpZXcpCiAgICAgICAgICAgICB0aGlzLl92ZXJ0aWNhbE92 ZXJ2aWV3LnVwZGF0ZShyZWNvcmRzKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgdGhpcy5f dXBkYXRlQ2F0ZWdvcnlTdHJpcHMocmVjb3Jkcyk7CkBAIC03MTAsMTYgKzcwOSwxNSBAQCBXZWJJ bnNwZWN0b3IuSGVhcEdyYXBoLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5lbGVtZW50LmFk ZFN0eWxlQ2xhc3MoImhpZGRlbiIpOwogICAgIH0sCiAKLSAgICBzZXRTaXplOiBmdW5jdGlvbih3 LCBoKSB7Ci0gICAgICAgIHRoaXMuX2NhbnZhcy53aWR0aCA9IHc7Ci0gICAgICAgIHRoaXMuX2Nh bnZhcy5oZWlnaHQgPSBoIC0gNTsKLSAgICB9LAotCiAgICAgdXBkYXRlOiBmdW5jdGlvbihyZWNv cmRzKQogICAgIHsKICAgICAgICAgaWYgKCFyZWNvcmRzLmxlbmd0aCkKICAgICAgICAgICAgIHJl dHVybjsKIAorICAgICAgICBjb25zdCB5UGFkZGluZyA9IDU7CisgICAgICAgIHRoaXMuX2NhbnZh cy53aWR0aCA9IHRoaXMuZWxlbWVudC5jbGllbnRXaWR0aDsKKyAgICAgICAgdGhpcy5fY2FudmFz LmhlaWdodCA9IHRoaXMuZWxlbWVudC5jbGllbnRIZWlnaHQgLSB5UGFkZGluZzsKKwogICAgICAg ICBjb25zdCBsb3dlck9mZnNldCA9IDM7CiAgICAgICAgIHZhciBtYXhVc2VkSGVhcFNpemUgPSAw OwogICAgICAgICB2YXIgbWluVXNlZEhlYXBTaXplID0gMTAwMDAwMDAwMDAwOwo=