82456 2012-03-28 06:00:30 -0700 [EFL] Icon database path may be NULL when a new path was set 2012-05-07 05:29:31 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 g.czajkowski webkit-unassigned gyuyoung.kim leandro lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 589890 0 g.czajkowski 2012-03-28 06:00:30 -0700 ewk_settings_icon_database_path_set calls asynchronous method WebCore::iconDatabase().open(). There is no notification when the new path is set by WebCore. Moreover ewk_settings_icon_database_path_set keeps the new path in a local variable. To retrieve path to icon database ewk_settings_icon_database_path_get can be called. It first checks flags whether icon databse is opened and enabled. There is possibility that icon database has been set through API but it hasn't been opened by WebCore yet. So as a result ewk_settings_icon_database_path_get returns NULL because WebCore hasn't set an appropriate flag yet. It may happen while icon database set/get sequences. Information whether icon database is opened/enabled should be exposed by separate API. 589891 1 134275 g.czajkowski 2012-03-28 06:02:05 -0700 Created attachment 134275 proposed patch skip checking whether icon database is opened and enabled to get icon database path 589909 2 134282 g.czajkowski 2012-03-28 06:32:44 -0700 Created attachment 134282 rebased patch 603119 3 g.czajkowski 2012-04-16 06:59:05 -0700 Hi Lucas, Could you review this patch? I think those checks are no longer needed. WebKit-Gtk doesn't check them when the data base path is being gotten. 617531 4 134282 kling 2012-05-07 05:07:37 -0700 Comment on attachment 134282 rebased patch Certainly looks more correct this way. r=me 617537 5 134282 webkit.review.bot 2012-05-07 05:29:27 -0700 Comment on attachment 134282 rebased patch Clearing flags on attachment: 134282 Committed r116302: <http://trac.webkit.org/changeset/116302> 617538 6 webkit.review.bot 2012-05-07 05:29:31 -0700 All reviewed patches have been landed. Closing bug. 134275 2012-03-28 06:02:05 -0700 2012-03-28 06:32:44 -0700 proposed patch path_to_icon_databse_path.patch text/plain 2715 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4MzZjN2RkLi5kMjVlM2FjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjggQEAKKzIwMTItMDMtMjcgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gSWNvbiBkYXRhYmFzZSBwYXRoIG1h eSBiZSBOVUxMIHdoZW4gYSBuZXcgcGF0aCB3YXMgc2V0LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI0NTYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9wYXRo X3NldCBjYWxscyBhc3luY2hyb25vdXMgbWV0aG9kIFdlYkNvcmU6Omljb25EYXRhYmFzZSgpLm9w ZW4oKS4KKyAgICAgICAgVGhlcmUgaXMgbm8gbm90aWZpY2F0aW9uIHdoZW4gdGhlIG5ldyBwYXRo IGlzIHNldCBieSBXZWJDb3JlLgorICAgICAgICBNb3Jlb3ZlciBld2tfc2V0dGluZ3NfaWNvbl9k YXRhYmFzZV9wYXRoX3NldCBrZWVwcyB0aGUgbmV3IHBhdGggaW4gYSBsb2NhbCB2YXJpYWJsZS4K KworICAgICAgICBUbyByZXRyaWV2ZSBwYXRoIHRvIGljb24gZGF0YWJhc2UgZXdrX3NldHRpbmdz X2ljb25fZGF0YWJhc2VfcGF0aF9nZXQgY2FuIGJlIGNhbGxlZC4KKyAgICAgICAgSXQgZmlyc3Qg Y2hlY2tzIGZsYWdzIHdoZXRoZXIgaWNvbiBkYXRhYnNlIGlzIG9wZW5lZCBhbmQgZW5hYmxlZC4g VGhlcmUgaXMgcG9zc2liaWxpdHkKKyAgICAgICAgdGhhdCBpY29uIGRhdGFiYXNlIGhhcyBiZWVu IHNldCB0aHJvdWdoIEFQSSBidXQgaXQgaGFzbid0IGJlZW4gb3BlbmVkIGJ5IFdlYkNvcmUgeWV0 LgorICAgICAgICBTbyBhcyBhIHJlc3VsdCBld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9wYXRo X2dldCByZXR1cm5zIE5VTEwgYmVjYXVzZSBXZWJDb3JlIGhhc24ndAorICAgICAgICBzZXQgYW4g YXBwcm9wcmlhdGUgZmxhZyB5ZXQuCisKKyAgICAgICAgSXQgbWF5IGhhcHBlbiB3aGlsZSBpY29u IGRhdGFiYXNlIHNldC9nZXQgc2VxdWVuY2VzLgorICAgICAgICBJbmZvcm1hdGlvbiB3aGV0aGVy IGljb24gZGF0YWJhc2UgaXMgb3BlbmVkL2VuYWJsZWQgc2hvdWxkIGJlIGV4cG9zZWQgYnkgc2Vw YXJhdGUgQVBJLgorCisgICAgICAgICogZXdrL2V3a19zZXR0aW5ncy5jcHA6CisgICAgICAgIChl d2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9wYXRoX2dldCk6IHNraXAgY2hlY2tpbmcgd2hldGhl ciBpY29uIGRhdGFiYXNlIGlzIG9wZW5lZCwgZW5hYmxlZAorICAgICAgICAqIGV3ay9ld2tfc2V0 dGluZ3MuaDogdXBkYXRlIGRvYworCiAyMDEyLTAzLTI3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbU09VUF0gSW1wbGVtZW50IG1pc3Npbmcg bWV0aG9kcyBpbiBDb29raWVKYXJTb3VwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3Mu Y3BwCmluZGV4IGQxM2IzOWUuLjgxODljNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfc2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0 dGluZ3MuY3BwCkBAIC0xOTQsMTEgKzE5NCw2IEBAIEVpbmFfQm9vbCBld2tfc2V0dGluZ3NfaWNv bl9kYXRhYmFzZV9wYXRoX3NldChjb25zdCBjaGFyKiBkaXJlY3RvcnkpCiAKIGNvbnN0IGNoYXIq IGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX3BhdGhfZ2V0KHZvaWQpCiB7Ci0gICAgaWYgKCFX ZWJDb3JlOjppY29uRGF0YWJhc2UoKS5pc0VuYWJsZWQoKSkKLSAgICAgICAgcmV0dXJuIDA7Ci0g ICAgaWYgKCFXZWJDb3JlOjppY29uRGF0YWJhc2UoKS5pc09wZW4oKSkKLSAgICAgICAgcmV0dXJu IDA7Ci0KICAgICByZXR1cm4gX2V3a19pY29uX2RhdGFiYXNlX3BhdGg7CiB9CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuaCBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfc2V0dGluZ3MuaAppbmRleCBjY2U5YTVhLi5lMmNlZmE2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmgKKysrIGIvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a19zZXR0aW5ncy5oCkBAIC0xNDcsNyArMTQ3LDcgQEAgRUFQSSBFaW5hX0Jv b2wgICAgICAgIGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX3BhdGhfc2V0KGNvbnN0IGNoYXIg KnBhdGgpOwogICogc2F2ZSB5b3Vyc2VsZiBzb21lIGNwdSBjeWNsZXMgYW5kIHVzZSBlaW5hX3N0 cmluZ3NoYXJlX3JlZigpCiAgKiBpbnN0ZWFkIG9mIGVpbmFfc3RyaW5nc2hhcmVfYWRkKCkgb3Ig c3RyZHVwKCkuCiAgKgotICogQHJldHVybiBkYXRhYmFzZSBwYXRoIG9yIEBjIDAgaWYgbm9uZSBp cyBzZXQgb3IgZGF0YWJhc2UgaXMgY2xvc2VkCisgKiBAcmV0dXJuIGRhdGFiYXNlIHBhdGggb3Ig QGMgMCBpZiBub25lIGlzIHNldAogICovCiBFQVBJIGNvbnN0IGNoYXIgICAgICAqZXdrX3NldHRp bmdzX2ljb25fZGF0YWJhc2VfcGF0aF9nZXQodm9pZCk7CiAK 134282 2012-03-28 06:32:44 -0700 2012-05-07 05:29:27 -0700 rebased patch path_to_icon_databse_path.patch text/plain 2705 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4MzZjN2RkLi42MGJlYmIxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjcgQEAKKzIwMTItMDMtMjggIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gSWNvbiBkYXRhYmFzZSBwYXRoIG1h eSBiZSBOVUxMIHdoZW4gYSBuZXcgcGF0aCB3YXMgc2V0LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI0NTYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9wYXRo X3NldCBjYWxscyBhc3luY2hyb25vdXMgbWV0aG9kIFdlYkNvcmU6Omljb25EYXRhYmFzZSgpLm9w ZW4oKS4KKyAgICAgICAgVGhlcmUgaXMgbm8gbm90aWZpY2F0aW9uIHdoZW4gdGhlIG5ldyBwYXRo IGlzIHNldCBieSBXZWJDb3JlLgorICAgICAgICBNb3Jlb3ZlciBld2tfc2V0dGluZ3NfaWNvbl9k YXRhYmFzZV9wYXRoX3NldCBrZWVwcyB0aGUgbmV3IHBhdGggaW4gYSBsb2NhbCB2YXJpYWJsZS4K KworICAgICAgICBUbyByZXRyaWV2ZSBwYXRoIHRvIGljb24gZGF0YWJhc2UgZXdrX3NldHRpbmdz X2ljb25fZGF0YWJhc2VfcGF0aF9nZXQgY2FuIGJlIGNhbGxlZC4KKyAgICAgICAgSXQgZmlyc3Qg Y2hlY2tzIGZsYWdzIHdoZXRoZXIgaWNvbiBkYXRhYnNlIGlzIG9wZW5lZCBhbmQgZW5hYmxlZC4g VGhlcmUgaXMgcG9zc2liaWxpdHkKKyAgICAgICAgdGhhdCBpY29uIGRhdGFiYXNlIGhhcyBiZWVu IHNldCB0aHJvdWdoIEFQSSBidXQgaXQgaGFzbid0IGJlZW4gb3BlbmVkIGJ5IFdlYkNvcmUgeWV0 LgorICAgICAgICBTbyBhcyBhIHJlc3VsdCBld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9wYXRo X2dldCByZXR1cm5zIE5VTEwgYmVjYXVzZSBXZWJDb3JlIGhhc24ndAorICAgICAgICBzZXQgYW4g YXBwcm9wcmlhdGUgZmxhZyB5ZXQuCisKKyAgICAgICAgSXQgbWF5IGhhcHBlbiB3aGlsZSBpY29u IGRhdGFiYXNlIHNldC9nZXQgc2VxdWVuY2VzLgorICAgICAgICBJbmZvcm1hdGlvbiB3aGV0aGVy IGljb24gZGF0YWJhc2UgaXMgb3BlbmVkL2VuYWJsZWQgc2hvdWxkIGJlIGV4cG9zZWQgYnkgc2Vw YXJhdGUgQVBJLgorCisgICAgICAgICogZXdrL2V3a19zZXR0aW5ncy5jcHA6CisgICAgICAgIChl d2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9wYXRoX2dldCk6IFNraXAgY2hlY2tpbmcgd2hldGhl ciBpY29uIGRhdGFiYXNlIGlzIG9wZW5lZCwgZW5hYmxlZC4KKyAgICAgICAgKiBld2svZXdrX3Nl dHRpbmdzLmg6CisKIDIwMTItMDMtMjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtTT1VQXSBJbXBsZW1lbnQgbWlzc2luZyBtZXRob2RzIGlu IENvb2tpZUphclNvdXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0 dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKaW5kZXgg ZDEzYjM5ZS4uODE4OWM2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19z ZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAK QEAgLTE5NCwxMSArMTk0LDYgQEAgRWluYV9Cb29sIGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNl X3BhdGhfc2V0KGNvbnN0IGNoYXIqIGRpcmVjdG9yeSkKIAogY29uc3QgY2hhciogZXdrX3NldHRp bmdzX2ljb25fZGF0YWJhc2VfcGF0aF9nZXQodm9pZCkKIHsKLSAgICBpZiAoIVdlYkNvcmU6Omlj b25EYXRhYmFzZSgpLmlzRW5hYmxlZCgpKQotICAgICAgICByZXR1cm4gMDsKLSAgICBpZiAoIVdl YkNvcmU6Omljb25EYXRhYmFzZSgpLmlzT3BlbigpKQotICAgICAgICByZXR1cm4gMDsKLQogICAg IHJldHVybiBfZXdrX2ljb25fZGF0YWJhc2VfcGF0aDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19zZXR0aW5ncy5oCmluZGV4IGNjZTlhNWEuLmUyY2VmYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3NldHRpbmdzLmgKQEAgLTE0Nyw3ICsxNDcsNyBAQCBFQVBJIEVpbmFfQm9vbCAgICAgICAg ZXdrX3NldHRpbmdzX2ljb25fZGF0YWJhc2VfcGF0aF9zZXQoY29uc3QgY2hhciAqcGF0aCk7CiAg KiBzYXZlIHlvdXJzZWxmIHNvbWUgY3B1IGN5Y2xlcyBhbmQgdXNlIGVpbmFfc3RyaW5nc2hhcmVf cmVmKCkKICAqIGluc3RlYWQgb2YgZWluYV9zdHJpbmdzaGFyZV9hZGQoKSBvciBzdHJkdXAoKS4K ICAqCi0gKiBAcmV0dXJuIGRhdGFiYXNlIHBhdGggb3IgQGMgMCBpZiBub25lIGlzIHNldCBvciBk YXRhYmFzZSBpcyBjbG9zZWQKKyAqIEByZXR1cm4gZGF0YWJhc2UgcGF0aCBvciBAYyAwIGlmIG5v bmUgaXMgc2V0CiAgKi8KIEVBUEkgY29uc3QgY2hhciAgICAgICpld2tfc2V0dGluZ3NfaWNvbl9k YXRhYmFzZV9wYXRoX2dldCh2b2lkKTsKIAo=