82445 2012-03-28 03:39:41 -0700 Leak in WebCore::SVGFontElement::create 2012-04-04 17:39:49 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 66438 http://crbug.com/120453 P2 Normal --- 1 bashi bashi jschuh macpherson menard thorton webkit.review.bot zimmermann oldest_to_newest 589815 0 bashi 2012-03-28 03:39:41 -0700 See the stacktrace at http://crbug.com/120453. r76990 introduced RefPtrs to hold SVGFontElement and looks like it is the cause of the leak. I checked removing RefPtrs fixed the leak and svg/custom/use-multiple-on-nested-disallowed-font.html passed successfully (DRT didn't crash). I think zimmermann's recent changes (e.g. r109333) disallow invalid svg contents like the test and the test is no longer effective. jschuh@, zimmermann@, Do you think it is safe to remove RefPtrs which were introduces by r76990? 589817 1 134254 bashi 2012-03-28 03:42:16 -0700 Created attachment 134254 Patch 589897 2 134254 zimmermann 2012-03-28 06:06:49 -0700 Comment on attachment 134254 Patch I think they were added on purpose - don't you see any crashes now?? Maybe something has changed, but I'd be careful here. Can you try running tests under guard malloc? nrwt --tolerance 0 -p svg -g, and/or with --gc-between-tests. 590654 3 bashi 2012-03-28 17:23:39 -0700 (In reply to comment #2) > (From update of attachment 134254 [details]) > I think they were added on purpose - don't you see any crashes now?? Maybe something has changed, but I'd be careful here. I didn't see any crashes with this patch, but I agree that we should be careful. I'd like to hear jschuh's opinion. > Can you try running tests under guard malloc? nrwt --tolerance 0 -p svg -g, and/or with --gc-between-tests. All svg tests ran as expected with above switches (Debug/Release). 595870 4 thorton 2012-04-04 13:35:38 -0700 (In reply to comment #0) > See the stacktrace at http://crbug.com/120453. I don't see one. 596123 5 jschuh 2012-04-04 17:15:56 -0700 No, it's not safe to remove the RefPtr without making other changes. This is discussed in bug 66438, along with an explanation of the solution to the memory leak. I just haven't had a chance to do any WebKit work in the last few months. *** This bug has been marked as a duplicate of bug 66438 *** 596140 6 134254 bashi 2012-04-04 17:39:49 -0700 Comment on attachment 134254 Patch Thanks. Removing r?. 134254 2012-03-28 03:42:16 -0700 2012-04-04 17:39:48 -0700 Patch bug-82445-20120328194214.patch text/plain 4537 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWE3Yzg1MzJiZmFkMGJi NTkxM2UyYjkwZTQ3YWEyYmEyNTYxZmJjNS4uZTdlYTcyZjE1NTgzYjA5MWZkNDMwZDE0YzUzNmE4 Nzg0YmNlNjIwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAzLTI4ICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KKworICAgICAgICBMZWFrIGluIFdl YkNvcmU6OlNWR0ZvbnRFbGVtZW50OjpjcmVhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNDQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIFJlZlB0cnMgZnJvbSBzdmcgZm9udCBmYWNlIHRv IGF2b2lkIGxlYWsuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2VzIGluIGJlaGF2 aW9yLgorCisgICAgICAgICogY3NzL0NTU0ZvbnRGYWNlU291cmNlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkNTU0ZvbnRGYWNlU291cmNlOjpnZXRGb250RGF0YSk6CisgICAgICAgIChXZWJDb3Jl OjpDU1NGb250RmFjZVNvdXJjZTo6c3ZnRm9udEZhY2VFbGVtZW50KToKKyAgICAgICAgKFdlYkNv cmU6OkNTU0ZvbnRGYWNlU291cmNlOjpzZXRTVkdGb250RmFjZUVsZW1lbnQpOgorICAgICAgICAq IGNzcy9DU1NGb250RmFjZVNvdXJjZS5oOgorICAgICAgICAoQ1NTRm9udEZhY2VTb3VyY2UpOgor ICAgICAgICAqIHN2Zy9TVkdGb250RmFjZUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U1ZHRm9udEZhY2VFbGVtZW50Ojphc3NvY2lhdGVkRm9udEVsZW1lbnQpOgorICAgICAgICAqIHN2 Zy9TVkdGb250RmFjZUVsZW1lbnQuaDoKKyAgICAgICAgKFNWR0ZvbnRGYWNlRWxlbWVudCk6CisK IDIwMTItMDMtMjcgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW2Nocm9taXVtXSBSZW5hbWUgb3BhcXVlQ29udGVudHNSZWdpb24oKSB0byB2aXNpYmxlQ29u dGVudE9wYXF1ZVJlZ2lvbigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9u dEZhY2VTb3VyY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYWNlU291cmNlLmNw cAppbmRleCBlMzY3MzVhZmI2YjE3MzQ3MTcwODY3ZTc0ODQxN2Q3ZTNkNjcyZTRiLi5iNDBiZTM3 NTcyYjRmZWNlN2YxZmJlMGJkNzMwOTk3NDgxZjY3YWYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTRm9udEZhY2VTb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NGb250RmFjZVNvdXJjZS5jcHAKQEAgLTE3Myw3ICsxNzMsNyBAQCBTaW1wbGVGb250RGF0YSog Q1NTRm9udEZhY2VTb3VyY2U6OmdldEZvbnREYXRhKGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgZm9u dERlc2NyaQogI2lmIEVOQUJMRShTVkdfRk9OVFMpCiAgICAgICAgICAgICAvLyBJbi1Eb2N1bWVu dCBTVkcgRm9udHMKICAgICAgICAgICAgIGlmIChtX3N2Z0ZvbnRGYWNlRWxlbWVudCkKLSAgICAg ICAgICAgICAgICBmb250RGF0YSA9IGFkb3B0UHRyKG5ldyBTaW1wbGVGb250RGF0YShTVkdGb250 RGF0YTo6Y3JlYXRlKG1fc3ZnRm9udEZhY2VFbGVtZW50LmdldCgpKSwgZm9udERlc2NyaXB0aW9u LmNvbXB1dGVkUGl4ZWxTaXplKCksIHN5bnRoZXRpY0JvbGQsIHN5bnRoZXRpY0l0YWxpYykpOwor ICAgICAgICAgICAgICAgIGZvbnREYXRhID0gYWRvcHRQdHIobmV3IFNpbXBsZUZvbnREYXRhKFNW R0ZvbnREYXRhOjpjcmVhdGUobV9zdmdGb250RmFjZUVsZW1lbnQpLCBmb250RGVzY3JpcHRpb24u Y29tcHV0ZWRQaXhlbFNpemUoKSwgc3ludGhldGljQm9sZCwgc3ludGhldGljSXRhbGljKSk7CiAj ZW5kaWYKICAgICAgICAgfQogICAgIH0gZWxzZSB7CkBAIC0xOTgsMTAgKzE5OCwxMCBAQCBTaW1w bGVGb250RGF0YSogQ1NTRm9udEZhY2VTb3VyY2U6OmdldEZvbnREYXRhKGNvbnN0IEZvbnREZXNj cmlwdGlvbiYgZm9udERlc2NyaQogI2lmIEVOQUJMRShTVkdfRk9OVFMpCiBTVkdGb250RmFjZUVs ZW1lbnQqIENTU0ZvbnRGYWNlU291cmNlOjpzdmdGb250RmFjZUVsZW1lbnQoKSBjb25zdAogewot ICAgIHJldHVybiBtX3N2Z0ZvbnRGYWNlRWxlbWVudC5nZXQoKTsKKyAgICByZXR1cm4gbV9zdmdG b250RmFjZUVsZW1lbnQ7CiB9CiAKLXZvaWQgQ1NTRm9udEZhY2VTb3VyY2U6OnNldFNWR0ZvbnRG YWNlRWxlbWVudChQYXNzUmVmUHRyPFNWR0ZvbnRGYWNlRWxlbWVudD4gZWxlbWVudCkKK3ZvaWQg Q1NTRm9udEZhY2VTb3VyY2U6OnNldFNWR0ZvbnRGYWNlRWxlbWVudChTVkdGb250RmFjZUVsZW1l bnQqIGVsZW1lbnQpCiB7CiAgICAgbV9zdmdGb250RmFjZUVsZW1lbnQgPSBlbGVtZW50OwogfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYWNlU291cmNlLmggYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTRm9udEZhY2VTb3VyY2UuaAppbmRleCBlMzZmZTQ1NDI5YTg4NmZk ZjY3OGI2M2Y0MGEwZjMwNTgzZGVlNDQ5Li4zNTljYzU4MTBiYzZhMDEyOTI3Mzk2ZTAwY2U2M2Rk MmE5OWRiZDZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udEZhY2VTb3Vy Y2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udEZhY2VTb3VyY2UuaApAQCAtNjUs NyArNjUsNyBAQCBwdWJsaWM6CiAKICNpZiBFTkFCTEUoU1ZHX0ZPTlRTKQogICAgIFNWR0ZvbnRG YWNlRWxlbWVudCogc3ZnRm9udEZhY2VFbGVtZW50KCkgY29uc3Q7Ci0gICAgdm9pZCBzZXRTVkdG b250RmFjZUVsZW1lbnQoUGFzc1JlZlB0cjxTVkdGb250RmFjZUVsZW1lbnQ+KTsKKyAgICB2b2lk IHNldFNWR0ZvbnRGYWNlRWxlbWVudChTVkdGb250RmFjZUVsZW1lbnQqKTsKICAgICBib29sIGlz U1ZHRm9udEZhY2VTb3VyY2UoKSBjb25zdDsKICAgICB2b2lkIHNldEhhc0V4dGVybmFsU1ZHRm9u dChib29sIHZhbHVlKSB7IG1faGFzRXh0ZXJuYWxTVkdGb250ID0gdmFsdWU7IH0KICNlbmRpZgpA QCAtNzksNyArNzksNyBAQCBwcml2YXRlOgogICAgIEhhc2hNYXA8dW5zaWduZWQsIFNpbXBsZUZv bnREYXRhKj4gbV9mb250RGF0YVRhYmxlOyAvLyBUaGUgaGFzaCBrZXkgaXMgY29tcG9zZWQgb2Yg c2l6ZSBzeW50aGV0aWMgc3R5bGVzLgogCiAjaWYgRU5BQkxFKFNWR19GT05UUykKLSAgICBSZWZQ dHI8U1ZHRm9udEZhY2VFbGVtZW50PiBtX3N2Z0ZvbnRGYWNlRWxlbWVudDsKKyAgICBTVkdGb250 RmFjZUVsZW1lbnQqIG1fc3ZnRm9udEZhY2VFbGVtZW50OwogICAgIFJlZlB0cjxTVkdGb250RWxl bWVudD4gbV9leHRlcm5hbFNWR0ZvbnRFbGVtZW50OwogICAgIGJvb2wgbV9oYXNFeHRlcm5hbFNW R0ZvbnQ7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdGb250RmFj ZUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZvbnRGYWNlRWxlbWVudC5jcHAK aW5kZXggMGM2N2FjODk5YjRiMDA5OGUzODBmYTJhMTlmZGM5NzNmNTQwYjJmNS4uYWQ4MTkyNmMy YjhkMzI5MGU1OWFjNzM5YTRkNGM2YTk5YzA4MjRjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvc3ZnL1NWR0ZvbnRGYWNlRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NW R0ZvbnRGYWNlRWxlbWVudC5jcHAKQEAgLTI2NCw3ICsyNjQsNyBAQCBTdHJpbmcgU1ZHRm9udEZh Y2VFbGVtZW50Ojpmb250RmFtaWx5KCkgY29uc3QKIAogU1ZHRm9udEVsZW1lbnQqIFNWR0ZvbnRG YWNlRWxlbWVudDo6YXNzb2NpYXRlZEZvbnRFbGVtZW50KCkgY29uc3QKIHsKLSAgICByZXR1cm4g bV9mb250RWxlbWVudC5nZXQoKTsKKyAgICByZXR1cm4gbV9mb250RWxlbWVudDsKIH0KIAogdm9p ZCBTVkdGb250RmFjZUVsZW1lbnQ6OnJlYnVpbGRGb250RmFjZSgpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcv U1ZHRm9udEZhY2VFbGVtZW50LmgKaW5kZXggYjQ1ODEzOTkwZjU0OTk2N2RmN2U0MTMzOWYwYjYw OWE1YjQ5NTY1MC4uODM2ODJlOGQyM2RmYWIyMWMxNGM0OWE0ZTY5NTk1ZjYzYzQxODVmOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZvbnRGYWNlRWxlbWVudC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3N2Zy9TVkdGb250RmFjZUVsZW1lbnQuaApAQCAtNjEsNyArNjEsNyBAQCBw cml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCByZW1vdmVkRnJvbURvY3VtZW50KCk7CiAKICAgICBS ZWZQdHI8Q1NTRm9udEZhY2VSdWxlPiBtX2ZvbnRGYWNlUnVsZTsKLSAgICBSZWZQdHI8U1ZHRm9u dEVsZW1lbnQ+IG1fZm9udEVsZW1lbnQ7CisgICAgU1ZHRm9udEVsZW1lbnQqIG1fZm9udEVsZW1l bnQ7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==